Matthew Pickering pushed to branch wip/improve-implicit-lifting-error at Glasgow Haskell Compiler / GHC

Commits:

• 92f9cb5c
  by Matthew Pickering at 2025-05-14T10:00:44+01:00

  Accept test output
  

• 5ee40de7
  by Matthew Pickering at 2025-05-19T17:13:02+01:00

  Refactor the treatment of nested Template Haskell splices
  
  More information is now kept in the AST about what kind of splice.
  
  * The difference between a normal splice, a quasiquoter and implicit
    splice caused by lifting is stored in the AST after renaming.
  
  * This improves error messages since the original program can be easily
    printed.
  
  In the future, the typechecked AST should also retain information about
  the splices and the specific desugaring being left to the desugarer.
  
  Also, `runRnSplice` should call `tcUntypedSplice`, otherwise the
  typechecking logic is duplicated (see the `QQError` and `QQTopError`
  tests for a difference caused by this).
  

65 changed files:

• compiler/GHC/Builtin/Names/TH.hs
• compiler/GHC/Hs/Expr.hs
• compiler/GHC/Hs/Expr.hs-boot
• compiler/GHC/Hs/Instances.hs
• compiler/GHC/HsToCore/Quote.hs
• compiler/GHC/Iface/Ext/Ast.hs
• compiler/GHC/Parser.y
• compiler/GHC/Parser/Lexer.x
• compiler/GHC/Rename/Expr.hs
• compiler/GHC/Rename/Splice.hs
• compiler/GHC/Tc/Errors/Ppr.hs
• compiler/GHC/Tc/Gen/App.hs
• compiler/GHC/Tc/Gen/Expr.hs
• compiler/GHC/Tc/Gen/Head.hs
• compiler/GHC/Tc/Gen/Splice.hs
• compiler/GHC/Tc/Gen/Splice.hs-boot
• compiler/GHC/Tc/Types/ErrCtxt.hs
• compiler/GHC/Tc/Types/TH.hs
• compiler/GHC/Tc/Utils/Concrete.hs
• compiler/GHC/Tc/Utils/TcMType.hs
• compiler/GHC/ThToHs.hs
• compiler/Language/Haskell/Syntax/Expr.hs
• compiler/Language/Haskell/Syntax/Extension.hs
• testsuite/tests/annotations/should_fail/annfail03.stderr
• testsuite/tests/annotations/should_fail/annfail09.stderr
• testsuite/tests/quasiquotation/qq001/qq001.stderr
• testsuite/tests/quasiquotation/qq002/qq002.stderr
• testsuite/tests/quasiquotation/qq003/qq003.stderr
• testsuite/tests/quasiquotation/qq004/qq004.stderr
• testsuite/tests/quotes/LiftErrMsg.stderr
• testsuite/tests/quotes/LiftErrMsgDefer.stderr
• + testsuite/tests/quotes/LiftErrMsgTyped.hs
• + testsuite/tests/quotes/LiftErrMsgTyped.stderr
• + testsuite/tests/quotes/QQError.hs
• + testsuite/tests/quotes/QQError.stderr
• testsuite/tests/quotes/T10384.stderr
• testsuite/tests/quotes/TH_localname.stderr
• testsuite/tests/quotes/all.T
• testsuite/tests/splice-imports/SI03.stderr
• testsuite/tests/splice-imports/SI05.stderr
• testsuite/tests/splice-imports/SI16.stderr
• testsuite/tests/splice-imports/SI18.stderr
• testsuite/tests/splice-imports/SI20.stderr
• testsuite/tests/splice-imports/SI25.stderr
• testsuite/tests/splice-imports/SI28.stderr
• testsuite/tests/splice-imports/SI31.stderr
• + testsuite/tests/th/QQInQuote.hs
• + testsuite/tests/th/QQTopError.hs
• + testsuite/tests/th/QQTopError.stderr
• testsuite/tests/th/T10598_TH.stderr
• testsuite/tests/th/T14681.stderr
• testsuite/tests/th/T16976z.stderr
• testsuite/tests/th/T17804.stderr
• testsuite/tests/th/T17820a.stderr
• testsuite/tests/th/T17820b.stderr
• testsuite/tests/th/T17820c.stderr
• testsuite/tests/th/T17820d.stderr
• testsuite/tests/th/T17820e.stderr
• testsuite/tests/th/T23829_hasty.stderr
• testsuite/tests/th/T23829_hasty_b.stderr
• testsuite/tests/th/T5508.stderr
• testsuite/tests/th/T5795.stderr
• testsuite/tests/th/TH_Lift.stderr
• testsuite/tests/th/all.T
• testsuite/tests/th/overloaded/TH_overloaded_constraints_fail.stderr

The diff was not included because it is too large.