Simon Peyton Jones pushed to branch wip/T23162-spj at Glasgow Haskell Compiler / GHC

Commits:

• 94b62aa7
  by Simon Peyton Jones at 2025-09-08T03:37:14-04:00

  Refactor ForAllCo
  
  This is a pure refactor, addressing #26389.
  
  It arranges that the kind coercion in a ForAllCo is a MCoercion, rather
  than a plain Coercion, thus removing redundancy in the common case.
  See (FC8) in Note [ForAllCo]
  
  It's a nice cleanup.
  

• 624afa4a
  by sheaf at 2025-09-08T03:38:05-04:00

  Use tcMkScaledFunTys in matchExpectedFunTys
  
  We should use tcMkScaledFunTys rather than mkScaledFunTys in
  GHC.Tc.Utils.Unify.matchExpectedFunTys, as the latter crashes
  when the kind of the result type is a bare metavariable.
  We know the result is always Type-like, so we don't need scaledFunTys
  to try to rediscover that from the kind.
  
  Fixes #26277
  

• 0975d2b6
  by sheaf at 2025-09-08T03:38:54-04:00

  Revert "Remove hptAllFamInstances usage during upsweep"
  
  This reverts commit 3bf6720eff5e86e673568e756161e6d6150eb440.
  

• 0cf34176
  by soulomoon at 2025-09-08T03:38:54-04:00

  Family consistency checks: add test for #26154
  
  This commit adds the test T26154, to make sure that GHC doesn't crash
  when performing type family consistency checks. This test case
  was extracted from Agda.
  
  Fixes #26154
  

• 7ec1773f
  by Richard Eisenberg at 2025-09-08T10:59:44+01:00

  Move some fundep solving to new spot
  
  Work in progress...[skip ci]
  
  This completes moving dict fundeps to the main loop
  
  We need wanted/wanted fundeps too
  
  ...and some other refactors
  
  Wibbles
  
  Make FunDeps into a new module
  
  Solve new_eqs rather than adding them to WantedConstraints
  
  Wibble
  
  Import wibbles
  
  Comments only [skip ci]
  
  WIP on FunDeps [skip ci]
  
  Work in progress [skip ci]
  
  More WIP
  
  Wibbles to fundeps [skip ci]
  
  Kill off kickOutAfterUnification
  
  More wibbles
  
  Need to remove the unification-count stuff entirely
  and do more tidying up -- this commit is mainly for CI
  
  Wibbles solver
  
  Iterate the simples more often than plugins
  
  Start to extend to equalities
  
  Whitespace only
  
  Small improvements
  
  Wibbles
  

• 7579e6d8
  by Simon Peyton Jones at 2025-09-08T10:59:44+01:00

  Improved error messages from fundep changes
  

• d77d6652
  by Simon Peyton Jones at 2025-09-08T10:59:44+01:00

  Wibbles
  

• 09d927e9
  by Simon Peyton Jones at 2025-09-08T10:59:44+01:00

  Fix typo
  

• bb7086d6
  by Simon Peyton Jones at 2025-09-08T10:59:44+01:00

  Wibbles
  

• 5ce660a3
  by Simon Peyton Jones at 2025-09-10T17:37:13+01:00

  Nuke FunDepOrigin1 and 2
  

69 changed files:

• compiler/GHC/Core/Coercion.hs
• compiler/GHC/Core/Coercion.hs-boot
• compiler/GHC/Core/Coercion/Opt.hs
• compiler/GHC/Core/Lint.hs
• compiler/GHC/Core/Opt/Arity.hs
• compiler/GHC/Core/Reduction.hs
• compiler/GHC/Core/TyCo/FVs.hs
• compiler/GHC/Core/TyCo/Rep.hs
• compiler/GHC/Core/TyCo/Subst.hs
• compiler/GHC/Core/TyCo/Tidy.hs
• compiler/GHC/Core/Type.hs
• compiler/GHC/Core/Unify.hs
• compiler/GHC/CoreToIface.hs
• compiler/GHC/Driver/Env.hs
• compiler/GHC/Iface/Rename.hs
• compiler/GHC/Iface/Syntax.hs
• compiler/GHC/Iface/Type.hs
• compiler/GHC/IfaceToCore.hs
• compiler/GHC/Tc/Errors.hs
• compiler/GHC/Tc/Instance/Family.hs
• compiler/GHC/Tc/Instance/FunDeps.hs
• compiler/GHC/Tc/Module.hs
• compiler/GHC/Tc/Solver/Default.hs
• compiler/GHC/Tc/Solver/Dict.hs
• compiler/GHC/Tc/Solver/Equality.hs
• + compiler/GHC/Tc/Solver/FunDeps.hs
• compiler/GHC/Tc/Solver/InertSet.hs
• compiler/GHC/Tc/Solver/Monad.hs
• compiler/GHC/Tc/Solver/Solve.hs
• compiler/GHC/Tc/TyCl/Utils.hs
• compiler/GHC/Tc/Types/Constraint.hs
• compiler/GHC/Tc/Types/Origin.hs
• compiler/GHC/Tc/Utils/TcMType.hs
• compiler/GHC/Tc/Utils/TcType.hs
• compiler/GHC/Tc/Utils/Unify.hs
• compiler/GHC/Tc/Zonk/TcType.hs
• compiler/GHC/Types/Basic.hs
• compiler/GHC/Types/Id/Make.hs
• compiler/GHC/Unit/Home/Graph.hs
• compiler/GHC/Unit/Home/PackageTable.hs
• compiler/ghc.cabal.in
• testsuite/tests/deriving/should_fail/T3621.stderr
• testsuite/tests/indexed-types/should_fail/T9662.stderr
• testsuite/tests/parser/should_fail/RecordDotSyntaxFail10.stderr
• testsuite/tests/parser/should_fail/RecordDotSyntaxFail13.stderr
• testsuite/tests/parser/should_fail/T20654a.stderr
• testsuite/tests/partial-sigs/should_fail/T14040a.stderr
• testsuite/tests/polykinds/T6068.stdout
• testsuite/tests/simplCore/should_compile/OpaqueNoCastWW.stderr
• testsuite/tests/typecheck/no_skolem_info/T14040.stderr
• testsuite/tests/typecheck/should_compile/T13651.hs
• + testsuite/tests/typecheck/should_compile/T26154.hs
• + testsuite/tests/typecheck/should_compile/T26154_A.hs
• + testsuite/tests/typecheck/should_compile/T26154_B.hs
• + testsuite/tests/typecheck/should_compile/T26154_B.hs-boot
• + testsuite/tests/typecheck/should_compile/T26154_Other.hs
• + testsuite/tests/typecheck/should_compile/T26277.hs
• testsuite/tests/typecheck/should_compile/all.T
• testsuite/tests/typecheck/should_compile/tc126.hs
• testsuite/tests/typecheck/should_fail/FD3.stderr
• testsuite/tests/typecheck/should_fail/FDsFromGivens2.stderr
• testsuite/tests/typecheck/should_fail/T13506.stderr
• testsuite/tests/typecheck/should_fail/T19415.stderr
• testsuite/tests/typecheck/should_fail/T19415b.stderr
• testsuite/tests/typecheck/should_fail/T5246.stderr
• testsuite/tests/typecheck/should_fail/T5978.stderr
• testsuite/tests/typecheck/should_fail/T8603.stderr
• testsuite/tests/typecheck/should_fail/T9612.stderr
• testsuite/tests/typecheck/should_fail/tcfail143.stderr

The diff was not included because it is too large.