GitLab

Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC

Commits:

e5cb5491

by Cheng Shao at 2026-01-24T07:12:34-05:00

hadrian: drop obsolete configure/make builder logic for libffi

This patch drops obsolete hadrian logic around `Configure
libffiPath`/`Make libffiPath` builders, they are no longer needed
after libffi-clib has landed. Closes #26815.

3 changed files:

hadrian/src/Context.hs
hadrian/src/Settings/Builders/Configure.hs
hadrian/src/Settings/Builders/Make.hs

Changes:

hadrian/src/Context.hs

@@ -11,7 +11,7 @@ module Context (
      pkgLibraryFile,
      pkgConfFile, pkgStampFile, resourcePath, objectPath, contextPath, getContextPath, libPath, distDir,
      distDynDir,
 -    haddockStatsFilesDir, ensureConfigured, autogenPath, rtsContext, rtsBuildPath, libffiBuildPath
 +    haddockStatsFilesDir, ensureConfigured, autogenPath, rtsContext, rtsBuildPath
      ) where
  import Base
@@ -93,14 +93,6 @@ rtsContext stage = vanillaContext stage rts
  rtsBuildPath :: Stage -> Action FilePath
  rtsBuildPath stage = buildPath (rtsContext stage)
 --- | Build directory for in-tree 'libffi' library.
 -libffiBuildPath :: Stage -> Action FilePath
 -libffiBuildPath stage = buildPath $ Context
 -    stage
 -    libffi
 -    (error "libffiBuildPath: way not set.")
 -    (error "libffiBuildPath: inplace not set.")
+-
  pkgFileName :: Context -> Package -> String -> String -> Action FilePath
  pkgFileName context package prefix suffix = do
      pid  <- pkgUnitId (stage context) package

hadrian/src/Settings/Builders/Configure.hs

@@ -8,8 +8,7 @@ configureBuilderArgs :: Args
  configureBuilderArgs = do
      stage      <- getStage
      gmpPath    <- expr (gmpBuildPath stage)
 -    libffiPath <- expr (libffiBuildPath stage)
 -    mconcat [ builder (Configure gmpPath) ? do
 +    builder (Configure gmpPath) ? do
                  targetArch <- queryTarget queryArch
                  targetPlatform <- queryTarget targetPlatformTriple
                  buildPlatform <- queryBuild targetPlatformTriple
@@ -28,16 +27,3 @@ configureBuilderArgs = do
                       -- option.
                       <> [ "--enable-alloca=malloc-notreentrant" | targetArch == "wasm32" ]
                       <> [ "--with-pic=yes" ]
+-
 -            , builder (Configure libffiPath) ? do
 -                top            <- expr topDirectory
 -                targetPlatform <- queryTarget targetPlatformTriple
 -                way            <- getWay
 -                pure [ "--prefix=" ++ top -/- libffiPath -/- "inst"
 -                     , "--libdir=" ++ top -/- libffiPath -/- "inst/lib"
 -                     , "--enable-static=yes"
 -                     , "--enable-shared="
 -                            ++ (if wayUnit Dynamic way
 -                                    then "yes"
 -                                    else "no")
 -                     , "--host=" ++ targetPlatform ] ]

hadrian/src/Settings/Builders/Make.hs

@@ -12,12 +12,8 @@ makeBuilderArgs = do
      threads    <- shakeThreads <$> expr getShakeOptions
      stage      <- getStage
      gmpPath    <- expr (gmpBuildPath stage)
 -    libffiPaths <- forM [Stage1, Stage2, Stage3 ] $ \s -> expr (libffiBuildPath s)
      let t = show $ max 4 (threads - 2) -- Don't use all Shake's threads
 -    mconcat $
 -        (builder (Make gmpPath   ) ? pure ["MAKEFLAGS=-j" ++ t]) :
 -        [ builder (Make libffiPath) ? pure ["MAKEFLAGS=-j" ++ t, "install"]
 -        | libffiPath <- libffiPaths ]
 +    builder (Make gmpPath) ? pure ["MAKEFLAGS=-j" ++ t]
  validateBuilderArgs :: Args
  validateBuilderArgs = builder (Make "testsuite/tests") ? do