Apoorv Ingle pushed to branch wip/spj-apporv-Oct24 at Glasgow Haskell Compiler / GHC

Commits:

• 0fb37893
  by Matthew Pickering at 2025-06-23T13:55:10-04:00

  Move ModuleGraph into UnitEnv
  
  The ModuleGraph is a piece of information associated with the
  ExternalPackageState and HomeUnitGraph. Therefore we should store it
  inside the HomeUnitEnv.
  

• 3bf6720e
  by soulomoon at 2025-06-23T13:55:52-04:00

  Remove hptAllFamInstances usage during upsweep
  
  Fixes #26118
  
  This change eliminates the use of hptAllFamInstances during the upsweep phase,
  as it could access non-below modules from the home package table.
  
  The following updates were made:
  
  * Updated checkFamInstConsistency to accept an explicit ModuleEnv FamInstEnv
    parameter and removed the call to hptAllFamInstances.
  * Adjusted hugInstancesBelow so we can construct ModuleEnv FamInstEnv
    from its result,
  * hptAllFamInstances and allFamInstances functions are removed.
  

• 4cd6429d
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  - Remove one `SrcSpan` field from `VAExpansion`. It is no longer needed.
  - Make `tcExpr` take a `Maybe HsThingRn` which will be passed on to tcApp and used by splitHsApps to determine a more accurate `AppCtx`
  - `tcXExpr` is less hacky now
  - do not look through HsExpansion applications
  - kill OrigPat and remove HsThingRn From VAExpansion
  - look through XExpr ExpandedThingRn while inferring type of head
  - always set in generated code after stepping inside a ExpandedThingRn
  - fixing record update error messages
  - remove special case of tcbody from tcLambdaMatches
  - wrap last stmt expansion in a HsPar so that the error messages are prettier
  - remove special case of dsExpr for ExpandedThingTc
  - make EExpand (HsExpr GhcRn) instead of EExpand HsThingRn
  - fixing error messages for rebindable
  

• fe55834b
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  some progress on tick
  

• a258d0e7
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  remove adhoc cases from ticks
  

• a620300b
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  fix the case where head of the application chain is an expanded expression and the argument is a type application c.f. T19167.hs
  

• 0eba8097
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  move setQLInstLevel inside tcInstFun
  

• ab6d8ea9
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  ignore ds warnings originating from gen locations
  

• bcfecf7e
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  filter expr stmts error msgs
  

• 2f877d2f
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  exception for AppDo while  making error ctxt
  

• d8e66ef2
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  moving around things for locations and error ctxts
  

• 001515a0
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  popErrCtxt doesn't push contexts and popErrCtxts in the first argument to bind and >> in do expansion statements
  

• c3e320f3
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  accept test cases with changed error messages
  
  -------------------------
  Metric Decrease:
      T9020
  -------------------------
  

• 8a34d35f
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  look through PopErrCtxt while splitting exprs in application chains
  

• 6a3fd9ce
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  remove special case for HsExpanded in Ticks
  

• d7b17d49
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  check the right origin for record selector incomplete warnings
  

• d5895136
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  kill VAExpansion
  

• 84731698
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  pass CtOrigin to tcApp for instantiateSigma
  

• 9a7dcbca
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  do not suppress pprArising
  

• 8a6b5771
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  kill VACall
  

• c538fa76
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  kill AppCtxt
  

• 82fbc450
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  remove addHeadCtxt
  

• 875ba420
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  fix pprArising for MonadFailErrors
  

• 4b6cdbc9
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  rename ctxt to sloc
  

• aa53551b
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  fix RepPolyDoBind error message herald
  

• a347731a
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  SrcCodeCtxt
  
  more changes
  

• ef425b46
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  make tcl_in_gen_code a SrcCodeCtxt and rename DoOrigin to DoStmtOrigin
  

• 72820354
  by Apoorv Ingle at 2025-06-23T17:53:11-05:00

  make error messages for records saner
  

58 changed files:

• compiler/GHC.hs
• compiler/GHC/Core/Opt/Pipeline.hs
• compiler/GHC/Driver/Backpack.hs
• compiler/GHC/Driver/Env.hs
• compiler/GHC/Driver/Env/Types.hs
• compiler/GHC/Driver/Main.hs
• compiler/GHC/Driver/Make.hs
• compiler/GHC/Driver/Pipeline/Execute.hs
• compiler/GHC/Hs.hs
• compiler/GHC/Hs/Expr.hs
• compiler/GHC/HsToCore/Expr.hs
• compiler/GHC/HsToCore/Match.hs
• compiler/GHC/HsToCore/Pmc.hs
• compiler/GHC/HsToCore/Quote.hs
• compiler/GHC/HsToCore/Ticks.hs
• compiler/GHC/Iface/Load.hs
• compiler/GHC/Rename/Expr.hs
• compiler/GHC/Tc/Errors/Ppr.hs
• compiler/GHC/Tc/Gen/App.hs
• + compiler/GHC/Tc/Gen/App.hs-boot
• compiler/GHC/Tc/Gen/Do.hs
• compiler/GHC/Tc/Gen/Expr.hs
• compiler/GHC/Tc/Gen/Head.hs
• compiler/GHC/Tc/Gen/Match.hs
• compiler/GHC/Tc/Instance/Family.hs
• compiler/GHC/Tc/Module.hs
• compiler/GHC/Tc/Types/LclEnv.hs
• compiler/GHC/Tc/Types/Origin.hs
• compiler/GHC/Tc/Utils/Monad.hs
• compiler/GHC/Unit/Env.hs
• compiler/GHC/Unit/Home/Graph.hs
• compiler/GHC/Unit/Home/PackageTable.hs
• ghc/GHCi/UI.hs
• testsuite/tests/deSugar/should_compile/T10662.stderr
• testsuite/tests/deSugar/should_compile/T3263-1.stderr
• testsuite/tests/deSugar/should_compile/T3263-2.stderr
• testsuite/tests/default/default-fail05.stderr
• testsuite/tests/indexed-types/should_fail/T2693.stderr
• testsuite/tests/indexed-types/should_fail/T5439.stderr
• testsuite/tests/plugins/test-defaulting-plugin.stderr
• testsuite/tests/polykinds/T13393.stderr
• testsuite/tests/printer/T17697.stderr
• testsuite/tests/typecheck/should_compile/T14590.stderr
• testsuite/tests/typecheck/should_compile/valid_hole_fits.stderr
• testsuite/tests/typecheck/should_fail/DoExpansion1.stderr
• testsuite/tests/typecheck/should_fail/DoExpansion2.stderr
• testsuite/tests/typecheck/should_fail/T10971d.stderr
• testsuite/tests/typecheck/should_fail/T13311.stderr
• testsuite/tests/typecheck/should_fail/T24064.stderr
• testsuite/tests/typecheck/should_fail/T3323.stderr
• testsuite/tests/typecheck/should_fail/T3613.stderr
• testsuite/tests/typecheck/should_fail/T7851.stderr
• testsuite/tests/typecheck/should_fail/T8603.stderr
• testsuite/tests/typecheck/should_fail/T9612.stderr
• testsuite/tests/typecheck/should_fail/tcfail102.stderr
• testsuite/tests/typecheck/should_fail/tcfail128.stderr
• testsuite/tests/typecheck/should_fail/tcfail168.stderr
• testsuite/tests/warnings/should_fail/CaretDiagnostics1.stderr

The diff was not included because it is too large.