GitLab

Rodrigo Mesquita pushed to branch wip/module_graph_mode at Glasgow Haskell Compiler / GHC

Commits:

34a9b55d

by lazyLambda at 2025-04-04T06:22:26-04:00

Driver: make MonadComprehensions imply ParallelListComp

This commit changes GHC.Driver.Flags.impliedXFlags to make the
MonadComprehensions extension enable the ParallelListComp extension.

Fixes #25645

d99eb7cd

by sheaf at 2025-04-04T06:23:28-04:00

NamedDefaults: handle poly-kinded unary classes

With this commit, we accept named default declarations for poly-kinded
classes such as Typeable, e.g.

  default Typeable (Char)

This used to fail because we assumed the kind of the class was monomorphic,
e.g.

  Type -> Constraint
  (Type -> Type) -> Constraint
  Nat -> Constraint

Now, we can handle a simple polymorphic class such as

  Typeable :: forall k. k -> Constraint

Note that we keep the restriction that the class must only have
one visible argument.

This is all explained in the new Note [Instance check for default declarations]
in GHC.Tc.Gen.Default.

Fixes #25882

4cbc90de

by sheaf at 2025-04-04T11:39:05-04:00

LLVM: add type annotations to AtomicFetch_cmm.cmm

e2237305

by sheaf at 2025-04-04T11:39:05-04:00

Cmm lint: lint argument types of CallishMachOps

This commit adds a new check to Cmm lint to ensure that the argument
types to a CallishMachOp are correct. The lack of this check was
detected in the AtomicFetch test: the literals being passed as the
second arguments to operations such as 'fetch_add', 'fetch_and'... were
of the wrong width, which tripped up the LLVM backend.

9363e547

by Cheng Shao at 2025-04-04T11:39:50-04:00

ci: add ghc-wasm-meta integration testing jobs

This patch adds ghc-wasm-meta integration testing jobs to the CI
pipeline, which are only triggered via the `test-wasm` MR label or
manually when the `wasm` label is set.

These jobs will fetch the wasm bindists and test them against a
variety of downstream projects, similarly to head.hackage jobs for
native bindists, offering a convenient way to catch potential
downstream breakage while refactoring the wasm backend.

27029e60

by Adam Gundry at 2025-04-04T11:40:36-04:00

base: Minor fixes to GHC.Records haddocks

This corrects a stale reference to OverloadedRecordFields (which should
be OverloadedRecordDot), fixes the haddock link syntax and adds an
@since pragma.

f827c4c6

by Rodrigo Mesquita at 2025-04-07T11:22:10-04:00

Parametrize default logger action with Handles

Introduce `defaultLogActionWithHandles` to allow GHC applications to use
GHC's formatting but using custom handles.

`defaultLogAction` is then trivially reimplemented as
```
defaultLogActionWithHandles stdout stderr
```

5dade5fd

by sheaf at 2025-04-07T11:23:02-04:00

Finer-grained recompilation checking for exports

This commit refines the recompilation checking logic, to avoid
recompiling modules with an explicit import list when the modules they
import start exporting new items.

More specifically, when:

  1. module N imports module M,
  2. M is changed, but in a way that:
      a. preserves the exports that N imports
      b. does not introduce anything that forces recompilation downstream,
         such as orphan instances

then we no longer require recompilation of N.

Note that there is more to (2a) as initially meets the eye:

  - if N includes a whole module or "import hiding" import of M,
    then we require that the export list of M does not change,
  - if N only includes explicit imports, we check that the imported
    items don't change, e.g.

      - if we have @import M(T(K, f), g)@, we must check that N
        continues to export all these identifiers, with the same Avail
        structure (i.e. we should error if N stops bundling K or f with
        T)
      - if we have @import M(T(..))@, we must check that the children
        of T have not changed

See Note [When to recompile when export lists change?] in GHC.Iface.Recomp.

This is all tested in the new tests RecompExports{1,2,3,4,5}

Fixes #25881

f32d6c2b

by Andreas Klebinger at 2025-04-07T22:01:25-04:00

NCG: AArch64 - Add -finter-module-far-jumps.

When enabled the arm backend will assume jumps to targets outside of the
current module are further than 128MB away.

This will allow for code to work if:
* The current module results in less than 128MB of code.
* The whole program is loaded within a 4GB memory region.

We have seen a few reports of broken linkers (#24648) where this flag might allow
a program to compile/run successfully at a very small performance cost.

-------------------------
Metric Increase:
    T783
-------------------------

553c280b

by Andreas Klebinger at 2025-04-07T22:02:11-04:00

Revert "rts: fix small argument passing on big-endian arch (fix #23387)"

Based on analysis documented in #25791 this doesn't fully fix the big
while introducing new bugs on little endian architectures.

A more complete fix will have to be implemented to fix #23387

This reverts commit 4f02d3c1a7b707e609bb3aea1dc6324fa19a5c39.

b0dc6599

by Andreas Klebinger at 2025-04-07T22:02:11-04:00

Interpreter: Fixes to handling of subword value reads/writes.

Load subword values as full words from the stack truncating/expanding as
neccesary when dealing with subwords. This way byte order is implicitly
correct.

This commit also fixes the order in which we are pushing literals onto
the stack on big endian archs.

Last but not least we enable a test for ghci which actually tests these
subword operations.

ed38c09b

by Cheng Shao at 2025-04-07T22:02:53-04:00

testsuite: don't test WasmControlFlow stdout

This patch solves a potential test flakiness in `WasmControlFlow` by
removing `WasmControlFlow.stdout` which is not so portable/stable as
it seems. See added `Note [WasmControlFlow]` for more detailed
explanation.

f807c590
by Rodrigo Mesquita at 2025-04-08T17:41:51-04:00
```
debugger: Add docs to obtainTermFromId
```

5dba052d

by Rodrigo Mesquita at 2025-04-08T17:41:51-04:00

Move logic to find and set Breakpoint to GHC

Breakpoints are uniquely identified by a module and an index unique
within that module. `ModBreaks` of a Module contains arrays mapping from
this unique breakpoint index to information about each breakpoint. For
instance, `modBreaks_locs` stores the `SrcSpan` for each breakpoint.

To find a breakpoint using the line number you need to go through all
breakpoints in the array for a given module and look at the line and
column stored in the `SrcSpan`s. Similarly for columns and finding
breakpoints by name.

This logic previously lived within the `GHCi` application sources,
however, it is common to any GHC applications wanting to set
breakpoints, like the upcoming `ghc-debugger`.

This commit moves this logic for finding and setting breakpoints to the
GHC library so it can be used by both `ghci` and `ghc-debugger`.

bc0b9f73

by Rodrigo Mesquita at 2025-04-08T17:41:51-04:00

Refactor and move logic for identifier breakpoints

Breakpoints can be set on functions using syntax of the form
`[Module.]function`. The parsing, resolution (e.g. inferring implicit
module), and validation of this syntax for referring to functions was
tightly coupled with its GHCi use.

This commit extracts the general purpose bits of resolving this syntax
into `GHC.Runtime.Debugger.Breakpoints` so it can be further used by
other GHC applications and to improve the code structure of GHCi.

Moreover, a few utilities that do splitting and joining of identifiers
as strings were moved to `GHC.Runtime.Eval.Utils`, which also can be
used in the future to clean up `GHC.Runtime.Eval` a bit.

4f728d21
by Rodrigo Mesquita at 2025-04-08T17:41:51-04:00
```
debugger: derive Ord for BreakpointIds
```

5528771c

by Rodrigo Mesquita at 2025-04-08T17:41:51-04:00

debugger: Move context utils from GHCi to GHC

Moves `enclosingTickSpan`, `getCurrentBreakSpan`, and
`getCurrentBreakModule`, general utilities on the internal debugger
state, into the GHC library.

4871f543

by sheaf at 2025-04-08T17:42:43-04:00

Implicit quantification in type synonyms: add test

This adds a test for ticket #24090, which involves implicit
quantification in type synonyms.
The underlying issue was fixed in 0d4ee209dfe53e5074d786487f531dabc36d561c.

48917d3c

by sheaf at 2025-04-08T17:42:44-04:00

Turn on implicit-rhs-quantification by default

This flag was added to GHC 9.8, and will be removed in a future GHC
release. In preparation, this commit adds it to the default warning
flags.

629be068

by Rodrigo Mesquita at 2025-04-08T17:43:26-04:00

debugger: Add breakpoints to every Stmt

While single-stepping through a Haskell program we stop at every
breakpoint. However, we don't introduce breakpoints at every single
expression (e.g. single variables) because they would be too many and
uninteresting.

That said, in a do-block, it is expected that stepping over would break
at every line, even if it isn't particularly interesting (e.g. a single
arg like getArgs). Moreover, let-statements in do-blocks, despite only
being evaluated once needed, lead to surprising jumps while stepping
through because some have outermost (outside the let) breakpoints
while others don't.

This commit makes every statement in a do-block have a breakpoint.
This leads to predictable stepping through in a do-block.
Duplicate breakpoints in the same location are avoided using the
existing blacklist mechanism, which was missing a check in one relevant place.

Fixes #25932

99a3affd

by Matthew Pickering at 2025-04-08T17:44:08-04:00

driver: refactor: Split downsweep and MakeAction into separate modules.

This will facilitate using the downsweep functions in other parts of
the compiler than just --make mode.

Also, the GHC.Driver.Make module was huge. Now it's still huge but
slightly smaller!

ecfec4df

by sheaf at 2025-04-09T14:13:12-04:00

Store user-written qualification in the GhcRn AST

This commit ensures we store the original user-written module
qualification in the renamed AST. This allows us to take into account
the user-written qualification in error messages.

Fixes #25877

97c884e2

by sheaf at 2025-04-09T14:13:12-04:00

TcRnIllegalTermLevelUse: simpler error when possible

This commit makes GHC emit a simple error message in the case of an
illegal term-level use of a data constructor: we will try to report an
out-of-scope error instead of a "Illegal term level use" error, as the
latter might be a bit overwhelming for newcomers.

We do this when we have a data constructor import suggestion to provide
to the user. For example:

  module M where { data A = A }

  module N where
    import M(A)

    x = Bool
    -- Illegal term-level use of Bool

    y = A
    -- Data constructor not in scope: A.
    -- Perhaps add 'A' to the import list of 'M'.

This commit also revamps the "similar names" suggestion mechanism,
and in particular its treatment of name spaces. Now, which name spaces
we suggest is based solely on what we are looking for, and no longer on
the NameSpace of the Name we have. This is because, for illegal term-level
use errors, it doesn't make much sense to change the suggestions based
on the fact that we resolved to e.g. a type constructor/class; what
matters is what we were expecting to see in this position.
See GHC.Rename.Unbound.{suggestionIsRelevant,relevantNameSpace} as well
as the new constructors to GHC.Tc.Errors.Types.WhatLooking.

Fixes #23982

bff645ab

by Rodrigo Mesquita at 2025-04-09T14:13:57-04:00

driver: Split Session functions out of Main

This commit moves out functions that help in creating and validating a
GHC multi session from Main into the ghc library where they can be used by
other GHC applications.

Moreover, `Mode` processing and `checkOptions` linting were moved to
separate modules within the ghc-bin executable package.

In particular:

- Move `Mode` types and functions (referring to the mode GHC is running
  on) to `ghc-bin:GHC.Driver.Session.Mode`

- Move `checkOptions` and aux functions, which validates GHC DynFlags
  based on the mode, to `ghc-bin:GHC.Driver.Session.Lint`

- Moves `initMulti`, `initMake`, and aux functions, which initializes a make/multi-unit
  session, into `ghc:GHC.Driver.Session.Units`.

501b015e
by Rodrigo Mesquita at 2025-04-09T14:13:57-04:00
```
docs: Improve haddock of ExecComplete
```

dea98988

by Andreas Klebinger at 2025-04-09T19:23:57-04:00

Avoid oversaturing constructor workers.

Constructor applications always need to take the exact number of
arguments. If we can't ensure that instead apply the constructor worker
like a regular function.

Fixes #23865

f1acdd2c

by sheaf at 2025-04-09T19:25:41-04:00

NamedDefaults: require the class to be standard

We now only default type variables if they only appear in constraints
of the form `C v`, where `C` is either a standard class or a class with
an in-scope default declaration.

This rectifies an oversight in the original implementation of the
NamedDefault extensions that was remarked in #25775; that implementation
allowed type variables to appear in unary constraints which had arbitrary
classes at the head.

See the rewritten Note [How type-class constraints are defaulted] for
details of the implementation.

Fixes #25775
Fixes #25778

5712e0d6

by Vladislav Zavialov at 2025-04-10T05:17:38+00:00

Retry type/class declarations and instances (#12088)

Retry type/class declarations and instances to account for non-lexical
dependencies arising from type/data family instances.

This patch improves the kind checker's ability to use type instances in kind
checking of other declarations in the same module.

* Key change: tcTyAndClassDecls now does multiple passes over the TyClGroups,
  as long as it is able to make progress.
  See the new Note [Retrying TyClGroups] in GHC.Tc.TyCl

* Supporting change: FVs of a TyClGroup are now recorded in its extension
  field, namely XCTyClGroup.
  See the new Note [Prepare TyClGroup FVs] in GHC.Rename.Module

* Instances are no longer inserted at the earliest positions where their FVs
  are bound. This is a simplification.
  See the new Note [Put instances at the end] in GHC.Rename.Module

* Automatic unpacking is now more predictable, but fewer fields get unpacked
  by default. Use explicit {-# UNPACK #-} pragmas instead.
  See the new Note [Flaky -funbox-strict-fields with type/data families]

For the wide range of newly accepted programs, consult the added test cases.

Fixed tickets:
    #12088, #12239, #14668, #15561, #16410, #16448, #16693,
    #19611, #20875, #21172, #22257, #25238, #25834

Metric Decrease:
    T8095

bc73a78d

by sheaf at 2025-04-10T15:07:24-04:00

checkFamApp: don't be so eager to cycle break

As remarked in #25933, a pure refactoring of checkTyEqRhs in
ab77fc8c7adebd610aa0bd99d653f9a6cc78a374 inadvertently changed behaviour,
as it caused GHC to introduce cycle-breaker variables in some
unnecessary circumstances.

This commit refactors 'GHC.Tc.Utils.Unify.checkFamApp' in a way that
should restore the old behaviour, so that, when possible, we first
recur into the arguments and only introduce a cycle breaker if this
recursion fails (e.g. due to an occurs check failure).

Fixes #25933

3acd8182

by Andreas Klebinger at 2025-04-10T22:32:12-04:00

Expand docs for RTS flag `-M`.

The behaviour of how/when exceptions are raised was not really covered
in the docs.

026c1a39

by Adam Sandberg Ericsson at 2025-04-10T22:32:56-04:00

add cases for more SchedulerStatus codes in rts_checkSchedStatus

5977c6a1

by sheaf at 2025-04-10T22:33:46-04:00

Squash warnings in GHC.Runtime.Heap.Inspect

There were incomplete record selector warnings in GHC.Runtime.Heap.Inspect
due to the use of the partial 'dataArgs' record selector. This is fixed
by passing the fields to the 'extractSubTerms' function directly,
rather than passing a value of the parent data type.

6a3e38f5

by Andreas Klebinger at 2025-04-11T15:13:53-04:00

hadrian: Make ghcWithInterpreter the universal source of truth about availability of the interpreter

We were doing some ad-hoc checks in different places in hadrian to
determine whether we supported the interprter or not. Now this check if
confined to one function, `ghcWithInterpreter`, and all the places which
use this information consult `ghcWithInterpreter` to determine what to
do.

Fixes #25533.

207de6f1

by Matthew Pickering at 2025-04-11T15:14:37-04:00

testsuite: Fix running TH tests with profiled dynamic compiler

Previously, I had failed to update the ghc_th_way_flags logic for the
profiled dynamic compiler.

In addition to this `ghc_dynamic` was incorrectly set for profiled
dynamic compiler.

I also updated MultiLayerModulesTH_OneShot test to work for any compiler
linkage rather than just dynamic.

Fixes #25947

-------------------------
Metric Decrease:
    MultiLayerModulesTH_Make
-------------------------

5455f2b9

by Matthew Pickering at 2025-04-12T08:31:36-04:00

driver: Add support for "Fixed" nodes in the ModuleGraph

A fixed node in the module graph is one which we presume is already
built. It's therefore up to the user to make sure that the interface
file and any relevant artifacts are available for a fixed node.

Fixed/Compile nodes are represented by the ModuleNodeInfo type, which
abstracts the common parts of Fixed/Compile nodes with accessor
functions of type `ModuleNodeInfo -> ...`.

Fixed nodes can only depend on other fixed nodes. This invariant can be
checked by the function `checkModuleGraph` or `mkModuleGraphChecked`.

--make mode is modified to work with fixed mode. In order to "compile" a
fixed node, the artifacts are just loaded into the HomePackageTable.
Currently nothing in the compiler will produce Fixed nodes but this is
tested with the FixedNodes GHC API test.

In subsequent patches we are going to remove the ExternalModuleGraph and
use Fixed nodes for modules in the module graph in oneshot mode.

Fixes #25920

ad64d5c2

by Cheng Shao at 2025-04-12T08:32:19-04:00

ci: remove manual case of ghc-wasm-meta downstream testing jobs

This patch removes the manual case of ghc-wasm-meta downstream testing
jobs; now the only way of including them in the pipeline and running
them is via the test-wasm label.

The reason of the removal is it proves to be problematic for MRs with
only the wasm label; the wasm job would succeed, then the pipeline
status would be waiting for manual action instead of succeeding. There
needs to be separate jobs for the label-triggered and manual-triggered
cases, but I don't think it's worth that extra complexity, the
label-triggered case is already sufficient.

b34890c7

by Vladislav Zavialov at 2025-04-13T01:08:21+03:00

Fix EmptyCase panic in tcMatches (#25960)

Due to faulty reasoning in Note [Pattern types for EmptyCase],
tcMatches was too keen to panic.

* Old (incorrect) assumption: pat_tys is a singleton list.
  This does not hold when \case{} is checked against a function type
  preceded by invisible forall. See the new T25960 test case.

* New (hopefully correct) assumption: vis_pat_tys is a singleton list.
  This should follow from:

    checkArgCounts :: MatchGroup GhcRn ... -> TcM VisArity
    checkArgCounts (MG { mg_alts = L _ [] })
      = return 1
    ...

84806ebc
by Vladislav Zavialov at 2025-04-13T11:40:08-04:00
```
Remove unused type: TokenLocation
```

05eb50df

by Vladislav Zavialov at 2025-04-13T19:16:38-04:00

Register EpToken in Parser.PostProcess.Haddock (#22558)

This change allows us to reject more badly placed Haddock comments.
Examples:

  module
    -- | Bad comment for the module
    T17544_kw where

  data Foo -- | Bad comment for MkFoo
    where MkFoo :: Foo

  newtype Bar -- | Bad comment for MkBar
    where MkBar :: () -> Bar

  class Cls a
      -- | Bad comment for clsmethod
    where
      clsmethod :: a

01944e5e

by Vladislav Zavialov at 2025-04-13T19:17:21-04:00

Reject puns in T2T (#24153)

This patch implements pun detection in T2T. Consider:

  x = 42
  f, g :: forall a -> ...
  f (type x) = g x

In accordance with the specification, the `g x` function call is renamed
as a term, so `x` refers to the top-level binding `x = 42`, not to the
type variable binding `type x` as one might expect.

This is somewhat counterintuitive because `g` expects a type argument.
Forbidding puns in T2T allows us to produce a helpful error message:

  Test.hs:5:16: error: [GHC-09591]
    Illegal punned variable occurrence in a required type argument.
    The name ‘x’ could refer to:
      ‘x’ defined at Test.hs:3:1
      ‘x’ bound at Test.hs:5:9

This commit is a follow up to 0dfb1fa799af254c8a1e1045fc3996af2d57a613
where checking for puns was left as future work.

cc580552

by Vladislav Zavialov at 2025-04-13T19:18:02-04:00

Additional test cases for #12088, #13790

Extract more test cases from ticket discussions, including multi-module
examples. Follow up to 5712e0d646f611dfbfedfd7ef6dff3a18c016edb

d47bf776

by Matthew Pickering at 2025-04-14T16:44:41+01:00

driver: Use ModuleGraph for oneshot and --make mode

This patch uses the `hsc_mod_graph` field for both oneshot and --make
mode. Therefore, if part of the compiler requires usage of the module
graph, you do so in a uniform way for the two different modes.

The `ModuleGraph` describes the relationship between the modules in the
home package and units in external packages. The `ModuleGraph` can be
queried when information about the transitive closure of a package is
needed. For example, the primary use of the ModuleGraph from within the
compiler is in the loader, which needs to know the transitive closure of
a module so it can load all the relevant objects for evaluation.

In --make mode, downsweep computes the ModuleGraph before any
compilation starts.

In oneshot mode, a thunk is created at the start of compilation, which
when forced will compute the module graph beneath the current module.
The thunk is only forced at the moment when the user uses Template
Haskell.

Finally, there are some situations where we need to discover what
dependencies to load but haven't loaded a module graph at all. In this
case, there is a fallback which computes the transitive closure on the
fly and doesn't cache the result. Presumably if you are going to call
getLinkDeps a lot, you would compute the right ModuleGraph before you
started.

Importantly, this removes the ExternalModuleGraph abstraction. This was quite
awkward to work with since it stored information about the home package
inside the EPS.

This patch will also be very useful when implementing explicit level
imports, which requires more significant use of the module graph in
order to determine which level instances are available at.

Towards #25795

-------------------------
Metric Decrease:
    MultiLayerModulesTH_Make
    MultiLayerModulesTH_OneShot
-------------------------

395e0ad1

by sheaf at 2025-04-16T12:33:26-04:00

base: remove .Internal modules (e.g. GHC.TypeLits)

This commit removes the following internal modules from base,
as per CLC proposal 217:

  - GHC.TypeNats.Internal
  - GHC.TypeLits.Internal
  - GHC.ExecutionStack.Internal

Fixes #25007

e0f3ff11

by Patrick at 2025-04-17T04:31:12-04:00

Refactor Handling of Multiple Default Declarations

Fixes: #25912, #25914, #25934

Previously, GHC discarded all loaded defaults (tcg_default) when local
defaults were encountered during typechecking. According to the
exportable-named-default proposal (sections 2.4.2 and 2.4.3), local
defaults should be merged into tcg_default, retaining any defaults
already present while overriding where necessary.

Key Changes:

* Introduce DefaultProvenance to track the origin of default declarations
  (local, imported, or built-in), replacing the original cd_module
  in ClassDefaults with cd_provenance :: DefaultProvenance.
* Rename tcDefaults to tcDefaultDecls, limiting its responsibility to only
  converting renamed class defaults into ClassDefaults.
* Add extendDefaultEnvWithLocalDefaults to merge local defaults into the
  environment, with proper duplication checks:
  - Duplicate local defaults for a class trigger an error.
  - Local defaults override imported or built-in defaults.
* Update and add related notes: Note [Builtin class defaults],
  Note [DefaultProvenance].
* Add regression tests: T25912, T25914, T25934.

Thanks sam and simon for the help on this patch.
Co-authored-by: sheaf <sam.derbyshire@gmail.com>

386f1854

by Teo Camarasu at 2025-04-17T04:31:55-04:00

template-haskell: Remove `addrToByteArrayName` and `addrToByteArray`

These were part of the implementation of the `Lift ByteArray` instance and were errornously exported because this module lacked an explicit export list. They have no usages on Hackage.

Resolves #24782

b96e2f77

by Sylvain Henry at 2025-04-18T20:46:33-04:00

RTS: remove target info and fix host info (#24058)

The RTS isn't a compiler, hence it doesn't have a target and we remove
the reported target info displayed by "+RTS --info". We also fix the
host info displayed by "+RTS --info": the host of the RTS is the
RTS-building compiler's target, not the compiler's host (wrong when
doing cross-compilation).

6d9965f4

by Sylvain Henry at 2025-04-18T20:46:33-04:00

RTS: remove build info

As per the discussion in !13967, there is no reason to tag the RTS with
information about the build platform.

d52e9b3f

by Vladislav Zavialov at 2025-04-18T20:47:15-04:00

Diagnostics: remove the KindMismatch constructor (#25957)

The KindMismatch constructor was only used as an intermediate
representation in pretty-printing.

Its removal addresses a problem detected by the "codes" test case:

  [GHC-89223] is untested (constructor = KindMismatch)

In a concious deviation from the usual procedure, the error code
GHC-89223 is removed entirely rather than marked as Outdated.
The reason is that it never was user-facing in the first place.

e2f2f9d0

by Vladislav Zavialov at 2025-04-20T10:53:39-04:00

Add name for -Wunusable-unpack-pragmas

This warning had no name or flag and was triggered unconditionally.
Now it is part of -Wdefault.

In GHC.Tc.TyCl.tcTyClGroupsPass's strict mode, we now have to
force-enable this warning to ensure that detection of flawed groups
continues to work even if the user disables the warning with the
-Wno-unusable-unpack-pragmas option. Test case: T3990c

Also, the misnamed BackpackUnpackAbstractType is now called
UnusableUnpackPragma.

6caa6508

by Adam Gundry at 2025-04-20T10:54:22-04:00

Fix specialisation of incoherent instances (fixes #25883)

GHC normally assumes that class constraints are canonical, meaning that
the specialiser is allowed to replace one dictionary argument with another
provided that they have the same type.  The `-fno-specialise-incoherents`
flag alters INCOHERENT instance definitions so that they will prevent
specialisation in some cases, by inserting `nospec`.

This commit fixes a bug in 7124e4ad76d98f1fc246ada4fd7bf64413ff2f2e, which
treated some INCOHERENT instance matches as if `-fno-specialise-incoherents`
was in effect, thereby unnecessarily preventing specialisation. In addition
it updates the relevant `Note [Rules for instance lookup]` and adds a new
`Note [Canonicity for incoherent matches]`.

0426fd6c
by Adam Gundry at 2025-04-20T10:54:23-04:00
```
Add regression test for #23429
```

eec96527

by Adam Gundry at 2025-04-20T10:54:23-04:00

user's guide: update specification of overlapping/incoherent instances

The description of the instance resolution algorithm in the user's
guide was slightly out of date, because it mentioned in-scope given
constraints only at the end, whereas the implementation checks for
their presence before any of the other steps.

This also adds a warning to the user's guide about the impact of
incoherent instances on specialisation, and more clearly documents
some of the other effects of `-XIncoherentInstances`.

a00eeaec

by Matthew Craven at 2025-04-20T10:55:03-04:00

Fix bytecode generation for `tagToEnum# <LITERAL>`

Fixes #25975.

2e204269

by Andreas Klebinger at 2025-04-22T12:20:41+02:00

Simplifier: Constant fold invald tagToEnum# calls to bottom expr.

When applying tagToEnum# to a out-of-range value it's best to simply
constant fold it to a bottom expression. That potentially allows more
dead code elimination and makes debugging easier.

Fixes #25976

7250fc0c

by Matthew Pickering at 2025-04-22T16:24:04-04:00

Move -fno-code note into Downsweep module

This note was left behind when all the code which referred to it was
moved into the GHC.Driver.Downsweep module

d2dc89b4

by Matthew Pickering at 2025-04-22T16:24:04-04:00

Apply editing notes to Note [-fno-code mode] suggested by sheaf

These notes were suggested in https://gitlab.haskell.org/ghc/ghc/-/merge_requests/14241

91564daf

by Matthew Pickering at 2025-04-24T00:29:02-04:00

ghci: Use loadInterfaceForModule rather than loadSrcInterface in mkTopLevEnv

loadSrcInterface takes a user given `ModuleName` and resolves it to the
module which needs to be loaded (taking into account module
renaming/visibility etc).

loadInterfaceForModule takes a specific module and loads it.

The modules in `ImpDeclSpec` have already been resolved to the actual
module to get the information from during renaming. Therefore we just
need to fetch the precise interface from disk (and not attempt to rename
it again).

Fixes #25951

2e0c07ab
by Simon Peyton Jones at 2025-04-24T00:29:43-04:00
```
Test for #23298
```

0eef99b0

by Sven Tennie at 2025-04-24T07:34:36-04:00

RV64: Introduce J instruction (non-local jumps) and don't deallocate stack slots for J_TBL (#25738)

J_TBL result in local jumps, there should not deallocate stack slots
(see Note [extra spill slots].)

J is for non-local jumps, these may need to deallocate stack slots.

1bd3d13e

by fendor at 2025-04-24T07:35:17-04:00

Add `UnitId` to `EvalBreakpoint`

The `EvalBreakpoint` is used to communicate that a breakpoint was
encountered during code evaluation.
This `EvalBreakpoint` needs to be converted to an `InternalBreakpointId`
which stores a `Module` to uniquely find the correct `Module` in the
Home Package Table.

The `EvalBreakpoint` used to store only a `ModuleName` which is then
converted to a `Module` based on the currently active home unit.
This is incorrect in the face of multiple home units, the break point
could be in an entirely other home unit!
To fix this, we additionally store the `UnitId` of the `Module` in
`EvalBreakpoint` to later reconstruct the correct `Module`

All of the changes are the consequence of extending `EvalBreakpoint`
with the additional `ShortByteString` of the `UnitId`.

For performance reasons, we store the `ShortByteString` backing the
`UnitId` directly, avoiding marshalling overhead.

fe6ed8d9

by Sylvain Henry at 2025-04-24T18:04:12-04:00

Doc: add doc for JS interruptible calling convention (#24444)

6111c5e4

by Ben Gamari at 2025-04-24T18:04:53-04:00

compiler: Ensure that Panic.Plain.assertPanic' provides callstack

In 36cddd2ce1a3bc62ea8a1307d8bc6006d54109cf @alt-romes removed CallStack
output from `GHC.Utils.Panic.Plain.assertPanic'`. While this output is
redundant due to the exception backtrace proposal, we may be
bootstrapping with a compiler which does not yet include this machinery.
Reintroduce the output for now.

Fixes #25898.

217caad1

by Matthew Pickering at 2025-04-25T18:58:42+01:00

Implement Explicit Level Imports for Template Haskell

This commit introduces the `ExplicitLevelImports` and
`ImplicitStagePersistence` language extensions as proposed in GHC
Proposal #682.

Key Features
------------

- `ExplicitLevelImports` adds two new import modifiers - `splice` and
`quote` - allowing precise control over the level at which imported
identifiers are available
- `ImplicitStagePersistence` (enabled by default) preserves existing
path-based cross-stage persistence behavior
- `NoImplicitStagePersistence` disables implicit cross-stage
persistence, requiring explicit level imports

Benefits
--------

- Improved compilation performance by reducing unnecessary code generation
- Enhanced IDE experience with faster feedback in `-fno-code` mode
- Better dependency tracking by distinguishing compile-time and runtime dependencies
- Foundation for future cross-compilation improvements

This implementation enables the separation of modules needed at
compile-time from those needed at runtime, allowing for more efficient
compilation pipelines and clearer code organization in projects using
Template Haskell.

Implementation Notes
--------------------

The level which a name is availble at is stored in the 'GRE', in the normal
GlobalRdrEnv. The function `greLevels` returns the levels which a specific GRE
is imported at. The level information for a 'Name' is computed by `getCurrentAndBindLevel`.
The level validity is checked by `checkCrossLevelLifting`.

Instances are checked by `checkWellLevelledDFun`, which computes the level an
instance by calling `checkWellLevelledInstanceWhat`, which sees what is
available at by looking at the module graph.

Modifications to downsweep
--------------------------

Code generation is now only enabled for modules which are needed at
compile time.
See the Note [-fno-code mode] for more information.

Uniform error messages for level errors
---------------------------------------

All error messages to do with levels are now reported uniformly using
the `TcRnBadlyStaged` constructor.

Error messages are uniformly reported in terms of levels.

0 - top-level
1 - quote level
-1 - splice level

The only level hard-coded into the compiler is the top-level in
GHC.Types.ThLevelIndex.topLevelIndex.

Uniformly refer to levels and stages
------------------------------------

There was much confusion about levels vs stages in the compiler.
A level is a semantic concept, used by the typechecker to ensure a
program can be evaluated in a well-staged manner.

A stage is an operational construct, program evaluation proceeds in
stages.

Deprecate -Wbadly-staged-types
------------------------------

`-Wbadly-staged-types` is deprecated in favour of `-Wbadly-levelled-types`.

Lift derivation changed
-----------------------

Derived lift instances will now not generate code with expression
quotations.

Before:

```
data A = A Int deriving Lift

=>
lift (A x) = [| A $(lift x) |]
```

After:

```
lift (A x) = conE 'A `appE` (lift x)
```

This is because if you attempt to derive `Lift` in a module where
`NoImplicitStagePersistence` is enabled, you would get an infinite loop
where a constructor was attempted to be persisted using the instance you
are currently defining.

GHC API Changes
---------------

The ModuleGraph now contains additional information about the type of
the edges (normal, quote or splice) between modules. This is abstracted
using the `ModuleGraphEdge` data type.

Fixes #25828

-------------------------
Metric Increase:
MultiLayerModulesTH_Make
-------------------------

7641a74a

by Simon Peyton Jones at 2025-04-26T22:05:19-04:00

Get a decent MatchContext for pattern synonym bindings

In particular when we have a pattern binding
    K p1 .. pn = rhs
where K is a pattern synonym.  (It might be nested.)

This small MR fixes #25995.  It's a tiny fix, to an error message,
removing an always-dubious `unkSkol`.

The bug report was in the context of horde-ad, a big program,
and I didn't manage to make a small repro case quickly. I decided
not to bother further.

ce616f49

by Simon Peyton Jones at 2025-04-27T21:10:25+01:00

Fix infelicities in the Specialiser

On the way to #23109 (unary classes) I discovered some infelicities
(or maybe tiny bugs, I forget) in the type-class specialiser.

I also tripped over #25965, an outright bug in the rule matcher

Specifically:

* Refactor: I enhanced `wantCallsFor`, whih previously always said
`True`, to discard calls of class-ops, data constructors etc.  This is
a bit more efficient; and it means we don't need to worry about
filtering them out later.

* Fix: I tidied up some tricky logic that eliminated redundant
  specialisations.  It wasn't working correctly.  See the expanded
  Note [Specialisations already covered], and
  (MP3) in Note [Specialising polymorphic dictionaries].

  See also the new top-level `alreadyCovered`
  function, which now goes via `GHC.Core.Rules.ruleLhsIsMoreSpecific`

  I also added a useful Note [The (CI-KEY) invariant]

* Fix #25965: fixed a tricky bug in the `go_fam_fam` in
  `GHC.Core.Unify.uVarOrFam`, which allows matching to succeed
  without binding all type varibles.

  I enhanced Note [Apartness and type families] some more

* #25703. This ticket "just works" with -fpolymorphic-specialisation;
  but I was surprised that it worked! In this MR I added documentation
  to Note [Interesting dictionary arguments] to explain; and tests to
  ensure it stays fixed.

22d11fa8

by Simon Peyton Jones at 2025-04-28T18:05:19-04:00

Track rewriter sets more accurately in constraint solving

The key change, which fixed #25440, is to call `recordRewriter` in
GHC.Tc.Solver.Rewrite.rewrite_exact_fam_app.  This missing call meant
that we were secretly rewriting a Wanted with a Wanted, but not really
noticing; and that led to a very bad error message, as you can see
in the ticket.

But of course that led me into rabbit hole of other refactoring around
the RewriteSet code:

* Improve Notes [Wanteds rewrite Wanteds]

* Zonk the RewriterSet in `zonkCtEvidence` rather than only in GHC.Tc.Errors.
  This is tidier anyway (e.g. de-clutters debug output), and helps with the
  next point.

* In GHC.Tc.Solver.Equality.inertsCanDischarge, don't replace a constraint
  with no rewriters with an equal constraint that has many. See
  See (CE4) in Note [Combining equalities]

* Move zonkRewriterSet and friends from GHC.Tc.Zonk.Type into
  GHC.Tc.Zonk.TcType, where they properly belong.

A handful of tests get better error messages.

For some reason T24984 gets 12% less compiler allocation -- good

Metric Decrease:
    T24984

6467d61e

by Brandon Chinn at 2025-04-29T18:36:03-04:00

Fix lexing "\^\" (#25937)

This broke in the refactor in !13128, where the old code parsed escape
codes and collapsed string gaps at the same time, but the new code
collapsed gaps first, then resolved escape codes. The new code used a
naive heuristic to skip escaped backslashes, but didn't account for
"\^\".

99868a86
by Jens Petersen at 2025-04-29T18:36:44-04:00
```
hadrian: default selftest to disabled
```

aba2a4a5

by Zubin Duggal at 2025-04-30T06:35:59-04:00

get-win32-tarballs.py: List tarball files to be downloaded if we cannot find them

Fixes #25929

d99a617b

by Ben Gamari at 2025-04-30T06:36:40-04:00

Move Data ModuleName instance to Language.Haskell.Syntax.Module.Name

Fixes #25968.

9995c2b7

by Serge S. Gulin at 2025-05-04T17:13:36+03:00

Support for ARM64 Windows (LLVM-enabled) (fixes #24603)

1. Add Windows AArch64 cross-compilation support via CI jobs
Introduce new CI configurations for cross-compiling to Windows ARM64 using Debian12Wine, FEX, and MSYS2.
Configure toolchain variables for LLVM MinGW and Wine emulation in CI pipelines.

2. Adjust compiler and RTS for AArch64 Windows compatibility
Reserve register `x18` on Windows and Darwin platforms in AArch64 codegen.
Handle Windows-specific relocations and data sections in AArch64 assembler.
Update PEi386 linker to recognize ARM64 binaries and support exception handling.
Adjust LLVM target definitions and data layouts for new architectures.
Update `ghc-toolchain` and build scripts to handle `TablesNextToCode` on Windows ARM64.

3. Enhance CI scripts and stability
Modify `ci.sh` to handle mingw cross-targets, fixing GHC executable paths and test execution.
Use `diff -w` in tests to ignore whitespace differences, improving cross-platform consistency.

4. Refactor and clean up code
Remove redundant imports in hello.hs test.
Improve error messages and checks for unsupported configurations in the driver.
Add `EXDEV` error code to `errno.js`.
Add async/sync flags to IO logs at `base.js`.
Improve POSIX compatibility for file close at `base.js`: decrease indeterminism for mixed cases of async and sync code.

5. Update dependencies: `Cabal`, `Win32`, `directory`, `process`, `haskeline`, and `unix`.

submodule

Co-authored-by: Cheng Shao <terrorjack@type.dance>
Co-authored-by: Dmitrii Egorov <egorov.d.i@icloud.com>
Co-authored-by: Andrei Borzenkov <root@sandwitch.dev>

50fa8165

by Javran Cheng at 2025-05-05T05:55:39-04:00

Suppress unused do-binding if discarded variable is Any or ZonkAny.

Consider example (#25895):

>  do { forever (return ()); blah }

where `forever :: forall a b. IO a -> IO b`.

Nothing constrains `b`, so it will be instantiates with `Any` or
`ZonkAny`.
But we certainly don't want to complain about a discarded do-binding.

Fixes #25895

e46c6b18

by Rodrigo Mesquita at 2025-05-06T09:01:57-04:00

Refactor mkTopLevImportedEnv out of mkTopLevEnv

This makes the code clearer and allows the top-level import context to
be fetched directly from the HomeModInfo through the API (e.g. useful
for the debugger).

0ce0d263

by Rodrigo Mesquita at 2025-05-06T09:01:57-04:00

Export sizeOccEnv from GHC.Types.Name.Occurrence

Counts the number of OccNames in an OccEnv

165f98d8

by Simon Peyton Jones at 2025-05-06T09:02:39-04:00

Fix a bad untouchability bug im simplifyInfer

This patch addresses #26004.  The root cause was that simplifyInfer
was willing to unify variables "far out".  The fix, in
runTcSWithEvBinds', is to initialise the inert set given-eq level with
the current level. See
    (TGE6) in Note [Tracking Given equalities]
in GHC.Tc.Solver.InertSet

Two loosely related refactors:

* Refactored approximateWCX to return just the free type
  variables of the un-quantified constraints.  That avoids duplication
  of work (these free vars are needed in simplifyInfer) and makes it
  clearer that the constraints themselves are irrelevant.

* A little local refactor of TcSMode, which reduces the number of
  parameters to runTcSWithEvBinds

6e67fa08

by Ben Gamari at 2025-05-08T06:21:21-04:00

llvmGen: Fix built-in variable predicate

Previously the predicate to identify LLVM builtin global variables was
checking for `$llvm` rather than `@llvm` as it should.

a9d0a22c

by Ben Gamari at 2025-05-08T06:21:22-04:00

llvmGen: Fix linkage of built-in arrays

LLVM now insists that built-in arrays use Appending linkage, not
Internal.

Fixes #25769.

9c6d2b1b

by sheaf at 2025-05-08T06:22:11-04:00

Use mkTrAppChecked in ds_ev_typeable

This change avoids violating the invariant of mkTrApp according to which
the argument should not be a fully saturated function type.
This ensures we don't return false negatives for type equality
involving function types.

Fixes #25998

75cadf81

by Ryan Hendrickson at 2025-05-08T06:22:55-04:00

haddock: Preserve indentation in multiline examples

Intended for use with :{ :}, but doesn't look for those characters. Any
consecutive lines with birdtracks will only have initial whitespace
stripped up to the column of the first line.

fee9b351

by Cheng Shao at 2025-05-08T06:23:36-04:00

ci: re-enable chrome for wasm ghci browser tests

Currently only firefox is enabled for wasm ghci browser tests, for
some reason testing with chrome works on my machine but gets stuck on
gitlab instance runners. This patch re-enables testing with chrome by
passing `--no-sandbox`, since chrome sandboxing doesn't work in
containers without `--cap-add=SYS_ADMIN`.

282df905

by Vladislav Zavialov at 2025-05-09T03:18:25-04:00

Take subordinate 'type' specifiers into account

This patch fixes multiple bugs (#22581, #25983, #25984, #25991)
in name resolution of subordinate import lists.

Bug #22581
----------
In subordinate import lists, the use of the `type` namespace specifier
used to be ignored. For example, this import statement was incorrectly
accepted:

  import Prelude (Bool(type True))

Now it results in an error message:

  <interactive>:2:17: error: [GHC-51433]
    In the import of ‘Prelude’:
      a data type called ‘Bool’ is exported,
      but its subordinate item ‘True’ is not in the type namespace.

Bug #25983
----------
In subordinate import lists within a `hiding` clause, non-existent
items led to a poor warning message with -Wdodgy-imports. Consider:

  import Prelude hiding (Bool(X))

The warning message for this import statement used to misreport the
cause of the problem:

  <interactive>:3:24: warning: [GHC-56449] [-Wdodgy-imports]
    In the import of ‘Prelude’:
      an item called ‘Bool’ is exported, but it is a type.

Now the warning message is correct:

  <interactive>:2:24: warning: [GHC-10237] [-Wdodgy-imports]
    In the import of ‘Prelude’:
      a data type called ‘Bool’ is exported, but it does not export
      any constructors or record fields called ‘X’.

Bug #25984
----------
In subordinate import lists within a `hiding` clause, non-existent
items resulted in the entire import declaration being discarded.
For example, this program was incorrectly accepted:

  import Prelude hiding (Bool(True,X))
  t = True

Now it results in an error message:

  <interactive>:2:5: error: [GHC-88464]
    Data constructor not in scope: True

Bug #25991
----------
In subordinate import lists, it was not possible to refer to a class
method if there was an associated type of the same name:

  module M_helper where
    class C a b where
      type a # b
      (#) :: a -> b -> ()

  module M where
    import M_helper (C((#)))

This import declaration failed with:

  M.hs:2:28: error: [GHC-10237]
    In the import of ‘M_helper’:
      an item called ‘C’ is exported, but it does not export any children
      (constructors, class methods or field names) called ‘#’.

Now it is accepted.

Summary
-------
The changes required to fix these bugs are almost entirely confined to
GHC.Rename.Names. Other than that, there is a new error constructor
BadImportNonTypeSubordinates with error code [GHC-51433].

Test cases:
  T22581a T22581b T22581c T22581d
  T25983a T25983b T25983c T25983d T25983e T25983f T25983g
  T25984a T25984b
  T25991a T25991b1 T25991b2

51b0ce8f

by Simon Peyton Jones at 2025-05-09T03:19:07-04:00

Slighty improve `dropMisleading`

Fix #26105, by upgrading the (horrible, hacky) `dropMisleading`
function.

This fix makes things a bit better but does not cure the underlying
problem.

7b2d1e6d

by Simon Peyton Jones at 2025-05-11T03:24:47-04:00

Refine `noGivenNewtypeReprEqs` to account for quantified constraints

This little MR fixes #26020.  We are on the edge of completeness
for newtype equalities (that doesn't change) but this MR makes GHC
a bit more consistent -- and fixes the bug reported.

eaa8093b

by Cheng Shao at 2025-05-11T03:25:28-04:00

wasm: mark freeJSVal as INLINE

This patch marks `freeJSVal` as `INLINE` for the wasm backend. I
noticed that the `freeJSVal` invocations are not inlined when
inspecting STG/Cmm dumps of downstream libraries that use release
build of the wasm backend. The performance benefit of inlining here is
very modest, but so is the cost anyway; if you are using `freeJSVal`
at all then you care about every potential chance to improve
performance :)

eac196df

by Cheng Shao at 2025-05-11T03:25:28-04:00

wasm: add zero length fast path for fromJSString

This patch adds a zero length fast path for `fromJSString`; when
marshaling a zero-length `JSString` we don't need to allocate an empty
`ByteArray#` at all.

652cba7e

by Peng Fan at 2025-05-14T04:24:35-04:00

Add LoongArch NCG support

Not supported before.

c01f4374

by Lin Runze at 2025-05-14T04:24:35-04:00

ci: Add LoongArch64 cross-compile CI for testing

ce6cf240

by Ben Gamari at 2025-05-14T04:25:18-04:00

rts/linker: Don't fail due to RTLD_NOW

In !12264 we started using the NativeObj machinery introduced some time
ago for loading of shared objects. One of the side-effects of this
change is shared objects are now loaded eagerly (i.e. with `RTLD_NOW`).
This is needed by NativeObj to ensure full visibility of the mappings of
the loaded object, which is in turn needed for safe shared object
unloading.

Unfortunately, this change subtly regressed, causing compilation
failures in some programs. Specifically, shared objects which refer to
undefined symbols (e.g. which may be usually provided by either the
executable image or libraries loaded via `dlopen`) will fail to load
with eager binding. This is problematic as GHC loads all package
dependencies while, e.g., evaluating TemplateHaskell splices. This
results in compilation failures in programs depending upon (but not
using at compile-time) packages with undefined symbol references.

To mitigate this NativeObj now first attempts to load an object via
eager binding, reverting to lazy binding (and disabling unloading) on
failure.

See Note [Don't fail due to RTLD_NOW].

Fixes #25943.

88ee8bb5

by Sylvain Henry at 2025-05-14T04:26:15-04:00

Deprecate GHC.JS.Prim.Internal.Build (#23432)

Deprecated as per CLC proposal 329 (https://github.com/haskell/core-libraries-committee/issues/329)

b4ed465b

by Cheng Shao at 2025-05-14T04:26:57-04:00

libffi: update to 3.4.8

Bumps libffi submodule.

a3e71296
by Matthew Pickering at 2025-05-14T04:27:38-04:00
```
Remove leftover trace
```

2d0ecdc6

by Cheng Shao at 2025-05-14T04:28:19-04:00

Revert "ci: re-enable chrome for wasm ghci browser tests"

This reverts commit fee9b351fa5a35d5778d1252789eacaaf5663ae8.
Unfortunately the chrome test jobs may still timeout on certain
runners (e.g. OpenCape) for unknown reasons.

3b3a5dec

by Ben Gamari at 2025-05-15T16:10:01-04:00

Don't emit unprintable characters when printing Uniques

When faced with an unprintable tag we now instead print the codepoint
number.

Fixes #25989.

(cherry picked from commit e832b1fadee66e8d6dd7b019368974756f8f8c46)

e1ef8974

by Mike Pilgrem at 2025-05-16T16:09:14-04:00

Translate iff in Haddock documentation into everyday English

fd64667d

by Vladislav Zavialov at 2025-05-20T03:25:08-04:00

Allow the 'data' keyword in import/export lists (#25899)

This patch introduces the 'data' namespace specifier in import and
export lists. The intended use is to import data constructors without
their parent type constructors, e.g.

  import Data.Proxy as D (data Proxy)
  type DP = D.Proxy   -- promoted data constructor

Additionally, it is possible to use 'data' to explicitly qualify any
data constructors or terms, incl. operators and field selectors

  import Prelude (Semigroup(data (<>)))
  import Data.Function (data (&))
  import Data.Monoid (data Dual, data getDual)

  x = Dual "Hello" <> Dual "World" & getDual

The implementation mostly builds on top of the existing logic for the
'type' and 'pattern' namespace specifiers, plus there are a few tweaks
to how we generate suggestions in error messages.

acc86753

by Ben Gamari at 2025-05-20T03:25:51-04:00

compiler: Use field selectors when creating BCOs

This makes it easier to grep for these fields.

60a55fd7

by Ben Gamari at 2025-05-20T03:25:51-04:00

compiler: Clarify BCO size

Previously the semantics and size of StgBCO was a bit unclear.
Specifically, the `size` field was documented to contain the size of the
bitmap whereas it was actually the size of the closure *and* bitmap.
Additionally, it was not as clear as it could be that the bitmap was a
full StgLargeBitmap with its own `size` field.

ac9fb269

by Simon Peyton Jones at 2025-05-20T09:19:04-04:00

Track rewriter sets more accurately in constraint solving

This MR addresses #26003, by refactoring the arcane
intricacies of Note [Equalities with incompatible kinds].
NB: now retitled to
    Note [Equalities with heterogeneous kinds].
and the main Note for this MR.

In particular:

* Abandon invariant (COERCION-HOLE) in Note [Unification preconditions] in
  GHC.Tc.Utils.Unify.

* Abandon invariant (TyEq:CH)) in Note [Canonical equalities] in
  GHC.Tc.Types.Constraint.

* Instead: add invariant (REWRITERS) to Note [Unification preconditions]:
  unify only if the constraint has an empty rewriter set.

Implementation:

* In canEqCanLHSFinish_try_unification, skip trying unification if there is a
  non-empty rewriter set.

* To do this, make sure the rewriter set is zonked; do so in selectNextWorkItem,
  which also deals with prioritisation.

* When a coercion hole is filled, kick out inert equalities that have that hole
  as a rewriter.  It might now be unlocked and available to unify.

* Remove the ad-hoc `ch_hetero_kind` field of `CoercionHole`.

* In `selectNextWorkItem`, priorities equalities withan empty rewriter set.

* Defaulting: see (DE6) in Note [Defaulting equalities]
  and Note [Limited defaulting in the ambiguity check]

* Concreteness checks: there is some extra faff to try to get decent
  error messages when the FRR (representation-polymorphism) checks
  fail. In partiular, add a "When unifying..." explanation when the
  representation-polymorphism check arose from another constraint.

86406f48

by Cheng Shao at 2025-05-20T09:19:47-04:00

rts: fix rts_clearMemory logic when sanity checks are enabled

This commit fixes an RTS assertion failure when invoking
rts_clearMemory with +RTS -DS. -DS implies -DZ which asserts that free
blocks contain 0xaa as the designated garbage value. Also adds the
sanity way to rts_clearMemory test to prevent future regression.
Closes #26011.

ChatGPT Codex automatically diagnosed the issue and proposed the
initial patch in a single shot, given a GHC checkout and the following
prompt:

---

Someone is reporting the following error when attempting to use `rts_clearMemory` with the RTS option `-DS`:

```
test.wasm: internal error: ASSERTION FAILED: file rts/sm/Storage.c, line 1216

    (GHC version 9.12.2.20250327 for wasm32_unknown_wasi)
    Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug
```

What's the culprit? How do I look into this issue?

---

I manually reviewed & revised the patch, tested and submitted it.

7147370b