GitLab

9815908e

by Simon Hengel at 2025-07-30T11:43:53+07:00

Use isKnownOrigName_maybe to reconstruct wired-in names

9909605a
by Simon Hengel at 2025-07-30T11:43:53+07:00
```
Rely on knownKeysOrigNameCache
```

@@ -100,9 +100,14 @@ OrigNameCache at all?  Good question; after all,
 ) Loading of interface files encodes names via Uniques, as detailed in
       Note [Symbol table representation of names] in GHC.Iface.Binary
 -It turns out that we end up looking up built-in syntax in the cache when we
 -generate Haddock documentation. E.g. if we don't find tuple data constructors
 -there, hyperlinks won't work as expected. Test case: haddockHtmlTest (Bug923.hs)
++
 +However note that:
 +  1) It turns out that we end up looking up built-in syntax in the cache when
 +     we generate Haddock documentation. E.g. if we don't find tuple data
 +     constructors there, hyperlinks won't work as expected. Test case:
 +     haddockHtmlTest (Bug923.hs)
 +  2) HIE de-serialization relies on built-in names being present in the
 +     knownKeysOrigNameCache.
  -}
  -- | The NameCache makes sure that there is just one Unique assigned for

@@ -25,9 +25,6 @@ import GHC.Iface.Ext.Utils
  import GHC.Driver.Session
  import GHC.SysTools
 -makeNc :: IO NameCache
 -makeNc = initNameCache 'z' []
+-
  dynFlagsForPrinting :: String -> IO DynFlags
  dynFlagsForPrinting libdir = do
    systemSettings <- initSysTools libdir
@@ -37,7 +34,7 @@ readTestHie :: FilePath -> IO (DynFlags, HieFile)
  readTestHie fp = do
    libdir:_ <- getArgs
    df <- dynFlagsForPrinting libdir
 -  nc <- makeNc
 +  nc <- newNameCache 'r' knownKeysOrigNameCache
    hfr <- readHieFile nc fp
    pure (df, hie_file_result hfr)