GitLab

Ben Gamari pushed to branch wip/T26539 at Glasgow Haskell Compiler / GHC

Commits:

5dc2e9ea
by Julian Ospald at 2025-10-27T18:17:23-04:00
```
Skip uniques test if sources are not available
```

544b9ec9

by Vladislav Zavialov at 2025-10-27T18:18:06-04:00

Re-export GHC.Hs.Basic from GHC.Hs

Clean up some import sections in GHC by re-exporting GHC.Hs.Basic
from GHC.Hs.

643ce801

by Julian Ospald at 2025-10-28T18:18:55-04:00

rts: remove unneccesary cabal flags

We perform those checks via proper autoconf macros
instead that do the right thing and then add those
libs to the rts buildinfo.

d69ea8fe

by Vladislav Zavialov at 2025-10-28T18:19:37-04:00

Test case for #17705

Starting with GHC 9.12 (the first release to include 5745dbd3),
all examples in this ticket are handled as expected.

4038a28b
by Andreas Klebinger at 2025-10-30T12:38:52-04:00
```
Add a perf test for #26425
```

f997618e

by Andreas Klebinger at 2025-10-30T12:38:52-04:00

OccAnal: Be stricter for better compiler perf.

In particular we are now stricter:

* When combining usageDetails.
* When computing binder info.

In combineUsageDetails when combining the underlying adds we compute a
new `LocalOcc` for each entry by combining the two existing ones.

Rather than wait for those entries to be forced down the road we now
force them immediately. Speeding up T26425 by about 10% with little
effect on the common case.

We also force binders we put into the Core AST everywhere now.
Failure to do so risks leaking the occ env used to set the binders
OccInfo.

For T26425 compiler residency went down by a factor of ~10x.

Compile time also improved by a factor of ~1.6.

-------------------------
Metric Decrease:
    T18698a
    T26425
    T9233
-------------------------

5618645b

by Vladislav Zavialov at 2025-10-30T12:39:33-04:00

Fix namespace specifiers in subordinate exports (#12488)

This patch fixes an oversight in the `lookupChildrenExport` function that
caused explicit namespace specifiers of subordinate export items to be
ignored:

  module M (T (type A)) where   -- should be rejected
  data T = A

Based on the `IEWrappedName` data type, there are 5 cases to consider:
1. Unadorned name:   P(X)
2. Named default:    P(default X)
3. Pattern synonym:  P(pattern X)
4. Type name:        P(type X)
5. Data name:        P(data X)

Case 1 is already handled correctly; cases 2 and 3 are parse errors; and
it is cases 4 and 5 that we are concerned with in this patch.

Following the precedent established in `LookupExactName`, we introduce
a boolean flag in `LookupChildren` to control whether to look up in all
namespaces or in a specific one. If an export item is accompanied by an
explicit namespace specifier `type` or `data`, we restrict the lookup in
`lookupGRE` to a specific namespace.

The newly introduced diagnostic `TcRnExportedSubordinateNotFound`
provides error messages and suggestions more tailored to this context
than the previously used `reportUnboundName`.

f75ab223

by Peter Trommler at 2025-10-31T18:43:13-04:00

ghc-toolchain: detect PowerPC 64 bit ABI

Check preprocessor macro defined for ABI v2 and assume v1 otherwise.
Fixes #26521

d086c474
by Peter Trommler at 2025-10-31T18:43:13-04:00
```
ghc-toolchain: refactor, move lastLine to Utils
```

995dfe0d

by Vladislav Zavialov at 2025-10-31T18:43:54-04:00

Tests for -Wduplicate-exports, -Wdodgy-exports

Add test cases for the previously untested diagnostics:

  [GHC-51876] TcRnDupeModuleExport
  [GHC-64649] TcRnNullExportedModule

This also revealed a typo (incorrect capitalization of "module") in the
warning text for TcRnDupeModuleExport, which is now fixed.

f6961b02

by Cheng Shao at 2025-11-01T00:08:01+01:00

wasm: reformat dyld source code

This commit reformats dyld source code with prettier, to avoid
introducing unnecessary diffs in subsequent patches when they're
formatted before committing.

0c9032a0

by Cheng Shao at 2025-11-01T00:08:01+01:00

wasm: simplify _initialize logic in dyld

This commit simplifies how we _initialize a wasm shared library in
dyld and removes special treatment for libc.so, see added comment for
detailed explanation.

ec1b40bd

by Cheng Shao at 2025-11-01T00:08:01+01:00

wasm: support running dyld fully client side in the browser

This commit refactors the wasm dyld script so that it can be used to
load and run wasm shared libraries fully client-side in the browser
without needing a wasm32-wasi-ghci backend:

- A new `DyLDBrowserHost` class is exported, which runs in the browser
  and uses the in-memory vfs without any RPC calls. This meant to be
  used to create a `rpc` object for the fully client side use cases.
- The exported `main` function now can be used to load user-specified
  shared libraries, and the user can use the returned `DyLD` instance
  to run their own exported Haskell functions.
- The in-browser wasi implementation is switched to
  https://github.com/haskell-wasm/browser_wasi_shim for bugfixes and
  major performance improvements not landed upstream yet.
- When being run by deno, it now correctly switches to non-nodejs code
  paths, so it's more convenient to test dyld logic with deno.

See added comments for details, as well as the added `playground001`
test case for an example of using it to build an in-browser Haskell
playground.

8f3e481f

by Cheng Shao at 2025-11-01T00:08:01+01:00

testsuite: add playground001 to test haskell playground

This commit adds the playground001 test case to test the haskell
playground in browser, see comments for details.

af40606a

by Cheng Shao at 2025-11-01T00:08:04+01:00

Revert "testsuite: add T26431 test case"

This reverts commit 695036686f8c6d78611edf3ed627608d94def6b7. T26431
is now retired, wasm ghc internal-interpreter logic is tested by
playground001.

86c82745

by Vladislav Zavialov at 2025-11-01T07:24:29-04:00

Supplant TcRnExportHiddenComponents with TcRnDodgyExports (#26534)

Remove a bogus special case in lookup_ie_kids_all,
making TcRnExportHiddenComponents obsolete.

fcf6331e

by Richard Eisenberg at 2025-11-03T08:33:05+00:00

Refactor fundep solving

This commit is a large-scale refactor of the increasingly-messy code that
handles functional dependencies.  It has virtually no effect on what compiles
but improves error messages a bit.  And it does the groundwork for #23162.

The big picture is described in
    Note [Overview of functional dependencies in type inference]
in GHC.Tc.Solver.FunDeps

* New module GHC.Tc.Solver.FunDeps contains all the fundep-handling
  code for the constraint solver.

* Fundep-equalities are solved in a nested scope; they may generate
  unifications but otherwise have no other effect.
  See GHC.Tc.Solver.FunDeps.solveFunDeps

  The nested needs to start from the Givens in the inert set, but
  not the Wanteds; hence a new function `resetInertCans`, used in
  `nestFunDepsTcS`.

* That in turn means that fundep equalities never show up in error
  messages, so the complicated FunDepOrigin tracking can all disappear.

* We need to be careful about tracking unifications, so we kick out
  constraints from the inert set after doing unifications.  Unification
  tracking has been majorly reformed: see Note [WhatUnifications] in
  GHC.Tc.Utils.Unify.

  A good consequence is that the hard-to-grok `resetUnificationFlag`
  has been replaced with a simpler use of
  `reportCoarseGrainUnifications`

Smaller things:

* Rename `FunDepEqn` to `FunDepEqns` since it contains multiple
  type equalities.

Some compile time improvement

Metrics: compile_time/bytes allocated
                          Baseline
                  Test       value      New value Change
---------------------- --------------------------------------
         T5030(normal) 173,839,232    148,115,248 -14.8% GOOD
hard_hole_fits(normal) 286,768,048    284,015,416  -1.0%

             geo. mean                             -0.2%
             minimum                              -14.8%
             maximum                               +0.3%

Metric Decrease:
    T5030

231adc30