Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC

Commits:

• 554487a7
  by Rodrigo Mesquita at 2025-10-01T23:04:43-04:00

  cleanup: Drop obsolete comment about HsConDetails
  
  HsConDetails used to have an argument representing the type of the
  tyargs in a list:
  
      data HsConDetails tyarg arg rec
        = PrefixCon [tyarg] [arg]
  
  This datatype was shared across 3 synonyms: HsConPatDetails,
  HsConDeclH98Details, HsPatSynDetails. In the latter two cases, `tyarg`
  was instanced to `Void` meaning the list was always empty for these
  cases.
  
  In 7b84c58867edca57a45945a20a9391724db6d9e4, this was refactored such
  that HsConDetails no longer needs a type of tyargs by construction. The
  first case now represents the type arguments in the args type itself,
  with something like:
  
      ConPat "MkE" [InvisP tp1, InvisP tp2, p1, p2]
  
  So the deleted comment really is just obsolete.
  
  Fixes #26461
  

1 changed file:

• compiler/Language/Haskell/Syntax/Decls.hs

Changes:

 -- | The arguments in a Haskell98-style data constructor.

 type HsConDeclH98Details pass

    = HsConDetails (HsConDeclField pass) (XRec pass [LHsConDeclRecField pass])

--- The Void argument to HsConDetails here is a reflection of the fact that

--- type applications are not allowed in data constructor declarations.

 -- | The arguments in a GADT constructor. Unlike Haskell98-style constructors,

 -- GADT constructors cannot be declared with infix syntax. As a result, we do