Hannes Siebenhandl pushed to branch wip/fendor/remove-stg_stackDecode at Glasgow Haskell Compiler / GHC

Commits:

• a03b407d
  by fendor at 2025-08-25T14:44:23+02:00

  Move stack decoding logic from ghc-heap to ghc-internal
  
  The stack decoding logic in `ghc-heap` is more sophisticated than the one
  currently employed in `CloneStack`. We want to use the stack decoding
  implementation from `ghc-heap` in `base`.
  We cannot simply depend on `ghc-heap` in `base` due do bootstrapping
  issues.
  Thus, we move the code that is necessary to implement stack decoding to
  `ghc-internal`. This is the right location, as we don't want to add a
  new API to `base`.
  
  Moving the stack decoding logic and re-exposing it in ghc-heap is
  insufficient, though, as we have a dependency cycle between.
  
  * ghc-heap depends on stage1:ghc-internal
  * stage0:ghc depends on stage0:ghc-heap
  
  To fix this, we remove ghc-heap from the set of `stage0` dependencies.
  
  This is not entirely straight-forward, as a couple of boot dependencies,
  such as `ghci` depend on `ghc-heap`.
  Luckily, the boot compiler of GHC is now >=9.10, so we can migrate `ghci`
  to use `ghc-internal` instead of `ghc-heap`, which already exports the
  relevant modules.
  
  However, we cannot 100% remove ghc's dependency on `ghc-heap`, since
  when we compile `stage0:ghc`, `stage1:ghc-internal` is not yet
  available.
  Thus, when we compile with the boot-compiler, we still depend on an
  older version of `ghc-heap`, and only use the modules from `ghc-internal`,
  if the `ghc-internal` version is recent enough.
  
  -------------------------
  Metric Increase:
      size_hello_artifact
      size_hello_artifact_gzip
      size_hello_unicode
      size_hello_unicode_gzip
  -------------------------
  
  These metric increases are unfortunate, they are most likely caused by
  the larger (literally in terms of lines of code) stack decoder implementation
  that are now linked into hello-word binaries.
  
  On linux, it is almost a 10% increase, which is considerable.
  

• 6277fc36
  by fendor at 2025-08-25T17:31:14+02:00

  Implement `decode` in terms of `decodeStackWithIpe`
  
  Uses the more efficient stack decoder implementation.
  

• 5d9aa6a4
  by fendor at 2025-08-25T17:31:14+02:00

  Remove stg_decodeStackzh
  

54 changed files:

• compiler/GHC/ByteCode/Types.hs
• compiler/GHC/Runtime/Heap/Inspect.hs
• compiler/GHC/Runtime/Interpreter.hs
• compiler/ghc.cabal.in
• hadrian/src/Rules/ToolArgs.hs
• hadrian/src/Settings/Default.hs
• libraries/base/src/GHC/Stack/CloneStack.hs
• libraries/ghc-heap/GHC/Exts/Heap/ClosureTypes.hs
• libraries/ghc-heap/GHC/Exts/Heap/Closures.hs
• + libraries/ghc-heap/GHC/Exts/Heap/Constants.hs
• + libraries/ghc-heap/GHC/Exts/Heap/InfoTable.hs
• + libraries/ghc-heap/GHC/Exts/Heap/InfoTable/Types.hs
• + libraries/ghc-heap/GHC/Exts/Heap/InfoTableProf.hs
• libraries/ghc-heap/GHC/Exts/Heap/ProfInfo/Types.hs
• + libraries/ghc-heap/GHC/Exts/Stack/Constants.hs
• libraries/ghc-heap/GHC/Exts/Stack/Decode.hs
• libraries/ghc-heap/ghc-heap.cabal.in
• libraries/ghc-heap/cbits/HeapPrim.cmm → libraries/ghc-internal/cbits/HeapPrim.cmm
• libraries/ghc-heap/cbits/Stack.cmm → libraries/ghc-internal/cbits/Stack.cmm
• libraries/ghc-internal/cbits/StackCloningDecoding.cmm
• libraries/ghc-heap/cbits/Stack_c.c → libraries/ghc-internal/cbits/Stack_c.c
• libraries/ghc-internal/ghc-internal.cabal.in
• libraries/ghc-internal/jsbits/base.js
• libraries/ghc-internal/src/GHC/Internal/Exception/Backtrace.hs
• + libraries/ghc-internal/src/GHC/Internal/Heap/Closures.hs
• libraries/ghc-heap/GHC/Exts/Heap/Constants.hsc → libraries/ghc-internal/src/GHC/Internal/Heap/Constants.hsc
• libraries/ghc-heap/GHC/Exts/Heap/InfoTable.hsc → libraries/ghc-internal/src/GHC/Internal/Heap/InfoTable.hsc
• libraries/ghc-heap/GHC/Exts/Heap/InfoTable/Types.hsc → libraries/ghc-internal/src/GHC/Internal/Heap/InfoTable/Types.hsc
• libraries/ghc-heap/GHC/Exts/Heap/InfoTableProf.hsc → libraries/ghc-internal/src/GHC/Internal/Heap/InfoTableProf.hsc
• + libraries/ghc-internal/src/GHC/Internal/Heap/ProfInfo/Types.hs
• libraries/ghc-internal/src/GHC/Internal/Stack/CloneStack.hs
• libraries/ghc-heap/GHC/Exts/Stack/Constants.hsc → libraries/ghc-internal/src/GHC/Internal/Stack/Constants.hsc
• + libraries/ghc-internal/src/GHC/Internal/Stack/Decode.hs
• libraries/ghc-heap/tests/stack-annotation/Makefile → libraries/ghc-internal/tests/stack-annotation/Makefile
• libraries/ghc-heap/tests/stack-annotation/TestUtils.hs → libraries/ghc-internal/tests/stack-annotation/TestUtils.hs
• libraries/ghc-heap/tests/stack-annotation/all.T → libraries/ghc-internal/tests/stack-annotation/all.T
• libraries/ghc-heap/tests/stack-annotation/ann_frame001.hs → libraries/ghc-internal/tests/stack-annotation/ann_frame001.hs
• libraries/ghc-heap/tests/stack-annotation/ann_frame001.stdout → libraries/ghc-internal/tests/stack-annotation/ann_frame001.stdout
• libraries/ghc-heap/tests/stack-annotation/ann_frame002.hs → libraries/ghc-internal/tests/stack-annotation/ann_frame002.hs
• libraries/ghc-heap/tests/stack-annotation/ann_frame002.stdout → libraries/ghc-internal/tests/stack-annotation/ann_frame002.stdout
• libraries/ghc-heap/tests/stack-annotation/ann_frame003.hs → libraries/ghc-internal/tests/stack-annotation/ann_frame003.hs
• libraries/ghc-heap/tests/stack-annotation/ann_frame003.stdout → libraries/ghc-internal/tests/stack-annotation/ann_frame003.stdout
• libraries/ghc-heap/tests/stack-annotation/ann_frame004.hs → libraries/ghc-internal/tests/stack-annotation/ann_frame004.hs
• libraries/ghc-heap/tests/stack-annotation/ann_frame004.stdout → libraries/ghc-internal/tests/stack-annotation/ann_frame004.stdout
• libraries/ghci/GHCi/Message.hs
• libraries/ghci/ghci.cabal.in
• rts/CloneStack.c
• rts/CloneStack.h
• rts/RtsSymbols.c
• rts/include/stg/MiscClosures.h
• testsuite/tests/interface-stability/base-exports.stdout
• testsuite/tests/interface-stability/base-exports.stdout-javascript-unknown-ghcjs
• testsuite/tests/interface-stability/base-exports.stdout-mingw32
• testsuite/tests/interface-stability/base-exports.stdout-ws-32

The diff was not included because it is too large.