GitLab

David Eichmann pushed to branch wip/27162/hadrian-linkhs-response-file at Glasgow Haskell Compiler / GHC

Commits:

c439d0d8

by Duncan Coutts at 2026-04-13T17:47:40+01:00

Use response files for hadrian linking with ghc (support long command lines)

In future supoort for windows dynamic linking, we expect long command
lines for linking dll files with ghc. Experiments with dynamic linking the
ghc-internal library yielded a link command well over 32kb. We did not
encounter this before for static libs, since we already use ar's @file
feature (if available, which it is for the llvm toolchain).

Co-authored-by: David Eichmann <davide@well-typed.com>

2 changed files:

hadrian/src/Builder.hs
hadrian/src/Settings/Builders/Ghc.hs

Changes:

hadrian/src/Builder.hs

@@ -345,11 +345,8 @@ instance H.Builder Builder where
                  Haddock BuildPackage -> runHaddock path buildArgs buildInputs
 -                Ghc FindHsDependencies _ -> do
 -                  -- Use a response file for ghc -M invocations, to
 -                  -- avoid issues with command line size limit on
 -                  -- Windows (#26637)
 -                  runGhcWithResponse path buildArgs buildInputs
++
 +                Ghc _ _ -> runGhcWithResponse path buildArgs buildInputs buildOptions
                  HsCpp    -> captureStdout
@@ -393,16 +390,18 @@ runHaddock haddockPath flagArgs fileInputs = withTempFile $ \tmp -> do
      writeFile' tmp $ escapeArgs fileInputs
      cmd [haddockPath] flagArgs ('@' : tmp)
 -runGhcWithResponse :: FilePath -> [String] -> [FilePath] -> Action ()
 -runGhcWithResponse ghcPath flagArgs fileInputs = withTempFile $ \tmp -> do
+-
 -    writeFile' tmp $ escapeArgs fileInputs
+-
 -    -- We can't put the flags in a response file, because some flags
 -    -- require empty arguments (such as the -dep-suffix flag), but
 -    -- that isn't supported yet due to #26560.
 -    cmd [ghcPath] flagArgs ('@' : tmp)
+-
 +-- | Use a response file for ghc invocations to avoid issues with command line
 +-- size limit on Windows (#26637).
 +runGhcWithResponse :: FilePath -- ^ Path to ghc
 +  -> [String] -- ^ Arguments passed on the command line
 +  -> [FilePath] -- ^ Input file paths (passed via response file)
 +  -> [CmdOption]
 +  -> Action ()
 +runGhcWithResponse ghcPath buildArgs buildInputs buildOptions = withTempFile $ \tmp -> do
 +  let tmpContents = escapeArgs buildInputs
 +  putVerbose $ "Build Inputs (" <> tmp <> "): " <> show buildInputs
 +  writeFile' tmp tmpContents
 +  cmd [ghcPath] buildArgs ('@' : tmp) buildOptions
  -- TODO: Some builders are required only on certain platforms. For example,
  -- 'Objdump' is only required on OpenBSD and AIX. Add support for platform

hadrian/src/Settings/Builders/Ghc.hs

@@ -62,7 +62,6 @@ compileAndLinkHs = (builder (Ghc CompileHs) ||^ builder (Ghc LinkHs)) ? do
                    [ arg "-fwrite-ide-info"
                    , arg "-hiedir", arg hie_path
+                   ]
 -            , getInputs
              , arg "-o", arg =<< getOutput ]
  compileC :: Args
@@ -78,7 +77,6 @@ compileC = builder (Ghc CompileCWithGhc) ? do
              , mconcat (map (map ("-optc" ++) <$>) ccArgs)
              , defaultGhcWarningsArgs
              , arg "-c"
 -            , getInputs
              , arg "-o"
              , arg =<< getOutput ]
@@ -95,7 +93,6 @@ compileCxx = builder (Ghc CompileCppWithGhc) ? do
              , mconcat (map (map ("-optcxx" ++) <$>) ccArgs)
              , defaultGhcWarningsArgs
              , arg "-c"
 -            , getInputs
              , arg "-o"
              , arg =<< getOutput ]