Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC

Commits:

• 77deaa7a
  by Cheng Shao at 2025-09-14T21:29:45-04:00

  hadrian: build in-tree gmp with -fvisibility=hidden
  
  When hadrian builds in-tree gmp, it should build the shared objects
  with -fvisibility=hidden. The gmp symbols are only used by bignum
  logic in ghc-internal and shouldn't be exported by the ghc-internal
  shared library. We should always strive to keep shared library symbol
  table lean, which benefits platforms with slow dynamic linker or even
  hard limits about how many symbols can be exported (e.g. macos dyld,
  win32 dll and wasm dyld).
  

1 changed file:

• hadrian/src/Rules/Gmp.hs

Changes:

 import Hadrian.BuildPath

 import Hadrian.Expression

 import Settings.Builders.Common (cArgs, getStagedCCFlags)

-import GHC.Platform.ArchOS

 -- | Build in-tree GMP library objects (if GmpInTree flag is set) and return

 -- their paths.

                 mconcat

                     [ cArgs

                     , getStagedCCFlags

-                    , anyTargetArch [ArchWasm32] ? arg "-fvisibility=default"

+                    -- gmp symbols are only used by bignum logic in

+                    -- ghc-internal and shouldn't be exported by the

+                    -- ghc-internal shared library.

+                    , arg "-fvisibility=hidden"

                     ]

             env <- sequence

                      [ builderEnvironment "CC" $ Cc CompileC (stage ctx)