So I click on the filename above the Discussion and am warped to the Changes view (https://gitlab.haskell.org/ghc/ghc/merge_requests/74/diffs#9f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853).
But Simon's comment isn't there. Instead, I see a different comment, beginning with "In canEqTyVar we now compare kinds...". So I'm lost here.
When I try that, it starts by displaying the code from the file. No rotating circles or anything. But if I wait ten seconds, suddenly the comments appear. So:
Maybe you just weren’t waiting long enough?
Even displaying the original MR
https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904 is slow. For 18 seconds it displays a kind of skeleton page with horizontal grey bars that flash occasionally.
Then it renders.
Simon
From: Richard Eisenberg <rae@cs.brynmawr.edu>
Sent: 10 January 2019 19:05
To: Ben Gamari <ben@smart-cactus.org>
Cc: Simon Peyton Jones <simonpj@microsoft.com>; Evan Laforge <qdunkan@gmail.com>; ghc-devs <ghc-devs@haskell.org>
Subject: Re: Reviews
While we're whinging:
- I'm looking at the Discussion page for an MR (https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904)
and I see a comment Simon made, beginning with "No, I am not!". I wanted a bit more context. So I click on the filename above the Discussion and am warped to the Changes view (https://gitlab.haskell.org/ghc/ghc/merge_requests/74/diffs#9f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853).
But Simon's comment isn't there. Instead, I see a different comment, beginning with "In canEqTyVar we now compare kinds...". So I'm lost here.
- Simon recently posted a bunch of comments in response to a bunch of my comments. I have a thick stack of emails about each individual comment. But when I view the discussion page (https://gitlab.haskell.org/ghc/ghc/merge_requests/74),
I can find Simon's comments only buried in the Discussions that I started. There appears to be no way to glean, from the web page, what has happened since last I looked. Is there a way to see a "log" of activity on an MR? That way, in case I'm drowning in
email (common occurrence) and just want to get up to speed on a given MR, I can get an idea of what's gone on. Now, the thick stack of emails seems like the only way to do this.
- Is there a way to get a timestamped list of what discussions are resolved? Sometimes it's nice to be able to check that the resolution was what I had hoped for.
- The Changes page has a table of contents on the left. This is useful sometimes. (In this way, GL beats Phab, where it was sometimes hard to find where a certain file is listed when in the middle of a review.) But is there a way to collapse
the ToC? Most of the time, I'm focused on the code itself, and the ToC drastically reduces the number of characters per line, when I view diffs side-by-side.
Thanks!
Richard
PS: I well remember how phrustrated I was with Phab when that rolled out, and how I eventually came to appreciate it. I'm being more patient this time around. In retrospect my trouble was more with arcanist than with Phab itself. (Arcanist
and I never really got along... we just reached an unsteady truce, and I won't miss it.) I am happy to be using git as the tool now. But it's effortful to figure out efficient workflows in a new space, and I'm grateful for any help here. Thanks.