And a new bug: When I visit https://gitlab.haskell.org/ghc/ghc/merge_requests/444/diffs#note_8328, I see 6/13 discussions resolved, but the button to go to first unresolved discussion goes nowhere. And when I scroll through the page, expanding every file I see, I still can't find these unresolved discussions. :(

Richard

On Feb 26, 2019, at 7:59 AM, Richard Eisenberg <rae@cs.brynmawr.edu> wrote:

I can reproduce:

<Screen Shot 2019-02-26 at 7.58.52 AM.png>

Is there a good place to report this?

Richard

On Feb 26, 2019, at 5:18 AM, Simon Peyton Jones via ghc-devs <ghc-devs@haskell.org> wrote:

Look here:

https://gitlab.haskell.org/ghc/ghc/merge_requests/444/diffs#350c4076427c611b8f14e875a4ca553041c2b847_1930_1925

Look at the comment “Is this zipping necessary? We haven't zonked the scoped_kvs or the tc_tvs, I think” from Richard Eisenberg, just below line 1925 in TcHsType.

 

Now click on the grey “…” above his comment, to expand more code lines above.

 

Uh oh!  

  • The same comment now occurs twice, just below line 1904, and again just below 1925.
  • The first time it’s on the wrong line of code
  • But in the second position (the correct one) the “Reply” box is inactive.  I can’t type into it.

 

Is this is a bug? How to report it?

 

Simon

_______________________________________________
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs