Devs

I’m at a loss for how to review GitLab changes.  Richard sent me the message below.  So I follow the link to “View on GitLab”, or I manually edit the URL to plain

https://gitlab.haskell.org/ghc/ghc/merge_requests/116

Either way, I can’t see any comments whatsoever!  It says 5/5 discussions resolved, but I can’t actually see them.  There is not “toggle discussion” button anywhere.

What should I do?  This is quite a big problem.

I suppose we could issue guidance NEVER to resolve a discussion, but that seems like the wrong conclusion.

Simon

From: Richard Eisenberg <gitlab@gitlab.haskell.org>
Sent: 14 January 2019 03:03
To: Simon Peyton Jones <simonpj@microsoft.com>
Subject: Re: GHC | Some refactoring in tcInferApps (!116)

Richard Eisenberg commented on a discussion on compiler/typecheck/TcHsType.hs:

1022	+ (vcat [ ppr ki_binder
1023	+ , ppr ki_arg
1024	+ , ppr (tyBinderType ki_binder)
1025	+ , ppr subst
1026	+ , ppr (isInvisibleBinder ki_binder) ])
1027	+ ; ty_app_err ki_arg $ nakedSubstTy subst $
1028	+ mkPiTys all_ki_binders inner_ki }
1029	+
1030	+ -- no binder; try applying the substitution, or fail if that's not possible
1031	+ | otherwise
1032	+ = try_again_after_substing_or n subst fun inner_ki all_args $ \ substed_inner_ki ->
1033	+ ty_app_err ki_arg substed_inner_ki
1034	+
1035	+ go n subst fun all_ki_binders inner_ki all_args@(HsValArg arg : args)
1036	+ | ki_binder : ki_binders <- all_ki_binders
1037	+ = if isInvisibleBinder ki_binder

See if you like how I've done this now.

—
View it on GitLab.
You're receiving this email because of your account on gitlab.haskell.org. If you'd like to receive fewer emails, you can unsubscribe from this thread or adjust your notification settings.