On Thu, Jan 9, 2014 at 9:48 AM, Austin Seipp <austin@well-typed.com> wrote:

The first four are just tests that need to be updated. T4437 needs to
have PatternSynonyms listed (it tests the available extensions,) and
the generics test have had their output slightly changed. This is
because the generated terms are now annotated with the Origin type,
specifying where they come from. Here's an example from
GenDerivOutput1_1:

----------------------------
instance GHC.Generics.Selector CanDoRep1_1.S1_1_0Dd where
- GHC.Generics.selName _ = "d11d"
+ (Generated, GHC.Generics.selName _ = "d11d")
----------------------------

I'm not actually sure if this is what we want. Should -ddump-deriv
print this? I'm not sure we guarantee the output is syntactically
valid anyway, but it's worth considering. Removing this from the
output would mean these tests don't need any tweaks.

I think it is preferable not to show this Generated stuff. Even if -ddump-deriv is not entirely
syntactically valid, it often is, and I found myself copy-pasting from it multiple times before.

Cheers,
Pedro