Hi Joachim,

I wouldn't know which place is preferable. Simon?

(Your snippet did remind me that I forgot to remove the -fwarn-typeable-instances flag...
working on that now.)


Thanks,
Pedro


On Mon, Sep 9, 2013 at 8:25 AM, Joachim Breitner <mail@joachim-breitner.de> wrote:
Dear Predro,

Am Sonntag, den 08.09.2013, 18:27 -0500 schrieb Austin Seipp:
> I know Pedro committed the work to make manual
> Typeable instances an error, which is great.

the Coercible class has a similar property, and I added the check to
prevent manual instances to checkValidInstance in TcValidity:
https://github.com/nomeata/ghc/commit/5e3f13
while you did it in tcInstDecls1 in TcInstDecls:
http://git.haskell.org/?p=ghc.git;a=commitdiff;h=5335e56953c4bbe18166039c06256e725f074b64

I’m happy to follow suite if you tell me that TcInstDecls is indeed the
better spot for such a check.

Greetings,
Joachim

--
Joachim “nomeata” Breitner
  mail@joachim-breitner.dehttp://www.joachim-breitner.de/
  Jabber: nomeata@joachim-breitner.de  • GPG-Key: 0x4743206C
  Debian Developer: nomeata@debian.org

_______________________________________________
ghc-devs mailing list
ghc-devs@haskell.org
http://www.haskell.org/mailman/listinfo/ghc-devs