I subscribe to the ghc-tickets[1] mailing list which provides updates to all trac tickets. This is very useful, however when a ticket description is updated the whole description is included in the email which makes it hard to see what actually changed. The web interface shows a nice diff[2] of the changes, I think it would be good if emails could also include a diff rather than the current quite useless output. After a bit of investigation, it appears that the easiest way to achieve this is apply a simple patch to our copy of trac. The current format is hard coded on line 558 in this module, it seems easy to modify this section to instead provide a diff. http://www.edgewall.org/docs/trac-trunk/epydoc/trac.ticket.notification-pysr... There is also already a module which has the diff operations implemented which could be used. http://www.edgewall.org/docs/trac-trunk/epydoc/trac.versioncontrol.diff-modu... Another option would be to use something like the `AnnouncerPlugin`[3] but that seems like much more work and would still require someone to write a custom formatter. Any thoughts? Matt [1]: https://mail.haskell.org/mailman/listinfo/ghc-tickets [2]: https://ghc.haskell.org/trac/ghc/ticket/10873?action=diff&version=6 [3]: https://trac-hacks.org/wiki/AnnouncerPlugin
Matthew Pickering <matthewtpickering@gmail.com> writes:
I subscribe to the ghc-tickets[1] mailing list which provides updates to all trac tickets. This is very useful, however when a ticket description is updated the whole description is included in the email which makes it hard to see what actually changed. The web interface shows a nice diff[2] of the changes, I think it would be good if emails could also include a diff rather than the current quite useless output.
I think this would be a great improvement. I, for one, am quite guilty of incrementally editing ticket descriptions and the current email notifications are nearly useless in this case.
After a bit of investigation, it appears that the easiest way to achieve this is apply a simple patch to our copy of trac. The current format is hard coded on line 558 in this module, it seems easy to modify this section to instead provide a diff.
Herbert, perhaps we could do something along these lines? Cheers, - Ben
Ben Gamari <ben@smart-cactus.org> writes:
Matthew Pickering <matthewtpickering@gmail.com> writes:
I subscribe to the ghc-tickets[1] mailing list which provides updates to all trac tickets. This is very useful, however when a ticket description is updated the whole description is included in the email which makes it hard to see what actually changed. The web interface shows a nice diff[2] of the changes, I think it would be good if emails could also include a diff rather than the current quite useless output.
I think this would be a great improvement. I, for one, am quite guilty of incrementally editing ticket descriptions and the current email notifications are nearly useless in this case.
After a bit of investigation, it appears that the easiest way to achieve this is apply a simple patch to our copy of trac. The current format is hard coded on line 558 in this module, it seems easy to modify this section to instead provide a diff.
Herbert, perhaps we could do something along these lines?
Ping. Cheers, - Ben
Have you had any chance to think about this yet Herbert? Matt On Wed, Jan 6, 2016 at 6:44 PM, Ben Gamari <ben@smart-cactus.org> wrote:
Ben Gamari <ben@smart-cactus.org> writes:
Matthew Pickering <matthewtpickering@gmail.com> writes:
I subscribe to the ghc-tickets[1] mailing list which provides updates to all trac tickets. This is very useful, however when a ticket description is updated the whole description is included in the email which makes it hard to see what actually changed. The web interface shows a nice diff[2] of the changes, I think it would be good if emails could also include a diff rather than the current quite useless output.
I think this would be a great improvement. I, for one, am quite guilty of incrementally editing ticket descriptions and the current email notifications are nearly useless in this case.
After a bit of investigation, it appears that the easiest way to achieve this is apply a simple patch to our copy of trac. The current format is hard coded on line 558 in this module, it seems easy to modify this section to instead provide a diff.
Herbert, perhaps we could do something along these lines?
Ping.
Cheers,
- Ben
I attach a patch which should improve the notifications. Here is an example of the new output. https://www.irccloud.com/pastebin/HdlVbQt4/ Matt On Tue, Jan 19, 2016 at 11:29 AM, Matthew Pickering <matthewtpickering@gmail.com> wrote:
Have you had any chance to think about this yet Herbert?
Matt
On Wed, Jan 6, 2016 at 6:44 PM, Ben Gamari <ben@smart-cactus.org> wrote:
Ben Gamari <ben@smart-cactus.org> writes:
Matthew Pickering <matthewtpickering@gmail.com> writes:
I subscribe to the ghc-tickets[1] mailing list which provides updates to all trac tickets. This is very useful, however when a ticket description is updated the whole description is included in the email which makes it hard to see what actually changed. The web interface shows a nice diff[2] of the changes, I think it would be good if emails could also include a diff rather than the current quite useless output.
I think this would be a great improvement. I, for one, am quite guilty of incrementally editing ticket descriptions and the current email notifications are nearly useless in this case.
After a bit of investigation, it appears that the easiest way to achieve this is apply a simple patch to our copy of trac. The current format is hard coded on line 558 in this module, it seems easy to modify this section to instead provide a diff.
Herbert, perhaps we could do something along these lines?
Ping.
Cheers,
- Ben
Herbert now seems to have applied the patch. Hopefully this will improve the email situation for everyone. Matt On 20 Jan 2016 1:15 pm, "Matthew Pickering" <matthewtpickering@gmail.com> wrote:
I attach a patch which should improve the notifications.
Here is an example of the new output.
https://www.irccloud.com/pastebin/HdlVbQt4/
Matt
On Tue, Jan 19, 2016 at 11:29 AM, Matthew Pickering <matthewtpickering@gmail.com> wrote:
Have you had any chance to think about this yet Herbert?
Matt
On Wed, Jan 6, 2016 at 6:44 PM, Ben Gamari <ben@smart-cactus.org> wrote:
Ben Gamari <ben@smart-cactus.org> writes:
Matthew Pickering <matthewtpickering@gmail.com> writes:
I subscribe to the ghc-tickets[1] mailing list which provides updates to all trac tickets. This is very useful, however when a ticket description is updated the whole description is included in the email which makes it hard to see what actually changed. The web interface shows a nice diff[2] of the changes, I think it would be good if emails could also include a diff rather than the current quite useless output.
I think this would be a great improvement. I, for one, am quite guilty of incrementally editing ticket descriptions and the current email notifications are nearly useless in this case.
After a bit of investigation, it appears that the easiest way to achieve this is apply a simple patch to our copy of trac. The current format is hard coded on line 558 in this module, it seems easy to modify this section to instead provide a diff.
Herbert, perhaps we could do something along these lines?
Ping.
Cheers,
- Ben
participants (3)
-
Ben Gamari -
Ben Gamari -
Matthew Pickering