I noticed that the default value of the flag is unspecified (I believe that the flag should be on by default, as deactivating transitively unused bindings is pretty situational in my opinion; we may even decide to accept the proposal but without the flag, though I have a feeling that the author wouldn't be willing to implement the flagless version). I made a comment to that effect on Github.

The rest of the proposal looks good to me.

On Tue, 13 Feb 2024 at 11:59, Chris Dornan <chris@chrisdornan.com> wrote:

Proposal: Fine-Grained Unused Warnings (#42)
Author: Jakob Brünker
Rendered proposal: https://github.com/JakobBruenker/ghc-proposals/blob/fine-grained-unused/proposals/0000-fine-grained-unused-warnings.rst
Discussion: https://github.com/ghc-proposals/ghc-proposals/pull/434
Recommendation: Acceptance

## Summary

The proposal partitions warning about unused identifiers into

a) bindings that are truly unused (not mentioned anywhere) and
b) bindings that are mentioned exclusively in code that is itself (transitively) unused,

and suppresses the latter unless the -freport-indirectly-unused-bindings flag is specified.

The proposal is concise with some well-chosen examples and I recommend everyone at least skim it.

I propose that we accept this proposal if nobody objects by the start of next week (Monday, 2024-02-19).

Chris
_______________________________________________
ghc-steering-committee mailing list
ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee