Please review #678: Amendment to ImportShadowing
Dear Committee, Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports: https://github.com/ghc-proposals/ghc-proposals/pull/678 I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal. Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process Cheers, Adam -- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/ Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
Hi all, I have recommended "accept" for this minor modification of this proposal. I would appreciate it if everyone else on the committee would vote. Thanks, Erik Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Hi, I vote "accept" as well. I'm a bit surprised by the subtlety, but the clarified semantics makes sense. Cheers, Sebastian ------ Originalnachricht ------ Von "Erik de Castro Lopo" <erikd@mega-nerd.com> An ghc-steering-committee@haskell.org Datum 17.10.2024 01:38:19 Betreff Re: [ghc-steering-committee] Please review #678: Amendment to ImportShadowing
Hi all,
I have recommended "accept" for this minor modification of this proposal.
I would appreciate it if everyone else on the committee would vote.
Thanks, Erik
Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
Hi, I’m in support as well! Best, Moritz On Thu, Oct 17, 2024 at 4:31 PM Sebastian Graf <sgraf1337@gmail.com> wrote:
Hi,
I vote "accept" as well. I'm a bit surprised by the subtlety, but the clarified semantics makes sense.
Cheers, Sebastian
------ Originalnachricht ------ Von "Erik de Castro Lopo" <erikd@mega-nerd.com> An ghc-steering-committee@haskell.org Datum 17.10.2024 01:38:19 Betreff Re: [ghc-steering-committee] Please review #678: Amendment to ImportShadowing
Hi all,
I have recommended "accept" for this minor modification of this proposal.
I would appreciate it if everyone else on the committee would vote.
Thanks, Erik
Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
I support, subject to a couple of typos I have identified. Simon On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo <erikd@mega-nerd.com> wrote:
Hi all,
I have recommended "accept" for this minor modification of this proposal.
I would appreciate it if everyone else on the committee would vote.
Thanks, Erik
Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
I support as well. On 2024-10-17 08:58, Simon Peyton Jones wrote:
I support, subject to a couple of typos I have identified.
Simon
On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo <erikd@mega-nerd.com> wrote:
Hi all,
I have recommended "accept" for this minor modification of this proposal.
I would appreciate it if everyone else on the committee would vote.
Thanks, Erik
Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
Seems like a reasonable amendment, I'm in support. On Fri, Oct 18, 2024 at 10:33 AM Malte Ott <malte.ott@maralorn.de> wrote:
I support as well.
On 2024-10-17 08:58, Simon Peyton Jones wrote:
I support, subject to a couple of typos I have identified.
Simon
On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo <erikd@mega-nerd.com> wrote:
Hi all,
I have recommended "accept" for this minor modification of this proposal.
I would appreciate it if everyone else on the committee would vote.
Thanks, Erik
Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it? So, in favour. On Fri, 18 Oct 2024 at 17:43, Jakob Brünker <jakob.bruenker@gmail.com> wrote:
Seems like a reasonable amendment, I'm in support.
On Fri, Oct 18, 2024 at 10:33 AM Malte Ott <malte.ott@maralorn.de> wrote:
I support as well.
On 2024-10-17 08:58, Simon Peyton Jones wrote:
I support, subject to a couple of typos I have identified.
Simon
On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo <erikd@mega-nerd.com> wrote:
Hi all,
I have recommended "accept" for this minor modification of this proposal.
I would appreciate it if everyone else on the committee would vote.
Thanks, Erik
Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io.
I find it a little annoying that this isn't backward compatible Me too. I outline on the Github a way to make it backward compatible. *Everyone*: do express a view there. Simon On Mon, 21 Oct 2024 at 03:50, Arnaud Spiwack <arnaud.spiwack@tweag.io> wrote:
I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it?
So, in favour.
On Fri, 18 Oct 2024 at 17:43, Jakob Brünker <jakob.bruenker@gmail.com> wrote:
Seems like a reasonable amendment, I'm in support.
On Fri, Oct 18, 2024 at 10:33 AM Malte Ott <malte.ott@maralorn.de> wrote:
I support as well.
On 2024-10-17 08:58, Simon Peyton Jones wrote:
I support, subject to a couple of typos I have identified.
Simon
On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo <erikd@mega-nerd.com
wrote:
Hi all,
I have recommended "accept" for this minor modification of this proposal.
I would appreciate it if everyone else on the committee would vote.
Thanks, Erik
Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
--
Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
I'm in support. I agree with Simon's comment, we'd be well served by a better spec for what `module M` means in an export list, but this amendment is closer to what we would want. On Mon, 21 Oct 2024 at 04:50, Arnaud Spiwack <arnaud.spiwack@tweag.io> wrote:
I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it?
So, in favour.
On Fri, 18 Oct 2024 at 17:43, Jakob Brünker <jakob.bruenker@gmail.com> wrote:
Seems like a reasonable amendment, I'm in support.
On Fri, Oct 18, 2024 at 10:33 AM Malte Ott <malte.ott@maralorn.de> wrote:
I support as well.
On 2024-10-17 08:58, Simon Peyton Jones wrote:
I support, subject to a couple of typos I have identified.
Simon
On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo <erikd@mega-nerd.com
wrote:
Hi all,
I have recommended "accept" for this minor modification of this proposal.
I would appreciate it if everyone else on the committee would vote.
Thanks, Erik
Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
--
Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
-- -- Matthías Páll Gissurarson <http://mpg.is/>
we'd be well served by a better spec for what `module M` means in an export list,
Well, that's the entire purpose of this amendment! - Do you think it now gives a clear spec? - Do you prefer the alternative (more complicated, but backward compatible) spec I suggested here <https://github.com/ghc-proposals/ghc-proposals/pull/678#issuecomment-2421884753> ? Simon On Mon, 21 Oct 2024 at 09:27, Matthías Páll Gissurarson <mpg@mpg.is> wrote:
I'm in support. I agree with Simon's comment, we'd be well served by a better spec for what `module M` means in an export list, but this amendment is closer to what we would want.
On Mon, 21 Oct 2024 at 04:50, Arnaud Spiwack <arnaud.spiwack@tweag.io> wrote:
I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it?
So, in favour.
On Fri, 18 Oct 2024 at 17:43, Jakob Brünker <jakob.bruenker@gmail.com> wrote:
Seems like a reasonable amendment, I'm in support.
On Fri, Oct 18, 2024 at 10:33 AM Malte Ott <malte.ott@maralorn.de> wrote:
I support as well.
On 2024-10-17 08:58, Simon Peyton Jones wrote:
I support, subject to a couple of typos I have identified.
Simon
On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo < erikd@mega-nerd.com> wrote:
Hi all,
I have recommended "accept" for this minor modification of this proposal.
I would appreciate it if everyone else on the committee would vote.
Thanks, Erik
Adam Gundry wrote:
> Dear Committee, > > Gergő Érdi proposes to amend his import shadowing proposal #652 to > clarify the behaviour of module re-exports: > > https://github.com/ghc-proposals/ghc-proposals/pull/678 > > I'd like to nominate Erik de Castro Lopo as the shepherd, as he > shepherded the original proposal. > > Please guide us to a conclusion as outlined in > https://github.com/ghc-proposals/ghc-proposals#committee-process > > Cheers, > > Adam > > > -- > Adam Gundry, Haskell Consultant > Well-Typed LLP, https://www.well-typed.com/ > > Registered in England & Wales, OC335890 > 27 Old Gloucester Street, London WC1N 3AX, England >
--
Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
-- -- Matthías Páll Gissurarson <http://mpg.is/> _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
I’m in favor of the backward compatible one, it’s a bit more complicated but (I think) clearer. I’ve left some comments on the PR itself. /Matti Palli On Mon, Oct 21, 2024 at 10:48 Simon Peyton Jones < simon.peytonjones@gmail.com> wrote:
we'd be well served by a better spec for what `module M` means in an export list,
Well, that's the entire purpose of this amendment!
- Do you think it now gives a clear spec? - Do you prefer the alternative (more complicated, but backward compatible) spec I suggested here <https://github.com/ghc-proposals/ghc-proposals/pull/678#issuecomment-2421884753> ?
Simon
On Mon, 21 Oct 2024 at 09:27, Matthías Páll Gissurarson <mpg@mpg.is> wrote:
I'm in support. I agree with Simon's comment, we'd be well served by a better spec for what `module M` means in an export list, but this amendment is closer to what we would want.
On Mon, 21 Oct 2024 at 04:50, Arnaud Spiwack <arnaud.spiwack@tweag.io> wrote:
I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it?
So, in favour.
On Fri, 18 Oct 2024 at 17:43, Jakob Brünker <jakob.bruenker@gmail.com> wrote:
Seems like a reasonable amendment, I'm in support.
On Fri, Oct 18, 2024 at 10:33 AM Malte Ott <malte.ott@maralorn.de> wrote:
I support as well.
On 2024-10-17 08:58, Simon Peyton Jones wrote:
I support, subject to a couple of typos I have identified.
Simon
On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo < erikd@mega-nerd.com> wrote:
> Hi all, > > I have recommended "accept" for this minor modification of this proposal. > > I would appreciate it if everyone else on the committee would vote. > > Thanks, > Erik > > > Adam Gundry wrote: > > > Dear Committee, > > > > Gergő Érdi proposes to amend his import shadowing proposal #652 to > > clarify the behaviour of module re-exports: > > > > https://github.com/ghc-proposals/ghc-proposals/pull/678 > > > > I'd like to nominate Erik de Castro Lopo as the shepherd, as he > > shepherded the original proposal. > > > > Please guide us to a conclusion as outlined in > > https://github.com/ghc-proposals/ghc-proposals#committee-process > > > > Cheers, > > > > Adam > > > > > > -- > > Adam Gundry, Haskell Consultant > > Well-Typed LLP, https://www.well-typed.com/ > > > > Registered in England & Wales, OC335890 > > 27 Old Gloucester Street, London WC1N 3AX, England <https://www.google.com/maps/search/27+Old+Gloucester+Street,+London+WC1N+3AX,+England?entry=gmail&source=g> > > > > > -- >
> Erik de Castro Lopo > http://www.mega-nerd.com/ > _______________________________________________ > ghc-steering-committee mailing list > ghc-steering-committee@haskell.org > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee >
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
-- -- Matthías Páll Gissurarson <http://mpg.is/> _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
I would like to hear back from the proposal author. If he's willing to incorporate Simon's spec, I would be very happy. I still accept the proposal as-is in the interest of making progress. Am Mo., 21. Okt. 2024 um 11:40 Uhr schrieb Matthías Páll Gissurarson < mpg@mpg.is>:
I’m in favor of the backward compatible one, it’s a bit more complicated but (I think) clearer. I’ve left some comments on the PR itself.
/Matti Palli
On Mon, Oct 21, 2024 at 10:48 Simon Peyton Jones < simon.peytonjones@gmail.com> wrote:
we'd be well served by a better spec for what `module M` means in an export list,
Well, that's the entire purpose of this amendment!
- Do you think it now gives a clear spec? - Do you prefer the alternative (more complicated, but backward compatible) spec I suggested here <https://github.com/ghc-proposals/ghc-proposals/pull/678#issuecomment-2421884753> ?
Simon
On Mon, 21 Oct 2024 at 09:27, Matthías Páll Gissurarson <mpg@mpg.is> wrote:
I'm in support. I agree with Simon's comment, we'd be well served by a better spec for what `module M` means in an export list, but this amendment is closer to what we would want.
On Mon, 21 Oct 2024 at 04:50, Arnaud Spiwack <arnaud.spiwack@tweag.io> wrote:
I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it?
So, in favour.
On Fri, 18 Oct 2024 at 17:43, Jakob Brünker <jakob.bruenker@gmail.com> wrote:
Seems like a reasonable amendment, I'm in support.
On Fri, Oct 18, 2024 at 10:33 AM Malte Ott <malte.ott@maralorn.de> wrote:
I support as well.
On 2024-10-17 08:58, Simon Peyton Jones wrote: > I support, subject to a couple of typos I have identified. > > Simon > > On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo < erikd@mega-nerd.com> > wrote: > > > Hi all, > > > > I have recommended "accept" for this minor modification of this proposal. > > > > I would appreciate it if everyone else on the committee would vote. > > > > Thanks, > > Erik > > > > > > Adam Gundry wrote: > > > > > Dear Committee, > > > > > > Gergő Érdi proposes to amend his import shadowing proposal #652 to > > > clarify the behaviour of module re-exports: > > > > > > https://github.com/ghc-proposals/ghc-proposals/pull/678 > > > > > > I'd like to nominate Erik de Castro Lopo as the shepherd, as he > > > shepherded the original proposal. > > > > > > Please guide us to a conclusion as outlined in > > > https://github.com/ghc-proposals/ghc-proposals#committee-process > > > > > > Cheers, > > > > > > Adam > > > > > > > > > -- > > > Adam Gundry, Haskell Consultant > > > Well-Typed LLP, https://www.well-typed.com/ > > > > > > Registered in England & Wales, OC335890 > > > 27 Old Gloucester Street, London WC1N 3AX, England <https://www.google.com/maps/search/27+Old+Gloucester+Street,+London+WC1N+3AX,+England?entry=gmail&source=g> > > > > > > > > > -- > > ---------------------------------------------------------------------- > > Erik de Castro Lopo > > http://www.mega-nerd.com/ > > _______________________________________________ > > ghc-steering-committee mailing list > > ghc-steering-committee@haskell.org > > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee > >
> _______________________________________________ > ghc-steering-committee mailing list > ghc-steering-committee@haskell.org > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org
https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
-- -- Matthías Páll Gissurarson <http://mpg.is/> _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
+1 I updated the proposal status on github as it was still "pending shepherd recommendation". On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo <erikd@mega-nerd.com> wrote:
Hi all,
I have recommended "accept" for this minor modification of this proposal.
I would appreciate it if everyone else on the committee would vote.
Thanks, Erik
Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
Erik, this is an old one but I think you're still the shepherd? On Thu, 25 Jun 2026, 10:32 Simon Marlow, <marlowsd@gmail.com> wrote:
+1
I updated the proposal status on github as it was still "pending shepherd recommendation".
On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo <erikd@mega-nerd.com> wrote:
Hi all,
I have recommended "accept" for this minor modification of this proposal.
I would appreciate it if everyone else on the committee would vote.
Thanks, Erik
Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
Gergo has now revised the proposed amendment, so please take another look. I think it looks good to accept modulo Simon's polishing suggestions. Adam On 04/10/2024 08:58, Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/ Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
The ammendment looks good to me. The semantics stay as previously intended but are worded more precisely in regards to the report. Best, Malte On 2026-06-07 23:00, Adam Gundry wrote:
Gergo has now revised the proposed amendment, so please take another look. I think it looks good to accept modulo Simon's polishing suggestions.
Adam
On 04/10/2024 08:58, Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
_______________________________________________ ghc-steering-committee mailing list -- ghc-steering-committee@haskell.org To unsubscribe send an email to ghc-steering-committee-leave@haskell.org
+1 from me. Am Fr., 12. Juni 2026 um 00:26 Uhr schrieb Malte Ott <malte.ott@maralorn.de
:
The ammendment looks good to me. The semantics stay as previously intended but are worded more precisely in regards to the report.
Best, Malte
On 2026-06-07 23:00, Adam Gundry wrote:
Gergo has now revised the proposed amendment, so please take another look. I think it looks good to accept modulo Simon's polishing suggestions.
Adam
On 04/10/2024 08:58, Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
_______________________________________________ ghc-steering-committee mailing list -- ghc-steering-committee@haskell.org To unsubscribe send an email to ghc-steering-committee-leave@haskell.org
ghc-steering-committee mailing list -- ghc-steering-committee@haskell.org To unsubscribe send an email to ghc-steering-committee-leave@haskell.org
+1 from me as well.
On 15 Jun 2026, at 07:54, Sebastian Graf <sgraf1337@gmail.com> wrote:
+1 from me.
Am Fr., 12. Juni 2026 um 00:26 Uhr schrieb Malte Ott <malte.ott@maralorn.de <mailto:malte.ott@maralorn.de>>:
The ammendment looks good to me. The semantics stay as previously intended but are worded more precisely in regards to the report.
Best, Malte
On 2026-06-07 23:00, Adam Gundry wrote:
Gergo has now revised the proposed amendment, so please take another look. I think it looks good to accept modulo Simon's polishing suggestions.
Adam
On 04/10/2024 08:58, Adam Gundry wrote:
Dear Committee,
Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:
https://github.com/ghc-proposals/ghc-proposals/pull/678
I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.
Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process
Cheers,
Adam
-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/
Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England
_______________________________________________ ghc-steering-committee mailing list -- ghc-steering-committee@haskell.org <mailto:ghc-steering-committee@haskell.org> To unsubscribe send an email to ghc-steering-committee-leave@haskell.org <mailto:ghc-steering-committee-leave@haskell.org>
ghc-steering-committee mailing list -- ghc-steering-committee@haskell.org <mailto:ghc-steering-committee@haskell.org> To unsubscribe send an email to ghc-steering-committee-leave@haskell.org <mailto:ghc-steering-committee-leave@haskell.org>
ghc-steering-committee mailing list -- ghc-steering-committee@haskell.org To unsubscribe send an email to ghc-steering-committee-leave@haskell.org
participants (11)
-
Adam Gundry -
Arnaud Spiwack -
Erik de Castro Lopo -
Jakob Brünker -
Malte Ott -
Matthías Páll Gissurarson -
Moritz Angermann -
Rodrigo Mesquita -
Sebastian Graf -
Simon Marlow -
Simon Peyton Jones