Looks good to me. Thanks.<br><br><div class="gmail_quote">On Thu, Mar 18, 2010 at 1:54 PM, Bas van Dijk <span dir="ltr">&lt;<a href="mailto:v.dijk.bas@gmail.com">v.dijk.bas@gmail.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hello,<br>
<br>
after discovering the bugs regarding asynchronous exceptions and<br>
laziness in Data.Unique and Control.Concurrent.SampleVar I became a<br>
bit suspicious about the other concurrency mechanisms.<br>
<br>
It looks like Control.Concurrent.Chan is safe because it uses<br>
modifyMVar_ internally which performs the necessary block.<br>
<br>
Control.Concurrent.QSem and QSemN are not alright however! They both<br>
suffer the same bugs:<br>
<br>
* Potential dead-lock due to not blocking asynchronous exceptions.<br>
* Potential space-leak because of lazily putting numeric expression in a MVar.<br>
<br>
The attached patch fixes these bugs.<br>
<br>
regards,<br>
<font color="#888888"><br>
Bas<br>
</font><br>_______________________________________________<br>
Libraries mailing list<br>
<a href="mailto:Libraries@haskell.org">Libraries@haskell.org</a><br>
<a href="http://www.haskell.org/mailman/listinfo/libraries" target="_blank">http://www.haskell.org/mailman/listinfo/libraries</a><br>
<br></blockquote></div><br>