Hi Malcolm,
My test based on QC2 where I generate random VersionRange values,
format them as a string, parse them back and check are they the same.
So if you modify only the parsing part it will fail. As it is now. (It
might be correct parsing although. :))
Regards,
-- LAca
On Fri, Sep 11, 2009 at 12:52 PM, Malcolm Wallace
Laszlo,
This patch contains a typo, and does not compile for me.
Yes, I sent it off too quickly. I attach a revised version of the patch, that fixes the typo, improves the parser by allowing parentheses in version range expressions, and adds a check that the new syntax is accepted only by cabal >= 1.8.
http://sites.google.com/site/rizsotto/patches/cabal-ticket212.darcs
I have been having great trouble finding a way to test my patch - e.g. darcs cabal-install does not build with darcs Cabal currently. Since you appear to have a testing framework that is not yet incorporated into the standard Cabal repo, I would be very grateful if you could test the revised patch and let me know of any remaining errors.
And I also tried to solve this ticket earlier, here is my solution:
Regards, Malcolm
_______________________________________________ cabal-devel mailing list cabal-devel@haskell.org http://www.haskell.org/mailman/listinfo/cabal-devel