On Fri, 2006-07-21 at 16:00 +0100, Duncan Coutts wrote:
On Thu, 2006-07-20 at 11:49 -0700, Isaac Jones wrote:
Patches from Jeremy Shaw. Duncan, can you look at these and apply?
The patch looks mostly ok to me. So it just turns on or off the building of normal libs.
The TH thing - can we check that this is really the right thing to do?
So the code is forcing normal libs to be built when the library uses TH (even if the user didn't want to build normal libs).
Note that they've not got a fix for this yet in GHC:
http://www.haskell.org/pipermail/template-haskell/2003-July/000135.html http://www.haskell.org/pipermail/template-haskell/2005-July/000466.html
http://hackage.haskell.org/trac/ghc/ticket/651
So we should check with the GHC devs that the behaviour in this patch will need to be part of any solution. Otherwise it seems a bit preemptive.
Since no one said anything I've committed the patch but without the TH bit and with some other minor changes. Duncan