Simon Marlow wrote:
Ok, spurned on by the possibiliy of worse merges to come, I've cleaned up my current code, merged it up to date, and made it work (where "work" means "doesn't make anything worse" - i.e. there is no new functionality exposed to the user yet).
I've gone over the patch as far as it overlaps my patch (i.e. mostly ignoring the Configuration stuff). I like it, and I agree that it goes beyond what I did. One cosmetic nitpick,
+libFieldDescrs = map biToLib binfoFieldDescrs + ++ [ + listField "exposed-modules" text parseModuleNameQ + exposedModules (\mods lib -> lib{exposedModules=mods}) + ]
would look better (and follow the other field description's format closer) as +libFieldDescrs = map biToLib binfoFieldDescrs + ++ [ + listField "exposed-modules" + text parseModuleNameQ + exposedModules (\mods lib -> lib{exposedModules=mods}) + ]
I also merged Bertram Felgenhauer patches with my own, and I've included updated versions of his patches in this bundle: 1 patch for cleanups to parsing, I just took some docs from Bertram's patch because everything else is already in my changes, and 1 patch to add the exposed field.
Thanks. regards, Bertram