darcs patch: Distribution/Client/SrcDist.hs: fixed wa... (and 10 more)
Sun Dec 20 23:17:17 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/SrcDist.hs: fixed warning on -Wall (unused result) Sun Dec 20 23:19:40 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/IndexUtils.hs: fixed warning on -Wall (unused result) Sun Dec 20 23:32:35 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/Dependency/TopDown.hs: commented out unused 'addPackageExcludeConstraint' Sun Dec 20 23:33:50 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/BuildReports/Anonymous.hs: removed unused import of BuildResult Sun Dec 20 23:35:30 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/BuildReports/Upload.hs: marked result as unused Sun Dec 20 23:37:57 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/Haddock.hs: removed redundant instances Sun Dec 20 23:43:46 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/BuildReports/Storage.hs: removed double import if InstallPlan Sun Dec 20 23:44:48 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/Setup.hs: suppress warning (unused variable) Sun Dec 20 23:45:45 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/Unpack.hs: removed redundant import Sun Dec 20 23:55:08 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/Install.hs: removed unused 'compilerTemplateEnv' from import Mon Dec 21 00:01:05 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/InstallSymlink.hs: explicitely import 'catch' and friend tom System.IO
On Mon, 2009-12-21 at 00:04 +0200, Sergei Trofimovich wrote:
Sun Dec 20 23:17:17 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/SrcDist.hs: fixed warning on -Wall (unused result)
Thanks for all those patches for fixing the new warnings with ghc-6.12.
Mon Dec 21 00:04:47 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * cabal-install.cabal: added -Wall for ghc
Note that the cabal-install.cabal already uses -Wall: Executable cabal Main-Is: Main.hs -- We want assertion checking on even if people build with -O -- although it is expensive, we want to catch problems early: ghc-options: -Wall -fno-ignore-asserts if impl(ghc >= 6.8) ghc-options: -fwarn-tabs Other-Modules: ... Duncan
On Mon, 21 Dec 2009 14:53:12 +0000 Duncan Coutts <duncan.coutts@googlemail.com> wrote:
On Mon, 2009-12-21 at 00:04 +0200, Sergei Trofimovich wrote:
Sun Dec 20 23:17:17 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/SrcDist.hs: fixed warning on -Wall (unused result)
Thanks for all those patches for fixing the new warnings with ghc-6.12. Some of warnings are not fixed as they seem to be ghc errors, like: http://hackage.haskell.org/trac/ghc/ticket/3776 Some of warnings might be fixed in a wrong way (like imports for non-ghc/old-ghc). Does bundle contain suspicious patches to amend/throw off?
Mon Dec 21 00:04:47 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * cabal-install.cabal: added -Wall for ghc
Note that the cabal-install.cabal already uses -Wall: Oh sorry, I was sure it was off.
Duncan
-- Sergei
On Mon, 2009-12-21 at 21:09 +0200, Sergei Trofimovich wrote:
On Mon, 21 Dec 2009 14:53:12 +0000 Duncan Coutts <duncan.coutts@googlemail.com> wrote:
On Mon, 2009-12-21 at 00:04 +0200, Sergei Trofimovich wrote:
Sun Dec 20 23:17:17 EET 2009 Sergei Trofimovich <slyfox@community.haskell.org> * Distribution/Client/SrcDist.hs: fixed warning on -Wall (unused result)
Thanks for all those patches for fixing the new warnings with ghc-6.12. Some of warnings are not fixed as they seem to be ghc errors, like: http://hackage.haskell.org/trac/ghc/ticket/3776 Some of warnings might be fixed in a wrong way (like imports for non-ghc/old-ghc). Does bundle contain suspicious patches to amend/throw off?
Ok, thanks. I'll check them carefully. Duncan
participants (2)
-
Duncan Coutts -
Sergei Trofimovich