On 23 October 2011 00:58, Max Bolingbroke wrote:

Hi Bas,

On 22 October 2011 21:15, Bas van Dijk wrote:

...

Attached is the package logo patch I was working on.

I wonder if perhaps you should implement this more like how Duncan implemented change logs. i.e.:

 1. Add a rendLogo field to PackageRender  2. Have doPackageRender fill rendLogo out by doing an IO-monad query similar to getLogoHtml but which is of type e.g. IO (Maybe String), where the String will be the URI of the logo  3. Change packagePage to build HTML (i.e. img or object tag) from this URI based on the extension

I think the advantage of this approach is that:  a) You won't have to add the logo-finding code to both the package page and the candidate-package page, since PackageRender is shared code between them  b) The rendLogo field of PackageRender could sensibly be consumed by other users -- e.g. a feature producing JSON representing a package  c) It is more uniform with how stuff like this is currently implemented (I'm mainly thinking of changelogs here)

Thoughts?

Max

I like the idea Max. Attached is the patch which implements it. There's only one issue: In doPackageRender I can't make the distinction between normal and candidate packages so I can't serve the correct logo url. So currently candidate logo's are broken. Do you have an idea to make them work again? Regards, Bas

On 24 October 2011 09:53, Max Bolingbroke wrote:

On 24 October 2011 07:27, Bas van Dijk wrote:

...

I like the idea Max. Attached is the patch which implements it. There's only one issue: In doPackageRender I can't make the distinction between normal and candidate packages so I can't serve the correct logo url. So currently candidate logo's are broken. Do you have an idea to make them work again?

I see. It looks like doCandidateRender fixes up the result of doPackageRender by modifying the rendPkgUri. What this suggests to me is that we don't want to store the full logo URI but instead define a rendLogoUri :: PackageRender -> Maybe String which constructs the URL using the rendPkgUri.

I've modified your patch accordingly (attached) but haven't tested it.

Max

Thanks Max, it works on my site. Bas

On 24 October 2011 17:38, Tillmann Rendel wrote:

Wouldn't it be more in line with the rest of the cabal infrastructure to specify the logo file in the cabal file, similar to, e.g., the license file?

Yes it would be more in line. But apart from that, what advantage would it have? Bas

On 25 October 2011 10:48, Tillmann Rendel wrote:

I see many good reasons for both naming conventions and explicit configuration. I just wonder whether it is a good idea to switch from one to the other in the middle of Cabal's success story.

I see your point. I just remembered I proposed this myself in the ticket about this: http://hackage.haskell.org/trac/hackage/ticket/619 So I'm fine with adding it to the cabal file. I may even do this myself but I'm a bit swamped at the moment. Any ideas about my second point in the ticket: "Should there be a restriction on the logo width and height? Maybe we need support for multiple sized logo's: a big one to put on the hackage page and a small one to display in package lists. (Maybe we even need support for favicons)" Currently the only restriction on the logo is that it should be either a .svg or .png (or both but svg is preferred). There aren't any restrictions on dimensions. However the logo is shown with a height of 200px. Bas