[Hackage] #792: sdist doesn't not include source files from test-suite stanzas
#792: sdist doesn't not include source files from test-suite stanzas ----------------------------+----------------------------------------------- Reporter: tibbe | Owner: ttuegel Type: defect | Status: new Priority: normal | Milestone: Cabal-1.10 Component: Cabal library | Version: 1.8.0.6 Severity: normal | Keywords: Difficulty: unknown | Ghcversion: Platform: | ----------------------------+----------------------------------------------- `cabal sdist` doesn't include the source files from test-suite stanzas when generating the tarball. This leads to Hackage's QA checks rejecting the package. Steps to reproduce: 1. Create a Cabal package with a test-suite stanza (and set `hs-source- dirs` to e.g. `tests`). 2. Run `cabal sdist` 3. Unpack the tarball and look at the content. Thomas, could you please take a look? -- Ticket URL: http://hackage.haskell.org/trac/hackage/ticket/792 Hackage http://haskell.org/cabal/ Hackage: Cabal and related projects
#792: sdist doesn't not include source files from test-suite stanzas
----------------------------+-----------------------------------------------
Reporter: tibbe | Owner: ttuegel
Type: defect | Status: new
Priority: normal | Milestone: Cabal-1.10
Component: Cabal library | Version: 1.8.0.6
Severity: normal | Keywords:
Difficulty: unknown | Ghcversion:
Platform: |
----------------------------+-----------------------------------------------
Comment(by duncan):
{{{
#792: sdist doesn't not include source files from test-suite stanzas ----------------------------+----------------------------------------------- Reporter: tibbe | Owner: ttuegel Type: defect | Status: new Priority: normal | Milestone: Cabal-1.10 Component: Cabal library | Version: 1.8.0.6 Severity: normal | Keywords: Difficulty: unknown | Ghcversion: Platform: | ----------------------------+----------------------------------------------- Comment(by tibbe): Just to clarify the above IRC discussion, the problem exists even if the package is configured using `--enable-tests`: {{{ runghc Setup.hs configure --enable-tests --user runghc Setup.hs sdist tar -ztf dist/mypackage-1.0.tar.gz }}} -- Ticket URL: http://hackage.haskell.org/trac/hackage/ticket/792#comment:2 Hackage http://haskell.org/cabal/ Hackage: Cabal and related projects
#792: sdist doesn't not include source files from test-suite stanzas ----------------------------+----------------------------------------------- Reporter: tibbe | Owner: ttuegel Type: defect | Status: new Priority: normal | Milestone: Cabal-1.10 Component: Cabal library | Version: 1.8.0.6 Severity: normal | Keywords: Difficulty: unknown | Ghcversion: Platform: | ----------------------------+----------------------------------------------- Comment(by tibbe): Workaround: List all the test-suites' source files under the global `extra-source-files` field. -- Ticket URL: http://hackage.haskell.org/trac/hackage/ticket/792#comment:3 Hackage http://haskell.org/cabal/ Hackage: Cabal and related projects
#792: sdist doesn't not include source files from test-suite stanzas ----------------------------+----------------------------------------------- Reporter: tibbe | Owner: ttuegel Type: defect | Status: assigned Priority: normal | Milestone: Cabal-1.10 Component: Cabal library | Version: 1.8.0.6 Severity: normal | Keywords: Difficulty: unknown | Ghcversion: Platform: | ----------------------------+----------------------------------------------- Changes (by ttuegel): * status: new => assigned Comment: The patch I just attached fixes this problem when you do {{{runghc Setup.hs sdist}}}. My preliminary investigation shows that another patch for cabal-install will be necessary, but I haven't poked at the source yet. -- Ticket URL: http://hackage.haskell.org/trac/hackage/ticket/792#comment:4 Hackage http://haskell.org/cabal/ Hackage: Cabal and related projects
#792: sdist doesn't not include source files from test-suite stanzas ----------------------------+----------------------------------------------- Reporter: tibbe | Owner: ttuegel Type: defect | Status: assigned Priority: normal | Milestone: Cabal-1.10 Component: Cabal library | Version: 1.8.0.6 Severity: normal | Keywords: Difficulty: unknown | Ghcversion: Platform: | ----------------------------+----------------------------------------------- Comment(by ttuegel): Replying to [comment:4 ttuegel]:
The patch I just attached fixes this problem when you do {{{runghc Setup.hs sdist}}}. My preliminary investigation shows that another patch for cabal-install will be necessary, but I haven't poked at the source yet.
I was wrong, this fixes cabal-install, too. -- Ticket URL: http://hackage.haskell.org/trac/hackage/ticket/792#comment:5 Hackage http://haskell.org/cabal/ Hackage: Cabal and related projects
#792: sdist doesn't not include source files from test-suite stanzas
----------------------------+-----------------------------------------------
Reporter: tibbe | Owner: ttuegel
Type: defect | Status: closed
Priority: normal | Milestone: Cabal-1.10
Component: Cabal library | Version: 1.8.0.6
Severity: normal | Resolution: fixed
Keywords: | Difficulty: unknown
Ghcversion: | Platform:
----------------------------+-----------------------------------------------
Changes (by duncan):
* status: assigned => closed
* resolution: => fixed
Comment:
Applied.
{{{
Wed Jan 19 15:34:04 GMT 2011 Thomas Tuegel
#792: sdist doesn't not include source files from test-suite stanzas ----------------------------+----------------------------------------------- Reporter: tibbe | Owner: ttuegel Type: defect | Status: closed Priority: normal | Milestone: Cabal-1.10 Component: Cabal library | Version: 1.8.0.6 Severity: normal | Resolution: fixed Keywords: | Difficulty: unknown Ghcversion: | Platform: ----------------------------+----------------------------------------------- Changes (by basvandijk): * cc: v.dijk.bas@… (added) Comment: I just received a [https://github.com/basvandijk/monad-control/issues/1 bugreport of one of my libraries] about this. Is the fix already in any released version? -- Ticket URL: http://hackage.haskell.org/trac/hackage/ticket/792#comment:7 Hackage http://haskell.org/cabal/ Hackage: Cabal and related projects
#792: sdist doesn't not include source files from test-suite stanzas ----------------------------+----------------------------------------------- Reporter: tibbe | Owner: ttuegel Type: defect | Status: closed Priority: normal | Milestone: Cabal-1.10 Component: Cabal library | Version: 1.8.0.6 Severity: normal | Resolution: fixed Keywords: | Difficulty: unknown Ghcversion: | Platform: ----------------------------+----------------------------------------------- Comment(by elga): * [http://www.releve-identite-operateur.fr/rio-simyo.html simyo] -- Ticket URL: http://hackage.haskell.org/trac/hackage/ticket/792#comment:8 Hackage http://haskell.org/cabal/ Hackage: Cabal and related projects
participants (1)
-
Hackage