[Hackage] #689: Package checker shouldn't warn about deprecated extensions inside conditionals
#689: Package checker shouldn't warn about deprecated extensions inside conditionals --------------------------------+------------------------------------------- Reporter: guest | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: hackageDB website | Version: 1.6.0.3 Severity: normal | Keywords: Difficulty: unknown | Ghcversion: Platform: | --------------------------------+------------------------------------------- Hello, I uploaded a package to Hackage (extcore 0.6) that contains the following text in the Library section in the .cabal file: {{{ if impl(ghc > 6.8.2) { build-depends:syb } else { extensions: PatternSignatures } }}} The Hackage package checker warned me: "Deprecated extensions: 'PatternSignatures'. Instead of 'PatternSignatures' use 'ScopedTypeVariables'." This seems like a bug to me. Of course PatternSignatures is deprecated; that's why it's in a clause that only applies with a version of GHC less than 6.8.2. Warnings should trigger only for extensions that are deprecated in the version that the extension is declared for. -- Ticket URL: http://hackage.haskell.org/trac/hackage/ticket/689 Hackage http://haskell.org/cabal/ Hackage: Cabal and related projects
#689: Package checker shouldn't warn about deprecated extensions inside conditionals --------------------------------+------------------------------------------- Reporter: guest | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: hackageDB website | Version: 1.6.0.3 Severity: normal | Keywords: Difficulty: unknown | Ghcversion: Platform: | --------------------------------+------------------------------------------- Comment(by guest): (I can't figure out how to set my contact info here, but this report is from Tim Chevalier, chevalier@alum.wellesley.edu ) -- Ticket URL: http://hackage.haskell.org/trac/hackage/ticket/689#comment:1 Hackage http://haskell.org/cabal/ Hackage: Cabal and related projects
#689: Package checker shouldn't warn about deprecated extensions inside conditionals ----------------------------+----------------------------------------------- Reporter: guest | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Cabal library | Version: 1.6.0.3 Severity: normal | Keywords: Difficulty: unknown | Ghcversion: Platform: | ----------------------------+----------------------------------------------- Changes (by ross): * component: hackageDB website => Cabal library Comment: This comes from checkFields in the Cabal library; it will also be reported by "cabal check". -- Ticket URL: http://hackage.haskell.org/trac/hackage/ticket/689#comment:2 Hackage http://haskell.org/cabal/ Hackage: Cabal and related projects
#689: Package checker shouldn't warn about deprecated extensions inside conditionals ----------------------------+----------------------------------------------- Reporter: guest | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: Cabal library | Version: 1.6.0.3 Severity: normal | Resolution: wontfix Keywords: | Difficulty: unknown Ghcversion: | Platform: ----------------------------+----------------------------------------------- Changes (by duncan): * status: new => closed * resolution: => wontfix Comment: The warning is correct and safe. You can use `ScopedTypeVariables`. It has been supported in ghc since ghc-6.4 (which is the earliest version of ghc supported by cabal). In the other example of a deprecated extension, you can use the new extension name with the older ghc versions because cabal translates to the old alias. With future deprecations we must be careful to do the same or otherwise not to recommend incorrect solutions. I've added a note about this to the deprecation list. -- Ticket URL: http://hackage.haskell.org/trac/hackage/ticket/689#comment:3 Hackage http://haskell.org/cabal/ Hackage: Cabal and related projects
participants (1)
-
Hackage