May 2026 - ghc-commits

[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 2 commits: Ensure that SetOps.{minusList,unionListsOrd} can be specialized
by Marge Bot (＠marge-bot) 25 May '26

25 May '26

Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC Commits: 156f09b8 by Simon Jakobi at 2026-05-25T08:30:50-04:00 Ensure that SetOps.{minusList,unionListsOrd} can be specialized ...by marking them INLINABLE. Haddock allocates 0.1–0.3% less as a result. This also removes some redundant constraints on unionListsOrd. - - - - - 6a76e7aa by Cheng Shao at 2026-05-25T08:30:50-04:00 wasm: ensure post-linker output is synchronous ESM This patch fixes wasm backend's post-linker output script to ensure it's synchronous ESM and doesn't use top-level await, which doesn't work in ServiceWorkers. Fixes #27257. - - - - - 3 changed files: - + changelog.d/wasm-fix-serviceworker - compiler/GHC/Data/List/SetOps.hs - utils/jsffi/prelude.mjs Changes: ===================================== changelog.d/wasm-fix-serviceworker ===================================== @@ -0,0 +1,4 @@ +section: wasm-backend +synopsis: Ensure post-linker output is synchronous ESM and fix loading in ServiceWorker +issues: #27257 +mrs: !16093 ===================================== compiler/GHC/Data/List/SetOps.hs ===================================== @@ -60,12 +60,13 @@ getNth xs n = assertPpr (xs `lengthExceeds` n) (ppr n $$ ppr xs) $ -- -- Uses a set internally to record duplicates. This makes it slightly slower for -- very small lists but avoids quadratic behaviour for large lists. -unionListsOrd :: (HasDebugCallStack, Outputable a, Ord a) => [a] -> [a] -> [a] +unionListsOrd :: Ord a => [a] -> [a] -> [a] unionListsOrd xs ys - -- Since both arguments don't have internal duplicates we can just take all of xs - -- and every element of ys that's not already in xs. + -- Since both arguments don't have internal duplicates we can just take all of ys + -- and every element of xs that's not already in ys. = let set_ys = S.fromList ys in (filter (\e -> not $ S.member e set_ys) xs) ++ ys +{-# INLINABLE unionListsOrd #-} -- Ensure the function can be specialized. -- | Assumes that the arguments contain no duplicates unionLists :: (HasDebugCallStack, Outputable a, Eq a) => [a] -> [a] -> [a] @@ -108,6 +109,7 @@ minusList xs [y] = filter (/= y) xs minusList xs ys = filter (`S.notMember` yss) xs where yss = S.fromList ys +{-# INLINABLE minusList #-} -- Ensure the function can be specialized. {- ************************************************************************ ===================================== utils/jsffi/prelude.mjs ===================================== @@ -39,19 +39,13 @@ export class JSValManager { // To benchmark different setImmediate() implementations in the // browser, use https://github.com/jphpsf/setImmediate-shim-demo as a // starting point. -export const setImmediate = await (async () => { - // node, bun, or other scripts might have set this up in the browser +export const setImmediate = (() => { + // node, deno, bun, or other scripts might have set this up in the + // browser if (globalThis.setImmediate) { return globalThis.setImmediate; } - // deno - if (globalThis.Deno) { - try { - return (await import("node:timers")).setImmediate; - } catch {} - } - // https://developer.mozilla.org/en-US/docs/Web/API/Scheduler/postTask if (globalThis.scheduler) { return (cb, ...args) => scheduler.postTask(() => cb(...args)); View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/4d8d8e379bb06b8b0416d8e4422908… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/4d8d8e379bb06b8b0416d8e4422908… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/mangoiv/ghc-9.12-bp] AArch64: use ASR not LSR for MO_U_Shr at W8/W16
by Magnus (＠MangoIV) 25 May '26

25 May '26

Magnus pushed to branch wip/mangoiv/ghc-9.12-bp at Glasgow Haskell Compiler / GHC Commits: 82c521c6 by Ian Duncan at 2026-05-25T13:39:24+02:00 AArch64: use ASR not LSR for MO_U_Shr at W8/W16 The unsigned right shift (MO_U_Shr) for sub-word widths (W8, W16) with a variable shift amount was emitting ASR (arithmetic/signed shift right) after zero-extending with UXTB/UXTH. This should be LSR (logical/unsigned shift right). After zero-extension the upper bits happen to be 0 so ASR produces the same result, but it is semantically wrong and would break if the zero-extension were ever optimized away. Includes assembly output test (grep for lsr) and runtime test verifying unsigned right shift of Word8 and Word16 values. (cherry picked from commit 50188615342098345fc2822ea223ab23791bbf49) - - - - - 12 changed files: - + changelog.d/T26979 - compiler/GHC/CmmToAsm/AArch64/CodeGen.hs - + testsuite/tests/codeGen/should_gen_asm/aarch64-shl-subword.asm - + testsuite/tests/codeGen/should_gen_asm/aarch64-shl-subword.hs - + testsuite/tests/codeGen/should_gen_asm/aarch64-ushr-subword.asm - + testsuite/tests/codeGen/should_gen_asm/aarch64-ushr-subword.hs - testsuite/tests/codeGen/should_gen_asm/all.T - + testsuite/tests/codeGen/should_run/aarch64-subword-ops.hs - + testsuite/tests/codeGen/should_run/aarch64-subword-ops.stdout - + testsuite/tests/codeGen/should_run/aarch64-ushr-subword-run.hs - + testsuite/tests/codeGen/should_run/aarch64-ushr-subword-run.stdout - testsuite/tests/codeGen/should_run/all.T Changes: ===================================== changelog.d/T26979 ===================================== @@ -0,0 +1,11 @@ +section: compiler +issues: #26979 +mrs: !15620 +synopsis: + On AArch64, use an arithmetic instead of a logical right shift when + sign extending at 8/16 bit word size. +description: + The unsigned right shift ``MO_U_Shr`` for sub-word widths (``W8``, ``W16``) + with a variable shift amount now correctly emits ``LSR`` instead of ``ASR``. + ``ASR`` was semantically wrong, and would break if the zero-extension were + ever optimized away. ===================================== compiler/GHC/CmmToAsm/AArch64/CodeGen.hs ===================================== @@ -525,6 +525,15 @@ opRegWidth w = pprPanic "opRegWidth" (text "Unsupported width" <+> ppr w) -- sub-word-size value always contains the zero-extended form of that value -- in between operations. -- +-- IMPORTANT: this invariant only holds within a single expression tree as +-- generated by the NCG (via truncateReg after each sub-word operation). It +-- does NOT hold at function entry points or across basic block boundaries, +-- because the GHC calling convention does not guarantee that callers +-- zero-extend sub-word arguments. Therefore, any operation that is sensitive +-- to the upper bits of its input (e.g. unsigned right shift, unsigned +-- division) must explicitly zero- or sign-extend its operands rather than +-- assuming they are already extended. +-- -- For instance, consider the program, -- -- test(bits64 buffer) @@ -543,7 +552,7 @@ opRegWidth w = pprPanic "opRegWidth" (text "Unsupported width" <+> ppr w) -- Next we compute `c`: The `%not` requires no extension of its operands, but -- we must still truncate the result back down to 8-bits. Finally the `%shrl` -- requires no extension and no truncate since we can assume that --- `c` is zero-extended. +-- `c` is zero-extended (it was produced by a truncateReg in the same block). -- -- TODO: -- Don't use Width in Operands @@ -877,17 +886,30 @@ getRegister' config plat expr CmmMachOp (MO_U_Quot w) [x, y] | w == W8 -> do (reg_x, _format_x, code_x) <- getSomeReg x (reg_y, _format_y, code_y) <- getSomeReg y - return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` annExpr expr (UXTB (OpReg w reg_x) (OpReg w reg_x)) `snocOL` - (UXTB (OpReg w reg_y) (OpReg w reg_y)) `snocOL` - (UDIV (OpReg w dst) (OpReg w reg_x) (OpReg w reg_y))) + tmp_x <- getNewRegNat (intFormat w) + tmp_y <- getNewRegNat (intFormat w) + return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` annExpr expr (UXTB (OpReg w tmp_x) (OpReg w reg_x)) `snocOL` + (UXTB (OpReg w tmp_y) (OpReg w reg_y)) `snocOL` + (UDIV (OpReg w dst) (OpReg w tmp_x) (OpReg w tmp_y))) CmmMachOp (MO_U_Quot w) [x, y] | w == W16 -> do (reg_x, _format_x, code_x) <- getSomeReg x (reg_y, _format_y, code_y) <- getSomeReg y - return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` annExpr expr (UXTH (OpReg w reg_x) (OpReg w reg_x)) `snocOL` - (UXTH (OpReg w reg_y) (OpReg w reg_y)) `snocOL` - (UDIV (OpReg w dst) (OpReg w reg_x) (OpReg w reg_y))) + tmp_x <- getNewRegNat (intFormat w) + tmp_y <- getNewRegNat (intFormat w) + return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` annExpr expr (UXTH (OpReg w tmp_x) (OpReg w reg_x)) `snocOL` + (UXTH (OpReg w tmp_y) (OpReg w reg_y)) `snocOL` + (UDIV (OpReg w dst) (OpReg w tmp_x) (OpReg w tmp_y))) -- 2. Shifts. x << n, x >> n. + -- Sub-word left shifts by a constant: use UBFM (UBFIZ alias) to shift + -- and mask in a single instruction. See Note [Signed arithmetic on AArch64]. + CmmMachOp (MO_Shl w) [x, (CmmLit (CmmInt n _))] | w == W8, 0 <= n, n < 8 -> do + (reg_x, _format_x, code_x) <- getSomeReg x + return $ Any (intFormat w) (\dst -> code_x `snocOL` annExpr expr (UBFM (OpReg w dst) (OpReg w reg_x) (OpImm (ImmInteger ((32 - n) `mod` 32))) (OpImm (ImmInteger (7 - n))))) + CmmMachOp (MO_Shl w) [x, (CmmLit (CmmInt n _))] | w == W16, 0 <= n, n < 16 -> do + (reg_x, _format_x, code_x) <- getSomeReg x + return $ Any (intFormat w) (\dst -> code_x `snocOL` annExpr expr (UBFM (OpReg w dst) (OpReg w reg_x) (OpImm (ImmInteger ((32 - n) `mod` 32))) (OpImm (ImmInteger (15 - n))))) + CmmMachOp (MO_Shl w) [x, (CmmLit (CmmInt n _))] | w == W32 || w == W64 , 0 <= n, n < fromIntegral (widthInBits w) -> do @@ -901,8 +923,11 @@ getRegister' config plat expr CmmMachOp (MO_S_Shr w) [x, y] | w == W8 -> do (reg_x, _format_x, code_x) <- getSomeReg x (reg_y, _format_y, code_y) <- getSomeReg y - return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` annExpr expr (SXTB (OpReg w reg_x) (OpReg w reg_x)) `snocOL` - (ASR (OpReg w dst) (OpReg w reg_x) (OpReg w reg_y)) `snocOL` + -- Use a temporary register to avoid sign-extending reg_x in-place, + -- as other operations may use reg_x. + tmp <- getNewRegNat (intFormat w) + return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` annExpr expr (SXTB (OpReg w tmp) (OpReg w reg_x)) `snocOL` + (ASR (OpReg w dst) (OpReg w tmp) (OpReg w reg_y)) `snocOL` (UXTB (OpReg w dst) (OpReg w dst))) -- See Note [Signed arithmetic on AArch64] CmmMachOp (MO_S_Shr w) [x, (CmmLit (CmmInt n _))] | w == W16, 0 <= n, n < 16 -> do @@ -912,8 +937,11 @@ getRegister' config plat expr CmmMachOp (MO_S_Shr w) [x, y] | w == W16 -> do (reg_x, _format_x, code_x) <- getSomeReg x (reg_y, _format_y, code_y) <- getSomeReg y - return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` annExpr expr (SXTH (OpReg w reg_x) (OpReg w reg_x)) `snocOL` - (ASR (OpReg w dst) (OpReg w reg_x) (OpReg w reg_y)) `snocOL` + -- Use a temporary register to avoid sign-extending reg_x in-place, + -- as other operations may use reg_x. + tmp <- getNewRegNat (intFormat w) + return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` annExpr expr (SXTH (OpReg w tmp) (OpReg w reg_x)) `snocOL` + (ASR (OpReg w dst) (OpReg w tmp) (OpReg w reg_y)) `snocOL` (UXTH (OpReg w dst) (OpReg w dst))) -- See Note [Signed arithmetic on AArch64] CmmMachOp (MO_S_Shr w) [x, (CmmLit (CmmInt n _))] @@ -928,8 +956,8 @@ getRegister' config plat expr CmmMachOp (MO_U_Shr w) [x, y] | w == W8 -> do (reg_x, _format_x, code_x) <- getSomeReg x (reg_y, _format_y, code_y) <- getSomeReg y - return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` annExpr expr (UXTB (OpReg w reg_x) (OpReg w reg_x)) `snocOL` - (ASR (OpReg w dst) (OpReg w reg_x) (OpReg w reg_y))) + tmp <- getNewRegNat (intFormat w) + return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` UXTB (OpReg w tmp) (OpReg w reg_x) `snocOL` annExpr expr (LSR (OpReg w dst) (OpReg w tmp) (OpReg w reg_y))) CmmMachOp (MO_U_Shr w) [x, (CmmLit (CmmInt n _))] | w == W16, 0 <= n, n < 16 -> do (reg_x, _format_x, code_x) <- getSomeReg x @@ -937,8 +965,8 @@ getRegister' config plat expr CmmMachOp (MO_U_Shr w) [x, y] | w == W16 -> do (reg_x, _format_x, code_x) <- getSomeReg x (reg_y, _format_y, code_y) <- getSomeReg y - return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` annExpr expr (UXTH (OpReg w reg_x) (OpReg w reg_x)) - `snocOL` (ASR (OpReg w dst) (OpReg w reg_x) (OpReg w reg_y))) + tmp <- getNewRegNat (intFormat w) + return $ Any (intFormat w) (\dst -> code_x `appOL` code_y `snocOL` UXTH (OpReg w tmp) (OpReg w reg_x) `snocOL` annExpr expr (LSR (OpReg w dst) (OpReg w tmp) (OpReg w reg_y))) CmmMachOp (MO_U_Shr w) [x, (CmmLit (CmmInt n _))] | w == W32 || w == W64 ===================================== testsuite/tests/codeGen/should_gen_asm/aarch64-shl-subword.asm ===================================== @@ -0,0 +1 @@ +ubfm ===================================== testsuite/tests/codeGen/should_gen_asm/aarch64-shl-subword.hs ===================================== @@ -0,0 +1,8 @@ +{-# LANGUAGE MagicHash #-} +module ShlSubWord (shlW8) where + +import GHC.Exts +import GHC.Word + +shlW8 :: Word8 -> Word8 +shlW8 (W8# w) = W8# (uncheckedShiftLWord8# w 4#) ===================================== testsuite/tests/codeGen/should_gen_asm/aarch64-ushr-subword.asm ===================================== @@ -0,0 +1 @@ +lsr ===================================== testsuite/tests/codeGen/should_gen_asm/aarch64-ushr-subword.hs ===================================== @@ -0,0 +1,9 @@ +{-# LANGUAGE MagicHash #-} +module UShrSubWord (ushrW8) where + +import GHC.Exts +import GHC.Word + +ushrW8 :: Word8 -> Int -> Word8 +ushrW8 x n = x `shiftR` n + where shiftR (W8# w) (I# i) = W8# (wordToWord8# (word8ToWord# w `uncheckedShiftRL#` i)) ===================================== testsuite/tests/codeGen/should_gen_asm/all.T ===================================== @@ -12,3 +12,11 @@ test('bytearray-memcpy-unroll', is_amd64_codegen, compile_grep_asm, ['hs', True, test('T18137', [when(opsys('darwin'), skip), only_ways(llvm_ways)], compile_grep_asm, ['hs', False, '-fllvm -split-sections']) test('T24941', [only_ways(['optasm'])], compile, ['-fregs-graph']) +is_aarch64_codegen = [ + unless(arch('aarch64'), skip), + when(unregisterised(), skip), +] + +# AArch64-specific tests +test('aarch64-ushr-subword', is_aarch64_codegen, compile_grep_asm, ['hs', True, '-O']) +test('aarch64-shl-subword', is_aarch64_codegen, compile_grep_asm, ['hs', True, '-O']) ===================================== testsuite/tests/codeGen/should_run/aarch64-subword-ops.hs ===================================== @@ -0,0 +1,115 @@ +{-# LANGUAGE MagicHash #-} +module Main where + +import GHC.Exts +import GHC.Word +import GHC.Int + +-- Uses sub-word primops directly so that the NCG sees MO_Shl W8, +-- MO_U_Shr W8, MO_S_Shr W8 etc. (the Bits class widens to Word#/Int#). + +-- NOINLINE to prevent constant folding. + +-- MO_U_Shr W8/W16 variable shift +{-# NOINLINE ushrW8 #-} +ushrW8 :: Word8 -> Int -> Word8 +ushrW8 (W8# w) (I# i) = W8# (uncheckedShiftRLWord8# w i) + +{-# NOINLINE ushrW16 #-} +ushrW16 :: Word16 -> Int -> Word16 +ushrW16 (W16# w) (I# i) = W16# (uncheckedShiftRLWord16# w i) + +-- MO_S_Shr W8/W16 variable shift +{-# NOINLINE sshrI8 #-} +sshrI8 :: Int8 -> Int -> Int8 +sshrI8 (I8# x) (I# i) = I8# (uncheckedShiftRAInt8# x i) + +{-# NOINLINE sshrI16 #-} +sshrI16 :: Int16 -> Int -> Int16 +sshrI16 (I16# x) (I# i) = I16# (uncheckedShiftRAInt16# x i) + +-- MO_Shl W8/W16 variable shift +{-# NOINLINE shlW8 #-} +shlW8 :: Word8 -> Int -> Word8 +shlW8 (W8# w) (I# i) = W8# (uncheckedShiftLWord8# w i) + +{-# NOINLINE shlW16 #-} +shlW16 :: Word16 -> Int -> Word16 +shlW16 (W16# w) (I# i) = W16# (uncheckedShiftLWord16# w i) + +-- quot exercising MO_U_Quot W8/W16 +{-# NOINLINE quotW8 #-} +quotW8 :: Word8 -> Word8 -> Word8 +quotW8 (W8# x) (W8# y) = W8# (quotWord8# x y) + +{-# NOINLINE quotW16 #-} +quotW16 :: Word16 -> Word16 -> Word16 +quotW16 (W16# x) (W16# y) = W16# (quotWord16# x y) + +-- Register clobbering: use a value both in a shift/quot and afterward. +-- If the sign/zero extension clobbers the source register, the second +-- use sees the wrong value. + +{-# NOINLINE sshrAndAdd8 #-} +sshrAndAdd8 :: Int8 -> Int -> Int8 +sshrAndAdd8 a n = sshrI8 a n + a + +{-# NOINLINE sshrAndAdd16 #-} +sshrAndAdd16 :: Int16 -> Int -> Int16 +sshrAndAdd16 a n = sshrI16 a n + a + +{-# NOINLINE quotAndAdd8 #-} +quotAndAdd8 :: Word8 -> Word8 -> Word8 +quotAndAdd8 a b = quotW8 a b + a + b + +{-# NOINLINE quotAndAdd16 #-} +quotAndAdd16 :: Word16 -> Word16 -> Word16 +quotAndAdd16 a b = quotW16 a b + a + b + +main :: IO () +main = do + putStrLn "-- MO_U_Shr variable shift" + print (ushrW8 0x80 1) -- 64 + print (ushrW8 0xFF 4) -- 15 + print (ushrW8 0x42 0) -- 66 + print (ushrW16 0x8000 1) -- 16384 + print (ushrW16 0xFFFF 8) -- 255 + print (ushrW16 0x1234 0) -- 4660 + + putStrLn "-- MO_S_Shr variable shift" + print (sshrI8 (-1) 1) -- -1 + print (sshrI8 (-128) 1) -- -64 + print (sshrI8 127 1) -- 63 + print (sshrI8 0x42 3) -- 8 + print (sshrI16 (-1) 1) -- -1 + print (sshrI16 (-32768) 1) -- -16384 + print (sshrI16 32767 8) -- 127 + + putStrLn "-- MO_Shl variable shift" + print (shlW8 0x01 0) -- 1 + print (shlW8 0x01 4) -- 16 + print (shlW8 0xFF 1) -- 254 + print (shlW8 0x42 3) -- 16 + print (shlW16 0x0001 0) -- 1 + print (shlW16 0x0001 8) -- 256 + print (shlW16 0xFFFF 1) -- 65534 + print (shlW16 0x1234 4) -- 9024 + + putStrLn "-- MO_U_Quot" + print (quotW8 255 10) -- 25 + print (quotW8 200 7) -- 28 + print (quotW8 1 1) -- 1 + print (quotW16 65535 256) -- 255 + print (quotW16 1000 3) -- 333 + + putStrLn "-- register clobbering: shift + reuse" + print (sshrAndAdd8 (-128) 1) -- 64 (wraps: -64 + -128 = -192 = 64 as Int8) + print (sshrAndAdd8 0x42 1) -- 99 + print (sshrAndAdd16 (-32768) 1) -- 16384 (wraps) + print (sshrAndAdd16 0x1234 4) -- 4951 + + putStrLn "-- register clobbering: quot + reuse" + print (quotAndAdd8 200 7) -- 235 + print (quotAndAdd8 255 10) -- 34 (wraps: 290 mod 256) + print (quotAndAdd16 1000 3) -- 1336 + print (quotAndAdd16 65535 256) -- 510 (wraps: 66046 mod 65536) ===================================== testsuite/tests/codeGen/should_run/aarch64-subword-ops.stdout ===================================== @@ -0,0 +1,40 @@ +-- MO_U_Shr variable shift +64 +15 +66 +16384 +255 +4660 +-- MO_S_Shr variable shift +-1 +-64 +63 +8 +-1 +-16384 +127 +-- MO_Shl variable shift +1 +16 +254 +16 +1 +256 +65534 +9024 +-- MO_U_Quot +25 +28 +1 +255 +333 +-- register clobbering: shift + reuse +64 +99 +16384 +4951 +-- register clobbering: quot + reuse +235 +34 +1336 +510 ===================================== testsuite/tests/codeGen/should_run/aarch64-ushr-subword-run.hs ===================================== @@ -0,0 +1,9 @@ +import Data.Bits (shiftR) +import Data.Word (Word8, Word16) + +main :: IO () +main = do + print (shiftR (0x80 :: Word8) 1) + print (shiftR (0xFF :: Word8) 4) + print (shiftR (0x8000 :: Word16) 1) + print (shiftR (0xFFFF :: Word16) 8) ===================================== testsuite/tests/codeGen/should_run/aarch64-ushr-subword-run.stdout ===================================== @@ -0,0 +1,4 @@ +64 +15 +16384 +255 ===================================== testsuite/tests/codeGen/should_run/all.T ===================================== @@ -275,3 +275,6 @@ test('T27072d', [req_c, only_ways(['dyn']), when(not opsys('darwin'), skip), # Skipped on Darwin (Apple linker doesn't support --wrap). test('T27072w', [req_c, js_skip, when(opsys('darwin'), skip)], compile_and_run, ['T27072w_c.c -no-hs-main -optl-Wl,--wrap=hs_spt_remove']) +# AArch64-specific runtime tests +test('aarch64-ushr-subword-run', [unless(arch('aarch64'), skip)], compile_and_run, ['-O']) +test('aarch64-subword-ops', [unless(arch('aarch64'), skip)], compile_and_run, ['-O']) View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/82c521c62b1842672e6f411750df4c6… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/82c521c62b1842672e6f411750df4c6… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/spj-try-opt-coercion] Wibbles
by Simon Peyton Jones (＠simonpj) 25 May '26

25 May '26

Simon Peyton Jones pushed to branch wip/spj-try-opt-coercion at Glasgow Haskell Compiler / GHC Commits: 7574a932 by Simon Peyton Jones at 2026-05-25T13:20:20+01:00 Wibbles - - - - - 1 changed file: - compiler/GHC/Core/SimpleOpt.hs Changes: ===================================== compiler/GHC/Core/SimpleOpt.hs ===================================== @@ -35,7 +35,7 @@ import GHC.Core.Type hiding ( substTy, extendTvSubst, extendCvSubst, extendTvSub , isInScope, substTyVarBndr, cloneTyVarBndr ) import GHC.Core.Predicate( isCoVarType ) import GHC.Core.Coercion hiding ( substCo, substCoVarBndr ) -import GHC.Core.Coercion.Opt( optCoRefl, optTransCo ) +import GHC.Core.Coercion.Opt( optCoRefl ) import GHC.Types.Literal import GHC.Types.Id @@ -308,13 +308,13 @@ type SimpleClo = (SimpleOptEnv, InExpr) data SimpleContItem = ApplyToArg SimpleClo - | CastIt OutCoercion OutType + | CastIt OutCoercion -- The OutType is the corecionRKind of the coercion -- Used to make reflexivity checking more efficient instance Outputable SimpleContItem where ppr (ApplyToArg (_, arg)) = text "ARG" <+> ppr arg - ppr (CastIt co _) = text "CAST" <+> ppr co + ppr (CastIt co) = text "CAST" <+> ppr co data SimpleOptEnv = SOE { soe_opts :: {-# UNPACK #-} !SimpleOpts @@ -488,7 +488,7 @@ simple_app env e0@(Lam {}) as0@(_:_) where (env', b') = subst_opt_bndr env b -- See Note [Eliminate casts in function position] - do_beta env e@(Lam b _) as@(CastIt out_co _ : rest) + do_beta env e@(Lam b _) as@(CastIt out_co : rest) | isNonCoVarId b -- Optimise the inner lambda to make it an 'OutExpr', which makes it -- possible to call 'pushCoercionIntoLambda' with the 'OutCoercion' 'co'. @@ -563,18 +563,10 @@ add_cast env co1 as = as | otherwise = case as of - CastIt co2 _ : rest --- ToDo: get rid of the type field in CastIt? --- | ty2 `eqTypeIgnoringMultiplicity` coercionLKind opt_co1 --- -> rest --- ToDo: do we want to call optTransCo here? --- | otherwise -> CastIt (optTransCo in_scope opt_co1 co2) tyR : rest - | otherwise -> CastIt (mkTransCo opt_co1 co2) tyR : rest - _ -> CastIt opt_co1 tyR : as + CastIt co2 : rest -> CastIt (mkTransCo opt_co1 co2) : rest + _ -> CastIt opt_co1 : as where - in_scope = soeInScope env opt_co1 = simple_opt_co env co1 - tyR = coercionRKind opt_co1 rebuild_app :: HasDebugCallStack => SimpleOptEnv -> OutExpr -> [SimpleContItem] -> OutExpr @@ -583,7 +575,7 @@ rebuild_app env fun args = foldl mk_app fun args in_scope = soeInScope env mk_app out_fun = \case ApplyToArg arg -> App out_fun (simple_opt_clo in_scope arg) - CastIt co _ -> mk_cast out_fun co + CastIt co -> mk_cast out_fun co mk_cast :: CoreExpr -> CoercionR -> CoreExpr -- Does a full reflexivity check, unlike GHC.Core.Utils.mkCast, View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/7574a9326107b5a3df9ab1deb8e5c4c… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/7574a9326107b5a3df9ab1deb8e5c4c… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/mangoiv/process-bump] 2 commits: libraries/process: bump submodule to v1.6.29.0
by Magnus (＠MangoIV) 25 May '26

25 May '26

Magnus pushed to branch wip/mangoiv/process-bump at Glasgow Haskell Compiler / GHC Commits: 842285f5 by mangoiv at 2026-05-25T14:12:52+02:00 libraries/process: bump submodule to v1.6.29.0 This submodule bump resolves a segfault on macos 15. Fixes #27144 - - - - - 31576d9b by mangoiv at 2026-05-25T14:12:52+02:00 libraries/unix: in submodule, don't pick branch 2.7 The 2.7 branch is outdated and the module has been advanced far beyond it anyway, so remove that line. - - - - - 3 changed files: - .gitmodules - + changelog.d/bump-process - libraries/process Changes: ===================================== .gitmodules ===================================== @@ -82,7 +82,6 @@ path = libraries/unix url = https://gitlab.haskell.org/ghc/packages/unix.git ignore = untracked - branch = 2.7 [submodule "libraries/semaphore-compat"] path = libraries/semaphore-compat url = https://gitlab.haskell.org/ghc/semaphore-compat.git ===================================== changelog.d/bump-process ===================================== @@ -0,0 +1,8 @@ +section: libraries +issues: #27144 +mrs: !16096 +synopsis: + bump submodule to v1.6.29.0 +description: + This submodule bump resolves a segfault on macos 15 with + certain command line SDK versions. ===================================== libraries/process ===================================== @@ -1 +1 @@ -Subproject commit 72e5b7c75a17f543262674259b2ebf4a3bda390c +Subproject commit 92deb52c1781bf10ad390296dbc435abe103bfe4 View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/4d9ea2cd2ed566318d03d84b15755e… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/4d9ea2cd2ed566318d03d84b15755e… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc] Pushed new branch wip/sjakobi/multi-caret
by Simon Jakobi (＠sjakobi2) 25 May '26

25 May '26

Simon Jakobi pushed new branch wip/sjakobi/multi-caret at Glasgow Haskell Compiler / GHC -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/tree/wip/sjakobi/multi-caret You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/mangoiv/process-bump] libraries/unix: in submodule, don't pick branch 2.7
by Magnus (＠MangoIV) 25 May '26

25 May '26

Magnus pushed to branch wip/mangoiv/process-bump at Glasgow Haskell Compiler / GHC Commits: 4d9ea2cd by mangoiv at 2026-05-25T13:53:34+02:00 libraries/unix: in submodule, don't pick branch 2.7 The 2.7 branch is outdated and the module has been advanced far beyond it anyway, so remove that line. - - - - - 1 changed file: - .gitmodules Changes: ===================================== .gitmodules ===================================== @@ -82,7 +82,6 @@ path = libraries/unix url = https://gitlab.haskell.org/ghc/packages/unix.git ignore = untracked - branch = 2.7 [submodule "libraries/semaphore-compat"] path = libraries/semaphore-compat url = https://gitlab.haskell.org/ghc/semaphore-compat.git View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/4d9ea2cd2ed566318d03d84b15755ec… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/4d9ea2cd2ed566318d03d84b15755ec… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/spj-reinstallable-base2] 9 commits: move ioTyConOcc to KnownKeys
by Rodrigo Mesquita (＠alt-romes) 25 May '26

25 May '26

Rodrigo Mesquita pushed to branch wip/spj-reinstallable-base2 at Glasgow Haskell Compiler / GHC Commits: 8e941d6e by Rodrigo Mesquita at 2026-05-25T10:24:25+01:00 move ioTyConOcc to KnownKeys - - - - - 3062070e by Rodrigo Mesquita at 2026-05-25T10:24:25+01:00 Fix IO ty con for ghci - - - - - 4da99676 by Rodrigo Mesquita at 2026-05-25T10:44:10+01:00 GHC.Essentials fixes - - - - - d15d8b2c by Rodrigo Mesquita at 2026-05-25T10:50:19+01:00 Accept some krepStar and trModule (not needed in no-datatype modules) tests - - - - - d2277b51 by Rodrigo Mesquita at 2026-05-25T11:19:52+01:00 wired_in_names - - - - - 1a65c991 by Rodrigo Mesquita at 2026-05-25T11:25:16+01:00 accept test outs - - - - - 0859608f by Rodrigo Mesquita at 2026-05-25T11:32:48+01:00 output recomp24656 - - - - - 611e3ff9 by Rodrigo Mesquita at 2026-05-25T11:44:28+01:00 Accet more tests outputs - - - - - a36be512 by Rodrigo Mesquita at 2026-05-25T11:49:42+01:00 fix outdated note references - - - - - 65 changed files: - compiler/GHC/Builtin.hs - compiler/GHC/Builtin/KnownKeys.hs - compiler/GHC/Builtin/KnownOccs.hs - compiler/GHC/Builtin/WiredIn/Types.hs - compiler/GHC/Runtime/Context.hs - compiler/GHC/Tc/Gen/Splice.hs - compiler/GHC/Tc/Module.hs - compiler/GHC/Types/Name/Cache.hs - ghc/GHCi/UI.hs - libraries/base/src/GHC/Essentials.hs - testsuite/tests/backpack/should_compile/T20396.stderr - testsuite/tests/corelint/T21115b.stderr - testsuite/tests/count-deps/CountDepsAst.stdout - testsuite/tests/count-deps/CountDepsParser.stdout - testsuite/tests/deSugar/should_compile/T16615.stderr - testsuite/tests/deSugar/should_compile/T2431.stderr - testsuite/tests/default/DefaultImportFail01.stderr - testsuite/tests/default/DefaultImportFail02.stderr - testsuite/tests/default/DefaultImportFail03.stderr - testsuite/tests/default/DefaultImportFail04.stderr - testsuite/tests/default/DefaultImportFail05.stderr - testsuite/tests/default/DefaultImportFail07.stderr - testsuite/tests/default/T25775.stderr - testsuite/tests/diagnostic-codes/codes.stdout - testsuite/tests/driver/recomp24656/Makefile - testsuite/tests/driver/recomp24656/recomp24656.stdout - testsuite/tests/ghci.debugger/scripts/print019.stderr - testsuite/tests/indexed-types/should_fail/T12522a.stderr - testsuite/tests/interface-stability/ghc-experimental-exports.stdout - testsuite/tests/numeric/should_compile/T14170.stdout - testsuite/tests/numeric/should_compile/T14465.stdout - testsuite/tests/numeric/should_compile/T7116.stdout - testsuite/tests/overloadedlists/should_fail/overloadedlistsfail01.stderr - testsuite/tests/parser/should_compile/DumpParsedAst.stderr - testsuite/tests/parser/should_compile/DumpRenamedAst.stderr - testsuite/tests/parser/should_compile/DumpTypecheckedAst.stderr - testsuite/tests/parser/should_compile/KindSigs.stderr - testsuite/tests/parser/should_fail/RecordDotSyntaxFail10.stderr - testsuite/tests/parser/should_fail/RecordDotSyntaxFail11.stderr - testsuite/tests/parser/should_fail/RecordDotSyntaxFail13.stderr - testsuite/tests/parser/should_fail/RecordDotSyntaxFail8.stderr - testsuite/tests/partial-sigs/should_fail/NamedWildcardsNotInMonotype.stderr - testsuite/tests/patsyn/should_fail/T26465.stderr - testsuite/tests/roles/should_compile/Roles1.stderr - testsuite/tests/roles/should_compile/Roles13.stderr - testsuite/tests/roles/should_compile/Roles14.stderr - testsuite/tests/roles/should_compile/Roles2.stderr - testsuite/tests/roles/should_compile/Roles3.stderr - testsuite/tests/roles/should_compile/Roles4.stderr - testsuite/tests/roles/should_compile/T8958.stderr - testsuite/tests/simplCore/should_compile/OpaqueNoCastWW.stderr - testsuite/tests/simplCore/should_compile/T13543.stderr - testsuite/tests/simplCore/should_compile/T3717.stderr - testsuite/tests/simplCore/should_compile/T3772.stdout - testsuite/tests/simplCore/should_compile/T4908.stderr - testsuite/tests/simplCore/should_compile/T4930.stderr - testsuite/tests/simplCore/should_compile/T7360.stderr - testsuite/tests/simplCore/should_compile/T8274.stdout - testsuite/tests/simplCore/should_compile/T9400.stderr - testsuite/tests/simplCore/should_compile/noinline01.stderr - testsuite/tests/simplCore/should_compile/par01.stderr - testsuite/tests/th/TH_Roles2.stderr - testsuite/tests/typecheck/should_compile/T13032.stderr - testsuite/tests/typecheck/should_compile/T18406b.stderr - testsuite/tests/typecheck/should_compile/T18529.stderr The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/563805cc8d913a65768e8f1ddf9bdc… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/563805cc8d913a65768e8f1ddf9bdc… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/sjakobi/checkTyEqRhs] Prevent dictionary-passing in checkTyEqRhs
by Simon Jakobi (＠sjakobi2) 25 May '26

25 May '26

Simon Jakobi pushed to branch wip/sjakobi/checkTyEqRhs at Glasgow Haskell Compiler / GHC Commits: 5068e09e by Simon Jakobi at 2026-05-25T12:46:06+02:00 Prevent dictionary-passing in checkTyEqRhs ...by pre-specializing it to TcM. Previously, wherever checkTyEqRhs was used in other modules, the Core showed dictionary passing ($fMonadIOEnv). The added SPECIALIZE pragma prevents this. - - - - - 1 changed file: - compiler/GHC/Tc/Utils/Unify.hs Changes: ===================================== compiler/GHC/Tc/Utils/Unify.hs ===================================== @@ -4240,6 +4240,8 @@ checkTyEqRhs flags rhs = recurseIntoFamTyConApp flags tc tys | otherwise = check_ty_eq_rhs flags rhs +-- Prevent dictionary-passing when checkTyEqRhs is used in TcM in other modules: +{-# SPECIALIZE checkTyEqRhs :: TyEqFlags TcM a -> TcType -> TcM (PuResult a Reduction) #-} {- Note [Special case for top-level of Given equality] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/5068e09ee25cfb004f9178bd6603c4e… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/5068e09ee25cfb004f9178bd6603c4e… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/spj-try-opt-coercion] 9 commits: Use "grimily" instead of "grimly"
by Simon Peyton Jones (＠simonpj) 25 May '26

25 May '26

Simon Peyton Jones pushed to branch wip/spj-try-opt-coercion at Glasgow Haskell Compiler / GHC Commits: 6f9d7c71 by Markus Läll at 2026-05-21T15:25:34-04:00 Use "grimily" instead of "grimly" Fixes https://gitlab.haskell.org/ghc/ghc/-/issues/27221 - - - - - 50e999ca by fendor at 2026-05-21T15:26:18-04:00 Speed up 'closure' computation in `ghc-pkg` Cache the set of already seen `UnitId`s and use `Set` operations to speed up 'closure' computation. Further simplify the implementation of 'closure' to account for the actual usage. As a consequence, we rename 'closure' to 'brokenPackages' to reflect its purpose better after the simplification. - - - - - 7ecc6184 by sheaf at 2026-05-21T15:27:10-04:00 TcMPluginHandling: be more lenient when no plugins This change ensures that, if a function such as 'typecheckModule' was invoked with 'NoTcMPlugins', GHC doesn't spuriously complain about TcM plugins having already been stopped, as there were none to start with. - - - - - 72c8de5c by Simon Jakobi at 2026-05-23T18:41:42-04:00 Implement List.elem via foldr ...in order to allow specialization to Eq instances. The implementation of notElem is updated for consistency.` Corresponding CLC proposal: https://github.com/haskell/core-libraries-committee/issues/412 Addresses #27096. - - - - - 3268c610 by Alan Zimmerman at 2026-05-23T18:42:30-04:00 EPA: Fix span for qualified multiline string Fix the span for a qualified multiline string like Text.""" I'm a multiline Text value ! """ to extend to the end of the entire string, not just the first line. Closes #27274 - - - - - 1f096790 by Alan Zimmerman at 2026-05-23T18:43:20-04:00 EPA: Fix exact printing namespace-specified wildcards Ensures correct printing of imports of the form import Data.Bool (data True(data ..)) import Data.Bool (data True(type ..)) Closes #27291 - - - - - 56ada7c0 by Mrjtjmn at 2026-05-23T18:44:19-04:00 Fix ambiguous syntax of BangPatterns in users guide Update documentation for the BangPatterns extension to specify how surrounding whitespace affects interpretation of `!`. * Only when there is whitespace before `!` and no whitespace after, it is recognized as a BangPattern. * Other cases `⟨varid⟩!⟨varid⟩`, `⟨varid⟩ ! ⟨varid⟩`, `⟨varid⟩! ⟨varid⟩` are treated as infix operators. - - - - - 2b9445a6 by Simon Peyton Jones at 2026-05-25T11:43:21+01:00 Drastically reduce the use of the coercion optimiser This MR addresess #26679 by calling the coercion optimiser much less often; the coercion optimiser is expensive, and often ineffective, especially when it is called repeatedly. See Note [Coercion optimisation] in GHC.Core.Corecion.Opt. Specifically * Make coercion optimisation into its own pass, controlled by its own flag `-fopt-coercion` like any other pass. The pass runs early in the pipeline. * The Simplifier now contents itself with merely applying the current substitution to a coercion, and checking for reflexivity. * Kill off OptCoercionOpts, which is now unused. Another important, but only loosely related, improvement * In `GHC.Core.Subst.substIdBndr`, `GHC.Core.TyCo.Subst.substTyVarBndrUsing`, and `GHC.Core.TyCo.Subst.substTyVarBndrUsing`, check for an empty substitution. This keeps substitutions empty in the no-op case. See Note [Keeping the substitution empty] in GHC.Core.TyCo.Subst Compile time improves. Here are the compile-time allocation change over 1%: Baseline Test value Change ------------------------------------------------------------ CoOpt_Singletons(normal) 721,677,974 -7.9% GOOD LargeRecord(normal) 1,268,094,410 -20.4% GOOD T12545(normal) 772,150,124 -9.2% T12707(normal) 777,720,918 -1.5% GOOD T14766(normal) 918,228,179 -50.2% GOOD T15703(normal) 318,141,541 +1.0% BAD T18223(normal) 371,496,473 -7.6% GOOD T1969(normal) 670,830,326 +2.2% BAD T20261(normal) 573,444,953 -2.2% T24984(normal) 87,836,660 -1.5% T3064(normal) 171,636,592 -6.2% GOOD T5030(normal) 148,301,062 -16.4% GOOD T5321Fun(normal) 263,120,022 -3.3% GOOD T8095(normal) 777,033,006 -71.3% GOOD T9020(optasm) 222,159,574 -2.5% GOOD T9630(normal) 873,422,584 -15.4% GOOD T9872b(normal) 1,906,890,318 -2.9% GOOD T9872b_defer(normal) 2,878,170,737 -2.1% GOOD T9872d(normal) 356,978,798 -7.7% GOOD TcPlugin_RewritePerf(normal) 2,132,138,060 -2.6% GOOD geo. mean -2.7% minimum -71.3% maximum +2.2% Metric Decrease: CoOpt_Singletons LargeRecord T12707 T14766 T18223 T3064 T5030 T5321Fun T8095 T9020 T9630 T9872b T9872b_defer T9872d TcPlugin_RewritePerf Metric Increase: T15703 T1969 Serious attempt to avoid duplicating large coercions Progress on not-inlining coercions Add a type signature More on exported coercions More on coercion bindings Allow in letrec; indeed make the invariants for letrec the same as the invariants for top-level bindings. ToDo: document this Fix expression-equality for (Coercion co) We were just saying "True" which is utterly wrong. See Note [Equality for coercions] in GHC.Core.Map.Type Wibbles on coercion bindings Try a very cheap coercion optimiser Comments -- almost all just about core invariants Fuse optCoRefl and substCo Maybe this will be better than either Update Notes about core binding invariants T26332 really should fail with -dlinear-core-lint Try switching off the big optCoercion except in O2 Comments only Try dropping all optimisation The Simplifier just calls substCo, instead of optCoRefl Flags for tracing coercion sizes More optCoRefl * Deal with submultiplicities * In InitialPhase run even with empty subst Update user manual Care with the simple refl optimiser Improve the gobbler Fix warning Add changelog - - - - - 40b85323 by Simon Peyton Jones at 2026-05-25T11:43:21+01:00 More wibbles In particular, don't run any optimisation in the simple optimiser. - - - - - 84 changed files: - + changelog.d/elem-via-foldr-27096 - + changelog.d/ghc-pkg-faster-closure - + changelog.d/opt-coercion - compiler/GHC/Builtin/PrimOps.hs - compiler/GHC/CmmToLlvm/Base.hs - compiler/GHC/Core.hs - compiler/GHC/Core/Coercion.hs - compiler/GHC/Core/Coercion/Opt.hs - compiler/GHC/Core/FVs.hs - compiler/GHC/Core/LateCC/TopLevelBinds.hs - compiler/GHC/Core/Lint.hs - compiler/GHC/Core/Make.hs - compiler/GHC/Core/Map/Expr.hs - compiler/GHC/Core/Map/Type.hs - compiler/GHC/Core/Opt/CSE.hs - compiler/GHC/Core/Opt/ConstantFold.hs - compiler/GHC/Core/Opt/FloatIn.hs - compiler/GHC/Core/Opt/Monad.hs - compiler/GHC/Core/Opt/Pipeline.hs - compiler/GHC/Core/Opt/Pipeline/Types.hs - compiler/GHC/Core/Opt/SetLevels.hs - compiler/GHC/Core/Opt/Simplify/Env.hs - compiler/GHC/Core/Opt/Simplify/Iteration.hs - compiler/GHC/Core/Opt/Simplify/Utils.hs - compiler/GHC/Core/Opt/Specialise.hs - compiler/GHC/Core/Ppr.hs - compiler/GHC/Core/Rules.hs - compiler/GHC/Core/SimpleOpt.hs - compiler/GHC/Core/TyCo/FVs.hs - compiler/GHC/Core/TyCo/Rep.hs - compiler/GHC/Core/TyCo/Subst.hs - compiler/GHC/Core/Utils.hs - compiler/GHC/CoreToIface.hs - compiler/GHC/CoreToStg.hs - compiler/GHC/CoreToStg/Prep.hs - compiler/GHC/Data/TrieMap.hs - compiler/GHC/Driver/Config.hs - compiler/GHC/Driver/Config/Core/Lint.hs - compiler/GHC/Driver/Config/Core/Opt/Simplify.hs - compiler/GHC/Driver/DynFlags.hs - compiler/GHC/Driver/Flags.hs - compiler/GHC/Driver/Session.hs - compiler/GHC/HsToCore/Foreign/JavaScript.hs - compiler/GHC/Iface/Binary.hs - compiler/GHC/Iface/Make.hs - compiler/GHC/Iface/Rename.hs - compiler/GHC/Iface/Syntax.hs - compiler/GHC/Iface/Tidy.hs - compiler/GHC/Iface/Type.hs - compiler/GHC/IfaceToCore.hs - compiler/GHC/Parser/Lexer.x - compiler/GHC/Stg/Lint.hs - compiler/GHC/Stg/Pipeline.hs - compiler/GHC/StgToJS/Ids.hs - compiler/GHC/Tc/Types.hs - compiler/GHC/Tc/Utils/Monad.hs - compiler/GHC/Types/Id.hs - compiler/GHC/Types/Literal.hs - compiler/GHC/Types/Name/Cache.hs - compiler/GHC/Types/Unique.hs - compiler/GHC/Types/Unique/Supply.hs - compiler/GHC/Types/Var/Env.hs - compiler/GHC/Utils/Misc.hs - compiler/GHC/Utils/Outputable.hs - compiler/GHC/Utils/Trace.hs - docs/users_guide/debugging.rst - docs/users_guide/exts/stolen_syntax.rst - docs/users_guide/using-optimisation.rst - libraries/base/changelog.md - libraries/base/tests/perf/ElemNoFusion_O1.stderr - libraries/base/tests/perf/ElemNoFusion_O2.stderr - libraries/ghc-internal/src/GHC/Internal/List.hs - testsuite/tests/count-deps/CountDepsAst.stdout - testsuite/tests/count-deps/CountDepsParser.stdout - + testsuite/tests/ghc-api/T27273.hs - testsuite/tests/ghc-api/all.T - testsuite/tests/linear/should_compile/T26332.hs - testsuite/tests/linear/should_compile/all.T - testsuite/tests/printer/Makefile - + testsuite/tests/printer/PprQualifiedStrings.hs - + testsuite/tests/printer/Test27291.hs - testsuite/tests/printer/all.T - utils/check-exact/ExactPrint.hs - utils/ghc-pkg/Main.hs The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/843b9a2a0d9b8f99528a6f45053b7a… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/843b9a2a0d9b8f99528a6f45053b7a… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/semaphore-v2] 8 commits: Use "grimily" instead of "grimly"
by Zubin (＠wz1000) 25 May '26

25 May '26

Zubin pushed to branch wip/semaphore-v2 at Glasgow Haskell Compiler / GHC Commits: 6f9d7c71 by Markus Läll at 2026-05-21T15:25:34-04:00 Use "grimily" instead of "grimly" Fixes https://gitlab.haskell.org/ghc/ghc/-/issues/27221 - - - - - 50e999ca by fendor at 2026-05-21T15:26:18-04:00 Speed up 'closure' computation in `ghc-pkg` Cache the set of already seen `UnitId`s and use `Set` operations to speed up 'closure' computation. Further simplify the implementation of 'closure' to account for the actual usage. As a consequence, we rename 'closure' to 'brokenPackages' to reflect its purpose better after the simplification. - - - - - 7ecc6184 by sheaf at 2026-05-21T15:27:10-04:00 TcMPluginHandling: be more lenient when no plugins This change ensures that, if a function such as 'typecheckModule' was invoked with 'NoTcMPlugins', GHC doesn't spuriously complain about TcM plugins having already been stopped, as there were none to start with. - - - - - 72c8de5c by Simon Jakobi at 2026-05-23T18:41:42-04:00 Implement List.elem via foldr ...in order to allow specialization to Eq instances. The implementation of notElem is updated for consistency.` Corresponding CLC proposal: https://github.com/haskell/core-libraries-committee/issues/412 Addresses #27096. - - - - - 3268c610 by Alan Zimmerman at 2026-05-23T18:42:30-04:00 EPA: Fix span for qualified multiline string Fix the span for a qualified multiline string like Text.""" I'm a multiline Text value ! """ to extend to the end of the entire string, not just the first line. Closes #27274 - - - - - 1f096790 by Alan Zimmerman at 2026-05-23T18:43:20-04:00 EPA: Fix exact printing namespace-specified wildcards Ensures correct printing of imports of the form import Data.Bool (data True(data ..)) import Data.Bool (data True(type ..)) Closes #27291 - - - - - 56ada7c0 by Mrjtjmn at 2026-05-23T18:44:19-04:00 Fix ambiguous syntax of BangPatterns in users guide Update documentation for the BangPatterns extension to specify how surrounding whitespace affects interpretation of `!`. * Only when there is whitespace before `!` and no whitespace after, it is recognized as a BangPattern. * Other cases `⟨varid⟩!⟨varid⟩`, `⟨varid⟩ ! ⟨varid⟩`, `⟨varid⟩! ⟨varid⟩` are treated as infix operators. - - - - - e8340970 by Zubin Duggal at 2026-05-25T16:07:39+05:30 Update to semaphore-compat 2.0.0 using v2 of the protocol On Linux and other POSIX platforms, GHC's -jsem jobserver client now speaks v2 of the semaphore-compat protocol, which uses Unix domain sockets in place of POSIX named semaphores. This avoids the libc-ABI issues that affected the old implementation. Windows is unaffected and continues to use the v1 protocol (Win32 named semaphores); its reported protocol version remains v1. When GHC receives a -jsem name whose protocol version it does not support, it emits a -Wsemaphore-version-mismatch warning and falls back to -j<N> rather than crashing. ghc --info exposes the supported version in a new "Semaphore version" entry so cabal-install can detect a mismatch before invoking GHC. Users on a cabal-install that predates the v2 update will continue to build successfully on Linux/POSIX, but will lose the cross-process -jsem coordination and fall back to -j<N> per GHC invocation. Users must upgrade to a cabal-install that supports protocol v2 to recover full parallelism. Also fix a leak in cleanupSem (#27253): cleanupSem used to snapshot heldTokens and release them before killing the loop, while the loop's in-flight acquire/release children could still be mutating it. Cleanup now runs inside the loop's own exit handler, after draining the active child via a new activeChild TVar, so the snapshot has no concurrent mutator. See also: - GHC proposal amendment: https://github.com/ghc-proposals/ghc-proposals/pull/673 - cabal-install patch: https://github.com/haskell/cabal/pull/11628 - semaphore-compat MR: https://gitlab.haskell.org/ghc/semaphore-compat/-/merge_requests/8 Bump semaphore-compat submodule to 2.0.0 Fixes #25087 and #27253 - - - - - 43 changed files: - + changelog.d/elem-via-foldr-27096 - + changelog.d/ghc-pkg-faster-closure - + changelog.d/jobserver-leak-fix - + changelog.d/semaphore-v2 - compiler/GHC/CmmToLlvm/Base.hs - compiler/GHC/Core/Opt/Monad.hs - compiler/GHC/Driver/Errors/Ppr.hs - compiler/GHC/Driver/Errors/Types.hs - compiler/GHC/Driver/Flags.hs - compiler/GHC/Driver/MakeAction.hs - compiler/GHC/Driver/MakeSem.hs - compiler/GHC/Driver/Session.hs - compiler/GHC/HsToCore/Foreign/JavaScript.hs - compiler/GHC/Iface/Binary.hs - compiler/GHC/Parser/Lexer.x - compiler/GHC/Stg/Pipeline.hs - compiler/GHC/StgToJS/Ids.hs - compiler/GHC/Tc/Types.hs - compiler/GHC/Tc/Utils/Monad.hs - compiler/GHC/Types/Error/Codes.hs - compiler/GHC/Types/Hint.hs - compiler/GHC/Types/Hint/Ppr.hs - compiler/GHC/Types/Name/Cache.hs - compiler/GHC/Types/Unique.hs - compiler/GHC/Types/Unique/Supply.hs - docs/users_guide/exts/stolen_syntax.rst - docs/users_guide/using-warnings.rst - docs/users_guide/using.rst - hadrian/src/Flavour.hs - libraries/base/changelog.md - libraries/base/tests/perf/ElemNoFusion_O1.stderr - libraries/base/tests/perf/ElemNoFusion_O2.stderr - libraries/ghc-internal/src/GHC/Internal/List.hs - libraries/semaphore-compat - testsuite/tests/diagnostic-codes/codes.stdout - + testsuite/tests/ghc-api/T27273.hs - testsuite/tests/ghc-api/all.T - testsuite/tests/printer/Makefile - + testsuite/tests/printer/PprQualifiedStrings.hs - + testsuite/tests/printer/Test27291.hs - testsuite/tests/printer/all.T - utils/check-exact/ExactPrint.hs - utils/ghc-pkg/Main.hs The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/d21ad32bdd809a1c7dd1d2a1becc2e… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/d21ad32bdd809a1c7dd1d2a1becc2e… You're receiving this email because of your account on gitlab.haskell.org.

1 0