July 2026 - ghc-commits

[Git][ghc/ghc][master] 3 commits: ci: add missing docker permission workaround in abi-test job
by Marge Bot (＠marge-bot) 17 Jul '26

17 Jul '26

Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC Commits: 0f64f348 by Cheng Shao at 2026-07-16T15:41:08+00:00 ci: add missing docker permission workaround in abi-test job - - - - - 660cb239 by Cheng Shao at 2026-07-16T19:37:48+00:00 bindist: Fix make install -j race condition on macos/freebsd This patch fixes make install -j race condition on macos/freebsd. BSD install fails with EEXIST when multiple install processes concurrently create the same prefix directory. So we add an `install_dirs` prerequisite job that sequentially creates the directories for subsequent jobs to work with. Fixes #27499. Co-authored-by: Codex <codex(a)openai.com> - - - - - 08130257 by Cheng Shao at 2026-07-16T19:37:48+00:00 ci: run bindist make install with -j This patch makes the ci scripts run `make install` with `-j` to reduce wall clock time when installing the bindist, see related issue for benchmark numbers. This only affects ghc ci logic, the user-facing default is up to distributors and is still `-j1`. Closes #27029. - - - - - 4 changed files: - .gitlab-ci.yml - .gitlab/ci.sh - + changelog.d/fix-make-install-j - hadrian/bindist/Makefile Changes: ===================================== .gitlab-ci.yml ===================================== @@ -499,7 +499,7 @@ hadrian-multi: || tar -xf ghc-x86_64-linux-deb13-release.tar.xz -C tmp pushd tmp/ghc-*/ ./configure --prefix=$root - make install + make install -j$CPUS popd rm -Rf tmp - export HC=$root/bin/ghc @@ -1005,7 +1005,7 @@ perf-nofib: tar -xf ../ghc-x86_64-linux-fedora43-release.tar.xz -C tmp pushd tmp/ghc-*/ ./configure --prefix=$root - make install + make install -j$CPUS popd rm -Rf tmp - export PATH=$root/bin:$PATH @@ -1047,7 +1047,7 @@ perf: || tar -xf ghc-x86_64-linux-deb13-release.tar.xz -C tmp pushd tmp/ghc-*/ ./configure --prefix=$root - make install + make install -j$CPUS popd rm -Rf tmp - export BOOT_HC=$(which ghc) @@ -1079,6 +1079,7 @@ abi-test: tags: - x86_64-linux script: + - sudo chown ghc:ghc -R . - root=$(pwd)/ghc - | mkdir tmp @@ -1086,7 +1087,7 @@ abi-test: || tar -xf ghc-x86_64-linux-deb13-release.tar.xz -C tmp pushd tmp/ghc-*/ ./configure --prefix=$root - make install + make install -j$CPUS popd rm -Rf tmp - export BOOT_HC=$(which ghc) ===================================== .gitlab/ci.sh ===================================== @@ -605,7 +605,7 @@ function make_install_destdir() { mkdir -p "$destdir" mkdir -p "$instdir" - run "$MAKE" DESTDIR="$destdir" install || fail "make install failed" + run "$MAKE" DESTDIR="$destdir" install -j"$cores" || fail "make install failed" # check for empty dir portably # https://superuser.com/a/667100 if find "$instdir" -mindepth 1 -maxdepth 1 | read; then @@ -899,8 +899,8 @@ function save_cache () { if [[ "${CI_JOB_NAME}" == *"darwin"* ]]; then # -a makes APFS behave like a COW file system # From man CP(1) - # copy files using clonefile(2). - # Note that if clonefile(2) is not supported for the target filesystem, + # copy files using clonefile(2). + # Note that if clonefile(2) is not supported for the target filesystem, # then cp will fallback to using copyfile(2) instead to ensure the copy still succeeds. cp -Rcf "$CABAL_DIR" "$CABAL_CACHE" else ===================================== changelog.d/fix-make-install-j ===================================== @@ -0,0 +1,4 @@ +section: packaging +synopsis: Fix race condition in bindist make install -j on macos/freebsd +issues: #27499 +mrs: !15707 ===================================== hadrian/bindist/Makefile ===================================== @@ -97,12 +97,26 @@ lib/targets/default.target : config.mk default.target @echo "Copying the bindist-configured default.target to lib/targets/default.target" cp default.target $@ +# sequentially create one layer of subdirectories under DESTDIR, then +# subsequent install_* jobs can happen concurrently without bsd +# install race condition. required for make install -j to work on +# macos/freebsd, see #27499. +.PHONY: install_dirs +install_dirs: + $(INSTALL_DIR) "$(DESTDIR)$(prefix)" + $(INSTALL_DIR) "$(DESTDIR)$(ActualBinsDir)" + $(INSTALL_DIR) "$(DESTDIR)$(WrapperBinsDir)" + $(INSTALL_DIR) "$(DESTDIR)$(ActualLibsDir)" + $(INSTALL_DIR) "$(DESTDIR)$(mandir)" + $(INSTALL_DIR) "$(DESTDIR)$(docdir)" + $(INSTALL_DIR) "$(DESTDIR)$(datadir)" + # We need to install binaries relative to libraries. BINARIES = $(wildcard ./bin/*) .PHONY: install_bin_libdir -install_bin_libdir: +install_bin_libdir: install_dirs @echo "Copying binaries to $(DESTDIR)$(ActualBinsDir)" - $(INSTALL_DIR) "$(DESTDIR)$(ActualBinsDir)" + for i in $(BINARIES); do \ if test -L "$$i"; then \ cp -RP "$$i" "$(DESTDIR)$(ActualBinsDir)"; \ @@ -112,15 +126,14 @@ install_bin_libdir: done .PHONY: install_bin_direct -install_bin_direct: +install_bin_direct: install_dirs @echo "Copying binaries to $(DESTDIR)$(WrapperBinsDir)" - $(INSTALL_DIR) "$(DESTDIR)$(WrapperBinsDir)" + $(INSTALL_PROGRAM) ./bin/* "$(DESTDIR)$(WrapperBinsDir)/" .PHONY: install_lib -install_lib: lib/settings lib/targets/default.target +install_lib: install_dirs lib/settings lib/targets/default.target @echo "Copying libraries to $(DESTDIR)$(ActualLibsDir)" - $(INSTALL_DIR) "$(DESTDIR)$(ActualLibsDir)" @dest="$(DESTDIR)$(ActualLibsDir)"; \ cd ./lib; \ @@ -146,9 +159,8 @@ install_lib: lib/settings lib/targets/default.target done; \ .PHONY: install_docs -install_docs: +install_docs: install_dirs @echo "Copying docs to $(DESTDIR)$(docdir)" - $(INSTALL_DIR) "$(DESTDIR)$(docdir)" if [ -d doc ]; then \ cd ./doc; $(FIND) . -type f -exec sh -c \ @@ -163,9 +175,9 @@ install_docs: fi .PHONY: install_data -install_data: +install_data: install_dirs @echo "Copying data to $(DESTDIR)share" - $(INSTALL_DIR) "$(DESTDIR)$(datadir)" + if [ -d share ]; then \ cd ./share; $(FIND) . -type f -exec sh -c \ '$(INSTALL_DIR) "$(DESTDIR)$(datadir)/`dirname $$1`" && \ @@ -177,18 +189,17 @@ MAN_SECTION := 1 MAN_PAGES := manpage/ghc.1 .PHONY: install_man -install_man: +install_man: install_dirs if [ -f $(MAN_PAGES) ]; then \ - $(INSTALL_DIR) "$(DESTDIR)$(mandir)"; \ $(INSTALL_DIR) "$(DESTDIR)$(mandir)/man$(MAN_SECTION)"; \ $(INSTALL_MAN) $(INSTALL_OPTS) $(MAN_PAGES) "$(DESTDIR)$(mandir)/man$(MAN_SECTION)"; \ fi export SHELL .PHONY: install_wrappers -install_wrappers: install_bin_libdir install_hsc2hs_wrapper +install_wrappers: install_dirs install_bin_libdir install_hsc2hs_wrapper @echo "Installing wrapper scripts" - $(INSTALL_DIR) "$(DESTDIR)$(WrapperBinsDir)" + for p in `cd ./wrappers; $(FIND) . ! -type d`; do \ mk/install_script.sh "$$p" "$(DESTDIR)/$(WrapperBinsDir)/$$p" "$(WrapperBinsDir)" "$(ActualBinsDir)" "$(ActualBinsDir)/$$p" "$(ActualLibsDir)" "$(docdir)" "$(includedir)"; \ done View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/ede4b17bdc54c055e44ad95711409c… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/ede4b17bdc54c055e44ad95711409c… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 5 commits: ci: add missing docker permission workaround in abi-test job
by Marge Bot (＠marge-bot) 17 Jul '26

17 Jul '26

Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC Commits: 0f64f348 by Cheng Shao at 2026-07-16T15:41:08+00:00 ci: add missing docker permission workaround in abi-test job - - - - - 660cb239 by Cheng Shao at 2026-07-16T19:37:48+00:00 bindist: Fix make install -j race condition on macos/freebsd This patch fixes make install -j race condition on macos/freebsd. BSD install fails with EEXIST when multiple install processes concurrently create the same prefix directory. So we add an `install_dirs` prerequisite job that sequentially creates the directories for subsequent jobs to work with. Fixes #27499. Co-authored-by: Codex <codex(a)openai.com> - - - - - 08130257 by Cheng Shao at 2026-07-16T19:37:48+00:00 ci: run bindist make install with -j This patch makes the ci scripts run `make install` with `-j` to reduce wall clock time when installing the bindist, see related issue for benchmark numbers. This only affects ghc ci logic, the user-facing default is up to distributors and is still `-j1`. Closes #27029. - - - - - 48fc6808 by Adam Gundry at 2026-07-16T23:16:32-04:00 Mark various language extension flags as deprecated (see #27329) The following language extensions are now deprecated: - AlternativeLayoutRule - AlternativeLayoutRuleTransitional - ParallelArrays - PolymorphicComponents - Rank2Types In addition, the warning `-Walternative-layout-rule-transitional` has been marked as deprecated, as it is emitted only under the deprecated extension `XAlternativeLayoutRuleTransitional`. - - - - - 8d957412 by Andrew Lelechenko at 2026-07-16T23:16:34-04:00 base: re-export GHC.Environment.getFullArgs from System.Environment CLC proposal https://github.com/haskell/core-libraries-committee/issues/431 - - - - - 58 changed files: - .gitlab-ci.yml - .gitlab/ci.sh - + changelog.d/T27329 - + changelog.d/fix-make-install-j - compiler/GHC/Driver/Flags.hs - compiler/GHC/Driver/Session.hs - compiler/GHC/Tc/Types/Rank.hs - docs/users_guide/expected-undocumented-flags.txt - docs/users_guide/exts/rank_polymorphism.rst - docs/users_guide/exts/static_pointers.rst - hadrian/bindist/Makefile - libraries/base/changelog.md - libraries/base/src/System/Environment.hs - libraries/ghc-internal/ghc-internal.cabal.in - testsuite/tests/backpack/should_compile/T13149.bkp - testsuite/tests/determinism/determ017/A.hs - testsuite/tests/ghci/scripts/T12005.script - testsuite/tests/haddock/perf/Fold.hs - testsuite/tests/indexed-types/should_fail/T7354.hs - testsuite/tests/interface-stability/base-exports.stdout - testsuite/tests/interface-stability/base-exports.stdout-javascript-unknown-ghcjs - testsuite/tests/interface-stability/base-exports.stdout-mingw32 - testsuite/tests/layout/layout001.stdout - testsuite/tests/layout/layout002.stdout - testsuite/tests/layout/layout003.stdout - testsuite/tests/layout/layout004.stdout - testsuite/tests/layout/layout005.stdout - testsuite/tests/layout/layout006.stdout - testsuite/tests/layout/layout007.stdout - testsuite/tests/layout/layout008.stdout - testsuite/tests/layout/layout009.stdout - testsuite/tests/linear/should_compile/T1735Min.hs - + testsuite/tests/parser/should_compile/T13087.stderr - testsuite/tests/parser/should_fail/T8431.stderr - testsuite/tests/parser/should_fail/readFail038.stderr - testsuite/tests/perf/compiler/T3064.hs - testsuite/tests/polykinds/T7594.hs - testsuite/tests/programs/thurston-modular-arith/Main.hs - testsuite/tests/rts/ipe/IpeStats/Fold.hs - testsuite/tests/simplCore/should_compile/T11562.hs - testsuite/tests/simplCore/should_run/T3591.hs - testsuite/tests/typecheck/should_compile/DeepSubsumption02.hs - testsuite/tests/typecheck/should_compile/T12507.hs - testsuite/tests/typecheck/should_compile/T13951.hs - testsuite/tests/typecheck/should_compile/T18920.hs - testsuite/tests/typecheck/should_compile/T2595.hs - testsuite/tests/typecheck/should_compile/T7541.hs - testsuite/tests/typecheck/should_fail/T6069.stderr - testsuite/tests/typecheck/should_fail/T7368a.hs - testsuite/tests/typecheck/should_run/T1735_Help/Basics.hs - testsuite/tests/typecheck/should_run/T3731-short.hs - testsuite/tests/typecheck/should_run/T3731.hs - testsuite/tests/typecheck/should_run/church.hs - testsuite/tests/typecheck/should_run/tcrun008.hs - testsuite/tests/typecheck/should_run/tcrun017.hs - testsuite/tests/typecheck/should_run/tcrun026.hs - testsuite/tests/typecheck/should_run/tcrun035.hs - testsuite/tests/typecheck/should_run/tcrun036.hs The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/23ca030dd4516c042ec51cf4b9c44f… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/23ca030dd4516c042ec51cf4b9c44f… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/sjakobi/T27507] testsuite: Add simpler T27507 reproducer
by Simon Jakobi (＠sjakobi2) 16 Jul '26

16 Jul '26

Simon Jakobi pushed to branch wip/sjakobi/T27507 at Glasgow Haskell Compiler / GHC Commits: a358c3f8 by Simon Jakobi at 2026-07-16T13:59:51+02:00 testsuite: Add simpler T27507 reproducer - - - - - 3 changed files: - + testsuite/tests/simplStg/should_run/T27507a.hs - + testsuite/tests/simplStg/should_run/T27507a.stdout - testsuite/tests/simplStg/should_run/all.T Changes: ===================================== testsuite/tests/simplStg/should_run/T27507a.hs ===================================== @@ -0,0 +1,28 @@ +{-# LANGUAGE BangPatterns #-} +-- Ensure the Box is returned boxed rather than unwrapped by CPR. +-- Ensure fun_exit is not floated to top, but works either way. +{-# OPTIONS_GHC -fno-cpr-anal -fno-full-laziness #-} + +module Main where + +import GHC.Exts (noinline) +import GHC.Exts.Heap (getClosureData, info, tipe) + +data Box a = Box !a + +foo :: Bool -> Int -> (Int, Box Int) +foo b !x = case x of + x' -> let -- Keep fun_exit monomorphic so that it can become a join point. + -- Without this signature its polymorphic result type prevents contification. + fun_exit :: Int -> Int -> (Int, Box Int) + fun_exit x_f i = (i, Box x_f) + {-# NOINLINE fun_exit #-} + in if b then fun_exit x' 0 else fun_exit x' 1 +{-# NOINLINE foo #-} + +main :: IO () +main = + case foo True 42 of + (_, bx) -> do + c <- noinline getClosureData bx + noinline print (tipe (info c)) ===================================== testsuite/tests/simplStg/should_run/T27507a.stdout ===================================== @@ -0,0 +1 @@ +CONSTR_1_0 ===================================== testsuite/tests/simplStg/should_run/all.T ===================================== @@ -24,3 +24,4 @@ test('T23783', normal, multimod_compile_and_run, ['T23783', '-O -v0']) test('unpack_enum', normal, compile_and_run, ['']) test('T27005a', normal, compile_and_run, ['']) test('T27507', normal, compile_and_run, ['']) +test('T27507a', normal, compile_and_run, ['']) View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/a358c3f8c8458b18eb31bd161499f01… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/a358c3f8c8458b18eb31bd161499f01… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 2 commits: Mark various language extension flags as deprecated (see #27329)
by Marge Bot (＠marge-bot) 16 Jul '26

16 Jul '26

Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC Commits: 18720342 by Adam Gundry at 2026-07-16T16:35:09-04:00 Mark various language extension flags as deprecated (see #27329) The following language extensions are now deprecated: - AlternativeLayoutRule - AlternativeLayoutRuleTransitional - ParallelArrays - PolymorphicComponents - Rank2Types In addition, the warning `-Walternative-layout-rule-transitional` has been marked as deprecated, as it is emitted only under the deprecated extension `XAlternativeLayoutRuleTransitional`. - - - - - 23ca030d by Andrew Lelechenko at 2026-07-16T16:35:10-04:00 base: re-export GHC.Environment.getFullArgs from System.Environment CLC proposal https://github.com/haskell/core-libraries-committee/issues/431 - - - - - 54 changed files: - + changelog.d/T27329 - compiler/GHC/Driver/Flags.hs - compiler/GHC/Driver/Session.hs - compiler/GHC/Tc/Types/Rank.hs - docs/users_guide/expected-undocumented-flags.txt - docs/users_guide/exts/rank_polymorphism.rst - docs/users_guide/exts/static_pointers.rst - libraries/base/changelog.md - libraries/base/src/System/Environment.hs - libraries/ghc-internal/ghc-internal.cabal.in - testsuite/tests/backpack/should_compile/T13149.bkp - testsuite/tests/determinism/determ017/A.hs - testsuite/tests/ghci/scripts/T12005.script - testsuite/tests/haddock/perf/Fold.hs - testsuite/tests/indexed-types/should_fail/T7354.hs - testsuite/tests/interface-stability/base-exports.stdout - testsuite/tests/interface-stability/base-exports.stdout-javascript-unknown-ghcjs - testsuite/tests/interface-stability/base-exports.stdout-mingw32 - testsuite/tests/layout/layout001.stdout - testsuite/tests/layout/layout002.stdout - testsuite/tests/layout/layout003.stdout - testsuite/tests/layout/layout004.stdout - testsuite/tests/layout/layout005.stdout - testsuite/tests/layout/layout006.stdout - testsuite/tests/layout/layout007.stdout - testsuite/tests/layout/layout008.stdout - testsuite/tests/layout/layout009.stdout - testsuite/tests/linear/should_compile/T1735Min.hs - + testsuite/tests/parser/should_compile/T13087.stderr - testsuite/tests/parser/should_fail/T8431.stderr - testsuite/tests/parser/should_fail/readFail038.stderr - testsuite/tests/perf/compiler/T3064.hs - testsuite/tests/polykinds/T7594.hs - testsuite/tests/programs/thurston-modular-arith/Main.hs - testsuite/tests/rts/ipe/IpeStats/Fold.hs - testsuite/tests/simplCore/should_compile/T11562.hs - testsuite/tests/simplCore/should_run/T3591.hs - testsuite/tests/typecheck/should_compile/DeepSubsumption02.hs - testsuite/tests/typecheck/should_compile/T12507.hs - testsuite/tests/typecheck/should_compile/T13951.hs - testsuite/tests/typecheck/should_compile/T18920.hs - testsuite/tests/typecheck/should_compile/T2595.hs - testsuite/tests/typecheck/should_compile/T7541.hs - testsuite/tests/typecheck/should_fail/T6069.stderr - testsuite/tests/typecheck/should_fail/T7368a.hs - testsuite/tests/typecheck/should_run/T1735_Help/Basics.hs - testsuite/tests/typecheck/should_run/T3731-short.hs - testsuite/tests/typecheck/should_run/T3731.hs - testsuite/tests/typecheck/should_run/church.hs - testsuite/tests/typecheck/should_run/tcrun008.hs - testsuite/tests/typecheck/should_run/tcrun017.hs - testsuite/tests/typecheck/should_run/tcrun026.hs - testsuite/tests/typecheck/should_run/tcrun035.hs - testsuite/tests/typecheck/should_run/tcrun036.hs The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/3e7b9a20dd6816155bbda1a0e431c1… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/3e7b9a20dd6816155bbda1a0e431c1… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/dcoutts/io-manager-tidy] 2 commits: In select I/O manager, ensure wakeup fds are within range
by Duncan Coutts (＠dcoutts) 16 Jul '26

16 Jul '26

Duncan Coutts pushed to branch wip/dcoutts/io-manager-tidy at Glasgow Haskell Compiler / GHC Commits: 0cd74e31 by Duncan Coutts at 2026-07-16T21:21:04+01:00 In select I/O manager, ensure wakeup fds are within range It could plausibly happen that if the RTS is used within another process that already has many open fds, that the new fds returned by newFdWakeup are out of bounds for select. - - - - - 95d7e7e5 by Duncan Coutts at 2026-07-16T21:23:33+01:00 Be more explicit about enum IOReadOrWrite values, and type within cmm Belt and braces. - - - - - 3 changed files: - rts/IOManager.h - rts/PrimOps.cmm - rts/posix/Select.c Changes: ===================================== rts/IOManager.h ===================================== @@ -319,7 +319,7 @@ void scavengeTSOIOManager(StgTSO *tso); /* Several code paths are almost identical between read and write paths. In * such cases we use a shared code path with an enum to say which we're doing. */ -typedef enum { IORead, IOWrite } IOReadOrWrite; +typedef enum { IORead = 0, IOWrite = 1 } IOReadOrWrite; /* Synchronous operations: I/O and delays. As synchronous operations they * necessarily operate on threads. The thread is suspended until the operation ===================================== rts/PrimOps.cmm ===================================== @@ -2269,7 +2269,7 @@ stg_waitReadzh ( W_ fd ) (ok) = ccall syncIOWaitReady(Capability_iomgr(MyCapability()) "ptr", CurrentTSO "ptr", - /* IORead */ 0::I32, fd); + /* IORead */ 0::CInt, fd); if (ok != 0::CBool) (likely: True) { jump stg_block_noregs(); } else { ===================================== rts/posix/Select.c ===================================== @@ -63,6 +63,14 @@ void initCapabilityIOManagerSelect(CapIOManager *iomgr) #if defined(HAVE_PREEMPTION) newFdWakeup(&iomgr->interrupt_fd_r, &iomgr->interrupt_fd_w); + + /* Would never happen in a standalone process, but could plausibly happen + * if the RTS is used within another process that already has many open fds. + */ + if (iomgr->interrupt_fd_r < 0 || iomgr->interrupt_fd_r >= (int)FD_SETSIZE || + iomgr->interrupt_fd_w < 0 || iomgr->interrupt_fd_w >= (int)FD_SETSIZE) { + barf("initCapabilityIOManagerSelect: fds out of select range"); + } #endif } @@ -284,6 +292,7 @@ awaitCompletedTimeoutsOrIOSelect(CapIOManager *iomgr, bool wait) { int fd = iomgr->interrupt_fd_r; maxfd = (fd > maxfd) ? fd : maxfd; + ASSERT(fd >= 0 && fd < (int)FD_SETSIZE); // checked during init FD_SET(fd, &rfd); } #endif View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/c0393a7c97b4d16b14be8368fd420b… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/c0393a7c97b4d16b14be8368fd420b… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/21101] Add changelog entry
by Sasha Bogicevic (＠Bogicevic) 16 Jul '26

16 Jul '26

Sasha Bogicevic pushed to branch wip/21101 at Glasgow Haskell Compiler / GHC Commits: f0232261 by Sasha Bogicevic at 2026-07-16T22:22:17+02:00 Add changelog entry - - - - - 1 changed file: - + changelog.d/21101 Changes: ===================================== changelog.d/21101 ===================================== @@ -0,0 +1,8 @@ +section: compiler +synopsis: Improve error messages and hints for invalid record wildcard patterns +description: + Record wildcard hints are now shown in more contexts and include + constructor arity; matching with ``..`` on a fieldless constructor + now produces a dedicated error message. +mrs: !8673 +issues: #21101 View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/f02322610e7b8b0f469bb283390f33e… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/f02322610e7b8b0f469bb283390f33e… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/az/epa-tidy-locatedxxx-8] EPA: Keep decls together in ClassDecl
by Alan Zimmerman (＠alanz) 16 Jul '26

16 Jul '26

Alan Zimmerman pushed to branch wip/az/epa-tidy-locatedxxx-8 at Glasgow Haskell Compiler / GHC Commits: ebc758f6 by Alan Zimmerman at 2026-07-16T20:46:54+01:00 EPA: Keep decls together in ClassDecl Similar to 1718230f4d3d19d8c49c0e5d496cb0fb6f399528 for HsValBindsLR, this commit updates ClassDecl so that it no longer splits out the assorted `LHsDecl GhcPs` until the renamer. It does this by inserting a type family (separate from the classic TTG one) for this. So data TyClDecl ... | ClassDecl { ... tcdDecls :: XClassDecls pass with type instance XClassDecls GhcPs = [LHsDecl GhcPs] type instance XClassDecls GhcRn = ClassDeclX GhcRn type instance XClassDecls GhcTc = ClassDeclX GhcTc data ClassDeclX pass = ClassDeclX { tcdSigs :: [LSig pass], -- ^ Methods' signatures tcdMeths :: LHsBinds pass, -- ^ Default methods tcdATs :: [LFamilyDecl pass], -- ^ Associated types; tcdATDefs :: [LTyFamDefltDecl pass], -- ^ Associated type defaults tcdDocs :: [LDocDecl pass] -- ^ Haddock docs } - - - - - 33 changed files: - compiler/GHC/Hs/Decls.hs - compiler/GHC/Hs/Instances.hs - compiler/GHC/Hs/Stats.hs - compiler/GHC/Hs/Utils.hs - compiler/GHC/HsToCore/Docs.hs - compiler/GHC/HsToCore/Quote.hs - compiler/GHC/Iface/Ext/Ast.hs - compiler/GHC/Parser/PostProcess.hs - compiler/GHC/Parser/PostProcess/Haddock.hs - compiler/GHC/Rename/Module.hs - compiler/GHC/Tc/TyCl.hs - compiler/GHC/Tc/TyCl/Class.hs - compiler/GHC/ThToHs.hs - compiler/Language/Haskell/Syntax/Binds.hs - compiler/Language/Haskell/Syntax/Decls.hs - compiler/Language/Haskell/Syntax/Extension.hs - testsuite/tests/haddock/haddock_examples/haddock.Test.stderr - testsuite/tests/haddock/should_compile_flag_haddock/T17544.stderr - testsuite/tests/haddock/should_compile_flag_haddock/T17544_kw.stderr - testsuite/tests/parser/should_compile/DumpRenamedAst.stderr - testsuite/tests/parser/should_compile/DumpSemis.stderr - testsuite/tests/parser/should_compile/T20452.stderr - testsuite/tests/printer/Test24533.stdout - utils/check-exact/ExactPrint.hs - utils/check-exact/Utils.hs - utils/haddock/haddock-api/src/Haddock/Backends/Hoogle.hs - utils/haddock/haddock-api/src/Haddock/Backends/LaTeX.hs - utils/haddock/haddock-api/src/Haddock/Backends/Xhtml/Decl.hs - utils/haddock/haddock-api/src/Haddock/Convert.hs - utils/haddock/haddock-api/src/Haddock/GhcUtils.hs - utils/haddock/haddock-api/src/Haddock/Interface/Create.hs - utils/haddock/haddock-api/src/Haddock/Interface/Rename.hs - utils/haddock/haddock-api/src/Haddock/Types.hs The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/ebc758f69f3da634ba9411e5b9ca32b… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/ebc758f69f3da634ba9411e5b9ca32b… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc] Pushed new branch wip/az/epa-tidy-locatedxxx-8
by Alan Zimmerman (＠alanz) 16 Jul '26

16 Jul '26

Alan Zimmerman pushed new branch wip/az/epa-tidy-locatedxxx-8 at Glasgow Haskell Compiler / GHC -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/tree/wip/az/epa-tidy-locatedxxx-8 You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/ci-make-install-j] 2 commits: bindist: Fix make install -j race condition on macos/freebsd
by Cheng Shao (＠TerrorJack) 16 Jul '26

16 Jul '26

Cheng Shao pushed to branch wip/ci-make-install-j at Glasgow Haskell Compiler / GHC Commits: 660cb239 by Cheng Shao at 2026-07-16T19:37:48+00:00 bindist: Fix make install -j race condition on macos/freebsd This patch fixes make install -j race condition on macos/freebsd. BSD install fails with EEXIST when multiple install processes concurrently create the same prefix directory. So we add an `install_dirs` prerequisite job that sequentially creates the directories for subsequent jobs to work with. Fixes #27499. Co-authored-by: Codex <codex(a)openai.com> - - - - - 08130257 by Cheng Shao at 2026-07-16T19:37:48+00:00 ci: run bindist make install with -j This patch makes the ci scripts run `make install` with `-j` to reduce wall clock time when installing the bindist, see related issue for benchmark numbers. This only affects ghc ci logic, the user-facing default is up to distributors and is still `-j1`. Closes #27029. - - - - - 4 changed files: - .gitlab-ci.yml - .gitlab/ci.sh - + changelog.d/fix-make-install-j - hadrian/bindist/Makefile Changes: ===================================== .gitlab-ci.yml ===================================== @@ -499,7 +499,7 @@ hadrian-multi: || tar -xf ghc-x86_64-linux-deb13-release.tar.xz -C tmp pushd tmp/ghc-*/ ./configure --prefix=$root - make install + make install -j$CPUS popd rm -Rf tmp - export HC=$root/bin/ghc @@ -1005,7 +1005,7 @@ perf-nofib: tar -xf ../ghc-x86_64-linux-fedora43-release.tar.xz -C tmp pushd tmp/ghc-*/ ./configure --prefix=$root - make install + make install -j$CPUS popd rm -Rf tmp - export PATH=$root/bin:$PATH @@ -1047,7 +1047,7 @@ perf: || tar -xf ghc-x86_64-linux-deb13-release.tar.xz -C tmp pushd tmp/ghc-*/ ./configure --prefix=$root - make install + make install -j$CPUS popd rm -Rf tmp - export BOOT_HC=$(which ghc) @@ -1087,7 +1087,7 @@ abi-test: || tar -xf ghc-x86_64-linux-deb13-release.tar.xz -C tmp pushd tmp/ghc-*/ ./configure --prefix=$root - make install + make install -j$CPUS popd rm -Rf tmp - export BOOT_HC=$(which ghc) ===================================== .gitlab/ci.sh ===================================== @@ -605,7 +605,7 @@ function make_install_destdir() { mkdir -p "$destdir" mkdir -p "$instdir" - run "$MAKE" DESTDIR="$destdir" install || fail "make install failed" + run "$MAKE" DESTDIR="$destdir" install -j"$cores" || fail "make install failed" # check for empty dir portably # https://superuser.com/a/667100 if find "$instdir" -mindepth 1 -maxdepth 1 | read; then @@ -899,8 +899,8 @@ function save_cache () { if [[ "${CI_JOB_NAME}" == *"darwin"* ]]; then # -a makes APFS behave like a COW file system # From man CP(1) - # copy files using clonefile(2). - # Note that if clonefile(2) is not supported for the target filesystem, + # copy files using clonefile(2). + # Note that if clonefile(2) is not supported for the target filesystem, # then cp will fallback to using copyfile(2) instead to ensure the copy still succeeds. cp -Rcf "$CABAL_DIR" "$CABAL_CACHE" else ===================================== changelog.d/fix-make-install-j ===================================== @@ -0,0 +1,4 @@ +section: packaging +synopsis: Fix race condition in bindist make install -j on macos/freebsd +issues: #27499 +mrs: !15707 ===================================== hadrian/bindist/Makefile ===================================== @@ -97,12 +97,26 @@ lib/targets/default.target : config.mk default.target @echo "Copying the bindist-configured default.target to lib/targets/default.target" cp default.target $@ +# sequentially create one layer of subdirectories under DESTDIR, then +# subsequent install_* jobs can happen concurrently without bsd +# install race condition. required for make install -j to work on +# macos/freebsd, see #27499. +.PHONY: install_dirs +install_dirs: + $(INSTALL_DIR) "$(DESTDIR)$(prefix)" + $(INSTALL_DIR) "$(DESTDIR)$(ActualBinsDir)" + $(INSTALL_DIR) "$(DESTDIR)$(WrapperBinsDir)" + $(INSTALL_DIR) "$(DESTDIR)$(ActualLibsDir)" + $(INSTALL_DIR) "$(DESTDIR)$(mandir)" + $(INSTALL_DIR) "$(DESTDIR)$(docdir)" + $(INSTALL_DIR) "$(DESTDIR)$(datadir)" + # We need to install binaries relative to libraries. BINARIES = $(wildcard ./bin/*) .PHONY: install_bin_libdir -install_bin_libdir: +install_bin_libdir: install_dirs @echo "Copying binaries to $(DESTDIR)$(ActualBinsDir)" - $(INSTALL_DIR) "$(DESTDIR)$(ActualBinsDir)" + for i in $(BINARIES); do \ if test -L "$$i"; then \ cp -RP "$$i" "$(DESTDIR)$(ActualBinsDir)"; \ @@ -112,15 +126,14 @@ install_bin_libdir: done .PHONY: install_bin_direct -install_bin_direct: +install_bin_direct: install_dirs @echo "Copying binaries to $(DESTDIR)$(WrapperBinsDir)" - $(INSTALL_DIR) "$(DESTDIR)$(WrapperBinsDir)" + $(INSTALL_PROGRAM) ./bin/* "$(DESTDIR)$(WrapperBinsDir)/" .PHONY: install_lib -install_lib: lib/settings lib/targets/default.target +install_lib: install_dirs lib/settings lib/targets/default.target @echo "Copying libraries to $(DESTDIR)$(ActualLibsDir)" - $(INSTALL_DIR) "$(DESTDIR)$(ActualLibsDir)" @dest="$(DESTDIR)$(ActualLibsDir)"; \ cd ./lib; \ @@ -146,9 +159,8 @@ install_lib: lib/settings lib/targets/default.target done; \ .PHONY: install_docs -install_docs: +install_docs: install_dirs @echo "Copying docs to $(DESTDIR)$(docdir)" - $(INSTALL_DIR) "$(DESTDIR)$(docdir)" if [ -d doc ]; then \ cd ./doc; $(FIND) . -type f -exec sh -c \ @@ -163,9 +175,9 @@ install_docs: fi .PHONY: install_data -install_data: +install_data: install_dirs @echo "Copying data to $(DESTDIR)share" - $(INSTALL_DIR) "$(DESTDIR)$(datadir)" + if [ -d share ]; then \ cd ./share; $(FIND) . -type f -exec sh -c \ '$(INSTALL_DIR) "$(DESTDIR)$(datadir)/`dirname $$1`" && \ @@ -177,18 +189,17 @@ MAN_SECTION := 1 MAN_PAGES := manpage/ghc.1 .PHONY: install_man -install_man: +install_man: install_dirs if [ -f $(MAN_PAGES) ]; then \ - $(INSTALL_DIR) "$(DESTDIR)$(mandir)"; \ $(INSTALL_DIR) "$(DESTDIR)$(mandir)/man$(MAN_SECTION)"; \ $(INSTALL_MAN) $(INSTALL_OPTS) $(MAN_PAGES) "$(DESTDIR)$(mandir)/man$(MAN_SECTION)"; \ fi export SHELL .PHONY: install_wrappers -install_wrappers: install_bin_libdir install_hsc2hs_wrapper +install_wrappers: install_dirs install_bin_libdir install_hsc2hs_wrapper @echo "Installing wrapper scripts" - $(INSTALL_DIR) "$(DESTDIR)$(WrapperBinsDir)" + for p in `cd ./wrappers; $(FIND) . ! -type d`; do \ mk/install_script.sh "$$p" "$(DESTDIR)/$(WrapperBinsDir)/$$p" "$(WrapperBinsDir)" "$(ActualBinsDir)" "$(ActualBinsDir)/$$p" "$(ActualLibsDir)" "$(docdir)" "$(includedir)"; \ done View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/06850ecf3325337709d6534ff208e6… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/06850ecf3325337709d6534ff208e6… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/fendor/external-unit-db-cache] 5 commits: Add regression test for #26423
by Hannes Siebenhandl (＠fendor) 16 Jul '26

16 Jul '26

Hannes Siebenhandl pushed to branch wip/fendor/external-unit-db-cache at Glasgow Haskell Compiler / GHC Commits: dfb54918 by fendor at 2026-07-16T17:01:22+02:00 Add regression test for #26423 - - - - - 45107d67 by fendor at 2026-07-16T17:01:22+02:00 WIP: introduce external unit database cache - - - - - 1023f9fd by fendor at 2026-07-16T17:01:22+02:00 Never modify UnitInfo for better sharing - - - - - 82d58e4d by fendor at 2026-07-16T17:01:22+02:00 WIP: Introduce UnitIndex for global data ------------------------- Metric Decrease: MultiComponentModules MultiComponentModulesRecomp MultiComponentModulesRecomp100 mhu-perf ------------------------- - - - - - c1494f02 by fendor at 2026-07-16T18:29:18+02:00 Split State.hs into many more modules - - - - - 38 changed files: - + changelog.d/unit-index - compiler/GHC.hs - compiler/GHC/Driver/Backpack.hs - compiler/GHC/Driver/Env.hs - compiler/GHC/Driver/Main/Hsc.hs - compiler/GHC/Driver/Main/Interactive.hs - compiler/GHC/Driver/Main/Passes.hs - compiler/GHC/Driver/Session/Units.hs - compiler/GHC/Types/Unique.hs - compiler/GHC/Unit/Env.hs - + compiler/GHC/Unit/External/Database.hs - + compiler/GHC/Unit/External/Index.hs - + compiler/GHC/Unit/External/ModuleOrigin.hs - + compiler/GHC/Unit/External/Providers.hs - + compiler/GHC/Unit/External/Query.hs - + compiler/GHC/Unit/External/Substitution.hs - + compiler/GHC/Unit/External/Validate.hs - + compiler/GHC/Unit/External/Visibility.hs - + compiler/GHC/Unit/External/Wired.hs - compiler/GHC/Unit/Home/Graph.hs - compiler/GHC/Unit/Info.hs - compiler/GHC/Unit/State.hs - compiler/GHC/Unit/State.hs-boot - compiler/GHC/Unit/Types.hs - compiler/ghc.cabal.in - ghc/GHCi/UI.hs - hadrian/src/Rules/Generate.hs - libraries/ghc-boot/GHC/Unit/Database.hs - testsuite/tests/count-deps/CountDepsParser.stdout - + testsuite/tests/driver/T26423/Hello.hs - + testsuite/tests/driver/T26423/Makefile - + testsuite/tests/driver/T26423/T26423.hs - + testsuite/tests/driver/T26423/T26423.stderr - + testsuite/tests/driver/T26423/T26423.stdout - + testsuite/tests/driver/T26423/all.T - + testsuite/tests/driver/T26423/test/Test.hs - + testsuite/tests/driver/T26423/test/test.pkg - utils/haddock/haddock-api/src/Haddock.hs The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/353ebdf55ae98b4fad1182067c2303… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/353ebdf55ae98b4fad1182067c2303… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0