- ghc-commits - Haskell.org

[Git][ghc/ghc] Pushed new branch wip/9.14.2-backports-darwin-ci
by Zubin (＠wz1000) 28 Jul '26

28 Jul '26

Zubin pushed new branch wip/9.14.2-backports-darwin-ci at Glasgow Haskell Compiler / GHC -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/tree/wip/9.14.2-backports-darwin-ci You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/wasm-remove-webkit-workaround] Revert "wasm: workaround WebKit bug in dyld"
by Cheng Shao (＠TerrorJack) 28 Jul '26

28 Jul '26

Cheng Shao pushed to branch wip/wasm-remove-webkit-workaround at Glasgow Haskell Compiler / GHC Commits: 34e976ac by Cheng Shao at 2026-07-28T10:28:05+02:00 Revert "wasm: workaround WebKit bug in dyld" This reverts commit c9b8465c2c338176fcab9d197e9d31f4aee11f68. The underlying webkit bug has been fixed in https://commits.webkit.org/314219@main. Closes #27564. - - - - - 1 changed file: - utils/jsffi/dyld.mjs Changes: ===================================== utils/jsffi/dyld.mjs ===================================== @@ -783,25 +783,7 @@ class DyLD { // Wasm memory & table #memory = new WebAssembly.Memory({ initial: 1 }); - #table = new WebAssembly.Table({ element: "anyfunc", initial: 1 }); - // First free slot, might be invalid when it advances to #table.length - #tableFree = 1; - // See Note [The evil wasm table grower] - #tableGrowInstance = new WebAssembly.Instance( - new WebAssembly.Module( - new Uint8Array([ - 0, 97, 115, 109, 1, 0, 0, 0, 1, 6, 1, 96, 1, 127, 1, 127, 2, 35, 1, 3, - 101, 110, 118, 25, 95, 95, 105, 110, 100, 105, 114, 101, 99, 116, 95, - 102, 117, 110, 99, 116, 105, 111, 110, 95, 116, 97, 98, 108, 101, 1, - 112, 0, 0, 3, 2, 1, 0, 7, 31, 1, 27, 95, 95, 103, 104, 99, 95, 119, 97, - 115, 109, 95, 106, 115, 102, 102, 105, 95, 116, 97, 98, 108, 101, 95, - 103, 114, 111, 119, 0, 0, 10, 11, 1, 9, 0, 208, 112, 32, 0, 252, 15, 0, - 11, - ]) - ), - { env: { __indirect_function_table: this.#table } } - ); // __stack_pointer #sp = new WebAssembly.Global( @@ -846,82 +828,6 @@ class DyLD { // Global STG registers #regs = {}; - // Note [The evil wasm table grower] - // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - // We need to grow the wasm table as we load shared libraries in - // wasm dyld. We used to directly call the table.grow() JS API, - // which works as expected in Firefox/Chrome, but unfortunately, - // WebKit's implementation of the table.grow() JS API is broken: - // https://bugs.webkit.org/show_bug.cgi?id=290681, which means that - // the wasm dyld simply does not work in WebKit-based browsers like - // Safari. - // - // Now, one simple workaround would be to avoid growing the table at - // all: just allocate a huge table upfront (current limitation - // agreed by all vendors is 10000000). To avoid unnecessary space - // waste on non-WebKit platforms, we could additionally check - // navigator.userAgent against some regexes and only allocate - // fixed-length table when there's no blink/gecko mention. But this - // is fragile and gross, and it's better to stick to a uniform code - // path for all browsers. - // - // Fortunately, it turns out the table.grow wasm instruction work as - // expected in WebKit! So we can invoke a wasm function that grows - // the table for us. But don't open a champagne yet, where would - // that wasm function come from? It can't be put into RTS, or even - // libc.so, because loading those libraries would require growing - // the table in the first place! Or perhaps, reserve a table upfront - // that's just large enough to load RTS and then we can access that - // function for subsequent table grows? But then we need to - // experiment for a reasonable initial size, and add a magic number - // here, which is also fragile and gross and not future-proof! - // - // So this special wasm function needs to live in a single wasm - // module, which is loaded before we load anything else. The full - // source code for this module is: - // - // (module - // (type (func (param i32) (result i32))) - // (import "env" "__indirect_function_table" (table 0 funcref)) - // (export "__ghc_wasm_jsffi_table_grow" (func 0)) - // (func (type 0) (param i32) (result i32) - // ref.null func - // local.get 0 - // table.grow 0 - // ) - // ) - // - // This module is 103 bytes so that we can inline its blob in dyld, - // and use the usually discouraged synchronous - // WebAssembly.Instance/WebAssembly.Module constructors to load it. - // On non-WebKit platforms, growing tables this way would introduce - // a bit of extra JS/Wasm interop overhead, which can be amplified - // as we used to call table.grow(1, foo) for every GOT.func item. - // Therefore, unless we're about to exceed the hard limit of table - // size, we now grow the table exponentially, and use bump - // allocation to calculate the table index to be returned. - // Exponential growth is only implemented to minimize the JS/Wasm - // interop overhead when calling __ghc_wasm_jsffi_table_grow; - // V8/SpiderMonkey/WebKit already do their own exponential growth of - // the table's backing buffer in their table growth logic. - // - // Invariants: n >= 0; when v is non-null, n === 1 - #tableGrow(n, v) { - const prev_free = this.#tableFree; - if (prev_free + n > this.#table.length) { - const min_delta = prev_free + n - this.#table.length; - const delta = Math.max(min_delta, this.#table.length); - this.#tableGrowInstance.exports.__ghc_wasm_jsffi_table_grow( - this.#table.length + delta <= 10000000 ? delta : min_delta - ); - } - if (v) { - this.#table.set(prev_free, v); - } - this.#tableFree += n; - return prev_free; - } - constructor({ args, rpc }) { this.#rpc = rpc; @@ -1116,7 +1022,7 @@ class DyLD { // __memory_base & __table_base, different for each .so let memory_base; - let table_base = this.#tableGrow(tableSize); + let table_base = this.#table.grow(tableSize); console.assert(tableP2Align === 0); // libc.so is always the first one to be ever loaded and has VIP @@ -1220,7 +1126,7 @@ class DyLD { if (this.exportFuncs[name]) { this.#gotFunc[name] = new WebAssembly.Global( { value: "i32", mutable: true }, - this.#tableGrow(1, this.exportFuncs[name]) + this.#table.grow(1, this.exportFuncs[name]) ); continue; } @@ -1271,7 +1177,7 @@ class DyLD { if (this.#gotFunc[k]) { const got = this.#gotFunc[k]; if (got.value === DyLD.#poison) { - const idx = this.#tableGrow(1, v); + const idx = this.#table.grow(1, v); got.value = idx; } else { this.#table.set(got.value, v); @@ -1325,7 +1231,7 @@ class DyLD { // Not in GOT.func yet, create the entry on demand if (this.exportFuncs[sym]) { console.assert(!this.#gotFunc[sym]); - const addr = this.#tableGrow(1, this.exportFuncs[sym]); + const addr = this.#table.grow(1, this.exportFuncs[sym]); this.#gotFunc[sym] = new WebAssembly.Global( { value: "i32", mutable: true }, addr View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/34e976ac2d43cff61cf6f9daa47d881… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/34e976ac2d43cff61cf6f9daa47d881… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc] Pushed new branch wip/wasm-remove-webkit-workaround
by Cheng Shao (＠TerrorJack) 28 Jul '26

28 Jul '26

Cheng Shao pushed new branch wip/wasm-remove-webkit-workaround at Glasgow Haskell Compiler / GHC -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/tree/wip/wasm-remove-webkit-workaround You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/supersven/hadrian-cross-stage3] Fix: Use library stage for some settings
by Sven Tennie (＠supersven) 28 Jul '26

28 Jul '26

Sven Tennie pushed to branch wip/supersven/hadrian-cross-stage3 at Glasgow Haskell Compiler / GHC Commits: deb65bee by GHC GitLab CI at 2026-07-28T09:49:57+02:00 Fix: Use library stage for some settings - - - - - 1 changed file: - hadrian/src/Rules/Generate.hs Changes: ===================================== hadrian/src/Rules/Generate.hs ===================================== @@ -483,24 +483,24 @@ bindistRules = do ("distrib" -/- "configure.ac" <.> "in") (root -/- stageString stage -/- "distrib" -/- "configure.ac") $ mconcat - [ interpolateSetting "ConfiguredEmsdkVersion" EmsdkVersion - , interpolateVar "LeadingUnderscore" $ yesNo <$> getTarget stage tgtSymbolsHaveLeadingUnderscore - , interpolateSetting "LlvmMaxVersion" LlvmMaxVersion - , interpolateSetting "LlvmMinVersion" LlvmMinVersion - , interpolateVar "LlvmTarget" $ getTarget stage tgtLlvmTarget - , interpolateSetting "ProjectVersion" ProjectVersion - , interpolateVar "EnableDistroToolchain" $ interp (staged (lookupStageBuildConfig "settings-use-distro-mingw")) - , interpolateVar "TablesNextToCode" $ yesNo <$> getTarget stage tgtTablesNextToCode - , interpolateVar "TargetHasLibm" $ yesNo <$> getTarget stage tgtHasLibm - , interpolateVar "TargetPlatform" $ getTarget stage targetPlatformTriple - , interpolateVar "TargetWordBigEndian" $ getTarget stage isBigEndian - , interpolateVar "TargetWordSize" $ getTarget stage wordSize - , interpolateVar "Unregisterised" $ yesNo <$> getTarget stage tgtUnregisterised - , interpolateVar "UseLibdw" $ fmap yesNo $ interp $ staged (fmap (isJust . tgtRTSWithLibdw) . targetStage) - , interpolateVar "UseLibffiForAdjustors" $ yesNo <$> getTarget stage tgtUseLibffiForAdjustors - , interpolateVar "GhcWithSMP" $ yesNo <$> targetSupportsSMP stage - , crossStageInterps - ] + [ interpolateSetting "ConfiguredEmsdkVersion" EmsdkVersion + , interpolateVar "LeadingUnderscore" $ yesNo <$> getLibTarget stage tgtSymbolsHaveLeadingUnderscore + , interpolateSetting "LlvmMaxVersion" LlvmMaxVersion + , interpolateSetting "LlvmMinVersion" LlvmMinVersion + , interpolateVar "LlvmTarget" $ getLibTarget stage tgtLlvmTarget + , interpolateSetting "ProjectVersion" ProjectVersion + , interpolateVar "EnableDistroToolchain" $ interp (staged (lookupStageBuildConfig "settings-use-distro-mingw")) + , interpolateVar "TablesNextToCode" $ yesNo <$> getLibTarget stage tgtTablesNextToCode + , interpolateVar "TargetHasLibm" $ yesNo <$> getLibTarget stage tgtHasLibm + , interpolateVar "TargetPlatform" $ getLibTarget stage targetPlatformTriple + , interpolateVar "TargetWordBigEndian" $ getLibTarget stage isBigEndian + , interpolateVar "TargetWordSize" $ getLibTarget stage wordSize + , interpolateVar "Unregisterised" $ yesNo <$> getLibTarget stage tgtUnregisterised + , interpolateVar "UseLibdw" $ yesNo <$> getLibTarget stage (isJust . tgtRTSWithLibdw) + , interpolateVar "UseLibffiForAdjustors" $ yesNo <$> getLibTarget stage tgtUseLibffiForAdjustors + , interpolateVar "GhcWithSMP" $ yesNo <$> libStageSupportsSMP stage + , crossStageInterps + ] -- We can build two kinds of bindists: Regular Stage2 (including -- cross-compilers) and fully cross-compiled Stage3. To avoid @@ -555,6 +555,13 @@ bindistRules = do where interp = interpretInContext (semiEmptyTarget Stage2) getTarget stage = interp . queryTarget stage + getLibTarget executableStage f = do + isCross <- crossStage executableStage + getTarget (if isCross then succStage executableStage else executableStage) f + -- | 'targetSupportsSMP' lifted to the library stage (see 'getLibTarget'). + libStageSupportsSMP stage = do + isCross <- crossStage stage + targetSupportsSMP (if isCross then succStage stage else stage) -- | Given a 'String' replace characters '.' and '-' by underscores ('_') so that -- the resulting 'String' is a valid C preprocessor identifier. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/deb65bee304001d598308edc30edcf7… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/deb65bee304001d598308edc30edcf7… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/spj-reinstallable-base2] Allow GHC.Essentials to be hidden
by sheaf (＠sheaf) 27 Jul '26

27 Jul '26

sheaf pushed to branch wip/spj-reinstallable-base2 at Glasgow Haskell Compiler / GHC Commits: 3de0d935 by sheaf at 2026-07-28T00:26:10+02:00 Allow GHC.Essentials to be hidden - - - - - 15 changed files: - compiler/GHC/Builtin.hs - compiler/GHC/Driver/Downsweep.hs - compiler/GHC/Driver/MakeFile.hs - compiler/GHC/HsToCore.hs - compiler/GHC/Iface/Errors/Ppr.hs - compiler/GHC/Iface/Load.hs - compiler/GHC/Iface/Make.hs - compiler/GHC/Iface/Recomp.hs - compiler/GHC/Unit/External.hs - compiler/GHC/Unit/Finder.hs - compiler/GHC/Unit/State.hs - libraries/base/base.cabal.in - testsuite/tests/interface-stability/base-exports.stdout - testsuite/tests/interface-stability/base-exports.stdout-javascript-unknown-ghcjs - testsuite/tests/interface-stability/base-exports.stdout-mingw32 The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/3de0d935d98533fcb348ff65424ad39… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/3de0d935d98533fcb348ff65424ad39… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/spj-reinstallable-base2] Allow GHC.Essentials to be hidden
by sheaf (＠sheaf) 27 Jul '26

27 Jul '26

sheaf pushed to branch wip/spj-reinstallable-base2 at Glasgow Haskell Compiler / GHC Commits: 1575eb10 by sheaf at 2026-07-28T00:18:35+02:00 Allow GHC.Essentials to be hidden - - - - - 16 changed files: - compiler/GHC/Builtin.hs - compiler/GHC/Driver/Downsweep.hs - compiler/GHC/Driver/MakeFile.hs - compiler/GHC/HsToCore.hs - compiler/GHC/Iface/Errors/Ppr.hs - compiler/GHC/Iface/Load.hs - compiler/GHC/Iface/Make.hs - compiler/GHC/Iface/Recomp.hs - compiler/GHC/Unit/External.hs - compiler/GHC/Unit/Finder.hs - compiler/GHC/Unit/State.hs - libraries/base/base.cabal.in - testsuite/tests/interface-stability/base-exports.stdout - testsuite/tests/interface-stability/base-exports.stdout-javascript-unknown-ghcjs - testsuite/tests/interface-stability/base-exports.stdout-mingw32 - utils/dump-decls/Main.hs Changes: ===================================== compiler/GHC/Builtin.hs ===================================== @@ -225,8 +225,7 @@ How known-occ entities work This is a big reason for (KnownOccNameInvariant): an export list cannot have two entities with the same OccName. - When GHC wants to find GHC.Essentials, it just looks for it in the same - way as any other import. + See Note [Finding GHC.Essentials] for how GHC finds the GHC.Essentials module. * There are three flags that control the treatment of known entities: -frebindable-known-names @@ -412,10 +411,9 @@ To make `wombat` into a known-key name, do the following. * Just like for known-occ names above, in any module in `base` or `ghc-internal` (which are compiled with -frebindable-known-names), ensure that `wombat` is in scope by saying `import M( wombat )`. --} -{- Note [Known entities and reinstallable base] -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +Note [Known entities and reinstallable base] +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The design of known-entities in GHC, described in Note [Overview of known entities], is carefully crafted to support a single version of GHC to compile different versions of base, even though GHC itself is compiled against a fixed version of @@ -453,6 +451,45 @@ Let's compare two examples: `coerce` and `enumFromTo`. `enumFromTo` (see `GHC.Iface.Load.lookupKnownOccName`). This means GHC never needs to know where precisely `enumFromTo` is defined, allowing it to be defined anywhere (wherever in `base`, or in a module imported by `base`). + +Note [Finding GHC.Essentials] +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +As explained in Note [Overview of known entities], when compiling a module that +does not enable -frebindable-known-names, GHC resolves known entities by looking +them up in GHC.Essentials. Every module that does not enable +-frebindable-known-names therefore acquires an implicit dependency on GHC.Essentials. + +As GHC.Essentials is an implementation detail, we would really rather not insist +that it be an exposed module (e.g. of 'base'). So we must ensure that GHC can +still adequately resolve the implicit dependency even if GHC.Essentials is hidden. + +Hidden-ness only ever obstructs the resolution of a 'ModuleName' into a 'Module'. +Thus, to allow GHC.Essentials to be hidden (not available via user-written +imports) while retaining the ability to resolve known entities, we follow the +following plan: + + (FindEssentials1) + 'GHC.Unit.Finder.findModuleWithIsBoot' has special logic to resolve a + possibly hidden GHC.Essentials module, using 'GHC.Unit.Finder.findEssentialsModule'. + + Every code path that needs to find GHC.Essentials despite it being hidden + goes through here, including: + + - downsweep GHC.Driver.Downsweep.summariseModuleDispatch + - ghc -M GHC.Driver.MakeFile.findDependency + - recompilation checking GHC.Iface.Recomp.checkDependencies + + Source-written imports go via 'GHC.Iface.Load.loadSrcInterface_maybe', + which uses 'GHC.Unit.Finder.findImportedModule', which rejects hidden modules. + + (FindEssentials2) + 'GHC.Unit.Module.Deps.mkDependencies' records the unit that provides + GHC.Essentials, so that the implicit dependency appears in the interface file. + + (FindEssentials3) + 'GHC.Driver.Make.warnUnusedPackages' has a special case to ensure that we + don't flag up the unit that provides GHC.Essentials as unused when it is + only implicitly imported. -} {- ===================================== compiler/GHC/Driver/Downsweep.hs ===================================== @@ -1374,9 +1374,8 @@ summariseModuleDispatch k hsc_env' home_unit is_boot (L _ wanted_mod) mb_pkg exc hsc_env = hscSetActiveHomeUnit home_unit hsc_env' find_it :: IO SummariseResult - find_it = do - found <- findImportedModuleWithIsBoot hsc_env wanted_mod is_boot mb_pkg + found <- findModuleWithIsBoot hsc_env wanted_mod is_boot mb_pkg case found of Found location mod | moduleUnitId mod `Set.member` hsc_all_home_unit_ids hsc_env -> ===================================== compiler/GHC/Driver/MakeFile.hs ===================================== @@ -305,8 +305,8 @@ findDependency :: HscEnv -> IO (Either (MsgEnvelope GhcMessage) (Maybe FilePath)) -- Interface file findDependency hsc_env srcloc pkg imp is_boot include_pkg_deps = do -- Find the module; this will be fast because - -- we've done it once during downsweep - r <- findImportedModuleWithIsBoot hsc_env imp is_boot pkg + -- we've done it once during downsweep. + r <- findModuleWithIsBoot hsc_env imp is_boot pkg case r of Found loc _ -- Home package: just depend on the .hi or hi-boot file ===================================== compiler/GHC/HsToCore.hs ===================================== @@ -106,7 +106,7 @@ import GHC.Unit.Module.Deps import Data.List (partition) import Data.IORef import GHC.Types.Unique.FM -import GHC.Iface.Load (KnownEntitySource(..), lookupKnownKeyName, lookupKnownKeysModule) +import GHC.Iface.Load (KnownEntitySource(..), lookupKnownKeyName, essentialsUnitId) import GHC.HsToCore.Types (DsGblEnv(..)) {- @@ -228,12 +228,12 @@ deSugar hsc_env ; let pluginModules = map lpModule (loadedPlugins (hsc_plugins hsc_env)) home_unit = hsc_home_unit hsc_env - ; essentials_mod <- liftIO $ lookupKnownKeysModule hsc_env dflags + ; essentials_uid <- liftIO $ essentialsUnitId hsc_env dflags ; let deps = mkDependencies home_unit (tcg_mod tcg_env) (tcg_imports tcg_env) (map mi_module pluginModules) - (moduleUnitId <$> essentials_mod) + essentials_uid ; safe_mode <- finalSafeMode dflags tcg_env ===================================== compiler/GHC/Iface/Errors/Ppr.hs ===================================== @@ -210,7 +210,7 @@ cantFindErrorX pkg_hidden_hint may_show_locations mod_or_interface (CantFindInst -- package flags when making suggestions. ToDo: if the original package -- also has a reexport, prefer that one pp_sugg (SuggestVisible m mod o) = ppr m <+> provenance o - where provenance ModHidden = empty + where provenance (ModHidden {}) = empty provenance (ModUnusable _) = empty provenance (ModOrigin{ fromOrigUnit = e, fromExposedReexport = res, @@ -227,7 +227,7 @@ cantFindErrorX pkg_hidden_hint may_show_locations mod_or_interface (CantFindInst <+> ppr mod) | otherwise = empty pp_sugg (SuggestHidden m mod o) = ppr m <+> provenance o - where provenance ModHidden = empty + where provenance (ModHidden {}) = empty provenance (ModUnusable _) = empty provenance (ModOrigin{ fromOrigUnit = e, fromHiddenReexport = rhs }) @@ -261,7 +261,7 @@ cantFindErrorX pkg_hidden_hint may_show_locations mod_or_interface (CantFindInst where pprMod (m, o) = text "it is bound as" <+> ppr m <+> text "by" <+> pprOrigin m o - pprOrigin _ ModHidden = panic "cantFindErr: bound by mod hidden" + pprOrigin _ (ModHidden {}) = panic "cantFindErr: bound by mod hidden" pprOrigin _ (ModUnusable _) = panic "cantFindErr: bound by mod unusable" pprOrigin m (ModOrigin e res _ f) = sep $ punctuate comma ( if e == Just True ===================================== compiler/GHC/Iface/Load.hs ===================================== @@ -24,7 +24,7 @@ module GHC.Iface.Load ( lookupKnownKeyThing, lookupKnownKeyName, lookupKnownOccThing, lookupKnownOccName, loadKnownKeyOccMaps, lookupKnownGRE, - lookupKnownKeysMap, lookupKnownKeysModule, + lookupKnownKeysMap, essentialsUnitId, -- RnM/TcM functions loadModuleInterface, loadModuleInterfaces, @@ -302,13 +302,14 @@ loadKnownKeyOccMaps -- We don't have a KnownKeyOccMap yet, so create it -- from the interface file for KnownKeyName do { hsc_env <- getTopEnv - ; mb_res <- liftIO $ findImportedModule hsc_env eSSENTIALS_NAME NoPkgQual - ; case mb_res of - Found _ mod -> Succeeded <$> build_maps mod - fr -> return (Failed (CantFindEssentials - (cannotFindModule hsc_env eSSENTIALS_NAME fr) - UnknownLoadEssentialsReason)) - } } } + ; res <- liftIO $ getEssentialsModule hsc_env + ; case res of + Succeeded mod -> Succeeded <$> build_maps mod + Failed err -> + return $ Failed $ + CantFindEssentials err UnknownLoadEssentialsReason + }}} + where doc = text "Need interface for KnownKeyNames" @@ -372,23 +373,39 @@ checkKnownKeyNamesIface known_key_names_occ_map Just name -> getOccName name /= occ #endif --- | Lookup the module exporting the canonical known-entities definitions (GHC.Essentials) -lookupKnownKeysModule :: HscEnv -> DynFlags {-^ Module dyn flags -} -> IO (Maybe Module) -lookupKnownKeysModule hsc_env dflags = do - eps <- hscEPS hsc_env - case eps_known_keys eps of - Just (_, kk_mod) -> return (Just kk_mod) - Nothing -> do - found_essentials <- findImportedModule hsc_env eSSENTIALS_NAME NoPkgQual - let rebindable_kn = gopt Opt_RebindableKnownNames dflags - let essentials_uid - | rebindable_kn = return Nothing - | Found _ mod <- found_essentials = return (Just mod) - | fr <- found_essentials = do - throwOneError (initSourceErrorContext dflags) $ - mkPlainErrorMsgEnvelope noSrcSpan $ GhcDriverMessage $ DriverInterfaceError $ - CantFindEssentials (cannotFindModule hsc_env eSSENTIALS_NAME fr) LookingForEssentialsModule - essentials_uid +-- | Identify the 'GHC.Essentials' module to use. +getEssentialsModule :: HscEnv -> IO (MaybeErr MissingInterfaceError Module) +getEssentialsModule hsc_env + = do { fr <- findEssentialsModule hsc_env + ; return $ case fr of + Found _ mod -> Succeeded mod + _ -> Failed $ cannotFindModule hsc_env eSSENTIALS_NAME fr } + +-- | Find the unit that provides the 'GHC.Essentials' module that is +-- implicitly depended on. +-- +-- 'Nothing' when @-frebindable-known-names@ is on, as in that case there is +-- no implicit dependency. +-- +-- See Note [Finding GHC.Essentials] in GHC.Builtin. +essentialsUnitId :: HscEnv -> DynFlags {-^ Module dyn flags -} -> IO (Maybe UnitId) +essentialsUnitId hsc_env dflags + | gopt Opt_RebindableKnownNames dflags + = return Nothing + | otherwise + = do { eps <- hscEPS hsc_env + ; case eps_known_keys eps of + -- We already resolved it: re-use the cached value. + Just (_, kk_mod) -> return (Just (moduleUnitId kk_mod)) + Nothing -> + do { res <- getEssentialsModule hsc_env + ; case res of + Succeeded mod -> return (Just (moduleUnitId mod)) + Failed err -> + throwOneError (initSourceErrorContext dflags) $ + mkPlainErrorMsgEnvelope noSrcSpan $ + GhcDriverMessage $ DriverInterfaceError $ + CantFindEssentials err LookingForEssentialsModule } } {- ********************************************************************* * * ===================================== compiler/GHC/Iface/Make.hs ===================================== @@ -244,12 +244,12 @@ mkIfaceTc hsc_env safe_mode mod_details mod_summary mb_program mb_modBreaks = do let pluginModules = map lpModule (loadedPlugins (hsc_plugins hsc_env)) let home_unit = hsc_home_unit hsc_env let dflags = ms_hspp_opts mod_summary - essentials_mod <- liftIO $ lookupKnownKeysModule hsc_env dflags + essentials_uid <- liftIO $ essentialsUnitId hsc_env dflags let deps = mkDependencies home_unit (tcg_mod tc_result) (tcg_imports tc_result) (map mi_module pluginModules) - (moduleUnitId <$> essentials_mod) + essentials_uid usage <- mkRecompUsageInfo hsc_env tc_result docs <- extractDocs dflags tc_result ===================================== compiler/GHC/Iface/Recomp.hs ===================================== @@ -638,7 +638,8 @@ checkMergedSignatures hsc_env mod_summary self_recomp = do checkDependencies :: HscEnv -> ModSummary -> ModIface -> IfG RecompileRequired checkDependencies hsc_env summary iface = do - res_normal <- classify_import (findImportedModule hsc_env) + -- See (FindEssentials2) in Note [Finding GHC.Essentials] in GHC.Builtin. + res_normal <- classify_import (\mod pkg -> findModuleWithIsBoot hsc_env mod NotBoot pkg) ([(st, p, m) | (st, p, m) <- (ms_textual_imps summary)] ++ [(NormalLevel, NoPkgQual, m) | m <- ms_srcimps summary ]) ===================================== compiler/GHC/Unit/External.hs ===================================== @@ -156,6 +156,12 @@ data ExternalPackageState eps_known_keys :: Maybe (KnownKeyNameMaps, Module), -- ^ See Note [Overview of known entities]. -- Caches the 'Module' where known entities are defined. + -- + -- BEWARE: there is a single 'ExternalPackageState' for + -- the whole session, so this caches a single 'GHC.Essentials' + -- for all home units. If two home units are compiled + -- against two different units both providing GHC.Essentials, + -- whichever is resolved first will be used for both. eps_inst_env :: !PackageInstEnv, -- ^ The total 'InstEnv' accumulated -- from all the external-package modules ===================================== compiler/GHC/Unit/Finder.hs ===================================== @@ -14,7 +14,8 @@ module GHC.Unit.Finder ( FinderCache(..), initFinderCache, findImportedModule, - findImportedModuleWithIsBoot, + findModuleWithIsBoot, + findEssentialsModule, findPluginModule, findExactModule, findHomeModule, @@ -43,6 +44,7 @@ import GHC.Data.OsPath import GHC.Unit.Env import GHC.Unit.Types +import GHC.Builtin.Modules( eSSENTIALS_NAME ) import GHC.Unit.Module import GHC.Unit.Module.Graph ( @@ -191,11 +193,45 @@ findImportedModule hsc_env mod pkg_qual = let home_module_name_providers_map = mgHomeModuleNameProvidersMap (hsc_mod_graph hsc_env) findImportedModuleNoHsc fc fopts (hsc_unit_env hsc_env) home_module_name_providers_map mb_home_unit mod pkg_qual -findImportedModuleWithIsBoot :: HscEnv -> ModuleName -> IsBootInterface -> PkgQual -> IO FindResult -findImportedModuleWithIsBoot hsc_env mod is_boot pkg_qual = do - res <- findImportedModule hsc_env mod pkg_qual - case (res, is_boot) of - (Found loc mod, IsBoot) -> return (Found (addBootSuffixLocn loc) mod) +-- | Resolve a 'ModuleName' into a 'Module'. +-- +-- Use this wherever GHC resolves a module's dependencies. +-- +-- Resolving a user-written import must use 'findImportedModule' instead. +findModuleWithIsBoot :: HscEnv -> ModuleName -> IsBootInterface -> PkgQual -> IO FindResult +findModuleWithIsBoot hsc_env mod_name is_boot pkg_qual + -- Allow GHC.Essentials to be found even when it is hidden. + -- See (FindEssentials1) in Note [Finding GHC.Essentials] in GHC.Builtin. + | mod_name == eSSENTIALS_NAME + , NotBoot <- is_boot + = findEssentialsModule hsc_env + | otherwise + = do res <- findImportedModule hsc_env mod_name pkg_qual + case (res, is_boot) of + (Found loc mod, IsBoot) -> return (Found (addBootSuffixLocn loc) mod) + _ -> return res + +-- | Find 'GHC.Essentials' (allowing it to be a hidden module of its unit). +-- +-- See Note [Finding GHC.Essentials] in GHC.Builtin. +findEssentialsModule :: HscEnv -> IO FindResult +findEssentialsModule hsc_env = do + res <- findImportedModule hsc_env eSSENTIALS_NAME NoPkgQual + case res of + NotFound {} + | Just mod <- lookupModuleEvenIfHidden (hsc_units hsc_env) eSSENTIALS_NAME + -> do let im = fst (getModuleInstantiation mod) + r <- findExactModule hsc_env im NotBoot + return $ case r of + InstalledFound loc -> Found loc mod + InstalledNoPackage _ -> NoPackage (moduleUnit mod) + InstalledNotFound fps _ -> + NotFound { fr_paths = fmap unsafeDecodeUtf fps + , fr_pkg = Just (moduleUnit mod) + , fr_pkgs_hidden = [] + , fr_mods_hidden = [] + , fr_unusables = [] + , fr_suggestions = [] } _ -> return res findImportedModuleNoHsc ===================================== compiler/GHC/Unit/State.hs ===================================== @@ -32,12 +32,14 @@ module GHC.Unit.State ( listVisibleModuleNames, lookupModuleInAllUnits, lookupModuleWithSuggestions, + lookupModuleEvenIfHidden, lookupModulePackage, lookupPluginModuleWithSuggestions, requirementMerges, LookupResult(..), ModuleSuggestion(..), ModuleOrigin(..), + HiddenModuleUnit(..), UnusableUnit(..), UnusableUnitReason(..), pprReason, @@ -81,6 +83,7 @@ import GHC.Platform.Ways import GHC.Unit.Database import GHC.Unit.Info import GHC.Unit.Ppr +import GHC.Builtin.Modules( eSSENTIALS_NAME ) import GHC.Unit.Types import GHC.Unit.Module import GHC.Unit.Home @@ -168,10 +171,8 @@ import Control.Applicative -- it could have come into scope. Warning: don't use the record functions, -- they're partial! data ModuleOrigin = - -- | Module is hidden, and thus never will be available for import. - -- (But maybe the user didn't realize), so we'll still keep track - -- of these modules.) - ModHidden + -- | The module is hidden (thus not available for a user-written import). + ModHidden !HiddenModuleUnit -- | Module is unavailable because the unit is unusable. | ModUnusable !UnusableUnit @@ -193,6 +194,11 @@ data ModuleOrigin = , fromPackageFlag :: Bool } +-- | Is the unit providing a hidden module itself visible in this compilation? +data HiddenModuleUnit + = HiddenModInVisibleUnit + | HiddenModInHiddenUnit + -- | A unusable unit module origin data UnusableUnit = UnusableUnit { uuUnit :: !Unit -- ^ Unusable unit @@ -201,7 +207,7 @@ data UnusableUnit = UnusableUnit } instance Outputable ModuleOrigin where - ppr ModHidden = text "hidden module" + ppr (ModHidden {}) = text "hidden module" ppr (ModUnusable _) = text "unusable module" ppr (ModOrigin e res rhs f) = sep (punctuate comma ( (case e of @@ -255,7 +261,7 @@ instance Monoid ModuleOrigin where -- | Is the name from the import actually visible? (i.e. does it cause -- ambiguity, or is it only relevant when we're making suggestions?) originVisible :: ModuleOrigin -> Bool -originVisible ModHidden = False +originVisible (ModHidden {}) = False originVisible (ModUnusable _) = False originVisible (ModOrigin b res _ f) = b == Just True || not (null res) || f @@ -1819,7 +1825,11 @@ mkModuleNameProvidersMap logger cfg pkg_map vis_map = esmap = listToUFM (es False) -- parameter here doesn't matter, orig will -- be overwritten - hiddens = [(m, mkModMap pk m ModHidden) | m <- hidden_mods] + hiddens = [(m, mkModMap pk m (ModHidden hidden_mod_unit)) | m <- hidden_mods] + + hidden_mod_unit + | b || not (null rns) = HiddenModInVisibleUnit + | otherwise = HiddenModInHiddenUnit pk = mkUnit pkg unit_lookup uid = lookupUnit' (unitConfigAllowVirtual cfg) pkg_map uid @@ -1940,8 +1950,36 @@ lookupModulePackage pkgs mn mfs = _ -> Nothing + -- If we implicitly depend on GHC.Essentials, mark the unit providing it + -- as used. See (FindEssentials4) in Note [Finding GHC.Essentials] in GHC.Builtin. + LookupHidden {} + | mn == eSSENTIALS_NAME + -> (\m -> [m]) <$> (lookupUnit pkgs . moduleUnit =<< lookupModuleEvenIfHidden pkgs mn) + _ -> Nothing +-- | Look up the module of this name provided by a /visible/ unit, even when +-- that module is hidden, i.e. is not in its unit's @exposed-modules@. +-- +-- This consults unit metadata only. Unlike "GHC.Unit.Finder", it does not +-- look for the module's interface file on disk, so it can answer \"which unit +-- provides this module?\" without requiring that unit to have been built yet. +-- +-- An exposed module always takes precedence over a hidden one, and a module +-- of a hidden unit is never returned. +lookupModuleEvenIfHidden :: UnitState -> ModuleName -> Maybe Module +lookupModuleEvenIfHidden pkgs mod_name = + case lookupModuleWithSuggestions pkgs mod_name NoPkgQual of + LookupFound m _ -> Just m + LookupHidden _ mods_hidden + | [m] <- [ m | (m, ModHidden HiddenModInVisibleUnit) <- mods_hidden ] + -> Just m + | otherwise + -> Nothing + LookupMultiple {} -> Nothing + LookupUnusable {} -> Nothing + LookupNotFound {} -> Nothing + lookupPluginModuleWithSuggestions :: UnitState -> ModuleName -> PkgQual @@ -1970,7 +2008,7 @@ lookupModuleWithSuggestions' pkgs mod_map name mb_pn let origin = filterOrigin mb_pn (mod_unit m) origin0 x = (m, origin) in case origin of - ModHidden + ModHidden {} -> (hidden_pkg, x:hidden_mod, unusable, exposed) ModUnusable _ -> (hidden_pkg, hidden_mod, x:unusable, exposed) @@ -2003,8 +2041,8 @@ lookupModuleWithSuggestions' pkgs mod_map name mb_pn filterOrigin (OtherPkg u) pkg o = let match_pkg p = u == unitId p in case o of - ModHidden - | match_pkg pkg -> ModHidden + ModHidden {} + | match_pkg pkg -> o | otherwise -> mempty ModUnusable _ | match_pkg pkg -> o ===================================== libraries/base/base.cabal.in ===================================== @@ -219,7 +219,6 @@ Library , GHC.Integer.Logarithms , GHC.IsList , GHC.Ix - , GHC.Essentials , GHC.List , GHC.Maybe , GHC.MVar @@ -307,6 +306,7 @@ Library other-modules: Data.List.NubOrdSet + GHC.Essentials System.CPUTime.Unsupported System.CPUTime.Utils if os(windows) ===================================== testsuite/tests/interface-stability/base-exports.stdout ===================================== @@ -5295,10 +5295,6 @@ module GHC.Err where errorWithoutStackTrace :: forall (r :: GHC.Internal.Types.RuntimeRep) (a :: TYPE r). [GHC.Internal.Types.Char] -> a undefined :: forall (r :: GHC.Internal.Types.RuntimeRep) (a :: TYPE r). GHC.Internal.Stack.Types.HasCallStack => a -module GHC.Essentials where - --- ignored - module GHC.Event where -- Safety: Safe ===================================== testsuite/tests/interface-stability/base-exports.stdout-javascript-unknown-ghcjs ===================================== @@ -5295,10 +5295,6 @@ module GHC.Err where errorWithoutStackTrace :: forall (r :: GHC.Internal.Types.RuntimeRep) (a :: TYPE r). [GHC.Internal.Types.Char] -> a undefined :: forall (r :: GHC.Internal.Types.RuntimeRep) (a :: TYPE r). GHC.Internal.Stack.Types.HasCallStack => a -module GHC.Essentials where - --- ignored - module GHC.Event where -- Safety: Safe ===================================== testsuite/tests/interface-stability/base-exports.stdout-mingw32 ===================================== @@ -5340,10 +5340,6 @@ module GHC.Err where errorWithoutStackTrace :: forall (r :: GHC.Internal.Types.RuntimeRep) (a :: TYPE r). [GHC.Internal.Types.Char] -> a undefined :: forall (r :: GHC.Internal.Types.RuntimeRep) (a :: TYPE r). GHC.Internal.Stack.Types.HasCallStack => a -module GHC.Essentials where - --- ignored - module GHC.Event.TimeOut where -- Safety: None ===================================== utils/dump-decls/Main.hs ===================================== @@ -68,7 +68,6 @@ ignoredModules = map mkModuleName $ concat [ unstableModules , platformDependentModules - , internalModules ] where unstableModules = @@ -81,8 +80,6 @@ ignoredModules = , "GHC.Num.Backend" , "GHC.Num.Backend.Selected" ] - internalModules = - [ "GHC.Essentials" ] ignoredOccNames :: [OccName] ignoredOccNames = View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/1575eb10deeedd07a263d476e37d33a… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/1575eb10deeedd07a263d476e37d33a… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/az/exactprint-annotation-rationalisation] 31 commits: ci: Use shallow submodule clones by default
by Alan Zimmerman (＠alanz) 27 Jul '26

27 Jul '26

Alan Zimmerman pushed to branch wip/az/exactprint-annotation-rationalisation at Glasgow Haskell Compiler / GHC Commits: f586c885 by Simon Jakobi at 2026-07-24T18:05:00-04:00 ci: Use shallow submodule clones by default Limit submodule clones to depth one to reduce CI checkout costs. Keep fetching full submodule history for the submodule lint jobs, which inspect commits across a range. Assisted-by: gpt-5.6-sol via Codex CLI - - - - - 306120d2 by Duncan Coutts at 2026-07-24T18:05:43-04:00 Fix flaky test T3994 on FreeBSD On current FreeBSD versions, calling getpgid on a zombie process fails. In T3994, if we're really unlucky with delays and scheduling then we can end up in exactly that situation. Just catch that specific exception and ignore it. It's rare, and not our fault. - - - - - 7b116a0b by Cheng Shao at 2026-07-24T18:06:24-04:00 ci: add missing workaround for docker permissions in lint jobs Some lint jobs use ci-images with default user `ghc`, and the gitlab ci docker executor requires the `sudo chown` workaround to fix workspace directory permission issue. This patch adds the missing workarounds for the lint jobs. Fixes #27554. Co-authored-by: Codex <codex(a)openai.com> - - - - - 815149f3 by Andrzej Rybczak at 2026-07-25T15:06:43+00:00 Add -Wdefaulted-callstack Adds a new warning, -Wdefaulted-callstack, which warns when an implicit CallStack parameter is defaulted to the empty stack. In particular, this includes call sites where a function with a HasCallStack constraint is called from a definition that does *not* provide one. At such call sites the call stack is cut off and does not include the enclosing definition's callers, which can be a source of surprise if the user wants complete call stacks. Closes #27077. - - - - - f6f2343f by Zubin Duggal at 2026-07-25T17:40:51-04:00 UniqueDFM: alter should preserve insertion order Before it always inserting new elements at the end. This is problematic because instances get inserted into the map with `alterF`, which can change ordering of how instances are printed with `:info` depending on the order in which we consult interfaces I expect `alter id k = id` and `alter (fmap f) k = adjust f k`. Moving keys to the end breaks that (`adjust` already preserves position). Fixes #27532 - - - - - f2347216 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: ClsInstDecl with decls as [LHsDecl GhcPs] in GhcPs Similar to 4fdfe75731e01dad7d7fa474c2703d0d3965afb1, this commit changes the as-parsed representation of class instance declarations to [LHsDecl GhcPs], and only separates them by type from the renamer onward. This also allows us to remove all the AnnSortKey machinery for exact printing, as it is now no longer needed. - - - - - fba59977 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Remove LocatedP from OverlapMode - - - - - e818b108 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Remove LocatedP from CType - - - - - 8babde29 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Remove LocatedP, last use in WarningTxt - - - - - 0c230543 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Remove LocatedE from WarningCategory - - - - - ad62582a by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Remove LocateE from XCImport and XCExport - - - - - f86db830 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Remove LocatedE from HsRecFields dot - - - - - 4883ed92 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Remove LocatedE completely, last usage for pats - - - - - 58219f51 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Remove AnnList (EpToken "where") usages This is moving toward removing the parameter from AnnList completely - - - - - a3b540e9 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA remove AnnList (EpToken "rec") usages - - - - - e6a10acd by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Remove last parameterised AnnList usage (EpaLocation) Also remove the parameter - - - - - fd235b27 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 TTG: Add extension points to BooleanFormula They are currently unused, but will be used for exact print annotations next - - - - - 955829b7 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Remove LocatedBC / SrcSpanBF - - - - - 97f1029a by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: remove unused addTrailingAnnToL. Squash appropriately - - - - - aa82ab90 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPS: Remove NoEpTok/NoEpUniTok, using an unhelpful SrcSpan instead Also introduce helper functions noEpTok and noEpUniTok to serve as simple replacements in code inserting an token annotation without location information. - - - - - 770924eb by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Some haddock processing tweaks - - - - - ab69f608 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 Some haddock exactprint tests - - - - - 2a74cfde by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: When adding comments honour trailing anns - - - - - 0a1c7676 by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA: Uses Parsers.parseModule for exactprint tests This is the advertised way to parse for use for exact printing in the ghc-exactprint library, make sure we test using it. - - - - - 38d9008f by Alan Zimmerman at 2026-07-26T13:38:48+01:00 EPA Fix HsCmdDo exact print with comments TODO: add test based on proc-do-complex-four-out.hs - - - - - 92d8e2db by Alan Zimmerman at 2026-07-27T19:48:12+01:00 EPA: Add comments about remaining Anno SrcSpan instances - - - - - c2b2adc0 by Alan Zimmerman at 2026-07-27T23:06:50+01:00 EPA: First pass implementation of HsList, for ClassDecls Just as a straight list replacement to start with, no payload. This shows the scope and invasiveness of the initial change - - - - - 6c8646d3 by Alan Zimmerman at 2026-07-27T23:07:56+01:00 Enable ppr test for Haddock1. It currently fails - - - - - 2b779f0c by Alan Zimmerman at 2026-07-27T23:07:56+01:00 WIP on removing NoEpAnn. Likely abandon - - - - - 72c6a1a3 by Alan Zimmerman at 2026-07-27T23:07:56+01:00 EPA: Add an overview doc for exact printing - - - - - 2199059c by Simon Peyton Jones at 2026-07-27T23:07:56+01:00 Added an intro section - - - - - 139 changed files: - .gitlab-ci.yml - + ExactPrint.md - + changelog.d/27532 - + changelog.d/warn-defaulted-callstack - compiler/GHC/Builtin/Utils.hs - compiler/GHC/Core/Class.hs - compiler/GHC/CoreToIface.hs - compiler/GHC/Data/BooleanFormula.hs - compiler/GHC/Driver/Flags.hs - compiler/GHC/Driver/Session.hs - compiler/GHC/Hs.hs - compiler/GHC/Hs/Binds.hs - compiler/GHC/Hs/Decls.hs - compiler/GHC/Hs/Decls/Overlap.hs - compiler/GHC/Hs/Doc.hs - compiler/GHC/Hs/DocString.hs - compiler/GHC/Hs/Dump.hs - compiler/GHC/Hs/Expr.hs - compiler/GHC/Hs/Extension/Pass.hs - compiler/GHC/Hs/ImpExp.hs - compiler/GHC/Hs/Instances.hs - compiler/GHC/Hs/Pat.hs - compiler/GHC/Hs/Stats.hs - compiler/GHC/Hs/Utils.hs - compiler/GHC/HsToCore/Docs.hs - compiler/GHC/HsToCore/Quote.hs - compiler/GHC/Iface/Ext/Ast.hs - compiler/GHC/Iface/Syntax.hs - compiler/GHC/Iface/Warnings.hs - compiler/GHC/IfaceToCore.hs - compiler/GHC/Parser.y - compiler/GHC/Parser/Annotation.hs - compiler/GHC/Parser/PostProcess.hs - compiler/GHC/Parser/PostProcess/Haddock.hs - compiler/GHC/Rename/Module.hs - compiler/GHC/Rename/Names.hs - compiler/GHC/Rename/Pat.hs - compiler/GHC/Tc/Deriv.hs - compiler/GHC/Tc/Errors/Ppr.hs - compiler/GHC/Tc/Errors/Types.hs - compiler/GHC/Tc/Solver/Default.hs - compiler/GHC/Tc/Solver/Dict.hs - compiler/GHC/Tc/TyCl.hs - compiler/GHC/Tc/TyCl/Class.hs - compiler/GHC/Tc/TyCl/Instance.hs - compiler/GHC/Tc/Types/Evidence.hs - compiler/GHC/Tc/Types/Origin.hs - compiler/GHC/Tc/Utils/Env.hs - compiler/GHC/Tc/Utils/Instantiate.hs - compiler/GHC/Tc/Utils/Unify.hs - compiler/GHC/ThToHs.hs - compiler/GHC/Types/Error/Codes.hs - compiler/GHC/Types/ForeignCall.hs - compiler/GHC/Types/Unique/DFM.hs - compiler/GHC/Unit/Module/Warnings.hs - compiler/Language/Haskell/Syntax/Basic.hs - compiler/Language/Haskell/Syntax/BooleanFormula.hs - compiler/Language/Haskell/Syntax/Decls.hs - compiler/Language/Haskell/Syntax/Expr.hs - compiler/Language/Haskell/Syntax/Extension.hs - docs/users_guide/using-warnings.rst - libraries/base/changelog.md - libraries/base/src/GHC/Stack.hs - libraries/ghc-internal/src/GHC/Internal/Stack.hs - testsuite/tests/ghc-api/T25121_status.stdout - testsuite/tests/ghc-api/exactprint/T22919.stderr - testsuite/tests/ghc-api/exactprint/Test20239.stderr - testsuite/tests/ghc-api/exactprint/ZeroWidthSemi.stderr - testsuite/tests/ghci/T16793/T16793.stdout - testsuite/tests/ghci/T18060/T18060.stdout - + testsuite/tests/ghci/T27532/Makefile - + testsuite/tests/ghci/T27532/T27532.stdout - + testsuite/tests/ghci/T27532/T27532j4.stdout - + testsuite/tests/ghci/T27532/a.script - + testsuite/tests/ghci/T27532/all.T - + testsuite/tests/ghci/T27532/b.script - + testsuite/tests/ghci/T27532/genT27532Modules - testsuite/tests/ghci/scripts/ListTuplePunsPpr.stdout - testsuite/tests/ghci/scripts/T4175.stdout - testsuite/tests/ghci/scripts/T8469.stdout - testsuite/tests/ghci/scripts/T8535.stdout - testsuite/tests/ghci/scripts/T9881.stdout - testsuite/tests/ghci/scripts/ghci020.stdout - testsuite/tests/ghci/scripts/ghci064.stdout - testsuite/tests/ghci/should_run/T10145.stdout - testsuite/tests/ghci/should_run/T18594.stdout - testsuite/tests/haddock/should_compile_flag_haddock/T17544.stderr - testsuite/tests/haddock/should_compile_flag_haddock/T17544_kw.stderr - testsuite/tests/haddock/should_compile_flag_haddock/T24221.stderr - testsuite/tests/interface-stability/base-exports.stdout - testsuite/tests/interface-stability/base-exports.stdout-javascript-unknown-ghcjs - testsuite/tests/interface-stability/base-exports.stdout-mingw32 - testsuite/tests/module/mod185.stderr - testsuite/tests/parser/should_compile/DumpParsedAst.stderr - testsuite/tests/parser/should_compile/DumpParsedAstComments.stderr - testsuite/tests/parser/should_compile/DumpRenamedAst.stderr - testsuite/tests/parser/should_compile/DumpSemis.stderr - testsuite/tests/parser/should_compile/DumpTypecheckedAst.stderr - testsuite/tests/parser/should_compile/KindSigs.stderr - testsuite/tests/parser/should_compile/T14189.stderr - testsuite/tests/parser/should_compile/T15279.stderr - testsuite/tests/parser/should_compile/T15323.stderr - testsuite/tests/parser/should_compile/T20452.stderr - testsuite/tests/parser/should_compile/T20718.stderr - testsuite/tests/parser/should_compile/T20718b.stderr - testsuite/tests/parser/should_compile/T20846.stderr - testsuite/tests/parser/should_compile/T23315/T23315.stderr - testsuite/tests/partial-sigs/should_compile/ExtraConstraints3.stderr - testsuite/tests/printer/AnnotationNoListTuplePuns.stdout - + testsuite/tests/printer/Haddock1.hs - testsuite/tests/printer/Makefile - testsuite/tests/printer/T18791.stderr - testsuite/tests/printer/Test20297.stdout - testsuite/tests/printer/Test24533.stdout - testsuite/tests/printer/all.T - testsuite/tests/process/T3994.hs - testsuite/tests/roles/should_compile/Roles14.stderr - testsuite/tests/roles/should_compile/Roles3.stderr - testsuite/tests/roles/should_compile/Roles4.stderr - testsuite/tests/roles/should_compile/T8958.stderr - testsuite/tests/typecheck/should_compile/T18406b.stderr - testsuite/tests/typecheck/should_compile/T18529.stderr - + testsuite/tests/typecheck/should_compile/WarnDefaultedCallStack.hs - + testsuite/tests/typecheck/should_compile/WarnDefaultedCallStack.stderr - testsuite/tests/typecheck/should_compile/all.T - testsuite/tests/typecheck/should_fail/T5300.stderr - utils/check-exact/ExactPrint.hs - utils/check-exact/Main.hs - utils/check-exact/Parsers.hs - utils/check-exact/Transform.hs - utils/check-exact/Utils.hs - utils/haddock/haddock-api/src/Haddock/Backends/Hoogle.hs - utils/haddock/haddock-api/src/Haddock/Backends/LaTeX.hs - utils/haddock/haddock-api/src/Haddock/Backends/Xhtml/Decl.hs - utils/haddock/haddock-api/src/Haddock/Convert.hs - utils/haddock/haddock-api/src/Haddock/GhcUtils.hs - utils/haddock/haddock-api/src/Haddock/Interface/Create.hs - utils/haddock/haddock-api/src/Haddock/Interface/Rename.hs - utils/haddock/haddock-api/src/Haddock/Types.hs The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/a15493982e6d2926d6877e095f5355… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/a15493982e6d2926d6877e095f5355… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][master] 3 commits: testsuite: skip runtime stats tests on debugged compilers
by Marge Bot (＠marge-bot) 27 Jul '26

27 Jul '26

Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC Commits: f8e3bee9 by Zubin Duggal at 2026-07-27T17:31:49-04:00 testsuite: skip runtime stats tests on debugged compilers Debugged flavours build the boot libraries without optimisation, so the runtime numbers do not match the baselines. - - - - - 1e326770 by Zubin Duggal at 2026-07-27T17:31:50-04:00 testsuite: mark #20706 tests fragile rather than broken Whether the static linux linker issues manifest depends on the host toolchain. - - - - - c0b13cbe by Zubin Duggal at 2026-07-27T17:31:50-04:00 testsuite: exclude libnuma from mostly-static It needs static system libraries (libnuma.a) that many platforms do not ship. Fixes #26914 - - - - - 10 changed files: - testsuite/driver/testlib.py - testsuite/tests/driver/all.T - testsuite/tests/driver/mostly-static/Makefile - testsuite/tests/ghci/T13786/all.T - testsuite/tests/ghci/linking/all.T - testsuite/tests/ghci/linking/dyn/all.T - testsuite/tests/package/T20010/all.T - testsuite/tests/plugins/all.T - testsuite/tests/rts/all.T - testsuite/tests/rts/linker/all.T Changes: ===================================== testsuite/driver/testlib.py ===================================== @@ -878,9 +878,11 @@ def _collect_stats(name: TestName, opts, metrics, deviation: Optional[int], else: tag = 'runtime' - # Compiler performance numbers change when debugging is on, making the results - # useless and confusing. Therefore, skip if debugging is on. - if config.compiler_debugged and is_compiler_stats_test: + # Performance numbers change when debugging is on, making the results + # useless and confusing. This applies to runtime numbers too, since + # debugged flavours also build the boot libraries without optimisation. + # Therefore, skip if debugging is on. + if config.compiler_debugged: opts.skip = True # If there are any residency testing metrics then turn on RESIDENCY_OPTS ===================================== testsuite/tests/driver/all.T ===================================== @@ -124,7 +124,7 @@ test('static001', [extra_files(['Static001.hs']), only_darwin], makefile_test, ['static001']) test('dynHelloWorld', - [only_ways(['dyn']), when(opsys('linux') and not ghc_dynamic() and not arch('wasm32'), expect_broken(20706))], + [only_ways(['dyn']), when(opsys('linux') and not ghc_dynamic() and not arch('wasm32'), fragile(20706))], compile_and_run, ['']) ===================================== testsuite/tests/driver/mostly-static/Makefile ===================================== @@ -24,6 +24,6 @@ mostly-static: "$(RANLIB)" "test/libtest-1.0.a" "$(GHC_PKG)" init $(LOCAL_PKGCONF) "$(GHC_PKG)" --no-user-package-db -f $(LOCAL_PKGCONF) register test/test.pkg -v0 - "$(TEST_HC)" $(TEST_HC_OPTS) --make -static-external -exclude-static-external=c,m,rt,dl,pthread,stdc++,atomic,gmp,ffi,iconv,wsock32,gdi32,winmm,dbghelp,psapi,user32,shell32,mingw32,kernel32,advapi32,mingwex,ws2_32,shlwapi,ole32,rpcrt4,ntdll,ucrt -hide-all-packages -package-db $(LOCAL_PKGCONF)/ -package base -package-id test-1.0 Hello.hs + "$(TEST_HC)" $(TEST_HC_OPTS) --make -static-external -exclude-static-external=c,m,rt,dl,pthread,stdc++,atomic,gmp,ffi,iconv,numa,wsock32,gdi32,winmm,dbghelp,psapi,user32,shell32,mingw32,kernel32,advapi32,mingwex,ws2_32,shlwapi,ole32,rpcrt4,ntdll,ucrt -hide-all-packages -package-db $(LOCAL_PKGCONF)/ -package base -package-id test-1.0 Hello.hs ./Hello $(LDD) Hello | grep libtest || true ===================================== testsuite/tests/ghci/T13786/all.T ===================================== @@ -1,4 +1,4 @@ test('T13786', - [when(unregisterised(), fragile(17018)), req_c, when(opsys('linux') and not ghc_dynamic(), expect_broken(20706))], + [when(unregisterised(), fragile(17018)), req_c, when(opsys('linux') and not ghc_dynamic(), fragile(20706))], makefile_test, []) ===================================== testsuite/tests/ghci/linking/all.T ===================================== @@ -33,7 +33,7 @@ test('ghcilink005', unless(doing_ghci, skip), req_dynamic_lib_support, req_interp, - when(opsys('linux') and not ghc_dynamic(), expect_broken(20706))], + when(opsys('linux') and not ghc_dynamic(), fragile(20706))], makefile_test, ['ghcilink005']) test('ghcilink006', ===================================== testsuite/tests/ghci/linking/dyn/all.T ===================================== @@ -3,7 +3,7 @@ setTestOpts(req_dynamic_lib_support) test('load_short_name', [ extra_files(['A.c']) , unless(doing_ghci, skip) , req_c - , when(opsys('linux') and not ghc_dynamic(), expect_broken(20706)) + , when(opsys('linux') and not ghc_dynamic(), fragile(20706)) ], makefile_test, ['load_short_name']) @@ -13,7 +13,7 @@ test('T1407', pre_cmd('$MAKE -s --no-print-directory compile_libT1407'), extra_hc_opts('-L"$PWD/T1407dir"'), js_broken(22359), - when(opsys('linux') and not ghc_dynamic(), expect_broken(20706))], + when(opsys('linux') and not ghc_dynamic(), fragile(20706))], makefile_test, []) test('T3242', ===================================== testsuite/tests/package/T20010/all.T ===================================== @@ -1,4 +1,4 @@ # Test that GHC links to the C++ standard library as expected # when the system-cxx-std-lib package is used. test('T20010', req_c, makefile_test, []) -test('T20010-ghci', [req_c, extra_files(['T20010_c.cpp', 'T20010.hs']), when(opsys('linux') and not ghc_dynamic(), expect_broken(20706))], makefile_test, []) +test('T20010-ghci', [req_c, extra_files(['T20010_c.cpp', 'T20010.hs']), when(opsys('linux') and not ghc_dynamic(), fragile(20706))], makefile_test, []) ===================================== testsuite/tests/plugins/all.T ===================================== @@ -131,7 +131,7 @@ test('T10294a', pre_cmd('$MAKE -s --no-print-directory -C annotation-plugin package.T10294a TOP={top}')], makefile_test, []) -test('frontend01', [extra_files(['FrontendPlugin.hs']), when(opsys('linux') and not ghc_dynamic(), expect_broken(20706))], +test('frontend01', [extra_files(['FrontendPlugin.hs']), when(opsys('linux') and not ghc_dynamic(), fragile(20706))], makefile_test, []) test('T11244', @@ -368,14 +368,14 @@ test('test-echo-in-line-many-args', test('plugins-external', [extra_files(['shared-plugin/']), pre_cmd('$MAKE -s --no-print-directory -C shared-plugin package.plugins01 TOP={top}'), - when(opsys('mingw32') or (opsys('linux') and not ghc_dynamic()), expect_broken(20706))], + when(opsys('mingw32') or (opsys('linux') and not ghc_dynamic()), fragile(20706))], makefile_test, []) test('test-phase-hooks-plugin', [extra_files(['hooks-plugin/']), pre_cmd('$MAKE -s --no-print-directory -C hooks-plugin package.test-phase-hooks-plugin TOP={top}'), - when(opsys('linux') and not ghc_dynamic(), expect_broken(20706))], + when(opsys('linux') and not ghc_dynamic(), fragile(20706))], compile, ['-package-db hooks-plugin/pkg.test-phase-hooks-plugin/local.package.conf -fplugin Hooks.PhasePlugin -package hooks-plugin ' + config.plugin_way_flags]) ===================================== testsuite/tests/rts/all.T ===================================== @@ -524,7 +524,7 @@ test('test-zeroongc', extra_run_opts('-DZ'), compile_and_run, ['-debug']) test('T13676', [when(opsys('mingw32'), expect_broken(17447)), extra_files(['T13676.hs']), - when(opsys('linux') and not ghc_dynamic(), expect_broken(20706))], + when(opsys('linux') and not ghc_dynamic(), fragile(20706))], ghci_script, ['T13676.script']) test('InitEventLogging', [ only_ways(['normal']) ===================================== testsuite/tests/rts/linker/all.T ===================================== @@ -74,7 +74,7 @@ test('T5435_v_asm_a', req_rts_linker, fragile(22970), when(arch('arm'), expect_broken(17559)), - when(opsys('linux') and not ghc_dynamic(), expect_broken(20706))], + when(opsys('linux') and not ghc_dynamic(), fragile(20706))], makefile_test, ['T5435_v_asm_a']) # this one just needs to run on linux, as darwin/mingw32 are covered # by the _a test already. @@ -84,14 +84,14 @@ test('T5435_v_asm_b', fragile(22970), when(arch('arm'), expect_broken(17559)), when(opsys('darwin') or opsys('mingw32'), skip), - when(opsys('linux') and not ghc_dynamic(), expect_broken(20706))], + when(opsys('linux') and not ghc_dynamic(), fragile(20706))], makefile_test, ['T5435_v_asm_b']) test('T5435_v_gcc', [extra_files(['T5435.hs', 'T5435_gcc.c']), req_rts_linker, fragile(22970), when(arch('arm'), expect_broken(17559)), - when(opsys('linux') and not ghc_dynamic(), expect_broken(20706))], + when(opsys('linux') and not ghc_dynamic(), fragile(20706))], makefile_test, ['T5435_v_gcc']) test('T5435_dyn_asm', [extra_files(['T5435.hs', 'T5435_asm.c']), @@ -152,7 +152,7 @@ test('T7072', req_rts_linker], makefile_test, ['T7072']) -test('T20494', [req_rts_linker, when(opsys('linux') and not ghc_dynamic(), expect_broken(20706))], +test('T20494', [req_rts_linker, when(opsys('linux') and not ghc_dynamic(), fragile(20706))], makefile_test, ['T20494']) test('T20918', View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/6cce494a7ec43953c7a949e0d8ce71… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/6cce494a7ec43953c7a949e0d8ce71… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][master] 2 commits: Introduce global unit database cache
by Marge Bot (＠marge-bot) 27 Jul '26

27 Jul '26

Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC Commits: 5d0ab71a by fendor at 2026-07-27T17:31:05-04:00 Introduce global unit database cache As a first step for better sharing of `UnitInfo` across `UnitEnv`, we introduce a new datatype called `ExternalUnitDatabases`. It primarily serves as an in-memory representation of *all* `UnitDatabase`s across `UnitEnv`. This means, if multiple `HomeUnitEnv`s depend on the same database, one way or another, we make sure that we don't parse from disk every time. Instead, we store the in-memory representation in `ExternalUnitDatabases`. `ExternalUnitDatabaseCache` is the equivalent of `ExternalUnitState` in the `UnitEnv`. It is a mutable variable wrapping `ExternalUnitDatabases`. The mutable `ExternalUnitDatabaseCache` is used in `initUnits` to make sure we don't parse the same unit database multiple times. Almost by accident, we change the semantics of `initUnits` to honour modifications to `packageDBFlags`. The inability to change `packageDBFlags` while also reusing the already parsed `UnitDatabase`s was reported in #26423 as a bug. Hence, we think this behaviour change is warranted and acceptable, especially since it comes with a breaking change to the `initUnits` API. Add regression test for #26423 Closes #26423 - - - - - 6cce494a by fendor at 2026-07-27T17:31:05-04:00 Introduce UnitIndex for global external unit caching `UnitInfo`s have been observed to cause a lot of memory usage in #27500. Especially with multiple home units, as the same (external) units are processed from scratch, even though most of the time we end up with exactly the same `UnitInfo`. We introduce a `UnitEnv` global cache that allows us to store external unit information that is used across all `HomeUnitEnv`s. The most important change in this commit is the introduction of the `UnitIndex`. It stores a global mapping of `UnitId` -> `UnitInfo`, and `initUnits` always uses the cached `UnitInfo` entry to populate each `HomeUnitEnv`'s `UnitState`. This allows us to ensure the following property: > Each `UnitInfo` should be alive exactly once in GHC. All `UnitState`s should reference 'UnitInfo's stored in the 'UnitIndex'. This ensured by calling 'initUnits' with the 'UnitIndex'. In addition, the `ExternalUnitDatabases` may also hold a reference to each on-disk representation of `UnitInfo`. This means, we impose an hard upper bound on the number of `UnitInfo`s alive in the GHC session: > The number of alive `UnitInfo`s closure objects must be the > sum of all loaded unit database times two. We add performance regression tests that make sure the number of live `UnitInfo` cannot exceed this threshold. Closes #27500 ------------------------- Metric Decrease: MultiComponentModules MultiComponentModulesRecomp MultiComponentModulesRecomp100 mhu-perf LinkableUsage02 ------------------------- These metrics increases are especially notable, as we are not even sharing anything big but merely the global package database with 50 entries. It shows how careful sharing of `UnitInfo` can improve memory usage. We expect this to be much more notable when the whole cabal package database is shared across multiple home units. `LinkableUsage02` metric decreases on unreg and i386 platform, only. --- Technical details To share the `UnitInfo`s correctly, it is important that we extract the `WireMap` into the `UnitIndex`. At the moment of writing, `WireMap` must be globally the same for all `HomeUnitEnv`s. This is important, as we could otherwise not cache the "fully-resolved" `UnitInfo`, as we don't change the `UnitId` or `unitAbiHash` when resolving wired-in units. Thus, there could be ambiguities, when the `WireMap` is not the same for all `UnitState`s across the `UnitEnv`. We consider a `UnitInfo` fully-resolved, if wired-in units have been updated, the `UnitInfo` has been validated and variables in the unit config, such as `${pkgroot}` have been resolved. Updating the wired-in units requires the `WireMap` to be globally the same. - - - - - 46 changed files: - + changelog.d/T26423 - + changelog.d/unit-index - compiler/GHC.hs - compiler/GHC/Driver/Backpack.hs - compiler/GHC/Driver/Env.hs - compiler/GHC/Driver/Main/Hsc.hs - compiler/GHC/Driver/Main/Interactive.hs - compiler/GHC/Driver/Main/Passes.hs - compiler/GHC/Driver/Session/Units.hs - compiler/GHC/Types/Unique.hs - compiler/GHC/Unit/Env.hs - + compiler/GHC/Unit/External/Database.hs - + compiler/GHC/Unit/External/Index.hs - + compiler/GHC/Unit/External/ModuleOrigin.hs - + compiler/GHC/Unit/External/Providers.hs - + compiler/GHC/Unit/External/Query.hs - + compiler/GHC/Unit/External/Substitution.hs - + compiler/GHC/Unit/External/Validate.hs - + compiler/GHC/Unit/External/Visibility.hs - + compiler/GHC/Unit/External/Wired.hs - compiler/GHC/Unit/Home/Graph.hs - compiler/GHC/Unit/Info.hs - compiler/GHC/Unit/State.hs - compiler/GHC/Unit/State.hs-boot - compiler/GHC/Unit/Types.hs - compiler/ghc.cabal.in - ghc/GHCi/UI.hs - hadrian/src/Rules/Generate.hs - testsuite/tests/count-deps/CountDepsParser.stdout - + testsuite/tests/driver/T26423/Hello.hs - + testsuite/tests/driver/T26423/Makefile - + testsuite/tests/driver/T26423/T26423.hs - + testsuite/tests/driver/T26423/T26423.stderr - + testsuite/tests/driver/T26423/T26423.stdout - + testsuite/tests/driver/T26423/all.T - + testsuite/tests/driver/T26423/test/Test.hs - + testsuite/tests/driver/T26423/test/test.pkg - + testsuite/tests/driver/TUnitInfo/Foo.hs - + testsuite/tests/driver/TUnitInfo/Makefile - + testsuite/tests/driver/TUnitInfo/all.T - + testsuite/tests/driver/TUnitInfo/genMhu.sh - + testsuite/tests/driver/TUnitInfo/generic-unit-info-space-mhu.stdout - + testsuite/tests/driver/TUnitInfo/generic-unit-info-space-single.stdout - + testsuite/tests/driver/TUnitInfo/generic-unit-info-space.hs - + testsuite/tests/driver/TUnitInfo/generic-unit-info-space.stdout - utils/haddock/haddock-api/src/Haddock.hs The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/f6f2343fbbfdfd8aaed9babf5983e3… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/f6f2343fbbfdfd8aaed9babf5983e3… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0

[Git][ghc/ghc][wip/9.14.2-backports] 2 commits: hadrian: need libffi before linking the dynamic rts
by Zubin (＠wz1000) 27 Jul '26

27 Jul '26

Zubin pushed to branch wip/9.14.2-backports at Glasgow Haskell Compiler / GHC Commits: e9e7e8ec by Zubin Duggal at 2026-07-28T01:21:28+05:30 hadrian: need libffi before linking the dynamic rts The rts link passes -lffi but never needed libffi. Whether the build succeeded or not was a race depending on if we managed to copy the libary before the link. - - - - - 5c2425a1 by Zubin Duggal at 2026-07-28T01:21:28+05:30 Prepare 9.14.2 Bump filpath submodule to 1.5.5.0 Bump Win32 submodule to 2.14.2.2 Metric Increase: T4029 T13379 libdir Metric Decrease: T5030 T24602_perf_size T25046_perf_size_gzip T25046_perf_size_unicode T25046_perf_size_unicode_gzip - - - - - 46 changed files: - − changelog.d/26616 - − changelog.d/T26978 - − changelog.d/T26979 - − changelog.d/T27046 - − changelog.d/T27047 - − changelog.d/T27123.md - − changelog.d/T27124.md - − changelog.d/T27131 - − changelog.d/T27182.md - − changelog.d/T27202 - − changelog.d/T27225 - − changelog.d/T27386 - − changelog.d/bump-process - − changelog.d/deterministic-usage-order - − changelog.d/fix-absent-dict-projection - − changelog.d/fix-blackhole-handling - − changelog.d/fix-cmm-atomic-load-store - − changelog.d/fix-compacting-gc-ap-27434 - − changelog.d/fix-exponential-case-desugar-27383 - − changelog.d/fix-finalizers-27072 - − changelog.d/fix-layout-stack-fcall - − changelog.d/fix-peekitbl-no-tntc - − changelog.d/fix-use-std-ap-thunk - − changelog.d/ghc-pkg-faster-closure - − changelog.d/hadrian-stale-package-confs-26661 - − changelog.d/jobserver-leak-fix - − changelog.d/more-efficient-home-unit-imports-finding - − changelog.d/reexported-module-errors - − changelog.d/semaphore-v2 - − changelog.d/tag-inference-27005 - − changelog.d/unused-type - − changelog.d/wasm-fix-serviceworker - − changelog.d/windows-rethrow-overlapped-exception - configure.ac - docs/users_guide/9.14.2-notes.rst - hadrian/bootstrap/generate_bootstrap_plans - + hadrian/bootstrap/plan-9_10_3.json - + hadrian/bootstrap/plan-9_12_4.json - + hadrian/bootstrap/plan-bootstrap-9_10_3.json - + hadrian/bootstrap/plan-bootstrap-9_12_4.json - hadrian/src/Rules/Library.hs - hadrian/src/Rules/Register.hs - libraries/Win32 - libraries/base/base.cabal.in - libraries/base/changelog.md - libraries/filepath The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/1ba96b2fb2ad00b4c08472723f5d3d… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/1ba96b2fb2ad00b4c08472723f5d3d… You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help

1 0