- ghc-commits - Haskell.org

[Git][ghc/ghc] Pushed new branch wip/27183
by Zubin (＠wz1000) 28 Apr '26

28 Apr '26

Zubin pushed new branch wip/27183 at Glasgow Haskell Compiler / GHC -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/tree/wip/27183 You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/T26989] 2 commits: Do not use mkCast during typechecking
by Simon Peyton Jones (＠simonpj) 28 Apr '26

28 Apr '26

Simon Peyton Jones pushed to branch wip/T26989 at Glasgow Haskell Compiler / GHC Commits: 9ec89815 by Simon Peyton Jones at 2026-04-28T11:48:38+01:00 Do not use mkCast during typechecking This commit fixes #27219. The problem was that the typechecker was using `mkCast`, whose assertion checks legitimately fail when applied to types that contain unification variables. - - - - - bd1503ad by Simon Peyton Jones at 2026-04-28T11:50:14+01:00 More improvements * pushCoValArg and pushCoTyArg return tyL, which is helpful for the caller * Don't optimise coercions if the type-substitution is empty. See Note [Optimising coercions] - - - - - 4 changed files: - compiler/GHC/Core/Opt/Arity.hs - compiler/GHC/Core/Opt/Simplify/Iteration.hs - compiler/GHC/Core/TyCo/Subst.hs - compiler/GHC/Tc/Types/Evidence.hs Changes: ===================================== compiler/GHC/Core/Opt/Arity.hs ===================================== @@ -2875,43 +2875,44 @@ pushCoArg :: CoercionR -> CoreArg -> Maybe (CoreArg, MCoercion) -- 'co' is always Representational pushCoArg co arg | Type ty <- arg - = do { (ty', m_co') <- pushCoTyArg co ty + = do { (_, ty', m_co') <- pushCoTyArg co ty ; return (Type ty', m_co') } | otherwise - = do { (arg_mco, m_co') <- pushCoValArg co + = do { (_, arg_mco, m_co') <- pushCoValArg co ; let arg_mco' = checkReflexiveMCo arg_mco -- checkReflexiveMCo: see Note [Check for reflexive casts in eta expansion] -- The coercion is very often (arg_co -> res_co), but without -- the argument coercion actually being ReflCo ; return (arg `mkCastMCo` arg_mco', m_co') } -pushCoTyArg :: CoercionR -> Type -> Maybe (Type, MCoercionR) +pushCoTyArg :: CoercionR -> Type -> Maybe (Type, Type, MCoercionR) -- We have (fun |> co) @ty -- Push the coercion through to return -- (fun @ty') |> co' -- 'co' is always Representational -- If the returned coercion is Nothing, then it would have been reflexive; -- it's faster not to compute it, though. -pushCoTyArg co ty +pushCoTyArg co arg_ty -- The following is inefficient - don't do `eqType` here, the coercion -- optimizer will take care of it. See #14737. -- -- | tyL `eqType` tyR -- -- = Just (ty, Nothing) - | isReflCo co - = Just (ty, MRefl) + | Just (ty, _) <- isReflCo_maybe co + = Just (ty, arg_ty, MRefl) | isForAllTy_ty tyL - = assertPpr (isForAllTy_ty tyR) (ppr co $$ ppr ty) $ - Just (ty `mkCastTy` co1, MCo co2) + = assertPpr (isForAllTy_ty tyR) (ppr co $$ ppr arg_ty) $ + Just (tyL, arg_ty `mkCastTy` co1, MCo co2) | otherwise = Nothing where - Pair tyL tyR = coercionKind co - -- co :: tyL ~R tyR - -- tyL = forall (a1 :: k1). ty1 - -- tyR = forall (a2 :: k2). ty2 + -- co :: tyL ~R tyR + -- tyL = forall (a1 :: k1). ty1 + -- tyR = forall (a2 :: k2). ty2 + tyL = coercionLKind co + tyR = coercionRKind co -- Used only in asssertions and debug messages co1 = mkSymCo (mkSelCo SelForAll co) -- co1 :: k2 ~N k1 @@ -2919,30 +2920,32 @@ pushCoTyArg co ty -- kinds of the types related by a coercion between forall-types. -- See the SelCo case in GHC.Core.Lint. - co2 = mkInstCo co (mkGReflLeftCo Nominal ty co1) - -- co2 :: ty1[ (ty|>co1)/a1 ] ~R ty2[ ty/a2 ] + co2 = mkInstCo co (mkGReflLeftCo Nominal arg_ty co1) + -- co2 :: ty1[ (arg_ty|>co1)/a1 ] ~R ty2[ arg_ty/a2 ] -- Arg of mkInstCo is always nominal, hence Nominal --- | If @pushCoValArg co = Just (co_arg, co_res)@, then +-- | If @pushCoValArg co = Just (tyL, co_arg, co_res)@, then -- --- > (\x.body) |> co = (\y. let { x = y |> co_arg } in body) |> co_res) +-- co :: tyL ~R# tyR +-- and +-- (\x.body) |> co = (\y. let { x = y |> co_arg } in body) |> co_res) -- -- or, equivalently -- --- > (fun |> co) arg = (fun (arg |> co_arg)) |> co_res +-- (fun |> co) arg = (fun (arg |> co_arg)) |> co_res -- -- If the LHS is well-typed, then so is the RHS. In particular, the argument -- @arg |> co_arg@ is guaranteed to have a fixed 'RuntimeRep', in the sense of -- Note [Fixed RuntimeRep] in GHC.Tc.Utils.Concrete. -pushCoValArg :: CoercionR -> Maybe (MCoercionR, MCoercionR) +pushCoValArg :: CoercionR -> Maybe (Type, MCoercionR, MCoercionR) pushCoValArg co -- The following is inefficient - don't do `eqType` here, the coercion -- optimizer will take care of it. See #14737. -- -- | tyL `eqType` tyR -- -- = Just (mkRepReflCo arg, Nothing) - | isReflCo co - = Just (MRefl, MRefl) + | Just (ty, _) <- isReflCo_maybe co + = Just (ty, MRefl, MRefl) | isFunTy tyL , (_, co1, co2) <- decomposeFunCo co @@ -2961,7 +2964,7 @@ pushCoValArg co (vcat [ text "co:" <+> ppr co , text "old_arg_ty:" <+> ppr old_arg_ty , text "new_arg_ty:" <+> ppr new_arg_ty ]) $ - Just (coToMCo (mkSymCo co1), coToMCo co2) + Just (tyL, coToMCo (mkSymCo co1), coToMCo co2) -- Critically, coToMCo to checks for ReflCo; the whole coercion may not -- be reflexive, but either of its components might be -- We could use isReflexiveCo, but it's not clear if the benefit @@ -2970,9 +2973,12 @@ pushCoValArg co | otherwise = Nothing where - old_arg_ty = funArgTy tyR + tyL = coercionLKind co new_arg_ty = funArgTy tyL - Pair tyL tyR = coercionKind co + + -- These two are used only in assertions and debug messages + tyR = coercionRKind co + old_arg_ty = funArgTy tyR pushCoercionIntoLambda :: HasDebugCallStack => InScopeSet -> Var -> CoreExpr -> CoercionR -> Maybe (Var, CoreExpr) ===================================== compiler/GHC/Core/Opt/Simplify/Iteration.hs ===================================== @@ -17,8 +17,7 @@ import GHC.Driver.Flags import GHC.Core import GHC.Core.Opt.Simplify.Monad import GHC.Core.Opt.ConstantFold -import GHC.Core.Type hiding ( substCo, substTy, substTyVar, extendTvSubst, extendCvSubst ) -import GHC.Core.TyCo.Compare( eqType ) +import GHC.Core.Opt.Stats ( Tick(..) ) import GHC.Core.Opt.Simplify.Env import GHC.Core.Opt.Simplify.Inline import GHC.Core.Opt.Simplify.Utils @@ -26,11 +25,14 @@ import GHC.Core.Opt.OccurAnal ( occurAnalyseExpr, zapLambdaBndrs ) import GHC.Core.Make ( FloatBind, mkImpossibleExpr, castBottomExpr ) import qualified GHC.Core.Make import GHC.Core.Coercion hiding ( substCo, substCoVar ) +import qualified GHC.Core.Coercion as Coercion import GHC.Core.Reduction import GHC.Core.Coercion.Opt ( optCoercion ) +import GHC.Core.Type hiding ( substCo, substTy, substTyVar, extendTvSubst, extendCvSubst ) +import GHC.Core.TyCo.Compare( eqType ) +import GHC.Core.TyCo.Subst( isEmptyTvSubst ) import GHC.Core.FamInstEnv ( FamInstEnv, topNormaliseType_maybe ) import GHC.Core.DataCon -import GHC.Core.Opt.Stats ( Tick(..) ) import GHC.Core.Ppr ( pprCoreExpr ) import GHC.Core.Unfold import GHC.Core.Unfold.Make @@ -1399,16 +1401,38 @@ simplCoercionF env co cont simplCoercion :: SimplEnv -> InCoercion -> SimplM OutCoercion simplCoercion env co - = do { let opt_co | reSimplifying env = substCo env co - | otherwise = optCoercion opts subst co - -- If (reSimplifying env) is True we have already simplified - -- this coercion once, and we don't want do so again; doing - -- so repeatedly risks non-linear behaviour - -- See Note [Inline depth] in GHC.Core.Opt.Simplify.Env - ; seqCo opt_co `seq` return opt_co } + = seqCo opt_co `seq` return opt_co where + -- See Note [Optimising coercions] + -- NB: substCo has a short-cut when both type and coercion substs are empty + opt_co | subst_only = Coercion.substCo subst co + | otherwise = optCoercion opts subst co + subst = getTCvSubst env opts = seOptCoercionOpts env + subst_only = isEmptyTvSubst subst || reSimplifying env + +{- Note [Optimising coercions] +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +Some programs have very big coercions and we'd like to avoid repeatedly +re-optimising them: + +* If the type-substitution is empty (common when no further transformations + are taking place) then there is generally no point in re-optimising. + If there is a type substitution, however, Refls may appear. + Example where this isEmptyTCvSubst test really helped: aT5030. + + Actually, if this is a "freshly-made" coercion (one built in the previous + iteration of the Simplifier, or a previous pass) then perhaps optimisations + /could/ occur; but we check for reflexivity in `rebuild_go`, and that's the + big win. Otherwise having a bigger-than necessary coercion is no so bad. + +* (reSimplifying env) is True we are in the body of an inlined function + so we (conservatively) and we don't want do so again; doing so repeatedly + risks non-linear behaviour. See Note [Inline depth] in GHC.Core.Opt.Simplify.Env. + + But if the inlining did a type substitution maybe we should re-optimise? +-} ----------------------------------- -- | Push a TickIt context outwards past applications and cases, as @@ -1742,6 +1766,9 @@ pushCast :: SimplEnv -> OutCoercion -> SimplCont -> SimplM SimplCont pushCast env co cont = go co True cont where + + -- ToDo: pushCast Refl (ApplylToVal arg1 (ApplyToVal arg2 ...)) + -- will do lots of unnecessary work. go :: OutCoercion -> Bool -> SimplCont -> SimplM SimplCont go co1 _ (CastIt { sc_co = co2, sc_cont = cont }) -- See Note [Optimising reflexivity] = go (mkTransCo co1 co2) False cont @@ -1749,12 +1776,12 @@ pushCast env co cont -- See Note [Avoid re-simplifying coercions] go co co_is_opt (ApplyToTy { sc_arg_ty = arg_ty, sc_cont = tail }) - | Just (arg_ty', m_co') <- pushCoTyArg co arg_ty + | Just (tyL, arg_ty', m_co') <- pushCoTyArg co arg_ty = {-#SCC "addCoerce-pushCoTyArg" #-} do { tail' <- go_mco m_co' co_is_opt tail ; return (ApplyToTy { sc_arg_ty = arg_ty' , sc_cont = tail' - , sc_hole_ty = coercionLKind co }) } + , sc_hole_ty = tyL }) } -- NB! As the cast goes past, the -- type of the hole changes (#16312) @@ -1768,16 +1795,14 @@ pushCast env co cont = -- pushCoValArg duplicates the coercion, so optimise first go (optOutCoercion (zapSubstEnv env) co co_is_opt) True cont --- ToDo: return coercionLKind. And similarly pushCoTyArg - - | Just (m_co1, m_co2) <- pushCoValArg co + | Just (tyL, m_co1, m_co2) <- pushCoValArg co = {-#SCC "addCoerce-pushCoValArg" #-} - do { tail' <- go_mco m_co2 co_is_opt tail + do { tail' <- go_mco m_co2 True tail ; return (ApplyToVal { sc_arg = arg , sc_env = arg_se , sc_cast = arg_mco `mkTransMCo` m_co1 , sc_cont = tail' - , sc_hole_ty = coercionLKind co }) } + , sc_hole_ty = tyL }) } go co co_is_opt cont | isReflCo co = return cont -- Having this at the end makes a huge @@ -1785,8 +1810,6 @@ pushCast env co cont -- See Note [Optimising reflexivity] | otherwise = return (CastIt { sc_co = co, sc_opt = co_is_opt, sc_cont = cont }) --- ToDo: pushCast Refl (ApplylToVal arg1 (ApplyToVal arg2 ...)) will do lots of unnecessary work. - -- If the first parameter is MRefl, then simplifying revealed a -- reflexive coercion. Omit. go_mco :: MOutCoercion -> Bool -> SimplCont -> SimplM SimplCont ===================================== compiler/GHC/Core/TyCo/Subst.hs ===================================== @@ -12,7 +12,7 @@ module GHC.Core.TyCo.Subst -- * Substitutions Subst(..), TvSubstEnv, CvSubstEnv, IdSubstEnv, emptyIdSubstEnv, emptyTvSubstEnv, emptyCvSubstEnv, composeTCvSubst, - emptySubst, mkEmptySubst, isEmptyTCvSubst, isEmptySubst, + emptySubst, mkEmptySubst, isEmptyTvSubst, isEmptyTCvSubst, isEmptySubst, mkSubst, mkTCvSubst, mkTvSubst, mkCvSubst, mkIdSubst, getTvSubstEnv, getIdSubstEnv, getCvSubstEnv, substInScopeSet, setInScope, getSubstRangeTyCoFVs, @@ -262,6 +262,11 @@ isEmptySubst :: Subst -> Bool isEmptySubst (Subst _ id_env tv_env cv_env) = isEmptyVarEnv id_env && isEmptyVarEnv tv_env && isEmptyVarEnv cv_env +-- | Checks if the type substitution (only) is empty +isEmptyTvSubst :: Subst -> Bool +isEmptyTvSubst (Subst _ _ tv_env _) + = isEmptyVarEnv tv_env + -- | Checks whether the tyvar and covar environments are empty. -- This function should be used over 'isEmptySubst' when substituting -- for types, because types currently do not contain expressions; we can ===================================== compiler/GHC/Tc/Types/Evidence.hs ===================================== @@ -59,7 +59,6 @@ import GHC.Tc.Utils.TcType import GHC.Core import GHC.Core.Coercion.Axiom import GHC.Core.Coercion -import GHC.Core.Utils( mkCast ) import GHC.Core.Ppr () -- Instance OutputableBndr TyVar import GHC.Core.Predicate import GHC.Core.Type @@ -932,7 +931,8 @@ evCastE ee co | assertPpr (coercionRole co == Representational) (vcat [text "Coercion of wrong role passed to evCastE:", ppr ee, ppr co]) $ isReflCo co = ee - | otherwise = mkCast ee co + | otherwise = Cast ee co -- Do not call mkCast because its assertion + -- checks fail on un-zonked terms (#27219) evDFunApp :: DFunId -> [Type] -> [EvExpr] -> EvTerm -- Dictionary instance application, including when the "dictionary function" View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/9bbd56e8ba16b562d10b5b94d92dbc… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/9bbd56e8ba16b562d10b5b94d92dbc… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/jeltsch/more-efficient-home-unit-imports-finding.with-debugging] WIP: fix failing test boot1 and multipleHomeUnits_reexport
by Hannes Siebenhandl (＠fendor) 28 Apr '26

28 Apr '26

Hannes Siebenhandl pushed to branch wip/jeltsch/more-efficient-home-unit-imports-finding.with-debugging at Glasgow Haskell Compiler / GHC Commits: 862cd76a by fendor at 2026-04-28T11:26:02+02:00 WIP: fix failing test boot1 and multipleHomeUnits_reexport - - - - - 1 changed file: - compiler/GHC/Unit/Finder.hs Changes: ===================================== compiler/GHC/Unit/Finder.hs ===================================== @@ -214,7 +214,6 @@ findImportedModuleNoHsc fc fopts ue complete_home_units mb_home_unit mod_name mb | otherwise -> pprPanic "findImportModule" (ppr mod_name $$ ppr mb_pkg $$ ppr (homeUnitId <$> mb_home_unit) $$ ppr uid $$ ppr (map fst all_opts)) OtherPkg _ -> pkg_import where - cached_module_providers = M.findWithDefault Set.empty mod_name (cu_providers complete_home_units) mb_home_unit_id = homeUnitId <$> mb_home_unit all_opts = case mb_home_unit_id of Nothing -> other_fopts @@ -249,42 +248,42 @@ findImportedModuleNoHsc fc fopts ue complete_home_units mb_home_unit mod_name mb units = case mb_home_unit_id of Nothing -> ue_homeUnitState ue Just home_unit_id -> HUG.homeUnitEnv_units $ ue_findHomeUnitEnv home_unit_id ue + hpt_deps :: Set.Set UnitId hpt_deps = homeUnitDepends units + + -- TODO: this predicate is wrong, we need something more focused + sorted_deps = case finder_lookupHomeInterfaces fopts of + True -> Set.toList hpt_deps + False -> sortHomeUnitsByLikelihoodFor complete_home_units mb_home_unit_id mod_name hpt_deps + + other_fopts = + [ (uid, initFinderOpts (homeUnitEnv_dflags (ue_findHomeUnitEnv uid ue))) + | uid <- sorted_deps + ] + +sortHomeUnitsByLikelihoodFor :: CompleteUnits -> Maybe UnitId -> ModuleName -> Set.Set UnitId -> [UnitId] +sortHomeUnitsByLikelihoodFor complete_home_units mb_home_unit_id mod_name hpt_deps = + let + cached_module_providers = M.findWithDefault Set.empty mod_name (cu_providers complete_home_units) cached_providing_deps = Set.intersection cached_module_providers hpt_deps other_cached_providing_deps = Set.toList $ maybe cached_providing_deps (\u -> Set.delete u cached_providing_deps) mb_home_unit_id uncached_providing_deps = - let candidates = Set.difference hpt_deps (cu_inventory complete_home_units) + let candidates = Set.difference hpt_deps cached_module_providers excluded = maybe cached_providing_deps (\u -> Set.insert u cached_providing_deps) mb_home_unit_id in Set.toList (Set.difference candidates excluded) - other_providing_deps = other_cached_providing_deps ++ uncached_providing_deps - other_fopts = - [ (uid, initFinderOpts (homeUnitEnv_dflags (ue_findHomeUnitEnv uid ue))) - | uid <- other_providing_deps - ] - !() = pprTrace "findImportedModuleNoHsc" (vcat lines) () where - - lines = [ - -- text "complete_home_units" <+> ppr complete_home_units, - -- text "mb_home_unit " <+> ppr mb_home_unit, - text "mod_name:" <+> ppr mod_name, - text "cached_module_providers:" <+> ppr cached_module_providers, - text "mb_home_unit_id:" <+> ppr mb_home_unit_id, - -- text "all_opts:" <+> ppr all_opts, - -- text "any_home_import:" <+> ppr any_home_import, - -- text "pkg_import:" <+> ppr pkg_import , - -- text "unqual_import:" <+> ppr unqual_import, - -- text "units:" <+> ppr units , - text "hpt_deps:" <+> ppr hpt_deps, - text "cached_providing_deps:" <+> ppr cached_providing_deps, - text "other_cached_providing_deps:" <+> ppr other_cached_providing_deps, - text "uncached_providing_deps:" <+> ppr uncached_providing_deps, - text "other_providing_deps:" <+> ppr other_providing_deps - -- text "other_fopts:" <+> ppr other_fopts - ] + all_deps = other_cached_providing_deps ++ uncached_providing_deps + in + assertPpr + (hpt_deps == Set.fromList all_deps) + ( text "Sorting must not remove HomeUnits" + $$ text "Module:" <+> ppr mod_name + $$ text "Original:" <+> ppr hpt_deps + $$ text "Sorted: " <+> ppr (Set.fromList all_deps)) + all_deps -- | Locate a plugin module requested by the user, for a compiler -- plugin. This consults the same set of exposed packages as View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/862cd76afdafce25019b79d918e63ad… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/862cd76afdafce25019b79d918e63ad… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/jeltsch/more-efficient-home-unit-imports-finding.with-debugging] WIP: fix failing test boot1 and multipleHomeUnits_reexport
by Hannes Siebenhandl (＠fendor) 28 Apr '26

28 Apr '26

Hannes Siebenhandl pushed to branch wip/jeltsch/more-efficient-home-unit-imports-finding.with-debugging at Glasgow Haskell Compiler / GHC Commits: 0c895a8d by fendor at 2026-04-28T11:24:23+02:00 WIP: fix failing test boot1 and multipleHomeUnits_reexport - - - - - 1 changed file: - compiler/GHC/Unit/Finder.hs Changes: ===================================== compiler/GHC/Unit/Finder.hs ===================================== @@ -214,7 +214,6 @@ findImportedModuleNoHsc fc fopts ue complete_home_units mb_home_unit mod_name mb | otherwise -> pprPanic "findImportModule" (ppr mod_name $$ ppr mb_pkg $$ ppr (homeUnitId <$> mb_home_unit) $$ ppr uid $$ ppr (map fst all_opts)) OtherPkg _ -> pkg_import where - cached_module_providers = M.findWithDefault Set.empty mod_name (cu_providers complete_home_units) mb_home_unit_id = homeUnitId <$> mb_home_unit all_opts = case mb_home_unit_id of Nothing -> other_fopts @@ -249,42 +248,41 @@ findImportedModuleNoHsc fc fopts ue complete_home_units mb_home_unit mod_name mb units = case mb_home_unit_id of Nothing -> ue_homeUnitState ue Just home_unit_id -> HUG.homeUnitEnv_units $ ue_findHomeUnitEnv home_unit_id ue + hpt_deps :: Set.Set UnitId hpt_deps = homeUnitDepends units + + sorted_deps = case finder_lookupHomeInterfaces fopts of + True -> Set.toList hpt_deps + False -> sortHomeUnitsByLikelihoodFor complete_home_units mb_home_unit_id mod_name hpt_deps + + other_fopts = + [ (uid, initFinderOpts (homeUnitEnv_dflags (ue_findHomeUnitEnv uid ue))) + | uid <- sorted_deps + ] + +sortHomeUnitsByLikelihoodFor :: CompleteUnits -> Maybe UnitId -> ModuleName -> Set.Set UnitId -> [UnitId] +sortHomeUnitsByLikelihoodFor complete_home_units mb_home_unit_id mod_name hpt_deps = + let + cached_module_providers = M.findWithDefault Set.empty mod_name (cu_providers complete_home_units) cached_providing_deps = Set.intersection cached_module_providers hpt_deps other_cached_providing_deps = Set.toList $ maybe cached_providing_deps (\u -> Set.delete u cached_providing_deps) mb_home_unit_id uncached_providing_deps = - let candidates = Set.difference hpt_deps (cu_inventory complete_home_units) + let candidates = Set.difference hpt_deps cached_module_providers excluded = maybe cached_providing_deps (\u -> Set.insert u cached_providing_deps) mb_home_unit_id in Set.toList (Set.difference candidates excluded) - other_providing_deps = other_cached_providing_deps ++ uncached_providing_deps - other_fopts = - [ (uid, initFinderOpts (homeUnitEnv_dflags (ue_findHomeUnitEnv uid ue))) - | uid <- other_providing_deps - ] - !() = pprTrace "findImportedModuleNoHsc" (vcat lines) () where - - lines = [ - -- text "complete_home_units" <+> ppr complete_home_units, - -- text "mb_home_unit " <+> ppr mb_home_unit, - text "mod_name:" <+> ppr mod_name, - text "cached_module_providers:" <+> ppr cached_module_providers, - text "mb_home_unit_id:" <+> ppr mb_home_unit_id, - -- text "all_opts:" <+> ppr all_opts, - -- text "any_home_import:" <+> ppr any_home_import, - -- text "pkg_import:" <+> ppr pkg_import , - -- text "unqual_import:" <+> ppr unqual_import, - -- text "units:" <+> ppr units , - text "hpt_deps:" <+> ppr hpt_deps, - text "cached_providing_deps:" <+> ppr cached_providing_deps, - text "other_cached_providing_deps:" <+> ppr other_cached_providing_deps, - text "uncached_providing_deps:" <+> ppr uncached_providing_deps, - text "other_providing_deps:" <+> ppr other_providing_deps - -- text "other_fopts:" <+> ppr other_fopts - ] + all_deps = other_cached_providing_deps ++ uncached_providing_deps + in + assertPpr + (hpt_deps == Set.fromList all_deps) + ( text "Sorting must not remove HomeUnits" + $$ text "Module:" <+> ppr mod_name + $$ text "Original:" <+> ppr hpt_deps + $$ text "Sorted: " <+> ppr (Set.fromList all_deps)) + all_deps -- | Locate a plugin module requested by the user, for a compiler -- plugin. This consults the same set of exposed packages as View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/0c895a8da89e0534e901b36238f232b… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/0c895a8da89e0534e901b36238f232b… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][ghc-10.0] Replace GHC 9.16 references with GHC 10.0
by Zubin (＠wz1000) 28 Apr '26

28 Apr '26

Zubin pushed to branch ghc-10.0 at Glasgow Haskell Compiler / GHC Commits: 53fd9e34 by Vladislav Zavialov at 2026-04-27T22:00:02+03:00 Replace GHC 9.16 references with GHC 10.0 - - - - - 10 changed files: - compiler/GHC/Driver/Flags.hs - docs/users_guide/debug-info.rst - docs/users_guide/exts/explicit_namespaces.rst - docs/users_guide/exts/linear_types.rst - docs/users_guide/exts/modifiers.rst - docs/users_guide/exts/qualified_strings.rst - docs/users_guide/exts/required_type_arguments.rst - docs/users_guide/using-warnings.rst - docs/users_guide/using.rst - testsuite/tests/typecheck/should_fail/all.T Changes: ===================================== compiler/GHC/Driver/Flags.hs ===================================== @@ -1112,9 +1112,9 @@ data WarningFlag = -- ^ @since 9.14, scheduled to be removed in 9.18 -- -- See Note [Quantifying over equalities in RULES] in GHC.Tc.Gen.Sig - | Opt_WarnUnusableUnpackPragmas -- Since 9.14 - | Opt_WarnPatternNamespaceSpecifier -- Since 9.14 - | Opt_WarnUnrecognisedModifiers -- ^ @since 9.16 + | Opt_WarnUnusableUnpackPragmas -- ^ @since 9.14 + | Opt_WarnPatternNamespaceSpecifier -- ^ @since 9.14 + | Opt_WarnUnrecognisedModifiers -- ^ @since 10.0 deriving (Eq, Ord, Show, Enum, Bounded) -- | Return the names of a WarningFlag @@ -1377,7 +1377,7 @@ standardWarnings -- see Note [Documenting warning flags] Opt_WarnTypeEqualityRequiresOperators, Opt_WarnInconsistentFlags, Opt_WarnTypeEqualityOutOfScope, - Opt_WarnImplicitRhsQuantification, -- was in -Wcompat since 9.8, enabled by default since 9.14, to turn into a hard error in 9.16 + Opt_WarnImplicitRhsQuantification, -- was in -Wcompat since 9.8, enabled by default since 9.14, to turn into a hard error in 10.2 (#25911) Opt_WarnViewPatternSignatures, Opt_WarnUselessSpecialisations, Opt_WarnDeprecatedPragmas, ===================================== docs/users_guide/debug-info.rst ===================================== @@ -478,7 +478,7 @@ to a source location. This lookup table is generated by using the ``-finfo-table :type: dynamic :category: debugging - :since: 9.16 + :since: 10.0 Disable generation of distinct info tables for all constructors. @@ -488,7 +488,7 @@ to a source location. This lookup table is generated by using the ``-finfo-table :type: dynamic :category: debugging - :since: 9.16 + :since: 10.0 The entries in the info table map resulting from :ghc-flag:`-fdistinct-constructor-tables` flag may significantly ===================================== docs/users_guide/exts/explicit_namespaces.rst ===================================== @@ -121,7 +121,7 @@ there is a need to support older GHC versions. Wildcards in import/export lists ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -**Since:** GHC 9.16 +**Since:** GHC 10.0 Namespace-specified wildcards ``type ..`` and ``data ..`` may be used to import all names in the corresponding namespace from a module: :: ===================================== docs/users_guide/exts/linear_types.rst ===================================== @@ -318,7 +318,7 @@ hidden; it is an essential part of the exposed interface.) Interaction with Modifiers -------------------------- -Since GHC version 9.16, Linear types use :extension:`Modifiers` syntax, and by +Since GHC version 10.0, Linear types use :extension:`Modifiers` syntax, and by default enable that extension. In earlier versions, linear types used a more restricted variant of that syntax. ===================================== docs/users_guide/exts/modifiers.rst ===================================== @@ -6,7 +6,7 @@ Modifiers .. extension:: Modifiers :shortdesc: Allow experimental modifier syntax. - :since: 9.16 + :since: 10.0 :status: Experimental Enable modifier syntax in various places, such as arrows (``a %m -> b``) and @@ -138,10 +138,10 @@ and limitations. let %1 (Just x) = ... -- (2b) let %1 !(Just x) = ... -- (2c) - In 9.14, (1a) and (2a) parsed as (1b) and (2b) respectively. From 9.16, (1a) + In 9.14, (1a) and (2a) parsed as (1b) and (2b) respectively. From 10.0, (1a) parses as (1d), and (2a) fails to parse. - Note that linear bindings must be strict. (1c) and (2c) parse in 9.16 the same + Note that linear bindings must be strict. (1c) and (2c) parse in 10.0 the same as in 9.14. But with ``-XStrict`` enabled, (1a) and (2a) would previously have been accepted, and are now rejected, even with ``-XLinearTypes -XNoModifiers``. ===================================== docs/users_guide/exts/qualified_strings.rst ===================================== @@ -6,7 +6,7 @@ Qualified string literals .. extension:: QualifiedStrings :shortdesc: Enable qualified string literals. - :since: 9.16.1 + :since: 10.0.1 Enable qualified string literals. ===================================== docs/users_guide/exts/required_type_arguments.rst ===================================== @@ -303,7 +303,7 @@ A few limitations apply: * In term syntax, in positions where ``*`` is a direct argument to ``->``, e.g. in ``f (* -> * -> *)`` and ``f (* -> Constraint)``, the ``*``\s stand for ``Type``, provided the :extension:`StarIsType` extension is enabled. - This is supported from GHC 9.16 onwards; earlier versions will produce + This is supported from GHC 10.0 onwards; earlier versions will produce a parse error. What to do instead: use ``Type`` from the ``Data.Kind`` module. ===================================== docs/users_guide/using-warnings.rst ===================================== @@ -2711,7 +2711,7 @@ of ``-W(no-)*``. :type: dynamic :reverse: -Wno-unrecognised-modifiers - :since: 9.16 + :since: 10.0 :default: on ===================================== docs/users_guide/using.rst ===================================== @@ -1618,7 +1618,7 @@ Some flags only make sense for particular target platforms. :type: dynamic :category: platform-options - :since: 9.16.1 + :since: 10.0.1 :implies: :ghc-flag:`-mavx512f` (x86 only) This flag allows the code generator (whether the :ref:`native code generator <native-code-gen>` @@ -1639,7 +1639,7 @@ Some flags only make sense for particular target platforms. :type: dynamic :category: platform-options - :since: 9.16.1 + :since: 10.0.1 :implies: :ghc-flag:`-mavx512f` (x86 only) This flag allows the code generator (whether the :ref:`native code generator <native-code-gen>` @@ -1684,7 +1684,7 @@ Some flags only make sense for particular target platforms. :type: dynamic :category: platform-options - :since: 9.16.1 + :since: 10.0.1 :implies: :ghc-flag:`-mavx512f` (x86 only) This flag allows the code generator (whether the :ref:`native code generator <native-code-gen>` @@ -1823,7 +1823,7 @@ Some flags only make sense for particular target platforms. :type: dynamic :category: platform-options - :since: 9.16.1 + :since: 10.0.1 (x86 only) This flag allows the code generator (whether the :ref:`native code generator <native-code-gen>` or the :ref:`LLVM backend <llvm-code-gen>`) to emit x86 GFNI instructions. ===================================== testsuite/tests/typecheck/should_fail/all.T ===================================== @@ -720,7 +720,7 @@ test('T17940', normal, compile_fail, ['']) test('ErrorIndexLinks', normal, compile_fail, ['-fprint-error-index-links=always']) test('T24064', normal, compile_fail, ['']) test('T24090a', normal, compile_fail, ['']) -test('T24090b', normal, compile, ['']) # scheduled to become an actual error in GHC 9.16 +test('T24090b', normal, compile, ['']) # scheduled to become an actual error in GHC 10.2 (#25911) test('T24298', normal, compile_fail, ['']) test('T24279', normal, compile, ['']) # Now accepted (Nov 2025) test('T24318', normal, compile_fail, ['']) View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/53fd9e344713c2d826ba62a9c07d6c4… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/53fd9e344713c2d826ba62a9c07d6c4… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/andreask/split-driver-main] Split GHC.Driver.Main.hs up into multiple components.
by Andreas Klebinger (＠AndreasK) 28 Apr '26

28 Apr '26

Andreas Klebinger pushed to branch wip/andreask/split-driver-main at Glasgow Haskell Compiler / GHC Commits: 24a04f05 by Andreas Klebinger at 2026-04-28T09:13:40+02:00 Split GHC.Driver.Main.hs up into multiple components. This commit splits GHC.Driver.Main into four components: * GHC.Driver.Main.Compile * GHC.Driver.Main.Hsc * GHC.Driver.Main.Interactive * GHC.Driver.Main.Passes We might improve that separation further in the future but this should hopefully make it easier to reason about and work with this part of the code. - - - - - 15 changed files: - compiler/GHC/Driver/Backpack.hs - compiler/GHC/Driver/Env/Types.hs - compiler/GHC/Driver/Main.hs - + compiler/GHC/Driver/Main/Compile.hs - compiler/GHC/Driver/Main.hs-boot → compiler/GHC/Driver/Main/Compile.hs-boot - + compiler/GHC/Driver/Main/Hsc.hs - + compiler/GHC/Driver/Main/Interactive.hs - + compiler/GHC/Driver/Main/Passes.hs - + compiler/GHC/Driver/Main/Passes.hs-boot - compiler/GHC/Iface/Load.hs - compiler/GHC/Iface/Tidy.hs - compiler/GHC/Types/Error.hs - compiler/GHC/Types/Error.hs-boot - compiler/ghc.cabal.in - testsuite/tests/linters/notes.stdout The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/24a04f052e081d627784a2f41170ea6… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/24a04f052e081d627784a2f41170ea6… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/T26989] Wibbles
by Simon Peyton Jones (＠simonpj) 28 Apr '26

28 Apr '26

Simon Peyton Jones pushed to branch wip/T26989 at Glasgow Haskell Compiler / GHC Commits: 9bbd56e8 by Simon Peyton Jones at 2026-04-27T23:54:56+01:00 Wibbles - - - - - 4 changed files: - compiler/GHC/Core/Coercion.hs - compiler/GHC/Core/Opt/Arity.hs - compiler/GHC/Core/Opt/Simplify/Iteration.hs - compiler/GHC/Core/Opt/Simplify/Utils.hs Changes: ===================================== compiler/GHC/Core/Coercion.hs ===================================== @@ -426,7 +426,8 @@ decomposeFunCo :: HasDebugCallStack decomposeFunCo (FunCo { fco_mult = w, fco_arg = co1, fco_res = co2 }) = (w, co1, co2) - -- Short-circuits the calls to mkSelCo + -- Fast path that short-circuits the calls to mkSelCo, + -- even though they would give the exact same answers decomposeFunCo co = assertPpr all_ok (ppr co) $ ===================================== compiler/GHC/Core/Opt/Arity.hs ===================================== @@ -2691,10 +2691,11 @@ same fix. -- | `tryEtaReduce [x,y,z] e sd` returns `Just e'` if `\x y z -> e` is evaluated -- according to `sd` and can soundly and gainfully be eta-reduced to `e'`. --- See Note [Eta reduction soundness] --- and Note [Eta reduction makes sense] when that is the case. tryEtaReduce :: UnVarSet -> [Var] -> CoreExpr -> SubDemand -> Maybe CoreExpr -- Return an expression equal to (\bndrs. body) +-- See Note [Eta reduction soundness] +-- and Note [Eta reduction makes sense] when that is the case. +-- and Note [Eta reduction based on evaluation context] for the `eval_sd` arg tryEtaReduce rec_ids bndrs body eval_sd = go (reverse bndrs) body (mkRepReflCo (exprType body)) where ===================================== compiler/GHC/Core/Opt/Simplify/Iteration.hs ===================================== @@ -1729,10 +1729,15 @@ optOutCoercion env co already_optimised opts = seOptCoercionOpts env addCastMCo :: MOutCoercion -> SimplCont -> SimplCont --- Simpler version of `pushCast` when optionally want to add a cast to the top +-- Simpler, non-monadic version of pushCastMCo when we are certain that +-- the cast should be at the top; i.e. cont is Stop or StrictArg addCastMCo MRefl cont = cont addCastMCo (MCo co) cont = CastIt { sc_co = co, sc_opt = False, sc_cont = cont } +pushCastMCo :: SimplEnv -> MOutCoercion -> SimplCont -> SimplM SimplCont +pushCastMCo _env MRefl cont = return cont +pushCastMCo env (MCo co) cont = pushCast env co cont + pushCast :: SimplEnv -> OutCoercion -> SimplCont -> SimplM SimplCont pushCast env co cont = go co True cont @@ -1753,7 +1758,7 @@ pushCast env co cont -- NB! As the cast goes past, the -- type of the hole changes (#16312) - -- (f |> co) e ===> (f (e |> co1)) |> co2 + -- (f |> co) arg ===> (f (arg |> co1)) |> co2 -- where co :: (s1->s2) ~ (t1->t2) -- co1 :: t1 ~ s1 -- co2 :: s2 ~ t2 @@ -1763,12 +1768,14 @@ pushCast env co cont = -- pushCoValArg duplicates the coercion, so optimise first go (optOutCoercion (zapSubstEnv env) co co_is_opt) True cont +-- ToDo: return coercionLKind. And similarly pushCoTyArg + | Just (m_co1, m_co2) <- pushCoValArg co = {-#SCC "addCoerce-pushCoValArg" #-} do { tail' <- go_mco m_co2 co_is_opt tail ; return (ApplyToVal { sc_arg = arg , sc_env = arg_se - , sc_cast = m_co1 `mkTransMCo` arg_mco + , sc_cast = arg_mco `mkTransMCo` m_co1 , sc_cont = tail' , sc_hole_ty = coercionLKind co }) } @@ -1778,6 +1785,7 @@ pushCast env co cont -- See Note [Optimising reflexivity] | otherwise = return (CastIt { sc_co = co, sc_opt = co_is_opt, sc_cont = cont }) +-- ToDo: pushCast Refl (ApplylToVal arg1 (ApplyToVal arg2 ...)) will do lots of unnecessary work. -- If the first parameter is MRefl, then simplifying revealed a -- reflexive coercion. Omit. @@ -2295,7 +2303,8 @@ simplInId env var cont | otherwise = case substId env var of ContEx se e mco - -> simplExprF (se `setInScopeFromE` env) e (addCastMCo mco cont) + -> do { cont' <- pushCastMCo env mco cont + ; simplExprF (se `setInScopeFromE` env) e cont' } -- Don't trimJoinCont; haven't already simplified e, -- so the cont is not embodied in e @@ -2393,10 +2402,12 @@ simplOutId env fun cont _ -> do { s' <- newId (fsLit "s") ManyTy realWorldStatePrimTy ; let (m,_,_) = splitFunTy fun_ty env' = arg_env `addNewInScopeIds` [s'] - cont' = addCastMCo arg_mco $ - ApplyToVal { sc_arg = Var s', sc_cast = MRefl - , sc_env = Simplified OkDup, sc_cont = inner_cont - , sc_hole_ty = mkVisFunTy m realWorldStatePrimTy new_runrw_res_ty } + hole_ty = mkVisFunTy m realWorldStatePrimTy new_runrw_res_ty + ; cont' <- pushCastMCo env' arg_mco $ + ApplyToVal { sc_arg = Var s', sc_cast = MRefl + , sc_env = Simplified OkDup + , sc_cont = inner_cont + , sc_hole_ty = hole_ty } -- cont' applies to s', then K ; body' <- simplExprC env' arg cont' ; return (Lam s' body') } ===================================== compiler/GHC/Core/Opt/Simplify/Utils.hs ===================================== @@ -620,26 +620,33 @@ dropContArgs n cont = pprPanic "dropContArgs" (ppr n $$ ppr cont) -- For example, when simplifying the argument `e` in `f e` and `f` has the -- demand signature `<MP(S,A)>`, this function will give you back `P(S,A)` when -- simplifying `e`. --- --- PRECONDITION: Don't call with 'ApplyToVal'. We haven't thoroughly thought --- about what to do then and no call sites so far seem to care. -contEvalContext :: SimplCont -> SubDemand -contEvalContext k = case k of - Stop _ _ sd -> sd - TickIt _ k -> contEvalContext k - CastIt { sc_cont = k } -> contEvalContext k - ApplyToTy{ sc_cont = k } -> contEvalContext k - -- ApplyToVal{sc_cont=k} -> mkCalledOnceDmd $ contEvalContext k +contEvalContext :: [Var] -> SimplCont -> SubDemand +contEvalContext bndrs cont = go cont + where + go (Stop _ _ sd) = sd + go (TickIt _ k) = go k + go (CastIt { sc_cont = k }) = go k + go (ApplyToTy{ sc_cont = k }) = go k + + -- The ApplyToVal case can actually happen, if we have + -- (CastIt co (ApplyToVal ..)) + -- Possible code: + -- go (ApplyToVal{sc_cont=k}) = mkCalledOnceDmd $ contEvalContext k -- Not 100% sure that's correct, . Here's an example: -- f (e x) and f :: <SC(S,C(1,L))> -- then what is the evaluation context of 'e' when we simplify it? E.g., -- simpl e (ApplyToVal x $ Stop "C(S,C(1,L))") -- then it *should* be "C(1,C(S,C(1,L))", so perhaps correct after all. - -- But for now we just panic: - ApplyToVal{} -> pprPanic "contEvalContext" (ppr k) - StrictArg{sc_fun=fun_info} -> subDemandIfEvaluated (Partial.head (ai_dmds fun_info)) - StrictBind{sc_bndr=bndr} -> subDemandIfEvaluated (idDemandInfo bndr) - Select{} -> topSubDmd + -- But for now we just return topDmd. + go (ApplyToVal{ sc_arg = arg }) = warnPprTrace True "contEvalContext" + (vcat [ text "arg:" <+> ppr arg + , text "bndrs:" <+> ppr bndrs + , text "cont:" <+> ppr cont ]) + topSubDmd + + go (StrictArg{sc_fun=fun_info}) = subDemandIfEvaluated (Partial.head (ai_dmds fun_info)) + go (StrictBind{sc_bndr=bndr}) = subDemandIfEvaluated (idDemandInfo bndr) + go (Select{}) = topSubDmd -- Perhaps reconstruct the demand on the scrutinee by looking at field -- and case binder dmds, see addCaseBndrDmd. No priority right now. @@ -1957,9 +1964,7 @@ rebuildLam env bndrs@(bndr:_) body cont mb_rhs = contIsRhs cont -- See Note [Eta reduction based on evaluation context] - eval_sd = contEvalContext cont - -- NB: cont is never ApplyToVal, because beta-reduction would - -- have happened. So contEvalContext can panic on ApplyToVal. + eval_sd = contEvalContext bndrs cont try_eta :: [OutBndr] -> OutExpr -> SimplM OutExpr try_eta bndrs body View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/9bbd56e8ba16b562d10b5b94d92dbc0… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/9bbd56e8ba16b562d10b5b94d92dbc0… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 9 commits: ghc: Distinguish between having an interpreter and having an internal one
by Marge Bot (＠marge-bot) 28 Apr '26

28 Apr '26

Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC Commits: adadb4d7 by Sven Tennie at 2026-04-27T16:08:41-04:00 ghc: Distinguish between having an interpreter and having an internal one Actually, these are related but different things: - ghc can run an interpreter (either internal or external) - ghc is compiled with an internal interpreter Splitting the logic solves compiler warnings and expresses the intent better. - - - - - 4a07935b by Vladislav Zavialov at 2026-04-27T16:08:42-04:00 Refactor HsWildCardTy to use HoleKind (#27111) The payload of this patch is that the extension fields of HsWildCardTy and HsHole now match: type instance XWildCardTy Ghc{Ps,Rn} = HoleKind type instance XHole Ghc{Ps,Rn} = HoleKind This is progress towards unification of HsExpr and HsType. Test case: T25121_status In addition to that, exact-printing of infix holes is fixed. Test case: PprInfixHole - - - - - 96b1c440 by Vladislav Zavialov at 2026-04-27T16:08:43-04:00 Move NamespaceSpecifier from x-fields into the AST proper (#26678) This refactoring moves NamespaceSpecifier out of extension fields and into the AST proper, as it is part of the user-written source, and is not pass-specific. Summary of changes: * Move NamespaceSpecifier from GHC/Hs/Basic.hs to Language/Haskell/Syntax/ImpExp.hs and parameterise it by the compiler pass, creating the necessary extension points * Move NamespaceSpecifier out of XFixitySig into FixitySig * Move NamespaceSpecifier out of XIEThingAll (IEThingAllExt) into IEThingAll * Move NamespaceSpecifier out of XIEWholeNamespace (IEWholeNamespaceExt) into IEWholeNamespace This is a pure refactoring with no change in behaviour. - - - - - b75f59be by Wen Kokke at 2026-04-27T16:08:47-04:00 rts: Add dynamic trace flags API This commit adds an API to the RTS (exposed via Rts.h) that allows users to dynamically change the trace flags. Prior to this commit, users were able to stop and start the profiling and heap profiling timers (via startProfTimer/stopProfTimer and startHeapProfTimer/stopHeapProfTimer). This extends that functionality to also cover the core event types. The getTraceFlag/setTraceFlag functions read and write the values of the trace flag cache, which is allocated by Trace.c, rather than modifying the members of RtsFlags.TraceFlags. This is done under the assumption that the members of RtsFlags should not be modified after RTS initialisation. Consequently, if the user modifies the trace flags using setTraceFlag, the object returned by getTraceFlags (from base) will not reflect these changes. The trace flags are not protected by locks of any sort. Hence, these functions are not thread-safe. However, the trace flags are not modified by the RTS after initialisation, only read, so the race conditions introduced by one user modifying them are most likely benign. This PR also puts the trace flag cache in a single global struct, as opposed to a collection of global variables, and changes the types of the individual flags from uint8_t to bool, as these have the same size on both Clang and GCC and are a better semantic match. Prior to the change to uint8_t, they had type int, see 42c47cd6. Even with its deprecation in C23, I don't think there should be any issue depending on stdbool.h. The TRACE_X macros are redefined to access the global struct, with values cast to const bool to ensure they are read-only. - - - - - 225e8279 by Wen Kokke at 2026-04-27T16:08:47-04:00 rts: Ensure TRACE_X values are used in place of RtsFlags.TraceFlags.X - - - - - e2637b60 by Wen Kokke at 2026-04-27T16:08:47-04:00 rts: Fix nonmoving-GC tracing The current nonmoving-GC tracing functions were written in a different style from the other tracing functions. They were directly implemented as, e.g., a traceConcMarkEnd function that called postConcMarkEnd. The other tracing functions are implemented as, e.g., traceThreadLabel_, a function that posts the thread label event, and traceThreadLabel, a macro that checks whether TRACE_scheduler is set. This commit fixes that implementation, and ensures that the nonmoving-GC tracing functions only emit events if nonmoving-GC tracing is enabled. - - - - - 868fe8e8 by Wen Kokke at 2026-04-27T16:08:47-04:00 rts: Add SymI_HasProto for get/setTraceFlag - - - - - 04f27095 by Wen Kokke at 2026-04-27T16:08:47-04:00 rts: Add SymI_HasProto for start/endEventLogging - - - - - e326cd4c by Simon Peyton Jones at 2026-04-27T16:08:48-04:00 Fix assertion check in checkResultTy As #27210 shows, the assertion was a little bit too eager. I refactored a bit by moving some code from GHC.Tc.Gen.App to GHC.Tc.Utils.Unify; see the new function tcSubTypeApp, which replaces tcSubTypeDS - - - - - 60 changed files: - + changelog.d/T19174.md - + changelog.d/ghc-api-holes-ast-27111 - + changelog.d/ghc-api-namespace-specifier-26678 - compiler/GHC/Hs/Basic.hs - compiler/GHC/Hs/Binds.hs - compiler/GHC/Hs/Decls.hs - compiler/GHC/Hs/Expr.hs-boot - compiler/GHC/Hs/ImpExp.hs - compiler/GHC/Hs/Type.hs - compiler/GHC/HsToCore/Docs.hs - compiler/GHC/HsToCore/Quote.hs - compiler/GHC/Iface/Ext/Ast.hs - compiler/GHC/Parser.y - compiler/GHC/Parser/PostProcess.hs - compiler/GHC/Parser/PostProcess/Haddock.hs - compiler/GHC/Rename/Bind.hs - compiler/GHC/Rename/Env.hs - compiler/GHC/Rename/HsType.hs - compiler/GHC/Rename/Module.hs - compiler/GHC/Rename/Names.hs - compiler/GHC/Rename/Pat.hs - compiler/GHC/Tc/Errors/Ppr.hs - compiler/GHC/Tc/Errors/Types.hs - compiler/GHC/Tc/Gen/App.hs - compiler/GHC/Tc/Gen/Export.hs - compiler/GHC/Tc/Gen/Head.hs - compiler/GHC/Tc/Gen/HsType.hs - compiler/GHC/Tc/Gen/Pat.hs - compiler/GHC/Tc/Utils/Unify.hs - compiler/GHC/ThToHs.hs - compiler/GHC/Types/Name/Reader.hs - compiler/Language/Haskell/Syntax/Binds.hs - compiler/Language/Haskell/Syntax/Decls.hs - compiler/Language/Haskell/Syntax/Extension.hs - compiler/Language/Haskell/Syntax/ImpExp.hs - ghc/GHC/Driver/Session/Mode.hs - ghc/GHCi/UI.hs - ghc/Main.hs - ghc/ghc-bin.cabal.in - hadrian/src/Settings/Packages.hs - rts/RtsSymbols.c - rts/Trace.c - rts/Trace.h - rts/include/rts/EventLogWriter.h - rts/sm/NonMoving.c - testsuite/tests/ghc-api/T25121_status.stdout - testsuite/tests/haddock/should_compile_flag_haddock/T17544_kw.stderr - testsuite/tests/parser/should_compile/T20846.stderr - testsuite/tests/printer/Makefile - + testsuite/tests/printer/PprInfixHole.hs - testsuite/tests/printer/all.T - + testsuite/tests/typecheck/should_fail/T27210.hs - + testsuite/tests/typecheck/should_fail/T27210.stderr - testsuite/tests/typecheck/should_fail/all.T - utils/check-exact/ExactPrint.hs - utils/haddock/haddock-api/src/Haddock/Backends/Hoogle.hs - utils/haddock/haddock-api/src/Haddock/Convert.hs - utils/haddock/haddock-api/src/Haddock/GhcUtils.hs - utils/haddock/haddock-api/src/Haddock/Interface/Rename.hs - utils/haddock/haddock-api/src/Haddock/Types.hs The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/5af4b7c79897e3f9965b9f7399ee1f… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/5af4b7c79897e3f9965b9f7399ee1f… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc][wip/andreask/split-driver-main] Split GHC.Driver.Main.hs up into multiple components.
by Andreas Klebinger (＠AndreasK) 28 Apr '26

28 Apr '26

Andreas Klebinger pushed to branch wip/andreask/split-driver-main at Glasgow Haskell Compiler / GHC Commits: e545f25c by Andreas Klebinger at 2026-04-27T21:14:39+02:00 Split GHC.Driver.Main.hs up into multiple components. This commit splits GHC.Driver.Main into four components: * GHC.Driver.Main.Compile * GHC.Driver.Main.Hsc * GHC.Driver.Main.Interactive * GHC.Driver.Main.Passes We might improve that separation further in the future but this should hopefully make it easier to reason about and work with this part of the code. - - - - - 14 changed files: - compiler/GHC/Driver/Backpack.hs - compiler/GHC/Driver/Env/Types.hs - compiler/GHC/Driver/Main.hs - + compiler/GHC/Driver/Main/Compile.hs - compiler/GHC/Driver/Main.hs-boot → compiler/GHC/Driver/Main/Compile.hs-boot - + compiler/GHC/Driver/Main/Hsc.hs - + compiler/GHC/Driver/Main/Interactive.hs - + compiler/GHC/Driver/Main/Passes.hs - + compiler/GHC/Driver/Main/Passes.hs-boot - compiler/GHC/Iface/Load.hs - compiler/GHC/Iface/Tidy.hs - compiler/GHC/Types/Error.hs - compiler/GHC/Types/Error.hs-boot - compiler/ghc.cabal.in The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e545f25ce00d3aea1662bd24e4c4f39… -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e545f25ce00d3aea1662bd24e4c4f39… You're receiving this email because of your account on gitlab.haskell.org.

1 0

[Git][ghc/ghc] Pushed new branch wip/int-index/ghc-10.0-from-9.16
by Vladislav Zavialov (＠int-index) 28 Apr '26

28 Apr '26

Vladislav Zavialov pushed new branch wip/int-index/ghc-10.0-from-9.16 at Glasgow Haskell Compiler / GHC -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/tree/wip/int-index/ghc-10.0-from-9.16 You're receiving this email because of your account on gitlab.haskell.org.

1 0