Simon Peyton Jones pushed to branch wip/T26115 at Glasgow Haskell Compiler / GHC Commits: 3afdcdca by Simon Peyton Jones at 2025-07-11T10:29:01+01:00 Wibbles - - - - - 2 changed files: - compiler/GHC/Core/FVs.hs - compiler/GHC/Core/Opt/Specialise.hs Changes: ===================================== compiler/GHC/Core/FVs.hs ===================================== @@ -188,24 +188,21 @@ exprSomeFreeVarsDSet fv_cand e = fvDVarSet $ filterFV fv_cand $ exprFVs e exprsSomeFreeVars :: InterestingVarFun -- Says which 'Var's are interesting -> [CoreExpr] -> VarSet -exprsSomeFreeVars fv_cand es = - fvVarSet $ filterFV fv_cand $ mapUnionFV exprFVs es +exprsSomeFreeVars fv_cand es = fvVarSet $ filterFV fv_cand $ mapUnionFV exprFVs es -- | Finds free variables in several expressions selected by a predicate -- returning a deterministically ordered list. exprsSomeFreeVarsList :: InterestingVarFun -- Says which 'Var's are interesting -> [CoreExpr] -> [Var] -exprsSomeFreeVarsList fv_cand es = - fvVarList $ filterFV fv_cand $ mapUnionFV exprFVs es +exprsSomeFreeVarsList fv_cand es = fvVarList $ filterFV fv_cand $ mapUnionFV exprFVs es -- | Finds free variables in several expressions selected by a predicate -- returning a deterministic set. exprsSomeFreeVarsDSet :: InterestingVarFun -- ^ Says which 'Var's are interesting -> [CoreExpr] -> DVarSet -exprsSomeFreeVarsDSet fv_cand e = - fvDVarSet $ filterFV fv_cand $ mapUnionFV exprFVs e +exprsSomeFreeVarsDSet fv_cand e = fvDVarSet $ filterFV fv_cand $ mapUnionFV exprFVs e -- Comment about obsolete code -- We used to gather the free variables the RULES at a variable occurrence ===================================== compiler/GHC/Core/Opt/Specialise.hs ===================================== @@ -2594,12 +2594,12 @@ specHeader , Core.Subst -- Apply this to the body -- RULE helpers - -- RULE forall rule_bndrs. f rule_es = $sf spec_bndrs + -- `RULE forall rule_bndrs. f rule_es = $sf spec_bndrs` , [OutBndr] -- rule_bndrs: Binders for the RULE , [OutExpr] -- rule_es: Args for the LHS of the rule -- Specialised function helpers - -- $sf = \spec_bndrs. let { dx_binds } in <orig-rhs> spec_arg + -- `$sf = \spec_bndrs. let { dx_binds } in <orig-rhs> spec_arg` , [OutBndr] -- spec_bndrs: Binders for $sf. Subset of rule_bndrs. , [DictBind] -- dx_binds: Auxiliary dictionary bindings , [OutExpr] -- spec_args: Specialised arguments for unfolding View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/3afdcdca67a54c537e33de808a2b5b8c... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/3afdcdca67a54c537e33de808a2b5b8c... You're receiving this email because of your account on gitlab.haskell.org.