Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC Commits: e1e1eb32 by Matthew Pickering at 2025-11-11T11:48:54-05:00 driver: Remove unecessary call to hscInsertHPT This call was left-over from e9445c013fbccf9318739ca3d095a3e0a2e1be8a If you follow the functions which call `upsweep_mod`, they immediately add the interface to the HomePackageTable when `upsweep_mod` returns. - - - - - 1 changed file: - compiler/GHC/Driver/Make.hs Changes: ===================================== compiler/GHC/Driver/Make.hs ===================================== @@ -1236,10 +1236,8 @@ upsweep_mod :: HscEnv -> Int -- total number of modules -> IO HomeModInfo upsweep_mod hsc_env mHscMessage old_hmi summary mod_index nmods = do - hmi <- compileOne' mHscMessage hsc_env summary - mod_index nmods (hm_iface <$> old_hmi) (maybe emptyHomeModInfoLinkable hm_linkable old_hmi) - hscInsertHPT hmi hsc_env - return hmi + compileOne' mHscMessage hsc_env summary + mod_index nmods (hm_iface <$> old_hmi) (maybe emptyHomeModInfoLinkable hm_linkable old_hmi) -- Note [When source is considered modified] View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e1e1eb328018d0ec138886a6390f2f52... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/e1e1eb328018d0ec138886a6390f2f52... You're receiving this email because of your account on gitlab.haskell.org.