Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC Commits: 9a73179a by Facundo Domínguez at 2026-07-08T04:49:26-04:00 Add item to MR checklist asking to squash fixup commits after approval The checklist has an item that reads All commits are either individually buildable or squashed. This item could be checked immediately after sending the merge request though. If reviewers ask for amends later on, and the author amends the merge request, there was no item that would remind the contributors to squash the fixup commits before landing. This commit adds a new item After all approvals and before landing: all fixup commits are squashed with their originating commits. which should be harder to mark as done before approvals have been given. - - - - - 1 changed file: - .gitlab/merge_request_templates/Default.md Changes: ===================================== .gitlab/merge_request_templates/Default.md ===================================== @@ -27,6 +27,7 @@ https://gitlab.haskell.org/ghc/ghc/-/wikis/Contributing-a-Patch - [ ] If this MR has the potential to break user programs, the ~"user-facing" label was applied to test against head.hackage. - [ ] All commits are either individually buildable or squashed. +- [ ] After all approvals and before landing: all fixup commits are squashed with their originating commits. - [ ] Commit messages describe *what they do*, referring to tickets using `#NNNNN` syntax. - [ ] Source comments describing the change were added. For larger changes [notes][notes] and cross-references from the relevant places were added (as applicable). View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/9a73179ad3244d0bc00f84c61cda90ef... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/9a73179ad3244d0bc00f84c61cda90ef... You're receiving this email because of your account on gitlab.haskell.org.