Andrea Vezzosi pushed to branch wip/romes/async-rpc at Glasgow Haskell Compiler / GHC Commits: 5a897150 by Andrea Vezzosi at 2026-10-20T09:53:52+02:00 ignore PipeReadClosedException on Shutdown. - - - - - 2 changed files: - compiler/GHC/Runtime/Interpreter.hs - libraries/ghci/GHCi/Server.hs Changes: ===================================== compiler/GHC/Runtime/Interpreter.hs ===================================== @@ -653,7 +653,7 @@ stopInterp interp = case interpInstance interp of ex <- getProcessExitCode (interpHandle (instProcess i)) if isJust ex then pure () - else sendMessage i Shutdown + else sendMessage i Shutdown `catch` \ PipeReadClosedException -> pure () -- We asked the server to shutdown, so we will also shutdown any communication. closePipe (interpPipe (instProcess i)) pure InterpPending ===================================== libraries/ghci/GHCi/Server.hs ===================================== @@ -209,8 +209,6 @@ defaultServerWithCustom customHandler = do uninterruptibleMask $ \restore -> servWithCustom verbose hook pipe restore customHandler where hook = return -- empty hook - -- we cannot allow any async exceptions while communicating, because - -- we will lose sync in the protocol, hence uninterruptibleMask. dieWithUsage :: IO a dieWithUsage = do View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/5a897150dceaac9a502bf3a095bc9741... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/5a897150dceaac9a502bf3a095bc9741... You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help
participants (1)
-
Andrea Vezzosi (@trac-Saizan)