Alan Zimmerman pushed to branch wip/az/exactprint-annotation-rationalisation at Glasgow Haskell Compiler / GHC Commits: d71a4700 by Alan Zimmerman at 2026-08-27T21:52:46+01:00 Exactprint: tidy up layout capturing - - - - - ae592dda by Alan Zimmerman at 2026-08-27T21:53:00+01:00 MOVE: add makeDelta test for Test20297 - - - - - ad0ac5c1 by Alan Zimmerman at 2026-08-27T22:17:59+01:00 EPA: Make ValBinds LocatedA in HsLocalBindsLR If we have items with an AnnList Annotation, as part of another, which has different content, it must be LocatedA. This is a technical requirement due to the way comment allocation happens during the makeDelta processing. Comments are queued for printing, and as soon as any non-comment is to be printed, the pending comments before that position are printed, and in makeDelta processing these attached as preceding comments to the thing just printed. The means they end up captured inside the layout region of the AnnList item. So for foo = x where -- comment x = 3 the comment ends up as a preceding comment of `x = 3`, inside the layout, and prints as foo = x where -- comment x = 3 - - - - - d36ddf50 by Alan Zimmerman at 2026-08-27T23:16:02+01:00 EPA: Make IPBinds LocatedA - - - - - 664bff4c by Alan Zimmerman at 2026-08-27T23:19:30+01:00 Extend Test20297 for additional occurrences - - - - - c450b492 by Alan Zimmerman at 2026-08-27T23:19:30+01:00 Plan update DO NOT COMMIT - - - - - ec0ce16b by Alan Zimmerman at 2026-08-27T23:19:30+01:00 EPA: First pass implementation of HsList, for ClassDecls Just as a straight list replacement to start with, no payload. This shows the scope and invasiveness of the initial change - - - - - a9a0db5f by Alan Zimmerman at 2026-08-27T23:19:30+01:00 EPA: HsList attempt WIP - - - - - cba7c0a9 by Alan Zimmerman at 2026-08-27T23:19:30+01:00 Enable ppr test for Haddock1. It currently fails - - - - - b29aea6d by Alan Zimmerman at 2026-08-27T23:19:30+01:00 WIP on removing NoEpAnn. Likely abandon - - - - - 061fdd5f by Alan Zimmerman at 2026-08-27T23:19:30+01:00 EPA: Add an overview doc for exact printing - - - - - e6ce637d by Simon Peyton Jones at 2026-08-27T23:19:30+01:00 Added an intro section - - - - - 60 changed files: - ANNLIST-LAYOUT-PLAN.md - + ExactPrint.md - LAYOUT-SCOPE-PLAN.md - compiler/GHC/Driver/Backpack.hs - compiler/GHC/Driver/Main/Interactive.hs - compiler/GHC/Hs.hs - compiler/GHC/Hs/Binds.hs - compiler/GHC/Hs/Decls.hs - compiler/GHC/Hs/DocString.hs - compiler/GHC/Hs/Expr.hs - compiler/GHC/Hs/ImpExp.hs - compiler/GHC/Hs/Instances.hs - compiler/GHC/Hs/Stats.hs - compiler/GHC/Hs/Utils.hs - compiler/GHC/HsToCore/Expr.hs - compiler/GHC/HsToCore/Pmc/Desugar.hs - compiler/GHC/HsToCore/Quote.hs - compiler/GHC/HsToCore/Ticks.hs - compiler/GHC/Iface/Ext/Ast.hs - compiler/GHC/Parser.y - compiler/GHC/Parser/PostProcess.hs - compiler/GHC/Parser/PostProcess/Haddock.hs - compiler/GHC/Rename/Bind.hs - compiler/GHC/Rename/Expr.hs - compiler/GHC/Rename/Module.hs - compiler/GHC/Rename/Splice.hs - compiler/GHC/Runtime/Eval.hs - compiler/GHC/Tc/Deriv.hs - compiler/GHC/Tc/Gen/Bind.hs - compiler/GHC/Tc/Gen/Expr.hs - compiler/GHC/Tc/Module.hs - compiler/GHC/Tc/Types/Origin.hs - compiler/GHC/Tc/Zonk/Type.hs - compiler/GHC/ThToHs.hs - compiler/Language/Haskell/Syntax.hs - compiler/Language/Haskell/Syntax/Basic.hs - compiler/Language/Haskell/Syntax/Binds.hs - compiler/Language/Haskell/Syntax/Decls.hs - compiler/Language/Haskell/Syntax/Expr.hs - ghc/GHCi/UI.hs - testsuite/tests/haddock/should_compile_flag_haddock/T17544.stderr - testsuite/tests/haddock/should_compile_flag_haddock/T17544_kw.stderr - testsuite/tests/parser/should_compile/DumpRenamedAst.stderr - testsuite/tests/parser/should_compile/DumpSemis.stderr - testsuite/tests/parser/should_compile/T20452.stderr - testsuite/tests/printer/Makefile - + testsuite/tests/printer/Test20297.expected.hs - testsuite/tests/printer/Test20297.hs - testsuite/tests/printer/Test20297.stdout - + testsuite/tests/printer/Test20297MD.stdout - testsuite/tests/printer/Test24533.stdout - testsuite/tests/printer/all.T - utils/check-exact/ExactPrint.hs - utils/check-exact/Main.hs - utils/check-exact/Parsers.hs - utils/check-exact/Transform.hs - utils/check-exact/Utils.hs - utils/haddock/haddock-api/src/Haddock/Convert.hs - utils/haddock/haddock-api/src/Haddock/Interface/Rename.hs - utils/haddock/haddock-api/src/Haddock/Types.hs The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/b2b661a39d7532b5c97c7412028cfbb... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/b2b661a39d7532b5c97c7412028cfbb... You're receiving this email because of your account on gitlab.haskell.org. Manage all notifications: https://gitlab.haskell.org/-/profile/notifications | Help: https://gitlab.haskell.org/help