Wolfgang Jeltsch pushed to branch wip/jeltsch/more-efficient-home-unit-imports-finding at Glasgow Haskell Compiler / GHC Commits: fa3d2618 by Wolfgang Jeltsch at 2026-05-12T14:50:14+03:00 Move the comment in `rankedHomeUnitDeps` up - - - - - 1 changed file: - compiler/GHC/Unit/Finder.hs Changes: ===================================== compiler/GHC/Unit/Finder.hs ===================================== @@ -293,6 +293,9 @@ rankedHomeUnitDeps :: HomeModuleNameProvidersMap -> [UnitId] rankedHomeUnitDeps _ _ home_unit_deps | Set.null home_unit_deps = [] +-- The special handling of the situation where the dependency set is empty does +-- not change the result, but it avoids triggering evaluation of the module +-- graph. rankedHomeUnitDeps home_module_name_providers_map mod_name home_unit_deps = Set.toList cached_deps ++ Set.toList uncached_deps where @@ -307,11 +310,6 @@ rankedHomeUnitDeps home_module_name_providers_map mod_name home_unit_deps uncached_deps :: Set UnitId uncached_deps = Set.difference home_unit_deps cached_providers -{- - The special handling of the situation where the dependency set is empty does - not change the result, but it avoids triggering evaluation of the module - graph. --} -- | Locate a plugin module requested by the user, for a compiler -- plugin. This consults the same set of exposed packages as View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/fa3d26185406696dd21afdbecf43b2bd... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/fa3d26185406696dd21afdbecf43b2bd... You're receiving this email because of your account on gitlab.haskell.org.