Simon Hengel pushed to branch wip/sol/remove-ddump-json at Glasgow Haskell Compiler / GHC Commits: 95231c8e by Teo Camarasu at 2025-08-06T08:35:58-04:00 CODEOWNERS: add CLC as codeowner of base We also remove hvr, since I think he is no longer active - - - - - 77df0ded by Andrew Lelechenko at 2025-08-06T08:36:39-04:00 Bump submodule text to 2.1.3 - - - - - 8af260d0 by Nikolaos Chatzikonstantinou at 2025-08-06T08:37:23-04:00 docs: fix internal import in getopt examples This external-facing doc example shouldn't mention GHC internals when using 'fromMaybe'. - - - - - 26bc4e03 by Simon Hengel at 2025-08-07T16:29:09+07:00 Refactoring: Don't misuse `MCDiagnostic` for lint messages `MCDiagnostic` is meant to be used for compiler diagnostics. Any code that creates `MCDiagnostic` directly, without going through `GHC.Driver.Errors.printMessage`, side steps `-fdiagnostics-as-json` (see e.g. !14475, !14492 !14548). To avoid this in the future I want to control more narrowly who creates `MCDiagnostic` (see #24113). Some parts of the compiler use `MCDiagnostic` purely for formatting purposes, without creating any real compiler diagnostics. This change introduces a helper function, `formatDiagnostic`, that can be used in such cases instead of constructing `MCDiagnostic`. - - - - - 5b4d65b3 by Simon Hengel at 2025-08-07T16:41:37+07:00 Rename MCDiagnostic to UnsafeMCDiagnostic - - - - - 02a76e4b by Simon Hengel at 2025-08-07T16:45:31+07:00 Remove -ddump-json (fixes #24113) - - - - - 92101fd2 by Simon Hengel at 2025-08-07T16:49:47+07:00 Add SrcSpan to MCDiagnostic - - - - - e3cb924f by Simon Hengel at 2025-08-07T16:49:47+07:00 Refactoring: More consistently use logOutput, logInfo, fatalErrorMsg - - - - - 952a50db by Simon Hengel at 2025-08-07T16:49:47+07:00 Add Message data type - - - - - 46d2af4c by Simon Hengel at 2025-08-07T17:01:50+07:00 Get rid of MessageClass - - - - - a13b1068 by Simon Hengel at 2025-08-07T17:01:50+07:00 Rename DiagnosticMessage to GenericDiagnosticMessage - - - - - a5f576f7 by Simon Hengel at 2025-08-07T17:01:50+07:00 Remove JSON logging WIP - - - - - f3a82a3d by Simon Hengel at 2025-08-07T17:07:23+07:00 Add DiagnosticMessage - - - - - 39 changed files: - CODEOWNERS - compiler/GHC/Core/Lint.hs - compiler/GHC/Core/Opt/Monad.hs - compiler/GHC/Driver/CodeOutput.hs - compiler/GHC/Driver/Errors.hs - compiler/GHC/Driver/Flags.hs - compiler/GHC/Driver/Main.hs - compiler/GHC/Driver/Make.hs - compiler/GHC/Driver/Monad.hs - compiler/GHC/Driver/Pipeline.hs - compiler/GHC/Driver/Pipeline/Execute.hs - compiler/GHC/Driver/Pipeline/LogQueue.hs - compiler/GHC/Driver/Session.hs - compiler/GHC/HsToCore/Monad.hs - compiler/GHC/Iface/Load.hs - compiler/GHC/Linker/Deps.hs - compiler/GHC/Linker/Loader.hs - compiler/GHC/Runtime/Debugger.hs - compiler/GHC/Stg/Lint.hs - compiler/GHC/Tc/Errors.hs - compiler/GHC/Tc/Utils/Monad.hs - compiler/GHC/Types/Error.hs - compiler/GHC/Types/SourceError.hs - compiler/GHC/Utils/Error.hs - compiler/GHC/Utils/Logger.hs - docs/users_guide/debugging.rst - ghc/GHCi/UI.hs - ghc/GHCi/UI/Exception.hs - libraries/base/src/System/Console/GetOpt.hs - libraries/text - testsuite/tests/driver/T16167.stderr - − testsuite/tests/driver/T16167.stdout - testsuite/tests/driver/all.T - testsuite/tests/driver/json2.stderr - − testsuite/tests/driver/json_dump.hs - − testsuite/tests/driver/json_dump.stderr - utils/check-exact/Main.hs - utils/check-exact/Preprocess.hs - utils/haddock/haddock-api/src/Haddock/Backends/Hyperlinker/Parser.hs The diff was not included because it is too large. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/c108fbc58afe83b6d7df366bf0b8b0e... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/c108fbc58afe83b6d7df366bf0b8b0e... You're receiving this email because of your account on gitlab.haskell.org.