Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC Commits: b883f08f by Cheng Shao at 2026-03-20T12:31:33-04:00 hadrian: don't compile RTS with -Winline This patch removes `-Winline` from cflags when compiling the RTS, given that: 1. It generates a huge pile of spam and hurts developer experience 2. Whether inlining happens is highly dependent on toolchains, flavours, etc, and it's not really an issue to fix if inlining doesn't happen; it's a hint to the C compiler anyway. Fixes #27060. - - - - - 333387d6 by Cheng Shao at 2026-03-20T12:31:33-04:00 hadrian: compile libffi-clib with -Wno-deprecated-declarations This patch adds `-Wno-deprecated-declarations` to cflags of `libffi-clib`, given that it produces noise at compile-time that aren't really our issue to fix anyway, it's from vendored libffi source code. - - - - - 1 changed file: - hadrian/src/Settings/Packages.hs Changes: ===================================== hadrian/src/Settings/Packages.hs ===================================== @@ -280,6 +280,8 @@ ghcInternalArgs = package ghcInternal ? do libffiPackageArgs :: Args libffiPackageArgs = package libffi ? do rtsWays <- getRtsWays + -- noise when compiling libffi sources + let cArgs = mconcat [ arg "-Wno-deprecated-declarations" ] mconcat [ builder (Cabal Flags) ? mconcat [ any (wayUnit Profiling) rtsWays `cabalFlag` "profiling" @@ -287,6 +289,8 @@ libffiPackageArgs = package libffi ? do , any (wayUnit Dynamic) rtsWays `cabalFlag` "dynamic" , any (wayUnit Threaded) rtsWays `cabalFlag` "threaded" ] + , builder (Cc (FindCDependencies CDep)) ? cArgs + , builder (Ghc CompileCWithGhc) ? map ("-optc" ++) <$> cArgs ] -- | RTS-specific command line arguments. @@ -377,9 +381,6 @@ rtsPackageArgs = package rts ? do , inputs ["**/Jumps_V32.c"] ? pure [ "-mavx2" | x86 ] , inputs ["**/Jumps_V64.c"] ? pure [ "-mavx512f" | x86 ] - -- inlining warnings happen in Compact - , inputs ["**/Compact.c"] ? arg "-Wno-inline" - -- emits warnings about call-clobbered registers on x86_64 , inputs [ "**/StgCRun.c" , "**/win32/ConsoleHandler.c", "**/win32/ThrIOManager.c"] ? arg "-w" @@ -446,7 +447,6 @@ rtsWarnings = mconcat , arg "-Wstrict-prototypes" , arg "-Wmissing-prototypes" , arg "-Wmissing-declarations" - , arg "-Winline" , arg "-Wpointer-arith" , arg "-Wmissing-noreturn" , arg "-Wnested-externs" View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/5b1be555be4f0989d78c274991c5046... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/5b1be555be4f0989d78c274991c5046... You're receiving this email because of your account on gitlab.haskell.org.