Sven Tennie pushed to branch wip/romes/hadrian-cross-stage2-rebase_SVEN_FINAL at Glasgow Haskell Compiler / GHC Commits: 86713ac2 by Sven Tennie at 2026-06-13T08:47:04+00:00 hadrian: build docs in cross-compiler bindist Remove the cross → Set.empty guard from defaultDocsTargets so that cross-compiler bindists include documentation, matching the behaviour of native bindists. The guard was introduced as a TODO in 9183601bbf; stage1 haddock support for cross GHC was subsequently added in 272eaef0be, making docs buildable in cross configurations. - - - - - 1 changed file: - hadrian/src/Settings/Default.hs Changes: ===================================== hadrian/src/Settings/Default.hs ===================================== @@ -300,21 +300,10 @@ defaultFlavour = Flavour , ghcThreaded = const True , ghcDebugAssertions = const False , ghcSplitSections = False - , ghcDocs = defaultDocsTargets + , ghcDocs = cmdDocsArgs , ghcHieFiles = const False , hashUnitIds = False } -defaultDocsTargets :: Action DocTargets -defaultDocsTargets = do - cross <- flag CrossCompiling - -- MP: Building documentation in cross configurations can work and should - -- work but currently is left as a TODO - -- - -- This is the ONLY place where we should branch on building documentation in - -- the cross setting. - if cross then return Set.empty - else cmdDocsArgs - -- | Default logic for determining whether to build -- dynamic GHC programs. -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/86713ac21a91d74cfafb5ce6b744e2e8... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/86713ac21a91d74cfafb5ce6b744e2e8... You're receiving this email because of your account on gitlab.haskell.org.