Simon Peyton Jones pushed to branch wip/T24464 at Glasgow Haskell Compiler / GHC Commits: 7cf2b4e3 by Simon Peyton Jones at 2026-01-18T18:15:37+00:00 Wibble - - - - - 2 changed files: - compiler/GHC/Tc/Gen/Sig.hs - compiler/GHC/Tc/Utils/Env.hs Changes: ===================================== compiler/GHC/Tc/Gen/Sig.hs ===================================== @@ -163,6 +163,9 @@ errors were dealt with by the renamer. ********************************************************************* -} tcTySigs :: [LSig GhcRn] -> TcM ([TcId], TcSigFun) +-- The returned [TcId] are the ones for which we have +-- a /complete/ type signature. +-- See Note [Complete and partial type signatures] tcTySigs hs_sigs = checkNoErrs $ do { -- Fail if any of the signatures is duff @@ -172,9 +175,6 @@ tcTySigs hs_sigs ; let ty_sigs = concat ty_sigs_s poly_ids = mapMaybe completeSigPolyId_maybe ty_sigs - -- The returned [TcId] are the ones for which we have - -- a complete type signature. - -- See Note [Complete and partial type signatures] env = mkNameEnv [(tcSigInfoName sig, sig) | sig <- ty_sigs] ; return (poly_ids, lookupNameEnv env) } ===================================== compiler/GHC/Tc/Utils/Env.hs ===================================== @@ -723,7 +723,7 @@ tcExtendLetEnv top_lvl sig_fn closed ids thing_inside [ (id_nm, ATcId { tct_id = id, tct_info = LetBound closed }) | Scaled _ id <- ids , let id_nm = idName id - , isNothing (sig_fn id_nm) -- See (ELE) above + , not (hasCompleteSig sig_fn id_nm) -- See (ELE) above ] $ foldr check_one_usg thing_inside ids where View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/7cf2b4e35e7db5fde1b9d5bb0e21cb5e... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/7cf2b4e35e7db5fde1b9d5bb0e21cb5e... You're receiving this email because of your account on gitlab.haskell.org.