Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC Commits: 242d4317 by sheaf at 2026-07-04T04:16:19-04:00 Remove outdated comment in GHC.Data.ShortText There was a long comment in GHC.Data.ShortText about a workaround that was necessary when bootstrapping with GHC 9.2 and below. The actual logic has since been dropped, but the comment remained. This commit removes the vestigial comment. - - - - - 1 changed file: - libraries/ghc-boot/GHC/Data/ShortText.hs Changes: ===================================== libraries/ghc-boot/GHC/Data/ShortText.hs ===================================== @@ -1,18 +1,7 @@ {-# LANGUAGE BangPatterns, MagicHash, UnboxedTuples, GeneralizedNewtypeDeriving, DerivingStrategies #-} {-# OPTIONS_GHC -O2 -funbox-strict-fields #-} --- gross hack: we maneuvered ourselves into a position where we can't boot GHC with a LLVM based GHC anymore. --- LLVM based GHC's fail to compile memcmp ffi calls. These end up as memcmp$def in the llvm ir, however we --- don't have any prototypes and subsequently the llvm toolchain chokes on them. Since 7fdcce6d, we use --- ShortText for the package database. This however introduces this very module; which through inlining ends --- up bringing memcmp_ByteArray from bytestring:Data.ByteString.Short.Internal into scope, which results in --- the memcmp call we choke on. --- --- The solution thusly is to force late binding via the linker instead of inlining when comping with the --- bootstrap compiler. This will produce a slower (slightly less optimised) stage1 compiler only. --- --- See issue 18857. hsyl20 deserves credit for coming up with the idea for the solution. --- | --- An Unicode string for internal GHC use. Meant to replace String + +-- | An Unicode string for internal GHC use. Meant to replace String -- in places where being a lazy linked is not very useful and a more -- memory efficient data structure is desirable. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/242d4317b3bbd671fa00c91a2969c4f4... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/242d4317b3bbd671fa00c91a2969c4f4... You're receiving this email because of your account on gitlab.haskell.org.