Andreas Klebinger pushed to branch wip/andreask/fix-prof-segv at Glasgow Haskell Compiler / GHC Commits: f7643584 by Andreas Klebinger at 2026-06-23T08:44:15+00:00 Apply 2 suggestion(s) to 2 file(s) Co-authored-by: Zubin <zubin.duggal@gmail.com> Co-authored-by: Magnus <contact@mangoiv.com> - - - - - 2 changed files: - changelog.d/T27123.md - rts/Apply.cmm Changes: ===================================== changelog.d/T27123.md ===================================== @@ -1,6 +1,6 @@ section: compiler synopsis: Fix two crashes that could happen in a multithreaded setting when profiling. -description: There where two bugs that could cause occasional segfaults or crashes with +description: There were two bugs that could cause occasional segfaults or crashes with an `PAP object entered` error when profiling. They only happened when two threads where racing to evaluate the same thunk, and specific GC timings. mrs: !16214 ===================================== rts/Apply.cmm ===================================== @@ -215,7 +215,7 @@ again: // STK_CHK_GEN() did a GC then the closure we're looking // at may have changed, e.g. a THUNK_SELECTOR may have // been evaluated by the GC. - // We always reload reload the info pointer now. And if + // We always reload the info pointer now. And if // the closure type changed we need to take a different case // alt altogether so we retry from the start in that case. View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/f7643584f63a2fbfea300a0c9597ebdc... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/f7643584f63a2fbfea300a0c9597ebdc... You're receiving this email because of your account on gitlab.haskell.org.
participants (1)
-
Andreas Klebinger (@AndreasK)