Re: [ANNOUNCE] GHC 8.0.1 source tarball available

On 05/14/16 11:28 AM, Ben Gamari wrote:

Páli Gábor János writes:

...

2016-05-13 7:58 GMT+02:00 Páli Gábor János :

...

2016-05-13 7:55 GMT+02:00 Páli Gábor János :

...

That is probably because FreeBSD has GNU make(1) as `gmake`, it should be invoked with that name. I suspect that, for some reason (which is unknown to me), the value of the $(MAKE) variable is not respected at the recursive invocation of make(1). [..] Ohh, I was quick to surrender: all you have to do is to s/make/$(MAKE)/ in line 22 at utils/haddock/doc/ghc.mk.

All right, everything is now filed as #12058.

Thanks Páli! This should now be fixed on the ghc-8.0 branch. The question how is what should be done about for the 8.0.1 release. It seems that there are two decisions to be made here,

1. Do we cut a new source tarball and bump the tag? 2. If so, do we throw out the existing binary distributions?

The pragmatist in me wants to answer 1) yes, 2) no, although I do dislike the idea of distributing binaries that weren't derived from the associated source tarball.

This is interesting since I build dists for solaris and openbsd and none of those were affected by the bug. I guess all other Linuxes naturally use gnu make as `make' and Windows in msys too so only non-GNU/non-Linux systems should be affected and from those only FreeBSD has caught this. If this is true, then I would recommend "no" to both points and leave the fix in 8.0 branch for 8.0.2... or! you can create 8.0.1b sources and rebuild on FreeBSD to have 8.0.1b binary dist for this platform. Anyway I think nobody will shoot anyone if Gabor just fix it in his own tree and rebuild silently fixed 8.0.1. Cheers, Karel