Re: [commit: ghc] ghc-7.8: add --with-ar and --with-ranlib configure parameters (05e160e)

Committed as 61654e5 Cheers, Gabor On 3/23/14, Karel Gardas wrote:

Hi Gabor,

indeed! I can just follow my intention to follow general logic of:

--with-<cmd> -> @<cmd>Cmd@

but you are right RANLIB logic is a little bit more comlex in aclocal.m4 so it uses different variables (REAL_RANLIB_CMD/RANLIB_CMD) than "usual" RanlibCmd.

So if you care about one useless AC_SUBST(RanlibCmd), please send the patch or if you do have commit access just fix that. As I said, intention was to follow usual logic although in this case non-functional....

Thanks, Karel

On 03/23/14 09:35 PM, Gabor Greif wrote:

...

Hi Karel,

I am missing a use of @RanlibCmd@, is this intentional?

Cheers,

Gabor

On 3/23/14, git@git.haskell.org wrote:

...

Repository : ssh://git@git.haskell.org/ghc

On branch : ghc-7.8 Link : http://ghc.haskell.org/trac/ghc/changeset/05e160e36527f6f36f997d7aa56f0cbe4c...

...

---------------------------------------------------------------

commit 05e160e36527f6f36f997d7aa56f0cbe4cbb50a3 Author: Karel Gardas Date: Sun Feb 9 21:58:05 2014 +0100

add --with-ar and --with-ranlib configure parameters

Both --with-ar and --with-ranlib are usable on non-GNU/Linux systems where GNU tools are usually installed (or possible to install), but not into standard location nor with standard name. Tested on Solaris 10.

Signed-off-by: Austin Seipp (cherry picked from commit ac24bf45258af701cdd67423d6107357f27bbedf)

...

---------------------------------------------------------------

05e160e36527f6f36f997d7aa56f0cbe4cbb50a3 configure.ac | 15 +++++++++++++++ mk/config.mk.in | 1 + 2 files changed, 16 insertions(+)

diff --git a/configure.ac b/configure.ac index 1c58da0..d32fd20 100644 --- a/configure.ac +++ b/configure.ac @@ -486,6 +486,21 @@ FP_ARG_WITH_PATH_GNU_PROG([NM], [nm], [nm]) NmCmd="$NM" AC_SUBST([NmCmd])

+dnl ** Which ar to use? +dnl -------------------------------------------------------------- +FP_ARG_WITH_PATH_GNU_PROG([AR], [ar], [ar]) +ArCmd="$AR" +fp_prog_ar="$AR" +AC_SUBST([ArCmd]) + +dnl ** Which ranlib to use? +dnl -------------------------------------------------------------- +FP_ARG_WITH_PATH_GNU_PROG([RANLIB], [ranlib], [ranlib]) +RanlibCmd="$RANLIB" +RANLIB="$RanlibCmd" +AC_SUBST([RanlibCmd]) + + # Note: we may not have objdump on OS X, and we only need it on Windows (for DLL checks) case $HostOS_CPP in cygwin32|mingw32) diff --git a/mk/config.mk.in b/mk/config.mk.in index fef1fb8..7cc7aec 100644 --- a/mk/config.mk.in +++ b/mk/config.mk.in @@ -661,6 +661,7 @@ DTRACE = @DtraceCmd@

LD = @LdCmd@ NM = @NmCmd@ +AR = @ArCmd@ OBJDUMP = @ObjdumpCmd@

LLC = @LlcCmd@

_______________________________________________ ghc-commits mailing list ghc-commits@haskell.org http://www.haskell.org/mailman/listinfo/ghc-commits