Re: Commit comments - call for opinions

I personally prefer seeing the whole commit message, if only because including it is more prominent than just a mention. Commits are really important, and should be made to stand out beyond just a mention. Not sure if this is worth yet more custom tooling, though. Richard

On Feb 8, 2019, at 7:04 PM, Ben Gamari wrote:

Matthew Pickering writes:

...

I am in favor of option b) as it fits in better with the "gitlab way of things". If we are to use gitlab then we should use it as it's most intended rather than trying to retrofit trac practices which have accrued over many years.

Adding commits as comments is just a hack in trac to work around missing native support for the fundamental operation of linking a commit to.

Well, I'm not sure that's *entirely* true.

...

I don't really see that it is much more inconvenient to click on a link to see the commit, the hash can be hovered over to see the commit title.

I can see Simon's point here; Trac tickets generally tell a story, consisting of both comments as well as commit messages. It's not clear to me why the content of the former should be more visible than that of the latter. They both tell equally-important parts of the story.

Cheers,

- Ben

_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs