On 21/11/2013 13:05, Kazu Yamamoto (山本和彦) wrote:
Hi SimonM,
But I'm not sure about this fix. I'm happy to merge in fixes for Mac in general, but in this case we seem to lose the line pragmas, which are actually useful (error messages will point to the original source, instead of some preprocessed file).
Yes. If we can find another solution which keeps line markers, it is much better, anyway.
But this patch effects templates only. When a template is included into an HS file (genearted from a '.x' file), the position is shifted. So, I'm not sure that line markers are important as you think.
Isn't this why the line pragmas are important? If GHC reports an error in the template code, we want the error message to point to the template source (GenericTemplate.hs), not the generated source file. This works right now, it'd be a shame to lose it. Cheers, Simon