I think pattern synonyms are great! A couple of questions: * what will Haddock show for a pattern export? * can we still write pattern matches that GHC can infer to be exhaustive when using pattern synonyms? Are we not doing ViewPatternsAlternative any more? https://ghc.haskell.org/trac/ghc/wiki/ViewPatternsAlternative Or is that just being treated as an orthogonal issue? I rather like that proposal, and we originally discussed it in conjunction with pattern synonyms. Cheers, Simon On 09/12/2013 08:58, Simon Peyton-Jones wrote:
PS: it was so obvious that I forgot to add: a major thank-you to Gergo, who did ALL the work.
Simon
| -----Original Message----- | From: Simon Peyton-Jones | Sent: 09 December 2013 08:58 | To: 'Dr. ERDI Gergo'; GHC Devs | Cc: Augustsson, Lennart | Subject: RE: Preparing for a review of pattern synonyms | | Just to say that I'm very pleased by this work. Haskell can abstract | over just about everything except patterns, and this feature fixes that | embarrassing lack. I've discussed the implementation extensively with | Gergo, and he's more-or-less rewritten it several times. It's quite | pretty I think. | | Thanks too to Lennart for pressing for it. I believe the first impetus | came at the Cambridge Haskell Hackathon. | | Simon | | | -----Original Message----- | | From: ghc-devs [mailto:ghc-devs-bounces@haskell.org] On Behalf Of Dr. | | ERDI Gergo | | Sent: 09 December 2013 06:06 | | To: GHC Devs | | Subject: Preparing for a review of pattern synonyms | | | | Hi, | | | | I believe I've finished implementing version 1 of pattern synonyms | (i.e. | | everything described in #5144, minus the things in #8581, #8582, #8583 | | and | | #8584). I've discussed the way forward with SPJ and he suggested | because | | of the cross-cutting nature of the patch, I should wait a reasonably | | long | | time (~1 month) after 7.8 is branched off for things to settle, and | | then formally submit it for review. | | | | So my question is, is there anything I can do in the meantime, in | | preparation for the review? The code is available at | | https://github.com/gergoerdi/ghc. I've also added some tests | | to the testsuite (https://github.com/gergoerdi/ghc-testsuite), and | | updated the wiki pages at | | https://ghc.haskell.org/trac/ghc/wiki/PatternSynonyms and | | https://ghc.haskell.org/trac/ghc/wiki/PatternSynonyms/Implementation. | | | | Thanks, | | Gergo | | | | _______________________________________________ | | ghc-devs mailing list | | ghc-devs@haskell.org | | http://www.haskell.org/mailman/listinfo/ghc-devs _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs