5 Dec
2024
5 Dec
'24
4:01 p.m.
Ben Gamari
On Wed, Dec 04, 2024 at 10:44:13AM +0000, Tom Ellis wrote:
There is test in place to confirm that the API of base does not change accidentally. [...]
Just so everyone here is in the loop:
My guess is that the CLC will consider this an unapproved change that should be reverted before release.
Unfortunately it appears that the situation is a bit worse than just an Enum instance.
Thankfully it appears I was wrong here. The additional changes I report below are approved under CLC#263. The only problem here is the missing `Enum` and `Show` instances for `IoSubSystem`. I have amended the merge request (!13683) to address this. Cheers, - Ben