Re: more submodule questions

On Jan 27, 2020, at 8:19 PM, Ben Gamari wrote:

The linter does not hold up builds for merge requests but will hold up a "pre-merge" validation job (e.g. a validation of an MR created by @marge-bot). This ensures that a patch containing a wip/ submodule reference will not be merged to master.

Very interesting! Are there other such checks? I always assume that if an MR passes CI, then it is suitable for merging. Of course, what you describe makes perfect sense here -- we don't require upstream to have our commits during CI, but we do during merging. I'm just wondering if there are other such scenarios that are checked for. Thanks, Richard